Commit graph

482871 commits

Author SHA1 Message Date
Stephan Bergmann
df4f438e74 Use ImplInheritanceHelper in VCLXAccessibleCheckBox
Change-Id: I6cb7926db61590a356db7c55eeda94053dbf189f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146188
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26 19:55:32 +00:00
Stephan Bergmann
7c63d968bb Use ImplInheritanceHelper in VCLXAccessibleButton
Change-Id: Ia5c384e7ae4b78e008836fafc5433accd8489f07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146187
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26 19:55:22 +00:00
Tibor Nagy
e8335bac56 tdf#153107 OOXML export: fix scale of tile of shape background
Relative scale values were exported as absolute values,
resulting broken shape background.

Change-Id: Ia38e125862e7f8ceff5d41754340723c3a9eb028
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145996
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-26 19:49:09 +00:00
Xisco Fauli
7b0b6e5232 UITest_writer_tests7: improve test a bit
To see where the problem might be

Change-Id: I0baed63408c96eddffbaa39e172bc922c0a78241
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146180
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-26 19:17:54 +00:00
Stephan Bergmann
1bc2be265c Use ImplInheritanceHelper in VCLXAccessibleBox
Change-Id: I8763463a2fd85a528870d140051dd9fb49aea608
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146186
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26 19:02:37 +00:00
Stephan Bergmann
e547fb841d Use ImplInheritanceHelper in SVTXAccessibleNumericField
Change-Id: I9d9b6a6d7cbd89983cbe803511b59226330ae9e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146185
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26 19:02:16 +00:00
Stephan Bergmann
fd92a175b5 Use ImplInheritanceHelper in VCLXAccessibleEdit
Change-Id: Ia81117c1819b4d3b5791a0d8ca66d79a26a3c9a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146184
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26 19:01:58 +00:00
Stephan Bergmann
b50d9685e8 Use ImplInheritanceHelper in VCLXAccessibleTextComponent
Change-Id: Iad1ae727e31908949d61d32b3828a67ac74398e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146183
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26 19:01:45 +00:00
Stephan Bergmann
fc2f4eb5ca Use ImplInheritanceHelper in OAccessibleMenuComponent
Change-Id: I7399a7e707d4a5915925d2e1b606ed7f6a364337
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146182
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26 19:01:24 +00:00
Stephan Bergmann
ce1fbb0974 Use ImplInheritanceHelper in OAccessibleMenuBaseComponent
Change-Id: I9527ea68c3fbb1637ea08cea6340b49bab9eac6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146181
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-26 19:01:09 +00:00
Ling Yang
a03dbcf786 add "LOONGARCH64" to the JAVAINTERPRETER 64bit check
Change-Id: Ia0d15eb3e235fbd750b818009b5168c61c6ff0ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139549
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
2023-01-26 16:45:19 +00:00
Caolán McNamara
481c740ff0 tdf#153220 exit header/footer edit mode, if active, on undo header/footer
Change-Id: Ibe97a9239bff03b7bcffc11c02b6bdff840c4481
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146178
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-26 16:22:12 +00:00
Caolán McNamara
abe1310448 cid#1520593 Uncaught exception
Change-Id: I14f412e9dda71863036cd99bc29f86d31b947163
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146177
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-26 16:01:12 +00:00
Xisco Fauli
f8a5e416ea tdf#146248: sw: move UItest to CppUnittest
Change-Id: Ibb198808d124457f6676cdf642b75289948514d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146174
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-26 15:39:45 +00:00
Caolán McNamara
2a40505d00 remove option to toggle IsPDFAsStandardPrintJobFormat from UI
to deprecate it. Still possible to toggle from expert config for now,
but we should push on and remove this and all the postscript printing at
this point.

Change-Id: If8869a62616b336764720f5dc56d86b94f16ffbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146169
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-26 15:09:20 +00:00
Caolán McNamara
b9249d7c4d cid#1520592 Logically dead code
Change-Id: If0e52b474369657e0ed602f859d180f829865f9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146176
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-26 14:58:46 +00:00
Xisco Fauli
49b616608d sw: no need to create the document twice
Change-Id: I566fde00f414b9b983770256697ff2a6f3cf1781
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146175
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-26 14:47:15 +00:00
Patrick Luby
a0d8251336 tdf#147342 Notify Skia that the window's backing properties changed
Change-Id: I4185a240a2ca6df1c92e86ff9950f86234d4ace8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146142
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-01-26 14:19:29 +00:00
Caolán McNamara
f12ea381d5 resave with latest glade
Change-Id: I6e2b3d33bb5388659761b89632d883ddc986de1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146168
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-26 13:57:41 +00:00
Kohei Yoshida
27653feb30 Just use std::variant and std::get
Change-Id: If467225fae07a9d33e324cac9ff32300d6c56534
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146151
Tested-by: Kohei Yoshida <kohei@libreoffice.org>
Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-01-26 13:52:54 +00:00
Regina Henschel
a6bbf5db74 tdf#128568 more font properties in VML Fontwork export
When export a Fontwork shape to VML then currently only font name and
size is exported. The patch adds style 'italic', weight 'bold' and
the special properties 'Character spacing' and 'SameLetterHeights' of
Fontwork shapes.

Change-Id: Ifb7b42ab6c63e12f5f672e670a3bde5bcf20b1aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146148
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-01-26 13:00:36 +00:00
Miklos Vajna
bef6c5ca4e sw: inherit SwFlyAtContentFrame from SwFlowFrame
Checking how e.g. section frames are split in SwFrame::GetNextLeaf(), we
call into SwFrame::GetNextSctLeaf() which then calls a dedicated
SwSectionFrame ctor that connects the master with its follow.

Add infrastructure to be able to do the same for fly at-content frames.
(At-fly anchored and as-char anchored frames are not relevant for the
broader multi-page floating table picture. Also, SwFrame::GetLeaf()
wants to work with a non-abstract type, so allocating SwFlyFrame there
would make no sense, so inherit SwFlyAtContentFrame and not SwFlyFrame
from SwFlowFrame.)

This is meant to be a minimal change, that can be unconditional, seeing
that the only dynamic_cast to SwFlowFrame in RestoreContent() only does
something if the frame has a follow, which is never the case at the
moment.

Towards an initial layout for multi-page fly frames.

Change-Id: I8ea930bed4bbddb96b181796ab893e810ba9dcd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146160
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-01-26 11:39:58 +00:00
Jean-Pierre Ledure
9079d15ec5 ScriptForge (SF_Calc) more accurate comments
Impact only on comments, code left unchanged

Change-Id: I5549f2549d2b9ff351ad6174b9dba458525db210
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146139
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
2023-01-26 11:22:37 +00:00
Noel Grandin
b6f8734963 improve comment about SKIA_DEBUG
Change-Id: I1101b0cc51a8c1f4302f479c3dcd3db002c1be88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146164
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26 11:09:12 +00:00
Caolán McNamara
070292c719 include filename if the test fails
which it does for me with fedora 38 s390x

Change-Id: I32ad30061717287e785a395afc893db1a5764bcd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146165
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-26 11:00:56 +00:00
Xisco Fauli
40d76def20 tdf#153161: sd: move UItest to CppUnittest
Change-Id: I14c1bc76b6cf19e287ef57a0aa5f34d842c69309
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146163
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-26 10:38:10 +00:00
Noel Grandin
4b1d750f9c use more concrete types in sd console
Change-Id: I5ac9d084616563ba3ae67ee040b4f52156baea67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146159
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26 10:05:41 +00:00
Noel Grandin
622cf1dfe5 use more concrete types in sd
Change-Id: Ia2903695ddb451e21b0ed4e8d0a149d912558a4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146158
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26 10:05:33 +00:00
Noel Grandin
d4237bfb17 GetDrawController should return pointer
since it may be nullptr

Change-Id: Id618ef6a25a8432024a67170a7d1402cb0fa6b8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146157
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26 10:05:24 +00:00
Noel Grandin
6b1f838803 use more concrete types in sd
Change-Id: I545858fe18e8a436fd2dda7402c825eac28fb2fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146156
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26 08:32:42 +00:00
Andreas Heinisch
263c15ee23 Delete extra whitespaces inserted by the editor
Change-Id: I89ef4d04e27e52f5ee6168f368e23f96e112a8be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146085
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-01-26 07:45:25 +00:00
Miklos Vajna
cba2fda9ce sw, FN_DELETE_TEXT_FORMFIELDS: remove unused StateMethod
FN_DELETE_TEXT_FORMFIELDS is only handled in SwTextShell::ExecField()
and SwTextShell::StateField() doesn't seem to have a default handler for
slots not mentioned explicitly, so this is not needed.

Change-Id: I00bc3c543c44d541d352748c721be43b76965e32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146144
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-26 07:38:41 +00:00
Noel Grandin
bfb8706466 no need for sd::ModuleController to load these factories via UNO
Change-Id: I2ac1d29ff9cbd5c8676dc1957a62ea02454d052e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146122
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26 06:36:45 +00:00
Noel Grandin
fec0b1e444 use more concrete types in sd
Change-Id: I754847ac759fb7c946f2c021e898fc0139ca5226
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146116
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-26 06:36:37 +00:00
Jim Raykowski
60035ea9b4 tdf#146178 Allow navigate by field to advance from last field
of document to the first field in the stack, and reverse

Change-Id: Ie0ef1eee0c556644f0b87a65b4bde1a7d9cdf337
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145775
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-01-26 03:12:48 +00:00
Kohei Yoshida
516bc904e9 Upgrade mdds and orcus to 2.1.0 and 0.18.0, respectively
Change-Id: I288b5b54bd07d951bcc68afda7514bde730193dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146107
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2023-01-26 02:27:57 +00:00
Caolán McNamara
df470d9658 ofz#54437 Timeout
Change-Id: Ib9b581a5e8b2385300923b2dc5bfaf7cee9c6bb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146146
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-25 20:39:08 +00:00
Caolán McNamara
647163e604 ofz#55392 Out-of-memory
Change-Id: Id1a351e25c3dcbff513357bb3ff4370e1430ff68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146147
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-25 20:38:41 +00:00
Caolán McNamara
71a04c2484 ofz#55389 Integer-overflow
Change-Id: I98bd62634ca054a668513df426fca408c78e7c95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146145
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-25 20:38:11 +00:00
Justin Luth
72b69aa86c sw: check for control before cursor pos on WrtShell ctor
It may be entirely possible that WrtShell always starts
with the current cursor at the beginning,
but it certainly shouldn't hurt to at least attempt to
look prior to whatever the cursor is when it starts up.

I just created the ability for getFieldmarkAfter
to loop around to the beginning, but I kept this
code the same initially to avoid sullying the basic patch
in case these particular lines somehow do bad things.

But /*bloop=*/true seem more appropriate to the intent
of this function than a false would. If we are in form
mode, do anything possible to get into a fieldmark.

Of course, we also have activeX controls
and content controls, so perhaps this needs a bit
of expansion to handle those as well...

Change-Id: I8a6ec499e3d88203e036baa9b4eada5592fcd815
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146047
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-25 20:21:19 +00:00
Michael Stahl
43744a9004 tdf#153090 sw: add UI to SwTOXSelectTabPage
Add a checkbox, label and a combobox, for Table of Figures/Table of
Tables/Table of Objects - annoyingly the latter is sort of disjoint in
the .ui file.

Another annoyance is that the tab page sometimes reads its own state
while initialising itself, overwriting its source.

This is perhaps not ideal, but it appears to work if you don't look at
it too closely.

Change-Id: I3d3d79f37a75bf6570149d794a2363a53de2f59f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146143
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-25 19:46:06 +00:00
Caolán McNamara
9d60497954 tdf#153092 text appears missing with font sizes < 1
where the size is scaled up, so restore use of scaling up when necessary.
But continue to use unscaled supplied values when provided integer sizes
to avoid scaling down.

Change-Id: I8de268d1c9ac8f0a75aa84e231812b12310db76a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146140
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-25 19:24:18 +00:00
Stephan Bergmann
4e0858dd9e Use ImplInheritanceHelper in AccessibleTabBarPageList
Change-Id: I1f03912046d94bd0e14f65310d93ec4f539fa304
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146115
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 18:56:17 +00:00
Stephan Bergmann
02fbe937dc Use ImplInheritanceHelper in AccessibleTabBarPage
Change-Id: I25092aa7307d9f1d69fbb29eb9a2db74071f760f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146114
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 18:56:06 +00:00
Stephan Bergmann
5db518df93 Use ImplInheritanceHelper in AccessibleTabBar
Change-Id: I709b18500f417f3f7019118bc2a298e73bbedcea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146113
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 18:55:47 +00:00
Stephan Bergmann
7af63ddd93 Use ImplInheritanceHelper in AccessibleListBox
Change-Id: I7fd3c43a991300a6180094ef9ac44e0dc3c56764
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146112
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 18:55:36 +00:00
Stephan Bergmann
4bde82182c Use ImplInheritanceHelper in AccessibleIconChoiceCtrl
Change-Id: Id5dec3b807509a073fcd2383ec37d2712cf24e9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146111
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 18:55:21 +00:00
Stephan Bergmann
bbe70a7e3d Use ImplInheritanceHelper in OAccessibleControlContext
Change-Id: I11d8f487df0c9e707be6a2aa98a32135643552f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146110
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 18:55:06 +00:00
Stephan Bergmann
9fd65d8f94 Revert "Update skia to m110"
This reverts commit aef70869b0 plus follow-up
4172fcb751 "Fix no-pch Windows build: missing
include".  It caused my Windows build `instdir/program/soffice` to immediatley
fail with

> skia\include/core/SkRefCnt.h(62): fatal error: "assert(this->getRefCnt() > 0)"
> warn:skia:10572:7804:external/skia/source/SkMemory_malloc.cxx:32: sk_abort_no_print

on start.

Change-Id: I751f83eda28d9a5a8f9dd4b2429389906ffce983
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146132
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 17:25:32 +00:00
Heiko Tietze
9844064f25 Resolves tdf#152947 - Accessibility for save status icon
Added a rectangle around the *yes variants

Change-Id: Ia60a5e4f6f7b0e04d0f0e7e8c5fd7bd0f8fa5492
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146136
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-25 16:42:17 +00:00