The option /Zc:wchar_t- prevented to use wchar_t as a built-in type
according to the C++ standard. In Visual C++ 6.0 and earlier, wchar_t
was not implemented as a built-in type, but was declared in wchar.h as
a typedef for unsigned short. Now, years later after the end of life
this outdated toolchain, there is no reason not to use native type.
The only issue could be the ABI compatibility. But on a quick look at
least, it looks like none of the mangled C++ symbols in the stable URE
interface actually depend on wchar_t.
We forgot to get rid of /Zc:wchar_t- in 5.1. Do that for LibreOffice
5.2, though.
Change-Id: I8d6b380660859efa44c83c830734978d31d756a0
Reviewed-on: https://gerrit.libreoffice.org/22589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Let the templated makeAny(v) just call Any(v), so that any special handling of
argument types needs to be only done for the Any ctor, not also for makeAny
(both the original makeAny implementation and the Any ctor implementation
internally use cppu::getTypeFavourUnsigned to determine the UNO type, so this
does not cause any difference in behavior):
* The specialization of makeAny for bool can be dropped.
* The overload of makeAny for OUStringConcat is replaced with an overloaded Any
ctor, so that
Any(s + "foo")
works now, too.
Curiously, only the Any ctor had been deleted for a sal_uInt16 argument (which
can conflict with sal_Unicode), but not makeAny. So introduce a specialization
of makeAny for sal_uInt16, so that that continues to work. (For backwards
compatiblity in the non-LIBO_INTERNAL_ONLY case; and in the LIBO_INIERNAL_ONLY
case we're moving away from the sal_uInt16/sal_Unicode clash anyway thanks to
C++11 char16_t, so it is arguably better to allow makeAny for sal_uIn16 than to
prohibit it.)
Change-Id: I7803703769730024863bb4e5b1b3416b81bd8960
FilterCache::impl_saveItem changes the properties of a config. item
one-by-one. But it also listens to the configuration changes and reloads
the whole item from the configuration on change...
Change-Id: I9e4ed1c6b013925d07f0942717fe3421f924279d
...which only happens ot work in environments where sizeof (bool) == 1. The
simpler alternative is to use the operator <<= template without passing explicit
UNO type information, anyway.
The std::nullptr_t overloads are needed to disambiguate calls with a nullptr
argument. (Which can at least be meaningful for VOID, but for other types what
it happens to do is store a default value of the given type.) As std::nullptr_t
is only C++11, this all needs to be LIBO_INTERNAL_ONLY.
Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
...which only happens to work in environments where sizeof (bool) == 1. The
simpler alternative is to use the Any ctor template without passing explicit UNO
type information, anyway.
The std::nullptr_t overloads are needed to disambiguate calls with a nullptr
argument. (Which can at least be meaningful for VOID, but for other types what
it happens to do is store a default value of the given type.) As std::nullptr_t
is only C++11, this all needs to be LIBO_INTERNAL_ONLY.
Change-Id: I0f72c73a088ef96e069c3ed8c78546b16d89b50a
SwHTMLParser::SetControlSize() loads a "hidden document" into the same
model (!) that is currently being imported (!), just so it can get a
awt::XControl from the ViewShell; unfortunately creating the ViewShell
happens to enable Undo too, so turn that off again.
This avoids triggering the assert in SwRegHistory::InsertItems() on
kde122884-1.html
Change-Id: I3d8fcd5c43bcb8e7ed8775710acbc2d40f2ffdd0
If decimal part is empty (with #) decimal separator should not be added.
It was not removed if there was text after value.
Change-Id: I891cad8b6bec0f27f4cef8aea80c5dad264f062d
Reviewed-on: https://gerrit.libreoffice.org/24586
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Quoted text should be detected and skiped
before detecting conditions
Change-Id: I1c78fed7f543fb335fbb8ec9ed50d9ab9dd10aa7
Reviewed-on: https://gerrit.libreoffice.org/24550
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Test if fraction format has no integer part is modified
to take into account all cases: ??/?? or ##/##
and do not detect false positive like ? ??/??
Change-Id: Ia8677a5ad496e5df56ce6bf1290323555e46ba0a
Reviewed-on: https://gerrit.libreoffice.org/24540
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
.xcu stores a '.' between keys and keys with no name count
.src has commands without name (identifier used instead)
Change-Id: I135c5f5594c429ebc1b278dbb7d5709b7b8ca119
Macros do not always end with \\ only those for translation
added #define exception to the lex layer.
Change-Id: I656bb8776d970288c243302cdc74a0afd975975e
The dialog calls SwEditShell::UpdateFields(), so if there is already
a existing field at the current cursor position it will be "updated"
before the new field is inserted.
Change-Id: I8ddbbe00534950759781a1ce8d0dca0376663462
This functionality seems to only have been used with NPAPI plugins.
They've been previously removed. Per the help text, if it is still
used by anything, you can use the context menu instead.
MN_READONLY_PLUGINOFF also appeared to be unused, so removed.
More code might be removable, but would affect activate on click/visible.
Change-Id: I12d5bf54edd3a2f716912179b87e798b47b3cc3d
Reviewed-on: https://gerrit.libreoffice.org/24500
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Project: help b4f803adf47059a195de82e8757a3fe1856f4596
Fix bookmark element
...that was broken by previous 7baa265c995f1d27cef325bf1583a579737e11df
"tdf#99637 Don’t mention Undo settings now in Expert Configuration"
Change-Id: Idecc9cca5bdef2da8a027ae9e1ce6f76d46dcdb5
Project: help 7baa265c995f1d27cef325bf1583a579737e11df
tdf#99637 Don’t mention Undo settings now in Expert Configuration
Change-Id: I5a6c8a193a1f80683a79e1e1b255d67586493a6e
...by changing the dialog text from "Enter user name and password for..." to "Wrong
user name and password for..." when an old password is already given.
Change-Id: Ie167c5ea263e9f75e0269c528dc88b69270208f3
This reverts commit bfca69eddd3d94e74d6b73f91476b79c8f72cce7.
Rather let the caller check for a valid token instead of checking it
twice for other places that already do, and we usually need two valid
tokens before even one call makes sens.
LO uses the .src quite differently, so a new implementation
was made.
The unused old functions are hanging in a #if 0, and will
be removed later.
Change-Id: Ic466a1b97f9f65c9f658612bd2aa325396e929c3
The new Google login sequence uses two html pages: one for user email
the other for password.
The older sequence used only one page for both user email and
user password.
Change-Id: If875ba3ec9680d7e8c700a269873e427ac037a8e
Reviewed-on: https://gerrit.libreoffice.org/24513
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
