Commit graph

461309 commits

Author SHA1 Message Date
Hossein
ea5641baee Updated README.md files to represent current code / use Markdown format
Previously, all of the README files have been renamed to README.md
and now, the contents of these files were changed to use Markdown
format. Other than format inconsistency, some README.md files lacked
information about modules, or were out of date. By using LibreOffice
/ OpenOffice wiki and other documentation websites, these files were
updated. Now every README.md file has a title, and some description.
The top-level README.md file is changed to add links to the modules.
The result of processing the Markdown format README.md files can be
seen at: https://docs.libreoffice.org/

Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07 17:47:16 +02:00
Tomaž Vajngerl
33da78c21f vcl: move graphic handling into Qt5GraphicsBackend
This is an effort to make SalGraphicsImpl mandatory for all
backends.
This introduces Qt5GraphicsBackend: a subclass of SalGraphicsImpl,
which now handles graphic rendering.

Change-Id: I42aece59d0c692ca1dd33e30f31c5bcceab02008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113734
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-07 17:46:14 +02:00
Tomaž Vajngerl
5a251208fe vcl: class to automatically delegate calls to SalGraphicImpl
A class for SalGraphic backends that delegates all the graphic
drawing calls to SalGraphicImpl.

Use this for GenPspGraphics.

Change-Id: I0461259802732e9107d9011608530f1ffe2891ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113733
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-07 17:40:04 +02:00
Luboš Luňák
43bcc236d8 cache Skia font
The conversion costs a little bit and it was done for each drawing.

Change-Id: Ifaad42308213f15839d9277beb837d21535bfc25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113735
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07 17:01:40 +02:00
Luboš Luňák
f99b311964 implement operators +,-,*,/ for tools::Size
If they exist for tools::Point, I don't see why they couldn't
do the same also for Size.

Change-Id: I02ca1bb413b0bd2694a904372e9a18a7a50be17b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113725
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07 17:00:38 +02:00
Luboš Luňák
d75a4d02c9 make tools::Point/Size/Rectangle/etc. constructors constexpr
Change-Id: I4aebf90bba7944f2f8e33312120f8714a8a1c2e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113724
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07 16:59:52 +02:00
Luboš Luňák
f73d57b260 avoid pointless O(N^2) dynamic_cast
I already tried to reduce the cost of this in ef4964a4e5,
but back then I missed the fact that in fact all the casts guaranteed.
So partially revert the first commit and simply use static_cast.

Change-Id: I4231f698119d56e9f2536f2f0c9d824442d76b09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113736
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07 16:59:19 +02:00
Henry Castro
bcecb77817 lok: show only the filename of the Macro Security dialog
Apply the patch for desktop case too.

Change-Id: Ia4cf6d2cefd0e02e11e48ca017f8af9f81600b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112003
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113688
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07 16:44:04 +02:00
Mike Kaganski
c89bfbc0d6 rtl::Static -> function local static also for UNO3_GETIMPLEMENTATION*_IMPL
Follow-up to 07fd90cc7d

Change-Id: I788607fe14fe12db015bf023dfac5bdc196b52ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113730
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-07 15:39:31 +02:00
Henry Castro
4079d59c01 lok: remove popup auto correct item
The auto correct options and auto correct
menu item are no longer need it.

Change-Id: I0a5e624c3393151cf80a06961f96d6a5fb8891ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113680
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07 15:36:16 +02:00
Caolán McNamara
7ecd3a095b skip check-if-root test if LIB_FUZZING_ENGINE is set
https://github.com/google/oss-fuzz/pull/5588/checks?check_run_id=2285987092

Where presubmit checks for oss-fuzz fail with
Makefile:62: recipe for target 'check-if-root' failed
despite the efforts made to detect running inside a container

LIB_FUZZING_ENGINE is set by oss-fuzz which builds LibreOffice by
calling bin/oss-fuzz-build.sh which uses
distro-configs/LibreOfficeOssFuzz.conf that enables --enable-fuzzers and
--enable-fuzzers ensures LIB_FUZZING_ENGINE is set, so checking for
LIB_FUZZING_ENGINE seems a reasonable test here to skip the root check

Change-Id: I930c87c13bd365b0adbefd3625598a89e48468ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113731
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07 15:01:10 +02:00
Armin Le Grand (Allotropia)
2f665daa29 tdf#141528 ensure that reset of linked state is executed
Take m_xDocHolder->GetComponent() and xModif->setModified
inside the local try..catch expression to ensure that the
reset of the linked state below (m_bIsLink and .clear())
is executed

Change-Id: I52d49569a43fd2c23dd997c7217f7552cbdcfb82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113722
Tested-by: Armin Le Grand <Armin.Le.Grand@me.com>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-04-07 14:40:04 +02:00
Caolán McNamara
f56af9a458 Resolves: tdf#141515 expander column space isn't wanted
in the relationships view

Change-Id: I1d4a34dbf86a797573705c202719f5159b5a8bcd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113729
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07 14:01:10 +02:00
Szymon Kłos
d4437f5071 jsdialog: simplify unselect for treeview
Change-Id: Iaadd8122d735103d89e4acb65bef1ca8c1ad2e1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112532
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113679
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-07 12:31:00 +02:00
László Németh
8e6203bd8f tdf#126735 sw Next Change: cycle through tracked changes
Next/Previous Change commands don't stop at the start or
end of the document, but continue on the end or start
of the document to cycle through all tracked changes,
like Find Next/Previous and other office suites do.

Change-Id: I5578d6b98b81ca1f8f222ba78e7d3c08339eca89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113716
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-07 12:22:53 +02:00
Michael Weghorn
d3c5087b1f tdf#141531 liblo-native-code: Add ODatabaseContext_get_implementation
Add 'com_sun_star_comp_dba_ODatabaseContext_get_implementation' to
liblo-native-code, needed to open mail merge files
with data source since

    commit e64dc07ca8
    Date:   Mon Mar 29 11:52:05 2021 +0300

        tdf#139906 Show warning message when data source is not avaible.

Change-Id: I6fdd500f9c3b9cc54310e78df694eba7103ff0b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113717
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-07 11:42:13 +02:00
Justin Luth
cfdfe45bf2 tdf#141341 docxexport: consolidate conversion of NumTypes
so that one comprehensive function is used for Page and Footnote
numbering types (which was already being used by list numbering).

I also added support for CHARS_ARABIC_ABJAD <=> arabicAbjad,
which was my trigger for consolidating all this.

OOXML has one definition (ST_NumberFormat) that specifies the valid
values for pgNumType, numFmt (list numbering),
numFmt (Endnote and Footnote numbering), so use the same
conversion function for all of these.
[Also used for caption, but I haven't noticed that yet in export.)

In the previous code, there was no possibility for
fmt.isEmpty() [despite repeated checks for that situation].
However, I thought it made sense to not specify anything if
the conversion didn't match something known (because perhaps
the locale could take over then?). In any case, that is a
slight change, but for pgNumType we were specifying "none"
instead of decimal, which didn't make much sense either.
So I don't expect anyone crying 'regression' over that.

Change-Id: I90037eb25a0f71d22d6ad1848f43761eb6b9fe00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113351
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-07 10:34:35 +02:00
Caolán McNamara
a3f0459e57 ScDocShell::GetActiveDialogParent instead of Application::GetDefDialogParent
which is more likely to be the relevant calc window

Change-Id: I7c939c42752e103494a1df7154b3318643d5206c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113705
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07 10:05:35 +02:00
Caolán McNamara
6b46b053c7 ofz#32965 move fpe fix of ofz#17212 into toRational
Change-Id: Ica301357f45fd289c41234b8a7059ab0ff264321
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113703
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07 10:05:08 +02:00
Michael Stahl
79ef3c7ae3 tdf#141467 xmloff,sc,sw: ODF export: reorder flys' ZOrder/z-index harder
Also keep the control layer distinct from the foreground, as a follow-up
to tdf#133487.

Try to improve the detection of already sorted indexes a bit to avoid
unnecessary sorting.

Hilariously the test docs require adding 3 additional items to the
extension schema.

Change-Id: I629d5b09294f679717677b9d89537d905ac4c404
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113696
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-07 10:03:15 +02:00
Xisco Fauli
795a3ad8ef tdf#141297: sd: Add UItest
Change-Id: I0e0a7869b77719d5080e6f4df83159251bed2f42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113708
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07 09:49:36 +02:00
Miklos Vajna
9ac1d3ac65 tdf#141267 PPTX export: fix handling of audio nodes with non-media source
Regression from commit cf5fa358a6 (PPTX
export: fix missing audio anim node for slide narrations, 2021-01-25),
the problem was that the audio source can be any kind of shape, not only
a media shape.

Fix the problem by explicitly checking of the shape has a media URL.

Change-Id: I2bdde0f9ed3576f307aabff5e39d441f295c203f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113715
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2021-04-07 09:45:13 +02:00
Szymon Kłos
c5153e9078 jsdialog: unselect treeview entry by iterator
avoid crash when using relative position from
deeper levels returned by get_selected_index
to unselect entry using unselect function
on root level

Change-Id: Iaaddb131031eb5273cb06412c976f310f7323f52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112374
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113678
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-07 09:03:59 +02:00
Xisco Fauli
c38a4a2dba tdf#119661: sw: Add UItest
Change-Id: I7e24060b9b8e3b2b673a854256c8d8afaf399eb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113707
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07 08:40:40 +02:00
Michael Weghorn
4cfcc0f48a tdf#141338 android: Make "Select file to open" view smaller
Use the same height as is used for the "Recent files"
entries.

Change-Id: Ia6c1e02507ac12b554eb042d6dd32c0fc78cb578
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113675
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-07 08:30:38 +02:00
Michael Weghorn
91eb5026f9 android: Move "Recent files" below system file picker view
Move the view that opens the system file picker when tapped
above the "Recent files" view in the Android Viewer start
activity.

Change-Id: I63ee0ea7fb784a3405877fcf5ed587ce06e8e093
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113674
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-07 08:30:17 +02:00
Michael Weghorn
a23bd42e9b android: Drop custom file abstraction + UI
Android Viewer had its own file abstraction layer.

From the (now deleted) IFile.java:

> An abstraction of the File class, intended to be implemented by different
> Document Providers.
>
> It represents a file or a directory in the context of a certain Document
> Provider. It wraps the file-related operations and provides access to the
> final document as a local File, downloading it if necessary.

However, Android already provides such an abstraction by
what is called "documents provider" there as well, s. [1].
Android Viewer has previously been adapted to
support and make use of that.
Therefore, drop the custom implementation to avoid
duplication and having to reimplement functionality
already provided otherwise.

Also, drop the custom UI elements to display and
select files implemented on top of the custom
file abstraction. Support for using the system file
picker (via the corresponding Intents) has been added
earlier and is now the only available option to open
files from within the app.

[1] https://developer.android.com/training/data-storage/shared/documents-files

Change-Id: Ide529e836a32fd7e880e5a72d971af9f9c7e74bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113667
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-07 08:29:57 +02:00
Noel Grandin
07fd90cc7d rtl::Static -> function local static
Change-Id: I2071c27bdf074403ec24e67f9278ac27f9491303
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113698
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07 08:08:44 +02:00
Stephan Bergmann
908b47604b loplugin:casttovoid: Fix VisitReturnStmt in lambda bodies
...as caused the

  assert(!returnTypes_.empty());

in VisitReturnStmt to hit for the return statement in the permutation2D lambda
body (which does not happen to be nested within any other function declaration)
in patch sets 1 and 2 of <https://gerrit.libreoffice.org/c/core/+/113522>
"Compute permutation2D at compile time".

Change-Id: Ic4aa55bef4361e40c2cd6247b5646f7b1ba82e6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113699
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-07 07:29:20 +02:00
Dennis Francis
3092322bb8 lok: draw bgcolor lines for covering client grid...
... that are over merged cells area. This is needed as client has no
information about merged cells.

Change-Id: I625d64cc3abd0ee1e60a8af9469a152286f25fd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113145
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit e3fa896aa1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113632
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-04-07 06:28:27 +02:00
Eike Rathke
d0b4719ca3 Related: tdf#128334 Make VBA Range getFormula(R1C1) work not only by accident
i.e. if document native grammar was very similar to the API
grammar (English UI function names, English locale and
separators, address convention).

Also alloc and init second string and conversion only if necessary.

These Formula and FormulaR1C1 properties still behave like
FormulaLocal and FormulaR1C1Local, which is wrong, see
https://bugs.documentfoundation.org/show_bug.cgi?id=128334#c12

Change-Id: I589b36c2cd51d5bbba767a309ccf61bd051928a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113711
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2021-04-07 02:22:54 +02:00
Jan-Marek Glogowski
ea4fb1559f tdf#136918 restrict symbol size to button width
... and scale the button based on the DPI scaling factor.

The symbol size is based on pDev->GetTextHeight(), but the button
itself is fixed to 20px, which would break at some point. So this
at least scales the button witdh based on DPI, just like commit
1eba1c4597 ("tdf#130991 Scale the
drop-down arrow size-request") did for the toolbar buttons.

OTOH this should probably just use the full button width ignoring
the GetTextHeight()...

Change-Id: I43010443265c10ad92f46cdecd1d7155a7a07a3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113710
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-07 01:27:51 +02:00
Eike Rathke
4d4fd4cc57 Resolves: tdf#128334 Reset mnCurrentSheetEndPos, mnCurrentSheetTab in all cases
Encountered for a single decimal separator not being a value
either, but could be for any condition within IsReference()
returning false up to the IsSingleReference() call.

Change-Id: I6222adf2a2d06904001175da8798b2ba9fdef99c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113697
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2021-04-07 01:01:00 +02:00
Mike Kaganski
6aa6b6c814 Fix --disable-pch build: missing include
... after b1253218e4

Change-Id: I62f4c06d804258ed25a0906510ab215e8a8482e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113704
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-06 23:25:10 +02:00
Henry Castro
598348c797 lok: strip directory and suffix from filenames
The Macro Warning dialog should only show the filename

Change-Id: I04f1d3a1b945d65276187ca0a284e41bd08ed298
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111941
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113687
Tested-by: Jenkins
2021-04-06 23:13:12 +02:00
Andrea Gelmini
317af2e31b Fix typos
Change-Id: I64d32773984a3ab06e809fcaeff8f95b910e127b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113700
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-06 23:01:31 +02:00
Stanislav Horacek
cf5cea8a44 Update git submodules
* Update helpcontent2 from branch 'master'
  to cc74ec0700415f60fe1f893d38c8bdf94b0f8f2b
  - use variable for path to AutoCorrect Options menu item
    
    Change-Id: I306a1fb2fd10d52d1d1d879558a90b62c9900534
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113263
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-06 22:59:55 +02:00
Caolán McNamara
c2c5b1f755 remove Application::GetDefDialogParent call in editeng
and pass in an explicit parent to use

Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06 21:46:05 +02:00
Julien Nabet
b5b27f017b Following 6fcabbd619
...tdf#129153: Show MIME type icon in main menu File>Recent documents list

No need to call n times aIconSettings ctr + GetUseImagesInMenus() since it won't change in the loop
+ rename "aIsIconsAllowed" to "bIsIconsAllowed" since it's a bool

Change-Id: I5729f0cdba9a0973afe4d0188f11361877300193
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113682
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-06 21:34:17 +02:00
Caolán McNamara
765e42d4c3 translation domain of sfx for .ui in framework doesn't look right
though there is nothing to translate. Probably should be fwk, but
there are no other .uis in framework and startmodule doesn't feel
right either. So just put it alongside the other svtools .uis
and give it a svt translation domain and fetch it from svtools

Change-Id: If6b89ae3b2ba45673f5ee5e3e9a4e1da40c80a53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113528
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06 21:28:35 +02:00
Caolán McNamara
84a4da19ae ExecuteSpellPopup never called with a null spelling callback
Change-Id: Id03001541ccfd8503a7b8181598bad9811542b4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113694
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06 21:28:03 +02:00
Xisco Fauli
8bdf557876 tdf#141084: sw: Add UItest
Change-Id: Ib301adfe480217550b008f88938bb9cacc8c98ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113664
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-06 21:12:02 +02:00
Henry Castro
b9554a6b20 lok: disable macro execution
Change-Id: I97a1fd7992d6be57e54c186045e62c3402b99375
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111752
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113685
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-06 20:30:16 +02:00
Henry Castro
6af317bb64 jsdialog: fix missing update for "treeview" action "select"
When Treeview control selects an item, the state of the control
has changed and it should update the new changes to the client side.

Change-Id: I27d6a215148fcef260799d76ffe209460f38c559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111355
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113683
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-06 19:52:50 +02:00
Henry Castro
a7f1439ca7 lok: fix treeview action "select"
Unfortunately the Macros dialog has a treeview control
that fill on demand and the position is absolute and
it has a side effect to deselect the item since the relative
entry position is nullptr.

Change-Id: Ie442f6d634437a293cde65da0764d3f433a70155
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110963
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113677
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-06 19:37:22 +02:00
Caolán McNamara
e90a9b6782 update pches
Change-Id: I835c8fcc237ece5cf9d7a3b261645139d022e9b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113652
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06 17:57:09 +02:00
Caolán McNamara
08f01ab647 typo: Allign->Align
Change-Id: I621dbef277d72f293c4cb10e020683a14d08ac51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113673
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06 17:56:52 +02:00
Caolán McNamara
b1253218e4 forward declare vcl::window in vcl/event.hxx
Change-Id: Ib3fc1b72d3d45377e2d4ccd0ff3e6835d2c29930
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113631
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06 17:32:51 +02:00
Caolán McNamara
b6fa0c15af improve scoping
Change-Id: Ifb34ca678e019ded44af98b18a72f81206168b8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113672
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06 17:32:28 +02:00
Caolán McNamara
3734437acf use GetOutputDevice for ImpEditView::GetBackgroundColor
in case the host is using getEditViewCallbacks

Change-Id: Iadc146a585c3fc3df6f77ab8def2d697da5186a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113671
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-06 17:32:00 +02:00