Introduced in commit f3234f4f14 (VBA
Add Padding properties to XTable, 2022-08-05). The unit test is
edited to test that the value returned by the methods is equal to
the initially set value, with precision of 0.1 pt.
Change-Id: I24144cd0e3c1e72bd2664a2a052ac3c7006595ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169762
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Make their names more explicit. This avoids ambiguity; previously,
convertTwipToMM100 was very similar to tools' convertTwipToMm100,
provoking the former function's use where the latter is better.
Drop convertTwipToMM100WithoutLimit, and use the unconstrained
function from tools directly instead.
Change-Id: Icdd1a67721cdd8a578bc786fda67c341b07ec84a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169759
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
in order to behave like cut
Change-Id: Ia30428edee00950e2874c0f615e4033167c1031b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169754
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
For some reason, MSVC fails to find the o3tl::convert overload for Size
defined in <tools/gen.hxx>, unless the call to convert is unqualified,
accompanied by a 'using namespace o3tl' in convertTwipToMm100.
Change-Id: I7100ef55156b6944b5adc5aefa52eee38b3fe69e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169751
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Use doubles instead of fractions.
Simplify correctWordWrapPolygon, which used redundant arithmetics
(it scaled by a fraction with nWrap100Percent in multiplier, then
by another fraction with nWrap100Percent in divisor).
Change-Id: I69a38ac7e3afda33a1e7725cab711d50dc80eed7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169746
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
This reverts commit ae56dc05b2
"tdf#96787: AutoCorrect: after deleting a replacement entry, it's still used".
Change-Id: Ifb4cf1b359b852c7610337d4bd389a8ca5dce610
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169713
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Use std::copy / std::reverse_copy for double serialization. Also
remove __cplusplus conditions, because the header is not included
in any C files. And simplify the functions uses, where casts were
unneeded.
Change-Id: I1d8375e601851231fdffcf52e3f3e3bdcbcbde7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169706
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
While writting a test for 7f593484a1
"tdf#158051 AutoCorrect: don't apply final sigma before apostrophe"
I realized the added rules where *σ’ -> ς’ ( which was the old behavior
)
instead of *σ’ -> σ’
Change-Id: Ibff92e74da3d353ba715025b244b614b7fb8f9fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169717
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
I ran into a problem where this global object would be destroyed and
then resurrected during shutdown.
Rather than make the existing code more complex, extend the existing
vcl::DeleteOnDeinit code and re-use that here.
Change-Id: Ib63739f57f489b1131111e9bab1db5fba7fd17bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169697
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Even with
commit 69189de8fa
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu May 16 09:26:44 2024 +0200
tdf#157009 android: Add icon symlink for F-Droid
(and its 24-2 backport) in place, the icon is not shown
for LibreOffice Viewer in the F-Droid app and on the repo
website [1].
Revisiting the related specs [2] [3], it turns out
that the icon needs to be in an "icon" subdir in the
"graphics" directory, so add that missing "icon" subdir
and move the symlink there.
From [2]:
> └── listings
> ├── en-US (en-US is the default locale in F-Droid)
> │ ├── title.txt (app name)
> │ ├── short-description.txt (short description, max 80 chars, mandatory)
> │ ├── full-description.txt (full app description, mandatory)
> │ ├── video-url.txt (URL to a video introducing the app)
> │ ├── whatsnew (alternative changelog location; single file, no .txt)
> │ └── graphics
> │ ├── icon (app icon; mandatory if your app doesn't include any png icon)
> │ │ └── *.(png|jpg) 1 image, usually 512x512
[1] https://f-droid.org/en/packages/org.documentfoundation.libreoffice/
[2] https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#triple-t-structure
[3] https://github.com/Triple-T/gradle-play-publisher?tab=readme-ov-file#uploading-graphic-based-listings
Change-Id: I43c23040bf63a34f8f9648b45fab6c47a8816b8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169700
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 8351b40030008eec294de3712fc1b67d99d00931
- Organizer -> General in Help pages
Change-Id: Ibe5a9e819138b964a5f7336f9d4a71c5d43dc1bb
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169683
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
which did I not see when I did
commit cb3c65fb70
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu Jun 27 19:24:28 2024 +0200
assert when SfxObjectItems are modified while in a pool
Change-Id: I16e2ee72eda4b3ca69f83eb70ad4f4b0a14748a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169696
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
when we have a lot of shapes, the number of listeners attached to
SdrModel becomes a serious bottleneck because of the number of
broadcast/notify function calls.
So
(1) make SvxUnoShape listen to the SdrObject
which achieves the same end, and reduces the bottleneck on the SdrModel.
(2) repurpose the maAllIncarnatedObjects set, which tracks all
objects linked to the SdrModel, so we can shut down the associated
UNO shapes during ClearModel. There is no other good way of doing
this, and if we don't do it, we get various use-after-free
issues during shutdown.
This takes the load time of a large DOCX with lots of shapes,
from 35s to 17s on my machine.
Change-Id: I34a6ac35c90de8b7103a7373aafe6e9607cc01c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169612
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
The first character was replaced with a number.
Fallout from 1f93816dd5
Change-Id: I3b9a39336d5f6f3c10c85231f86fd196a29e3644
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169621
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Introduces OverridingShells that when set, makes the view
act like the MainViewShell.
The main use case is having more then one ViewShell in a
single window, where context (toolbars, sidebars etc.) can
jump in between different ViewShells.
Uses OverridingShells to enable NotesPane to react
ToolBarShells. Accessing the functionality of ToolBarShells
without the previous hacks with slot forwarding.
Change-Id: Icc9721d7f54097025bc9dc7ef7069aed856e6d96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169658
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Only shows the error once for a given checkerURL.
Change-Id: I1873dc09584df33162c93d9d133b12eb8dfede04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169518
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
The CTFontRef in CoreTextFontFace::GetVariations() was never
released and a new CTFontRef was allocated in every call to
CoreTextFontFace::GetVariations(). So release the CTFontRef
and only allocate it once when mxVariations is populated.
Change-Id: I08999956501d5860fff67e48001ef85a62ca8079
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169690
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
the tmplate packaging code was full of copy'n'paste code with little
understanding on how the rules actually work/what the statements
actually do. (e.g. using separate calls to addprefix can be a matter
of taste, but adding the call to get the extra files each time is
pointless and just adds the same set of files multiple times).
Unifying the fixed list of files and standardizing the base path for the
relative filenames further allows to streamline the recipes
Change-Id: I814fdb6f6534a9d5046281c45b6da87110f2093e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169342
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
use non-scoped interaction handler instead of the scoped
SimpleFileAccessInteraction so that errors will be handled
with correct pop-up dialogs.
Also throw the correct type of DAVException for
USC_CONNECT_FAILED in Content::Open
Change-Id: If2031dfa2796f91fad6866bc9608194c92658b96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169519
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Update translations from branch 'master'
to b87971d7ac97460271cb13bd0e4cb2e554654a45
- update translations for 24.8/master
and force-fix errors using pocheck
Change-Id: I512d2cb5e312ef9dcec6426c13ad33d10441b017
Export the bugdoc to PDF without noticing that there is a content
control around some of the content and notice how the PDF export lacks
some words from the body text.
What happens is that content controls are exported to PDF as PDF forms
by default, and the selected option of a dropdown has to be an index, so
in case the text of the dropdown content control is not one of the
options, then the PDF will miss those words.
Fix the problem by inserting the text of the dropdown at the start if
there would be no valid index for it.
Also add a bit of padding around the rectangle of the content controls,
it turns out there is a default 1pt border in PDF, and this would lead
to a cut-off text at the end if we don't compensate for that border.
Change-Id: I99447894b320b42ad9ffe0d54d0190000621616b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169694
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
and add some asserts to catch if we modify these things when they inside
a pool, which now that they are in hash-based container, will cause
trouble.
Change-Id: I2779f25cbcf056fbf71e417731d9b1f09ae33dd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169629
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
which has always been a problem, but becomes a more obvious problem when
I implement some upcoming optimisations
Change-Id: I8b0368b0b8e9a726c71d241841afeed3876281d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169657
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
If the paragraph marker is formatted as Uppercase,
then Uppercase is applied to that line's numbering as well.
However, if the marker is formatted as SmallCaps,
it MUST NOT be applied for MSO formats.
Apparently MSO only supports Uppercase and SmallCaps,
not Lowercase or Titlease.
I don't like these adhoc exceptions, so I didn't
attempt to apply them to ODF formats.
Let's keep it simple for ODF - any char format that applies
to the entire paragraph should apply to numbering as well
(except for the existing underline/overline exceptions).
- if you don't like that char attributes apply at all, blame MSO.
- if you don't like that DOCX is missing your goofy formatting,
blame MSO for being inconsistent.
ooxmlexport12's tdf143384_tableInFoot_negativeMargins.docx
is almost interesting because it applies superscript
and small caps. However, the list is already uppercase,
so it can't be used for the test.
make CppunitTest_sw_ooxmlexport21 \
CPPUNIT_TEST_NAME=testTdf43767_caseMapNumbering
Change-Id: I273baebc996adfd001e1c591dbb9aef9272a42f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169476
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
“In Dutch (in Belgium as in the Netherlands), when you type "'s"
or "'t" in sentences like: "Ik ben 's morgens opgestaan", the
apostrophe is changed into an opening quote by the autocorrect
feature, which is incorrect and requires a manual correction.”
The bug reported with the suggested AutoCorrect extension
by Pierre François. The difference here is always to use the
de facto standard typographic apostrophe in the replacement.
Change-Id: I2ede612f72145abcca2bc1477ffae3cabc9e5641
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169645
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
