Commit graph

430855 commits

Author SHA1 Message Date
Caolán McNamara
c79653e33d tdf#101072 mpParent isn't SdNavigatorWin
Change-Id: Ibfb60302ce14f0a3492bf4d9311fb5e598f25719
Reviewed-on: https://gerrit.libreoffice.org/63567
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19 15:47:16 +01:00
Stephan Bergmann
221caface8 More adapting to C++2a char8_t
...in test code that is unhelpfully excluded on macOS, so wasn't covered by
c89a4996b8 "Adapt to C++2a char_t" which I
happened to do on macOS.

Change-Id: I215898a1c468c576d88914ee22deaaaa536d91e9
2018-11-19 15:15:52 +01:00
Andrea Gelmini
7f31a2a7fa Removed duplicated includes
Change-Id: Idd6a5e84d93016f97745e6d9b99e4f79f7614ea7
Reviewed-on: https://gerrit.libreoffice.org/63554
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-19 14:54:41 +01:00
andreas kainz
45e9d8b093 NB calc groupedbar compact big update and sync
Change-Id: I2c9babfd06694c319b387c53613f178e2ea538f8
Reviewed-on: https://gerrit.libreoffice.org/63557
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-19 14:02:14 +01:00
andreas kainz
f1a02fdd43 NB impress groupedbar compact big update and sync
Change-Id: I8156912bb6158716ef9923b53d8f1ade6c89648b
Reviewed-on: https://gerrit.libreoffice.org/63555
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-19 14:00:57 +01:00
andreas kainz
b1baf44324 NB writer groupedbar compact big update and sync
between different context toolbars, ready for release

Change-Id: I6288a9e3c7289fdca8991d4dc207c79f9d488e02
Reviewed-on: https://gerrit.libreoffice.org/63538
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-19 14:00:43 +01:00
Balazs Varga
f35d078091 Related: tdf#108104 Fix nitpick inline in ShapeProperty enum class
Change "///" to "///<" then the doxygen assigns the token on the
correct line.

Change-Id: Ia622a109e6e0797e967aa3c5d3ca4ba21e0ad458
Reviewed-on: https://gerrit.libreoffice.org/63556
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-19 14:00:38 +01:00
Stephan Bergmann
f2a3a51482 -Werror,-Wunused-private-field
Change-Id: Ic7164539420890a1dfef6ece37a1f549bced3d0e
2018-11-19 13:38:48 +01:00
Arkadiy Illarionov
b51f83a1b9 Simplify containers iterations in svx/source/[f-i]*
Use range-based loop or replace with STL functions

Change-Id: Icd11c895b7eca5ad438a8b0e29a762bb22d43b1b
Reviewed-on: https://gerrit.libreoffice.org/63531
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-19 13:17:32 +01:00
Tor Lillqvist
f26e9dc366 FormattedField is gone
Change-Id: I5debe51f2dd44ed659c6e1a358d236303c4b9a4b
2018-11-19 14:11:29 +02:00
Stephan Bergmann
601eb38254 missing include
Change-Id: Ic34c883b5479a959cccf00da5761849ebc008aa8
2018-11-19 13:02:47 +01:00
Stephan Bergmann
7d29c6c49f missing include
Change-Id: Iec63c3a357805e7fb19681ff8590f2444ce33017
2018-11-19 12:20:00 +01:00
Caolán McNamara
97bbffc917 weld TreeView
a) use GtkTreeStores for GtkTreeViews
b) ironically can't store GtkTreeStore contents in .ui apparently
c) set show_expanders for all non-trees and unconverted cases
d) on-demand subtrees

Change-Id: I3c1036a222daba2c129b1a22ffeb3fe35005ae31
Reviewed-on: https://gerrit.libreoffice.org/63336
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19 12:09:25 +01:00
Miklos Vajna
5b3592a42c sw: prefix members of SwTOXBaseSection and SwTableConfig
Change-Id: I2fc2a7d456c92851e7bbb250f4467f3e0fd4f88a
Reviewed-on: https://gerrit.libreoffice.org/63546
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2018-11-19 11:27:49 +01:00
Miklos Vajna
ec11c1aee0 external: update pdfium to 3613
Change-Id: I99bd67f45796eb85635543a5e4563bb7477cf63e
Reviewed-on: https://gerrit.libreoffice.org/63547
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2018-11-19 10:52:21 +01:00
andreas kainz
d0ecdcf4a5 Add addtextbox link to breeze and colibre icons
icon will be used in groupedbar compact Draw context NB

Change-Id: I8f8151fb25d24e0423d5fb625e08f13d27187d8e
Reviewed-on: https://gerrit.libreoffice.org/63537
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-19 10:51:43 +01:00
Gabor Kelemen
492ea7e085 tdf#42949 Fix IWYU warnings in include/vcl/[ab]*
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625
Reviewed-on: https://gerrit.libreoffice.org/63453
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-19 09:38:53 +01:00
Stephan Bergmann
50e644253f Take array-to-pointer decay into account in loplugin:redundantcast
Change-Id: I3c5bace180605d1a72a74feb1bf9f9b184a16d83
Reviewed-on: https://gerrit.libreoffice.org/63545
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-19 09:25:35 +01:00
Andrea Gelmini
adc8dfe0fa Fix _REFESH_ -> _REFRESH_
It passed "make check" on Linux.

Change-Id: I3ec957f3cab6da2790976ed67e2514d58d3e141b
Reviewed-on: https://gerrit.libreoffice.org/61044
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-19 08:37:05 +01:00
Andrea Gelmini
d5b887e232 Fix STR_REDLINE_FORMATED -> STR_REDLINE_FORMATTED
It passed "make check" on Linux.

Change-Id: If89dc17d0a907680f64d0d35dd147e00be694c0e
Reviewed-on: https://gerrit.libreoffice.org/60869
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-19 08:36:23 +01:00
Andrea Gelmini
f4dc137734 Fix typos
Change-Id: I6d51e4eb4a49a30193b904b2c7d62df1e16ea3d9
Reviewed-on: https://gerrit.libreoffice.org/63475
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-19 08:34:08 +01:00
Andrea Gelmini
2f049ebdb3 Fix typos
Change-Id: I0c966f517e337caa340526b48fa62b9910ce0a3e
Reviewed-on: https://gerrit.libreoffice.org/63504
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-19 08:33:09 +01:00
Noel Grandin
67408174f8 loplugin:constantparam
Change-Id: Ifc2a8db82bd8bb508bce7f226e2cb499d1e6f6f8
Reviewed-on: https://gerrit.libreoffice.org/63492
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-19 07:43:51 +01:00
Noel Grandin
9656150f31 loplugin:singlevalfields
Change-Id: If21bdaa8431a4d40bbf70a6e9a119d77a3596012
Reviewed-on: https://gerrit.libreoffice.org/63487
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-19 07:42:14 +01:00
Andrea Gelmini
4c4b05b762 Fix typos
Change-Id: Icf1b10c517d7c575250bc74de03162fbc13c89b1
Reviewed-on: https://gerrit.libreoffice.org/63476
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-19 07:12:04 +01:00
Markus Mohrhard
d71ea82055 add test for tdf#104579
Change-Id: I62112a2aa0eac6aaa78fdadabfc4439f2a66e6df
Reviewed-on: https://gerrit.libreoffice.org/63542
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-19 02:12:26 +01:00
Markus Mohrhard
afe5e1f8de tdf#104579, if no data point shape props are set take the series props
Change-Id: Ia2c0d6b05385a0f3900e20ef807b869e4098654c
Reviewed-on: https://gerrit.libreoffice.org/63541
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-19 01:59:35 +01:00
Stanislav Horacek
8b1d0dbe1d Update git submodules
* Update helpcontent2 from branch 'master'
  - update menu command to protect spreadsheet structure
    
    Change-Id: I14e424aea344ffeab47bc68d99b98dd56492dcbc
    Reviewed-on: https://gerrit.libreoffice.org/63521
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-19 01:30:30 +01:00
Stanislav Horacek
62bcd40ce7 Update git submodules
* Update helpcontent2 from branch 'master'
  - update commands to insert column before/after active column
    
    Change-Id: Ie633d63e70103f2eda88a677e72c7e91482e5ac0
    Reviewed-on: https://gerrit.libreoffice.org/63523
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-19 01:28:38 +01:00
Caolán McNamara
684641b3f8 coverity#1441441 Uncaught exception
Change-Id: I0c2208abe6a995d4980bd93bc5466306c6de696d
Reviewed-on: https://gerrit.libreoffice.org/63534
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19 00:39:32 +01:00
Caolán McNamara
55df51923c coverity#1441442 Unintended sign extension
Change-Id: Id0286f34ccc387dd148e42b83e8f62aacfb54219
Reviewed-on: https://gerrit.libreoffice.org/63535
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19 00:39:18 +01:00
Markus Mohrhard
9ccdf4d8ab tdf#108022, don't overwrite chart export information
Change-Id: I47d8a817022829c8cada614469303e440f377299
Reviewed-on: https://gerrit.libreoffice.org/63536
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-19 00:07:12 +01:00
Zdeněk Crhonek
ec91419438 add uitest for bug tdf#78133
Change-Id: I3a8c43f84fa69ff9a547806bbac9dfd37617f3e3
Reviewed-on: https://gerrit.libreoffice.org/63533
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-18 22:49:49 +01:00
Julien Nabet
e6019a99c8 cppcheck: unreadVariable dp_gui_extensioncmdqueue
Change-Id: I0bf922c5f0135d32f66a756c9e6af0bb22575a75
Reviewed-on: https://gerrit.libreoffice.org/63532
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-18 22:08:04 +01:00
Jens Carl
e1695ce5df tdf#45904 Move XEnumeration Java tests to C++
Move XEnumeration Java tests to C++
for ScIndexEnumeration_NamedRangesEnumeration.

Change-Id: I7cbe9fbeddd4d8ecbccddfdfd14cdcae01a06684
Reviewed-on: https://gerrit.libreoffice.org/63517
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-18 22:03:38 +01:00
Michael Stahl
02ee8445bb coverity#1441443 SwTextFrame always has a SwTextNode
Change-Id: I9453ec9f3021702d89efed0adcf3422a59ae28ae
Reviewed-on: https://gerrit.libreoffice.org/63530
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-11-18 20:34:20 +01:00
Alyssa Ross
c06570c6e9 Fix build on macOS 10.11
Setting an undefined property is a hard error, even though we check for
the property first. Using message notation instead reduces this to a
warning, and allows the build to continue on systems without
allowsAutomaticWindowTabbing.

Change-Id: I572d8900fdeca16c733d541084d64385891733c1
Reviewed-on: https://gerrit.libreoffice.org/63526
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2018-11-18 19:16:06 +01:00
Arkadiy Illarionov
587ef41f75 Simplify containers iterations in svx/source/[s-u]*
Use range-based loop or replace with STL functions

Change-Id: I2ec3e58cc46c9286ef863c732912ca7a729bab62
Reviewed-on: https://gerrit.libreoffice.org/63522
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-18 17:36:54 +01:00
Markus Mohrhard
8b83659bb8 tdf#102186, add test for deleted data labels
Change-Id: Ie4849b62f96cf6829aa845997bbc9647d94f4dbb
Reviewed-on: https://gerrit.libreoffice.org/63514
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-18 15:58:39 +01:00
Caolán McNamara
76e79bfd3d Resolves: tdf#121409 missing dialog parent
Change-Id: Ia290d3cc40806b2a88e33e6dabcf36543992f882
Reviewed-on: https://gerrit.libreoffice.org/63500
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-11-18 15:15:03 +01:00
Julien Nabet
7e89f4194e cppcheck: fix returnDanglingLifetime (l10ntools)
Change-Id: Ia3c094ee65be3f5048df6896a4a6428bdd8fed10
Reviewed-on: https://gerrit.libreoffice.org/63527
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-18 15:03:43 +01:00
Julien Nabet
d186932449 Use std::to_string (OOXMLParserState)
Change-Id: I145f45d9980496e1ba8636597a70c4dcbf49838c
Reviewed-on: https://gerrit.libreoffice.org/63525
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-18 13:29:02 +01:00
Bjoern Michaelsen
ced9b3e50c no more SwClient/SwModify for SwXTableRows
Change-Id: Ic487fc51134bacbbc16b675cc177602874b9bc2a
Reviewed-on: https://gerrit.libreoffice.org/63491
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-11-18 13:19:28 +01:00
Julien Nabet
0c3e10b840 Replace macro IMPLEMENTATION_ENTRY used once (filter)
Change-Id: I9781487fc7cdfd3dc71f27d51d74c0f4138eec65
Reviewed-on: https://gerrit.libreoffice.org/63524
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-18 12:55:26 +01:00
Stephan Bergmann
d30eb91f14 lolugin:staticmethods
Change-Id: I731ad0f55e68ffa7658955c9d8a557da2759fcac
Reviewed-on: https://gerrit.libreoffice.org/63496
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-18 12:51:03 +01:00
Mike Kaganski
a208ece664 tdf#120703 PVS: V560 A part of conditional expression is always true/false
Change-Id: I60bb778a88dd5619efd4858eb74d56d28616c777
Reviewed-on: https://gerrit.libreoffice.org/63520
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-18 12:32:18 +01:00
Mike Kaganski
cf6b3bece7 tdf#120703 PVS: Let ScConflictsFinder::GetEntry return reference
V560 A part of conditional expression is always true: pEntry.

V560 A part of conditional expression is always true: pConflictEntry.

Change-Id: I54fad2b0236c8c686f470a50ce45b096a842d56a
Reviewed-on: https://gerrit.libreoffice.org/63519
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-18 11:07:12 +01:00
Andrea Gelmini
19d7475077 Fix typos
Change-Id: I2a7877dc341e9bcbea231f5ce9edb1236f97df1c
Reviewed-on: https://gerrit.libreoffice.org/63505
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-18 10:47:52 +01:00
Jens Carl
7ff004e8ca tdf#45904 Move XEnumeration Java tests to C++
Move XEnumeration Java tests to C++
for ScIndexEnumeration_LabelRangesEnumeration.

Change-Id: I89c24de2323a2507fd5c1639af72c6b7121e77c9
Reviewed-on: https://gerrit.libreoffice.org/63516
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-18 08:59:30 +01:00
Jens Carl
986217f02d Bin obsolete header
Change-Id: I0a9ffcb8e49f60882fa944fdbc69225286ac3d44
Reviewed-on: https://gerrit.libreoffice.org/63515
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-18 08:59:18 +01:00