Commit graph

430855 commits

Author SHA1 Message Date
Andrea Gelmini
ecb962ed54 Fix typo
Change-Id: I041e0d04dd5a57602fd6139a2a854db243435bed
Reviewed-on: https://gerrit.libreoffice.org/63917
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2018-11-24 06:28:44 +01:00
Stephan Bergmann
70970f8b72 Revert "Do use -O1 for Apple Clang older than 9.1.0"
This reverts commit 55b9706bea, which is obsoleted
by b4f666f2e6 "Bump Xcode baseline to 9.3".

Change-Id: Id2240351ed9495e311d55887b8e34f2aa776ae06
Reviewed-on: https://gerrit.libreoffice.org/63896
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23 23:38:14 +01:00
Andrea Gelmini
7668e3df2d Fix typo
Change-Id: Ie80bd59d4f4cda81d8d8c5badeec095e4f110a98
Reviewed-on: https://gerrit.libreoffice.org/63824
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-23 22:31:42 +01:00
andreas kainz
f6b3a8e308 add keyboard navigation to tabbed draw
Change-Id: I5f68bf42d36ba4bcf3074f458b6aaffada61492a
Reviewed-on: https://gerrit.libreoffice.org/63863
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-23 22:23:02 +01:00
andreas kainz
953f8c7b53 tdf#121401 add can_focus to tabbs
Change-Id: I5e4b3559bdb642a3e0d8a44ad744efe65b684e59
Reviewed-on: https://gerrit.libreoffice.org/63859
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-23 22:22:08 +01:00
Caolán McNamara
f27bfc190d weld SfxMacroTabPage
Change-Id: I167dd233c8af64e31f0e266bac5cf5b9c4658ca6
Reviewed-on: https://gerrit.libreoffice.org/63893
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23 21:28:16 +01:00
Noel Grandin
9c0c5bc5ba convert FormulaDlgMode to scoped enum
and drop unused ARGS value

Change-Id: I9b9d0c9ea64a2174759dcf6406bdf6cd5be5862a
Reviewed-on: https://gerrit.libreoffice.org/63892
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23 20:31:42 +01:00
Noel Grandin
49b1107b6e remove unused enums in reportdesign,linguistic,l10ntools,vcl,svx
Change-Id: I3ae854f9fed485be915ded5bc4d7e93f5db23dc6
Reviewed-on: https://gerrit.libreoffice.org/63891
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23 20:31:22 +01:00
Noel Grandin
c110bfc810 convert CallbackType to scoped enum
and drop unused INVALID constant

Change-Id: Ifbfaeb209ed75af99f8e531105b9f23541034648
Reviewed-on: https://gerrit.libreoffice.org/63890
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23 19:52:13 +01:00
Thorsten Behrens
d112ffd5f1 Unit test for 0853b05b1f
Change-Id: Iea6554448f7a3fcc621eac7248abcee9c4285688
Related: i#117783 and tdf#38443
Reviewed-on: https://gerrit.libreoffice.org/58687
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23 18:32:31 +01:00
Stephan Bergmann
4cc183111a loplugin:override
Change-Id: Ia45b5f7c126c082d8f3835c3c3529a34a9e20975
2018-11-23 18:31:01 +01:00
Noel Grandin
0dbb5f09e0 use binary search for starmath token
Change-Id: I187a5471f0e733007e3a56d8bb4972ee71f7cf17
Reviewed-on: https://gerrit.libreoffice.org/63882
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23 17:55:10 +01:00
Noel Grandin
baf08f569f enum ScMatrix::Op is unnecessary
Change-Id: If4ae97b43f012f1770213d99407ffaadac05f9de
Reviewed-on: https://gerrit.libreoffice.org/63756
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23 17:53:55 +01:00
Stephan Bergmann
b4f666f2e6 Bump Xcode baseline to 9.3
...as discussed at
<https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html>
"minutes of ESC call ..."

Change-Id: I47e23d222b4b27256483dfd7de915dd99ae81317
Reviewed-on: https://gerrit.libreoffice.org/63878
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23 17:03:59 +01:00
Tor Lillqvist
3ace447b0f Use the correct DPI scaling factor in LibreOfficeKit for iOS, too
Fixes the rendering of spreadsheets in the iOS app. (The cell area was
rendered at half the scale of the row and column headers.)

Actual code change only in desktop/source/lib/init.cxx, but update
related comments elsewhere to mention CoreGraphics, too, and not just
cairo.

Change-Id: Ife99c6a2d58e592cfea3b4ed1ab09c19fba77e72
2018-11-23 17:48:20 +02:00
Adolfo Jayme Barrientos
c9b0766aee Update git submodules
* Update helpcontent2 from branch 'master'
  - Hyphenate pre-noun adjective phrase
    
    Change-Id: I108cb3b91031327f7d775857f8e7d55042eccb6c
2018-11-23 16:14:44 +01:00
Stephan Bergmann
d20d442087 Improve wording of loplugin:unoany warnings
...which apparently caused confusion occasionally, cf.
<https://gerrit.libreoffice.org/#/c/58687/5> "Unit test for
0853b05b1fabb231a7d57d811c5a06ee542d3295".

Change-Id: I32f1137bcbb86ffa04bc1a6a58fc93ef69cb3022
Reviewed-on: https://gerrit.libreoffice.org/63874
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23 14:39:44 +01:00
Alain Romedenne
ea297ab097 Update git submodules
* Update helpcontent2 from branch 'master'
  - tdf#114263 add help page for GetPathSelector()
    
    Change-Id: I021dcde2c5bb27713cbbff03af9f3662f187be4b
    Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    Reviewed-on: https://gerrit.libreoffice.org/63807
    Tested-by: Jenkins
2018-11-23 14:06:17 +01:00
Caolán McNamara
b3e5d954dc Resolves: tdf#121644 clear pointer to customlines when customlines cleared
Change-Id: I09bf6f3c484a2d90a865f0a5743c4e99d2f77b0a
Reviewed-on: https://gerrit.libreoffice.org/63871
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23 13:58:00 +01:00
Noel Grandin
981a98af30 remove some unused enums in sc/
Change-Id: I841f64a8b4f7f9a9e09df3b7877843616129dee1
Reviewed-on: https://gerrit.libreoffice.org/63755
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23 13:44:17 +01:00
Noel Grandin
70894bcdb3 improve function local statics
simplify the initialisaion and make them thread-safe i.e. initialise
them using the runtime's local static locking.

Thanks to mike kaganski for pointing out the nice lambda approach that
makes this feasible.

Change-Id: I76391189a6d0a3d7eed2d0d88d28dfa6541eaff7
Reviewed-on: https://gerrit.libreoffice.org/63645
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23 13:35:25 +01:00
Eike Rathke
0c8b936734 Check isEmptyStringQuery() early to avoid call ..., tdf#121052 follow-up
... and comparison of lcl_getPrevRowWithEmptyValueLookup() result.

Change-Id: Ie4b848f30a0696cc40b04376c352a530b99190b9
Reviewed-on: https://gerrit.libreoffice.org/63840
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2018-11-23 12:31:51 +01:00
Caolán McNamara
01e479272a Related: tdf#118764 last of the GtkRadioButtons with can-focus False
Change-Id: I1346478fb8bbb1720ecc6cf7c88407be3b126bf1
Reviewed-on: https://gerrit.libreoffice.org/63867
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23 12:30:00 +01:00
Caolán McNamara
af1cac1fd5 Related: tdf#118764 last of the GtkCheckButtons with can-focus False
Change-Id: I81d3e03a0ccea3851b01d39b2e972b13ef4f6359
Reviewed-on: https://gerrit.libreoffice.org/63869
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23 12:29:42 +01:00
Aleksei Nikiforov
bc023edb6a tdf#121417 Allow dynamic menu changes for Qt5 and KDE5 interfaces
Separate HandleMenuActivateEvent function call from HandleMenuCommandEvent function call
since first one might update some of menus. Also add call to HandleMenuDeActivateEvent function.

Delete action with Qt5MenuItem to reflect the change in actual menu.

Also update underlying qt-based menu from Qt5Menu::InsertItem function.

And update Qt5Menu::SetItemImage to work with different types of descendants of SalBitmap.
This code is shared between Qt5 and KDE5 plugins, but KDE5 plugin uses SvpSalBitmap instead of Qt5Bitmap.
New image conversion process is borrowed from GTK plugin code.
This approach is used in order to properly process transparency channel if it's present, and it is present usually.

This change also fixes tdf#120789.

Change-Id: Ifdc64c3e5d80782955b52e2da8fcff4844d2dc25
Reviewed-on: https://gerrit.libreoffice.org/63862
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-23 12:26:52 +01:00
Caolán McNamara
262377d1b4 check EnableLocalizedDecimalSep
Change-Id: I77b6b28ddf50b6fc363f09bf4f7226d39504a571
Reviewed-on: https://gerrit.libreoffice.org/63865
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23 12:03:22 +01:00
Aleksei Nikiforov
e0d6fe0b55 Move menu item insertion into separate function
Change-Id: I721910bbbd558827e9a5de1f8763426b460f08fa
Reviewed-on: https://gerrit.libreoffice.org/63861
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-23 11:48:22 +01:00
andreas kainz
8d53e34c52 Tabbed NB calc: fix drop down menues
Change-Id: I13978d74ad64891108b4c633d342146ad2655087
Reviewed-on: https://gerrit.libreoffice.org/63858
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-23 11:16:26 +01:00
Noel Grandin
6c19de4713 remove some dead enums in sd/
Change-Id: I72bfaf2be6939798cd3db21df959b07500751fab
Reviewed-on: https://gerrit.libreoffice.org/63754
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23 10:28:32 +01:00
Jim Raykowski
10aebd07f7 tdf#118764 Animation panel tab stop fixes
Change-Id: I551a5e930731b5a173066b831dd40bea1bfdfbcd
Reviewed-on: https://gerrit.libreoffice.org/63834
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23 10:02:24 +01:00
Caolán McNamara
a0131f3200 Related: tdf#118764 last of the GtkButtons with can-focus False
Change-Id: I8001d8c6c950e74df0f909e1cebfb3d1e52a84a4
Reviewed-on: https://gerrit.libreoffice.org/63846
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23 09:55:57 +01:00
Mike Kaganski
8ea1bdce62 Get rid of ValueSet's internal VirtualDevice, draw to RenderContext
This improves support for Online HiDPI scenarios.

Change-Id: I1d4d13d8877b761cabaefa028dcd50d8345d9893
Reviewed-on: https://gerrit.libreoffice.org/63827
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-23 08:37:34 +01:00
Stephan Bergmann
f23aa1a51c Bump compiler plugins Clang baseline to 5.0.2
...as discussed at
<https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html>
"minutes of ESC call ..."

Change-Id: Ia053da171d59747984546f38e19da808825b4f79
Reviewed-on: https://gerrit.libreoffice.org/63832
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23 08:20:53 +01:00
Markus Mohrhard
80cf278d36 tdf#114836, only set changed SfxItemSet properties
By always setting all existing properties again the calls started
to differ between XMultiPropertySet::setPropertyValues and
XPropertySet::setPropertyValue. This patch reduces the changes in
the called methods. We can not avoid slight differences but at least
the risk is minimized that something is unexpectedly changed.

Change-Id: I5866db7be2829e6aba930f620f45db655df4e3f7
Reviewed-on: https://gerrit.libreoffice.org/63854
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-23 08:00:40 +01:00
andreas kainz
df8ef9b050 Colibre icons: add calc data icons and sync with elementary
Change-Id: I38dc00c4d4364e50fa3e3aef8e3d613d9d8b4992
Reviewed-on: https://gerrit.libreoffice.org/63848
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-23 06:00:11 +01:00
Vasily Melenchuk
19923ea1d1 sw: new unit test for XTextCursor
Change-Id: I5b70f6dc8f7399be78daefa95d6d98687d99ec18
Reviewed-on: https://gerrit.libreoffice.org/61098
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23 00:09:57 +01:00
Vasily Melenchuk
ba85d48c03 sw: new testcase for XText
Change-Id: I8c4b89e1e0851e808daa0902f970f967c6d057a9
Reviewed-on: https://gerrit.libreoffice.org/61348
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23 00:09:17 +01:00
Vasily Melenchuk
284dd58e32 sw: new testcase for XTextRange
Change-Id: Ia476f4f001851d0f8b51fca62b5c041b1d866cc3
Reviewed-on: https://gerrit.libreoffice.org/61174
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23 00:08:38 +01:00
Thorsten Behrens
28033ada11 sw: fixup XAutoTextContainer test
This is a follow-up to 4967d498c4 and
avoids to have setup errors making these tests silently pass.

Also cleanup code a bit & share common init sequence.

Change-Id: I043447a28f5e2c9f416aa906135030c07b2cacc8
Reviewed-on: https://gerrit.libreoffice.org/63800
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23 00:08:02 +01:00
Serge Krot
c690fb0fa0 sw: new unit test for XAutoTextGroup
Change-Id: I3928248b73025f304c0e1ef7b5f86349df9a3c8d
Reviewed-on: https://gerrit.libreoffice.org/61267
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23 00:07:39 +01:00
Jim Raykowski
af16e73d78 tdf#121326 Don't tab stop at toolboxes with no visible or enabled items
Change-Id: I4d20bafbda9e6b675654d0359421cf9e57712d15
Reviewed-on: https://gerrit.libreoffice.org/63457
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 22:08:58 +01:00
Jim Raykowski
e08002d10f tdf#118764 Pos&Size and Shadow panels tab stop fixes
Change-Id: Id6ee2eed8ee96b901be8172cccc9b50e01877e3b
Reviewed-on: https://gerrit.libreoffice.org/63361
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 22:07:47 +01:00
Caolán McNamara
4b7e2b8a64 weld SwFramePage
Change-Id: I12f868611860867df26bd29474aa19189c2b9a96
Reviewed-on: https://gerrit.libreoffice.org/63818
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 21:59:48 +01:00
Caolán McNamara
b6aa70dc67 coverity#1441484 Logically dead code
Change-Id: I42a97ccb5cae95f57a03faf210af362a2874fcb1
Reviewed-on: https://gerrit.libreoffice.org/63809
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 21:58:51 +01:00
Caolán McNamara
7b6f9b6db7 coverity#1441483 try and silence bogus Using invalid iterator
Change-Id: I312cef93a0cef48207a3b7f5165dd48d702de3c6
Reviewed-on: https://gerrit.libreoffice.org/63810
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 21:58:25 +01:00
Caolán McNamara
e796f0b499 weld SwFrameURLPage
Change-Id: If189c6bbc11f85a47e3908e4ffcef36344ff8f9d
Reviewed-on: https://gerrit.libreoffice.org/63819
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 21:58:02 +01:00
Caolán McNamara
257a187af4 tdf#120426 save the style names when set or changed
instead of waiting until gaining focus of the listbox,
because of the differences in what that focus means in
the different backends. It was an odd way to do things anyway.

Change-Id: I072e3da04db184b49a86a9888080b60223813729
Reviewed-on: https://gerrit.libreoffice.org/63820
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22 21:55:41 +01:00
Zdeněk Crhonek
6f44d82b0b uitest Calc Scenarios
Change-Id: Iddb099f4b4773d8b70d24d7df011e103fbf0ac7a
Reviewed-on: https://gerrit.libreoffice.org/63806
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-22 21:45:10 +01:00
Serge Krot
9e55c8c7ff tdf#121052 sc: avoid multiple empty value lookups in ranges
Change-Id: I7759aef51af2f400f3f5ec69854fd9133e845f49
Reviewed-on: https://gerrit.libreoffice.org/62712
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-22 21:24:55 +01:00
Tor Lillqvist
54c2e3c83a Don't create temp file in save destination folder when sandboxed
In a sandboxed environment we don't want to attempt to create
temporary files in the same directory where the user has selected an
output file to be stored. The sandboxed process has permission only to
create the specifically named output file that the user chose in the
system file dialog in that directory.

Change-Id: I65274b4c433bd66b436429bea4b287a0505b72c9
2018-11-22 22:03:31 +02:00