Commit graph

423838 commits

Author SHA1 Message Date
Andrea Gelmini
eccea66848 Removed executable permission on images files
Change-Id: I052313be756947926e5807f2dd3071c405838bf6
Reviewed-on: https://gerrit.libreoffice.org/54909
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-02 01:19:40 +02:00
Andrea Gelmini
319a6fb33c Removed executable permission on data files
chmod -x for odp, ods and so on

Change-Id: I74397d9b8e24575130d2776ed90f4cfc13e1f03c
Reviewed-on: https://gerrit.libreoffice.org/52570
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-02 01:18:35 +02:00
Andrea Gelmini
7135c17d47 Removed executable permission on source file
Change-Id: I6f49685efe7b902f42229be000a5ef6f08923086
Reviewed-on: https://gerrit.libreoffice.org/54049
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-02 00:57:01 +02:00
Samuel Thibault
7a95afee62 gla11y: Enable warnings for more widgets missing a label
Namely
svxcorelo-SvxColorListBox
svxcorelo-SvxLanguageBox
sfxlo-SvxCharView
foruilo-RefEdit
svxcorelo-PaperSizeListBox

Change-Id: I5933c750001eeee7a25ce8597d781b4a0dcfbbe3
Reviewed-on: https://gerrit.libreoffice.org/54814
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-02 00:56:17 +02:00
Jim Raykowski
6a4db3a7a5 tdf#105225 A TOX background tab page based on the area tab page
Change-Id: Icc799b98b4ebf8dee6afab98d4a353f7b03e4449
Reviewed-on: https://gerrit.libreoffice.org/55151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-02 00:51:10 +02:00
Jim Raykowski
94cb2ac3cb tdf#105225 A section background tab page based on the area tab page
Change-Id: Ibe758cab371bc53207bd2ca617d123b7d660a774
Reviewed-on: https://gerrit.libreoffice.org/55149
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-02 00:51:02 +02:00
Christian Lohmaier
6fbcb4f1ad par2script: don't bother removing already removed parts of arguments
the s/\@// conflicts with jenkins default directory naming for
concurrent builds and is wrong at this place/in this form:
0ce067c1fc already changed the format of
the parameter from @listfile to @@listfile, so stripping a single @ at
the front won't help at all.
Furthermore the stripping already was added to the
par2script/parameters.pm earlier, so the worker functions don't need to
deal with transforming commandline arguments.

Change-Id: Ic55b8cda3cd114dfc5cb7ded6d53174cd8283af9
Reviewed-on: https://gerrit.libreoffice.org/55196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-01 23:36:51 +02:00
Stephan Bergmann
fa7c081ea7 Remove unused Qt5MenuItem::mpVCLMenu
Change-Id: Ia7f28a54f253f0263cc781feb5997bb51bb640b2
Reviewed-on: https://gerrit.libreoffice.org/55193
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01 21:21:29 +02:00
Stephan Bergmann
03b79b227f Fix various Clang and loplugin warnings in --enable-kde5
Change-Id: Ia79f97ca589720dbdfd14ea03560713fd2d22db9
Reviewed-on: https://gerrit.libreoffice.org/55195
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01 20:52:57 +02:00
Stephan Bergmann
e1ab044401 Improve loplugin:unreffun
...to avoid a false positive in --enable-qt5

> [build CXX] vcl/qt5/Qt5Widget.cxx
> /home/sbergman/lo/core/vcl/qt5/Qt5Widget.cxx:466:21: error: Unreferenced function declaration [loplugin:unreffun]
>     friend QWidget* createQt5Widget(Qt5Frame& rFrame, QWidget* parent, Qt::WindowFlags f);
>     ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.

Change-Id: I01e47bc5f5147916737d62fe18ce5312a0221a3f
Reviewed-on: https://gerrit.libreoffice.org/55189
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01 20:52:41 +02:00
Noel Grandin
29dbb86409 use more BitmapEx in sd
Change-Id: I5c24ca437a329b105151adfedcaed0016bdaf771
Reviewed-on: https://gerrit.libreoffice.org/55191
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-06-01 20:12:35 +02:00
Noel Grandin
c96d58cca2 use more BitmapEx in filter
Change-Id: I68fdad6a69a178df8c59c4272f1d8d0b2f101315
Reviewed-on: https://gerrit.libreoffice.org/55163
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-01 20:12:18 +02:00
Stephan Bergmann
d098fb74df Improve handling of _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING
_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING turned into a global
-D..., same as existing
_SILENCE_CXX17_OLD_ALLOCATOR_MEMBERS_DEPRECATION_WARNING.

Change-Id: Ifefdc930a1d3ecf5366523dea509bfaca1f4e002
Reviewed-on: https://gerrit.libreoffice.org/55188
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-06-01 19:08:03 +02:00
Miklos Vajna
c4015f2302 DOCX import: fix relativeFrom=page, align=right handling again
sw/qa/extras/ooxmlexport/data/wpg-nested.docx has a right sidebar on the
page, which is a nested drawingML group shape. This was fixed to have a
reasonable position in commit 51a61bd4ac
(DOCX import: fix relativeFrom=page, align=right handling, 2013-12-06)
but the testcase only asserted the document model, so it wasn't caught
that later commit af313fc149 (tdf#105143
DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat option,
2017-01-06) broke it.

Fix it again by reverting the original fix and focusing only the part
that is still a problem: the margins around the shape prevent it to be
exactly at the right edge (instead there is some spacing). The margins
are not relevant in the "no wrap: in front of text" and "no wrap: behind
text" cases, the Word UI even disables the controls in those wrap cases.

Improve the relevant testcase to assert the layout instead, so next time
this breaks, we'll more likely notice it.

For each modified existing testcase, I compared the old Writer, new
Writer and Word rendering result and came to the conclusion that it's
the test that should be changed, not the code.

Change-Id: Ida29929671148db77fdd9ce8dbfb5214bb4728dd
Reviewed-on: https://gerrit.libreoffice.org/55192
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-06-01 19:06:27 +02:00
Andrea Gelmini
587a210026 Fix typos
Change-Id: Icc6fd609d3e57277822c4de76bd3baf4b1900840
Reviewed-on: https://gerrit.libreoffice.org/55176
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-01 16:11:15 +02:00
Miklos Vajna
94dcb3b1a5 UITest_calc_tests: split this into 4 parts
Before: make -sr UITest_calc_tests -> 10m48.934s

After: make -sr -j4 UITest_calc_tests UITest_calc_tests2 UITest_calc_tests3 UITest_calc_tests4 -> 5m40.113s

As a start just split based on the number of .py files in the
directories, one could improve this further by making them even more
equal based on number of lines or something.

Change-Id: I7a98a29e5d18a7600575956a7d8a0ec81e804269
Reviewed-on: https://gerrit.libreoffice.org/55174
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-01 16:00:33 +02:00
Olivier Hallot
403a8674e3 Updated core
Project: help  c4b58d2a883f375a15a5d0ab339ce626155dd901

Linguistics

Change-Id: If71bbd56546d9a78c102faa3bc819d7557cd8e14
Reviewed-on: https://gerrit.libreoffice.org/55187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-06-01 15:48:44 +02:00
Stephan Bergmann
7ff3030a56 Missing includes (std::back_inserter; Windows --disable-pch)
Change-Id: Iff9aa5eaa105d4eef496a9a2459a785b6a722418
Reviewed-on: https://gerrit.libreoffice.org/55171
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01 15:48:15 +02:00
Stephan Bergmann
9a865aa288 Various trivial loplugin fixes in --enable-qt5
Change-Id: I9539eb77f663e1174919ae801495801f81571710
2018-06-01 15:28:26 +02:00
Noel Grandin
1cfe22ff1d remove old "convert to SVM1" code only active in debug mode
Change-Id: I1d83e6ea5f8eb998f95e6ec334a695eb1df78df1
Reviewed-on: https://gerrit.libreoffice.org/55173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-01 15:17:56 +02:00
andreas kainz
2e87a61cc7 Mimetype icon update for apps and impress
Change-Id: I99d47fe7845740b02f85af3de39bc177424894e7
Reviewed-on: https://gerrit.libreoffice.org/55175
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-06-01 15:11:32 +02:00
Stephan Bergmann
8729e89765 loplugin:nullptr (clang-cl)
Change-Id: Ic21436a2d71968b8fd01a55fd6c1b7bc07b70451
Reviewed-on: https://gerrit.libreoffice.org/55172
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01 14:23:17 +02:00
Stephan Bergmann
f1514f903c loplugin:includeform (clang-cl)
Change-Id: Ia15fc0ea8d46cd4eab6ca690e1dac3a530512ab6
Reviewed-on: https://gerrit.libreoffice.org/55170
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01 14:16:22 +02:00
Stephan Bergmann
501f1b6764 loplugin:unoany (clang-cl)
Change-Id: I2a27c41ed2045cca8b8efb5f9d07f3015c67f8a1
Reviewed-on: https://gerrit.libreoffice.org/55169
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01 14:16:03 +02:00
Caolán McNamara
1d75ed970a ofz#6440 timeout during fuzzing
Change-Id: I720c64b9bb14cee33ffab5547a7353e83f23a14c
Reviewed-on: https://gerrit.libreoffice.org/55147
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-01 13:08:31 +02:00
Arkadiy Illarionov
bea47ebdb4 tdf#96099 Remove some trivial typedef std::vector
Change-Id: Iaba48932dde059c88401ee60f7aac0048a79e9eb
Reviewed-on: https://gerrit.libreoffice.org/55045
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-01 12:30:35 +02:00
Gabor Kelemen
bdf5a7b579 tdf#42949 Fix IWYU warnings in chart2/source/view/inc/
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
and a bit of fallout management.

Change-Id: I1eb30323e083afca7c024d494856ccc66c41482d
Reviewed-on: https://gerrit.libreoffice.org/55037
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-01 11:47:09 +02:00
Noel Grandin
36ad2b1337 drop Image(Bitmap) constructor
and convert some more code from Bitmap to BitmapEx

Change-Id: Icf3c18608e0bb608408fe69722441cfa19f6b161
Reviewed-on: https://gerrit.libreoffice.org/55160
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-06-01 11:14:43 +02:00
Abhyudaya Sharma
6c4135416f OOXML types are now visible in Template Import Dialog
Change-Id: I5414391cebc4a5a8e08d6d0004fefc3a0acc8111
Reviewed-on: https://gerrit.libreoffice.org/55128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-06-01 10:58:34 +02:00
Katarina Behrens
8815acd18f Make clang-format happy, remove vcl/unx/kde5 from blacklist
just between us girls, I hate you clang-format

Change-Id: I4cd041eff7a9fa01eb9192cf357e3f07a26fa6ad
2018-06-01 10:06:33 +02:00
Katarina Behrens
c5b8b1a3c0 Use harfbuzz and graphite, needed after GenericSalLayout refactoring
Change-Id: I21c221715c4e6b4e692c8b5ea4d9c9eb5d073980
2018-06-01 10:06:33 +02:00
Katarina Behrens
3698ff07b9 Add radiobuttons to native menus
Change-Id: I015bbb0a337b917096ca6f542a73c24c79fbef7d
2018-06-01 10:06:33 +02:00
Katarina Behrens
42b390cb01 Add checkmark buttons to native menus
Change-Id: If64227af287006cb4f9b980dac97b2fb401eac88
2018-06-01 10:06:33 +02:00
Katarina Behrens
26bcf9610f Dispatch commands from menus for real
Change-Id: I01997caa22e14c1350bd83100edb74397ebab5d7
2018-06-01 10:06:33 +02:00
Katarina Behrens
b971f2cc18 Basic structure of a slot to dispatch commands from menu
Change-Id: If3a134f67f59d3238c27eb0fef99bf49a8970433
2018-06-01 10:06:32 +02:00
Katarina Behrens
cd762c362e Add shortcuts to native menu entries
something's wrong though, they don't really show

Change-Id: Id8559fd9b6a5d4b2b49442d179571d31a99b5b20
2018-06-01 10:06:32 +02:00
Katarina Behrens
5b02225ff7 Insert separators into native menu
Change-Id: I88bb70b1e443821cc8d1904039f2a8fb52df1ff9
2018-06-01 10:06:32 +02:00
Katarina Behrens
2ebd9da7d5 Native leaf menus and submenus are now visible
Change-Id: Ieaac0966b167d82c8bdeb60f3ce4b9cc8589ec62
2018-06-01 10:06:31 +02:00
Katarina Behrens
8d78318307 Clear menubar before opening a new app
Change-Id: Icab19e31f7aa737351460790d2028114b24284ad
2018-06-01 10:06:31 +02:00
Katarina Behrens
a2e372362a Replace ~ with & (Qt accelerator marker) in menu entries
Change-Id: Ie7866357d4e74b778849262c1c2b60605a26faad
2018-06-01 10:06:31 +02:00
Katarina Behrens
8c98a74906 Unify Color -> QColor conversion
this also resolves build failures on 32bit platforms

Change-Id: I53fa2faae52a8cb322644c5bd5e5e84d71110d8e
2018-06-01 10:06:30 +02:00
Katarina Behrens
f174739d36 Top-level native menubar items are now visible
Change-Id: I6746b4a41a99c75234e64ab48ce81ea97333da04
2018-06-01 10:06:30 +02:00
Katarina Behrens
aae09b331b Expose menu bar of the main window
and some addional work on activating menus

Change-Id: I0c4d87dc158f3253aa97d151385fce14551c11b9
2018-06-01 10:06:30 +02:00
Katarina Behrens
c889151a67 Templatize Qt5Widget class
to distinguish between QMainWindow (top-level SalFrame) and QWidget
(everything else). The former are going to receive a native menu

Change-Id: I9023d1e464345f96f13967f5e2c8b0716890fbc9
2018-06-01 10:06:30 +02:00
Katarina Behrens
33c5d209ba Basic ops (add, remove) with native menu items
nothing's visible yet

Change-Id: Iee9d31ecdb931e64016f8430b51b619a39528726
2018-06-01 10:06:30 +02:00
Katarina Behrens
621a9066cd Prep Qt5Instance for native menus
Change-Id: I7ec34b13823b943ef5e99b92d919c2df795d6ace
2018-06-01 10:06:30 +02:00
Katarina Behrens
f80ff212cf Basic skeleton of native menus
in the closet

Change-Id: Ic54b3853b53987b3e5a85444da0b9167a785bd81
2018-06-01 10:06:30 +02:00
Katarina Behrens
3fc3eaa9f8 Get rid of annoying focus rectangles in start centre
Change-Id: I7ef38b226cd2bab7641638c500341cf7c198026d
2018-06-01 10:06:30 +02:00
Katarina Behrens
e1487233ea Render list headers natively
they have somehow odd colour though

Change-Id: I645581cc594ba3e06c4475957565aadc633b9d20
2018-06-01 10:06:30 +02:00
Katarina Behrens
27d5588319 Use QImage format with premultiplied alpha
as that's what cairo (almost) silently expects

Change-Id: If1ad6f28fcc6fb7ddc2ac4fcec0a31bad512cb2a
2018-06-01 10:06:29 +02:00