Commit graph

451416 commits

Author SHA1 Message Date
Rizal Muttaqin
ed8356ec56 Colibre tdf#133268, Sukapura tdf#106229
- Colibre: Update help icons, update Presenter Console/Screen icons to follow Segoe MDL2
- Sukapura: Add help icons, update Presenter Console/Screen icons to follow SF-Symbols and add the UI
- Sukapura: Clean SVG files from unwanted bitmap

Change-Id: I87b0bb982565fadec97e7585d8c0f3e87cea8a5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97969
Tested-by: Jenkins
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-05 03:28:57 +02:00
Tor Lillqvist
86884f876e For macOS on arm64, be sure to use HOST_PLATFORM=arm64-apple-darwin
(That is for the external projects.)

Change-Id: I709ff37ebca304f862ff94bdb1c6e6035f5cda77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97981
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 00:01:40 +02:00
Noel Grandin
e3adb51c54 reduce number of framework libraries
Change-Id: I18bfdba3d26593f796d8b0bda87720e31066d5e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97968
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04 22:42:54 +02:00
Tor Lillqvist
50889effe5 Remove leftovers for OS X on PowerPC
Change-Id: Id9d553e58635c2fa7414108467ff7d22f5c74c41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97980
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-04 22:02:07 +02:00
Caolán McNamara
f9d86399e9 tdf#134479 allow disable font preview to work on existing font comboboxes
not just newly created one.

you can only restore back to a text-only view, not a text+(icon/whatever) view

Change-Id: Ic3becd7a942ee6b1dbabb57eebf1e25d1b626fdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97972
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-04 19:55:29 +02:00
Noel Grandin
d70da0b9e2 reduce number of framework libraries
Change-Id: If2bf85301eb1523a636d031f6e5a9f78cb1ee06b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97871
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04 16:56:59 +02:00
Dennis Francis
e6eeecbe72 use lcl_ExtendTiledDimension() in getRowColumnHeaders()
to avoid code repetitions.

Change-Id: If83b42175fb53132174fa33d169806e17a4a5cbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96973
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 3c6c039685)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97959
Tested-by: Jenkins
2020-07-04 16:37:14 +02:00
Dennis Francis
adf1182bbd use helper-class ScRangeProvider in getRowColumnHeader()
and avoid some code repetitions.

Change-Id: I3e006bc8d9880f3e1ec892aa8f2423edbf9bbf14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96972
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit c888a2d7dc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97958
Tested-by: Jenkins
2020-07-04 15:32:52 +02:00
Dennis Francis
954ec00ccd lokit: scPrintTwipsMsgs: Extend the tiled-area limits...
if the client visible area is "close" to these limits. Also
send tile-invalidations for the new area uncovered.

** All this is done only if the flag scPrintTwipsMsgs is set.

Change-Id: I3d6b8c6aaae1eb934030c5bdbc1094dc8be16a9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96971
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit d64a5efdb8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97957
Tested-by: Jenkins
2020-07-04 15:29:47 +02:00
Dennis Francis
2c798d6715 lokit: add new callback type LOK_CALLBACK_INVALIDATE_SHEET_GEOMETRY
This is to notify the clients about changes in current sheet's geometry
data. Use this to notify clients of various sheet geometry invalidations
if the new feature flag scPrintTwipsMsgs is set.

Change-Id: I478d2e646606320399905d7b15881a165a53146d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96969
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 7d0181f519)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97956
Tested-by: Jenkins
2020-07-04 15:27:29 +02:00
Dennis Francis
b6d8dd62dd lokit: Introduce new flag "sc_print_twips_msgs"...
for conditioning all changes needed to allow calc messages in print
twips coordinates.

Change-Id: I407b4d4d4e0a1dfb2c4339cafa10b368b437c82d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96904
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 8f382dcee0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96967
Tested-by: Jenkins
2020-07-04 12:04:55 +02:00
Dennis Francis
9f7cf0907e add row/col limits to the JSON
Change-Id: I92cead8212f30d0cc9b811be21b6639830e84fa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96903
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit fcb176a46c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96966
Tested-by: Jenkins
2020-07-04 12:03:18 +02:00
Dennis Francis
568d0e13ad lokit: table-outline: skip empty collections...
while encoding the information as string.

Change-Id: I890efc4a9b60125c68c663a69569864308fdbdcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96902
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 2a7d29c51d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96965
Tested-by: Jenkins
2020-07-04 12:01:56 +02:00
Dennis Francis
d24d7e2186 Unit tests for ITiledRenderable::getSheetGeometryData()
(Testing of groups/ouline case is not included)

Change-Id: Ia53e5489c376d2d86461a9fd3db4f5b7dc963b99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96898
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 4b7333da7f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96964
Tested-by: Jenkins
2020-07-04 09:48:57 +02:00
Dennis Francis
777f9cec09 Introduce ITiledRenderable::getSheetGeometryData()
ITiledRenderable::getSheetGeometryData(bool bColumns, bool bRows,
				       bool bSizes, bool bHidden,
				       bool bFiltered, bool bGroups)

and implement it for the Calc derivation (ScModelObj).

The aim is to use it actively in LOOL instead of the interface:

ITiledRenderable::getRowColumnHeaders(const tools::Rectangle& /*rRectangle*/)

This is used by the LOOL to fetch the sheet geometry data for just the
current view-area in the clients, so LOOL queries this everytime some
client's view-area changes.

Like the existing interface, the new one will provide all 'kinds' of
sheet geometry info [col/row sizes(twips), hidden/filtered and
grouping]. But the difference is, it generates data for the whole sheet
(not view-area specific). So the method need not be queried every time
the view area changes in the LOOL clients, and more importantly it
enables the clients to locate any cell at any zoom level without any
further help from the core. This means core needn't send various
client(zoom) specific positioning messages in pixel aligned twips. It
just can send all positioning messages in print twips uniformly to all
clients.

Conflicts:
	sc/source/core/data/segmenttree.cxx
	sc/source/ui/inc/tabview.hxx
	sc/source/ui/unoobj/docuno.cxx

Change-Id: Ib6aee9a0c92746b1576ed244e98cb54b572778c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96892
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 9faf7b5e7a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96963
Tested-by: Jenkins
2020-07-04 09:47:30 +02:00
Andrea Gelmini
c6073a5a01 Removed executable permission on cxx file
Change-Id: Id2139b19566a69e0e6e95346cab85dee6ef90943
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97812
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2020-07-04 09:05:51 +02:00
Adolfo Jayme Barrientos
8bb4952920 Fix HIG spacing in About dialog
Change-Id: Ia67d5c8994c39a1e89c79e8d51a2a679cba73d3e
2020-07-04 01:57:35 -05:00
Noel Grandin
43d2f3d5f1 avmedia/mac: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: I7dfb9933c1625b4e0b68cf8ab459eebcd3db9d44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97893
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04 08:33:02 +02:00
Noel Grandin
78639945da UnoControl: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: I3df173e3c7064d3d925d3abe5c652b8cbe6c8ea5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97892
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04 08:32:56 +02:00
Mark Hung
7dcc18b5ac tdf#119223 export the object name for pptx documents.
Originally the name was always an object type plus
an index. That not only ignores the existing
object name, but also makes an unnamed object named
in the roundtrip. So here the object name is used
no matter it is empty or not, to keep unamed object
unamed.

Change-Id: Ib29a8fbc1fd67fa9a4a4efbfd0b2e9c4fb50de0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96908
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-07-04 06:40:55 +02:00
Heiko Tietze
92c2318db9 Revert "tdf#126733: inverted emoticons sets for the conditional formatting"
This reverts commit a330d8eef0.

Reason for revert: Regression for existing documents

Change-Id: I7bf70ddfa54c40732ca902f258530f34cac6cd98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97910
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2020-07-04 01:27:39 +02:00
Mike Kaganski
49124a6c5e Re-implement 481e686a66
Marking documents modified simply on entry to an edit box created a
problem, when using search in a read-only Online session made the
document modified, and then auto-save failed, displaying a warning:

    Document cannot be saved. Check your permissions or contact the
    storage server administrator.

The original problem, that 481e686a66
fixed, was that entering a box in Impress in browser, typing, then
pressing Save without exiting the box did not save the edits. Yet,
the same sequence works outside of Online. In that case, the doc is
marked modified in SdrObjEditView::KeyInput, which obviously is not
called from Online, where SdrObjEditView::Command is called instead
with CommandEventId::ExtTextInput. So just make sure that we mark
the document modified also in this case, making sure that only the
actual edits set the "modified" flag.

This reverts 481e686a66.

Change-Id: Ib05bc0492616a306dd328bcb8f2e1c9d7e7aa191
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97870
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-04 00:12:32 +02:00
László Németh
a5073875fe tdf#134463 DOCX import: fix other "half" of contextualSpacing
Always ignore own bottom margin setting of the previous paragraph
with contextual spacing, if the actual paragraph is identical.
I.e. in that case, too, when the actual paragraph has no
contextual spacing, like MSO does.

Note: PARA_SPACE_MAX mode hasn't included this modification,
yet, so only ODT documents converted from DOCX use it at the
default setting.

See also commit e318d5d814
(tdf#125893 DOCX import: fix "half" contextual paragraph spacing).

Change-Id: I83fab2a2d85eeb9d48a8546d5a4e6423988d642c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97874
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-03 22:59:58 +02:00
Caolán McNamara
b6b7415095 rename FormattedEntry to EntryFormatter
Change-Id: I96079720f60b789f0b8d5483973150cb050e87e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97859
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03 18:10:13 +02:00
Caolán McNamara
8ac055fa8a change FormattedEntry to not own the Entry it operates on
Change-Id: I5b5753312a5bbfed3dbcdc47cc1781cbcf168750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97858
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03 18:09:53 +02:00
Caolán McNamara
97ccd327c6 change FormattedField so it doesn't inherit from Formatter but provides one
Change-Id: I728380fb4e2ed914c4b96c0915075af097846c55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97825
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03 18:08:47 +02:00
Xisco Fauli
643df295fa tdf#134455: sc: Add unittest
Change-Id: I48fe0445d08116e95da087a7ceeb45c1ad6609dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97823
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-03 18:06:53 +02:00
Xisco Fauli
3d79ac71d1 tdf#35636: sc: Add unittest
Change-Id: I79eee92015b4a4eafd57702e2ac1bf7fe1682f0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97840
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-03 18:06:04 +02:00
László Németh
d35b796efb Update git submodules
* Update helpcontent2 from branch 'master'
  to 4e7e70de93368b2d4de54665245484929d76eb90
  - tdf#133524 tdf#133589 (related) Document new "Localized options"
    
    of AutoCorrect.
    
    Change-Id: I8fce33762184ea558f62cce71cb0c09210623a22
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97822
    Tested-by: Jenkins
    Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-03 17:24:31 +02:00
Thorsten Behrens
b1954b19bc sfx2: cleanup cxx-only default params
Followup commit to a8ee7bc96f - not
idiomatic to have function-definition-only default params

Change-Id: I606545d7396ed1123247115e92ac2830a0738e34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97813
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-03 17:21:39 +02:00
Jan-Marek Glogowski
b1d0d0cf86 [API CHANGE] Move NSS profile handling into NSS service
While developing the patchset for tdf#127909, I broke the
certificate path dialog, because I wasn't aware, that the
NSSInitializer service has to use the same logic to auto-
select the users profile, then the dialog. So currently you
have to keep the complex service and dialog auto-select
logic in sync.

To prevent this error, this moves all the profile auto-selection
and enumeration into the NSSInitializer service. What I also
stumbled over is the particular lifecycle of the NSS library
initialization in the NSS service. This is just done, when the
first user calls some crypto function. As a result it's actually
possible to change the path setting without restarting
LibreOffice. But since the NSS deninitialization is run as an
atexit handler, this setting can't be changed after the init.

What is currently missing is any indication inside the dialog of
the currently active NSS setting in comparison to any later user
selection, if the user doesn't restart LibreOffice as requested.

Change-Id: I886962777958c363abeb0ec91fc8a35cbd39eb98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97668
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-03 17:13:12 +02:00
Jan-Marek Glogowski
47c098e576 Qt5 better / working wakeup handling
Report some of the stuff we can in AnyInput. And instead of
posting an event, just use QAbstractEventDispatcher::wakeUp().

Change-Id: I020a71eca7208030ddbfcd2b16d9bc4ceff315e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/73676
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-03 15:58:54 +02:00
Noel Grandin
23e8739b98 tdf#131942 no progress bar saving in Calc
regression from
    commit a7de363cea.
    remove unnecessary Window::Update() calls, which immediately follow
Invalidate

Change-Id: If081f9a54ad7fe528a7885ac796f0ec6a7059872
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96975
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03 15:40:51 +02:00
Julien Nabet
6425ce30dc loplugin:redundantstatic (extensions/updatecheckui)
Change-Id: I71144d4b61592cb1157057fe0cc6044d07957447
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97830
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-03 15:33:57 +02:00
Caolán McNamara
850eb2a240 drop some unnecessary includes and forward declares
Change-Id: I05bf82e3fc295d6f3f42287763c53b8e21da4b67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97824
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03 15:06:57 +02:00
Noel Grandin
516dc02998 avoid some sorting
Change-Id: I02aacffcac30d48f79fd8d2640392aa3f1214b41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97826
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03 14:53:23 +02:00
Noel Grandin
dc119d12f0 loplugin:unusedenumconstants
Change-Id: I6dde54ddc2a2be4a9bbe11cdb52550de7f6a1023
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97836
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03 14:51:48 +02:00
Noel Grandin
3fe6a2c11d Css1FrameSize::AnyHeight is dead
ever since initial import

Change-Id: Ifa8346b4f603afde84a1e61fc251137c189e674f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97835
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03 14:51:41 +02:00
Szymon Kłos
16ab6e5b16 notebookbar: remember LOKWindowId in interim builders
In case of notebookbar we need to remember the same id
in every builder for each view to be able to use
interim widgets. Then widgets are added to the same
map as main notebookbar widgets. SfxViewShell is
used as a common id as it is easily accessible.

Change-Id: I4fbf2da320396efc80b08bcee9e341c165b1a290
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97199
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97834
Tested-by: Jenkins
2020-07-03 14:49:46 +02:00
Szymon Kłos
126c5e57d7 revert jsdialog: always clean remember widgets
Don't delete all widgets when nested tab page
is used

Change-Id: I0ce2ce976791ca0c8325013df10f01abe341b78d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97119
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97833
Tested-by: Jenkins
2020-07-03 14:48:53 +02:00
Szymon Kłos
af2c312433 jsdialog: change sendDialogEvent API parameter
WindowId with 64bit length is needed

Change-Id: Ia11530fb4666fc64d7acde653085ed258058c169
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97100
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97832
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2020-07-03 14:48:46 +02:00
Regényi Balázs
cab956c480 tdf#112312 DOCX legacy shape export: keep fixed size
Classical/legacy shapes lost their fixed size when exporting them with the
option "Resize shape to fit text" because they do not have the ability to
resize to content.

Co-authored-by: Szabolcs Tóth

Change-Id: Idd84dea040f9607d0d498e591601a8648a605a2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97127
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-03 13:33:16 +02:00
Noel Grandin
7b14b4b377 remove some dead WindowType values
Change-Id: I7eb67e48a87e8cc2babbd46d482294877b08ab99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97828
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03 13:24:18 +02:00
Noel Grandin
84f1c0f7ca DragDropMode::CTRL_COPY is dead
since
    commit 3c5e074a8f
    Date:   Fri Jun 19 12:37:05 2020 +0100
    weld DataNavigator

Change-Id: Ib1a0474e0543f863236d58195653c6369c21e2fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97829
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03 13:22:08 +02:00
Noel Grandin
3c1026bd79 only loop over props once
Change-Id: If41314c90397199c14c91fe65ed41243ac385dae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97827
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03 13:11:41 +02:00
Szymon Kłos
9eaaf3b7e1 jsdialog: get widget depending on viewshell
Notebookbar always gets window id 0 what causes
conflict in map and some widgets doesn't work

Change-Id: I15b4e83d385e83bcf898148a871ddf540257cc81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97099
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97816
Tested-by: Jenkins
2020-07-03 12:13:39 +02:00
Szymon Kłos
645021ad49 jsdialog: always clean remember widgets
avoid crash when old, freed widged will be used

Change-Id: I4f4ec40bc8d1fdda4a141d1167c05d863d516633
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97014
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97814
Tested-by: Jenkins
2020-07-03 12:13:25 +02:00
Szymon Kłos
cef4ed2a79 jsdialog: working number format field
Change-Id: Ibc3dcd34008767a7a38cc9b52a23935e0387f67e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97016
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97815
Tested-by: Jenkins
2020-07-03 12:13:13 +02:00
Ahmed ElShreif
29d3978de0 uitest : Add demo for SvxNumValueSet support
The demo is just a test case added to BulletsAndNumbering Dialog test cases .

The BulletsAndNumbering Dialog has 4 SvxNumValueSet so The test case works with each one of them .

We now have support for "Writer: Format-Bullets and numbering dialog- Selection" item .

Change-Id: I3a0827991a5fd004489459feb7c49214c9e2b766
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97341
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-03 11:49:35 +02:00
Shiko
626c6ca43f uitest : Add Support for SvxNumValueSet
We need to add support for the SvxNumValueSet to use it in testing this item:
	Writer Format-Bullets and numbering dialog

You can now test any SvxNumValueSet with this lines:
	>> obj_name.executeAction("CHOOSE", mkPropertyValues({"POS": "pos_num"}))

I will provide another patch with test case fo Writer Format-Bullets and numbering dialog

Change-Id: I4e3835c34bd3509929ee2d5e832991aa95ed3bba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97271
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-03 11:49:20 +02:00