... instead of OUString::toAsciiUpperCase(). English names should
consist of ASCII alphanumeric only, but we don't know what an
AddIn's author comes up with. Lookup in ScCompiler is done with
CharClass as well.
For this, use the static ScCompiler::GetCharClassEnglish()
instance made public and guard creation with a mutex.
Change-Id: Icb79d49d4c7339c8d01b141de2a34715d794dd92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138004
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
and
cid#1507854 Big parameter passed by value
cid#1507853 Big parameter passed by value
cid#1507848 Big parameter passed by value
cid#1507846 Big parameter passed by value
cid#1507844 Big parameter passed by value
cid#1507843 Big parameter passed by value
cid#1507842 Big parameter passed by value
cid#1507845 Big parameter passed by value
cid#1507847 Big parameter passed by value
cid#1507849 Big parameter passed by value
cid#1507855 Big parameter passed by value
cid#1507850 Big parameter passed by value
cid#1507852 Big parameter passed by value
Change-Id: I03138b93d0936fe5e62453651227f3925a7b4b83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137981
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Qt has `QEvent::MouseButtonDblClick` as a specialized
type for "Mouse press again" [1] in addition to
just `QEvent::MouseButtonPress` for a single click.
Handle that as mouse button down event in LO as well,
to make handling of double-click work again after
commit 393c9f736b
Date: Tue Apr 19 16:00:31 2022 +0200
Qt use QEvent::type to handle the event correctly
[1] https://doc.qt.io/qt-6/qevent.html
Change-Id: I9964b554bf71f30861ed0868e7a8000c84de50ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138006
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
With a randomizing debug-mode libc++ (`export LIBCPP_DEBUG=-D_LIBCPP_DEBUG=1`
in config_host.mk), CppunitTest_sc_ucalc_pivottable consistently failed for me
with
> Expected: A Actual: a
> sc/qa/unit/ucalc_pivottable.cxx:1886:TestPivottable::testPivotTableCaseInsensitiveStrings
> assertion failed
> - Expression: bSuccess
> - Table output check failed
when _LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY_SEED is 140365334480272.
This change apparently happens to fix it, but I have no idea what exactly is
going on here. (comphelper::s3sort was introduced in
46d0afba73 "Implement parallel version of
super-scalar-sample-sort...", and
TestPivottable::testPivotTableCaseInsensitiveStrings traces back to
96086484d3 "Move pivot table tests into a separate
source file.)
Change-Id: I24316db6cb274f7afd0ce0a5aa9ced79121eeeb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136623
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This continues the revolution from tdf#81293 that was done
for the MOD section of this function in 7.4.
It looks like the same thing needs to be done for APP.
Prior to this commit, opening up the same form control
property dialog always opened up to the same initial tab,
regardless of the last-used-tab. ONLY of document reload
would the last-used-tab come into play.
Now it always opens up immediately tot he last-used-tab.
This is full fix for SAL_USE_VCLPLUGIN=gen.
gtk3 needs an additional fix so it doesn't follow the
second-last-used-tab instead.
Change-Id: Ie7c13cfb48de87c4ab595460680f4306e8feaac7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138002
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Just convert some loops to range based and fix strange loop logic
at 216 line.
Upd: rename *iterators* as Mike Kaganski adviced
Change-Id: Idf33b65f9c4466aa49c8f3bc13a12ad072dce7b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137929
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
For Gtk3, setting the Navigator tree view cursor -1 doesn't unselect
the selected entry which is what is wanted when the canvas selected
object is not in the Navigator tree view.
Change-Id: I879e8dc09870b91d42eadb6b42d9236c1a1cf40c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137916
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
...where
<127bf44385>
"[Clang][C++20] Support capturing structured bindings in lambdas" on Clang 16
trunk changed the return type from VarDecl to ValueDecl, causing
> compilerplugins/clang/reducevarscope.cxx:541:26: error: no matching member function for call to 'erase'
> maVarDeclMap.erase(varDecl);
> ~~~~~~~~~~~~~^~~~~
> /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:740:7: note: candidate function not viable: no known conversion from 'ValueDecl *' to 'const_iterator' (aka '_Node_const_iterator<std::pair<const clang::VarDecl *const, (anonymous namespace)::ReduceVarScope::DepthInfo>, __constant_iterators::value, __hash_cached::value>') for 1st argument
> erase(const_iterator __position)
> ^
> /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:745:7: note: candidate function not viable: no known conversion from 'ValueDecl *' to 'iterator' (aka '_Node_iterator<std::pair<const clang::VarDecl *const, (anonymous namespace)::ReduceVarScope::DepthInfo>, __constant_iterators::value, __hash_cached::value>') for 1st argument
> erase(iterator __position)
> ^
> /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:762:7: note: candidate function not viable: cannot convert from base class pointer 'ValueDecl *' to derived class pointer 'const key_type' (aka 'const clang::VarDecl *const') for 1st argument
> erase(const key_type& __x)
> ^
> /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:780:7: note: candidate function not viable: requires 2 arguments, but 1 was provided
> erase(const_iterator __first, const_iterator __last)
> ^
etc.
Change-Id: I79b062ca604435bc83a58eeb32df673e6c658bd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137984
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
<3c49576417>
"[ADT] Add has_value, value, value_or to llvm::Optional" is in Clang 15, and
<b5f8d42efe>
"[ADT] Deprecate Optional::{hasValue,getValue} (NFC)" is in Clang 16 trunk,
causing
> In file included from compilerplugins/clang/sharedvisitor/sharedvisitor.cxx:95:
> compilerplugins/clang/pointerbool.cxx:118:21: error: 'hasValue' is deprecated: Use has_value instead. [-Werror,-Wdeprecated-declarations]
> if (ret.hasValue() && (ret.getValue() == 1 || ret.getValue() == 0))
> ^
> ~/llvm/inst/include/llvm/ADT/Optional.h:324:5: note: 'hasValue' has been explicitly marked deprecated here
> [[deprecated("Use has_value instead.")]] constexpr bool hasValue() const {
> ^
etc.
Change-Id: I377effe29fc6752484d2870b9a0fd66fddc26bfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137982
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Just follow the pointers, instead of unnecesarily indexing through
the SwNodes array.
Change-Id: I7da103d1300e1cbb54a8ca2994170fb7b2d9779f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137938
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
to use, so databrowser with it (view data sources) has the tall case,
while bases, create table in design view has the short case
Change-Id: If3269d2ab2ce62f09acac624e5ef7e91ff91eaea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137953
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
the scrollbar in the statusbar can be thicker than the vertical one
which looks weird when both set to the thick size
Change-Id: I76496e47203a7cde72082f8e6b83f5af3e8c3759
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137952
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
On import, the values overwrote each other; export of the form data
was missing completely.
Change-Id: I918b3cfced39dc2602c6de03cdaf5848a9825dd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137861
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
That UI file was added in
commit 4bc62c4e9b
Date: Thu Aug 4 15:33:51 2022 +0100
split SwScrollbar up for reuse of adaptor
Include it for Android.
Without it, trying to load/display any document
would result in Android Viewer crashing or getting stuck,
with this in the ADB log:
08-08 09:22:20.102 6064 6256 D libo:sal/osl/unx/file: double-slash in path: /assets//config/soffice.cfg/svt/ui/scrollbars.ui
08-08 09:22:20.102 6064 6256 E libo:sal/osl/unx/file: miss cache: failed to open /assets//config/soffice.cfg/svt/ui/scrollbars.ui
08-08 09:22:20.102 6064 6256 W vcl.builder: 23:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
08-08 09:22:20.102 6064 6256 W vcl.builder: when: Unable to read .ui file exception: void
08-08 09:22:20.103 6064 6256 I LOKitTileProvider: ====> mOffice.documentLoad() returned null, trying to restart 'Office' and loading again
Change-Id: I0938d77dc9553d8acc7b2bdd4a72b5299b4ec1a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137943
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This was shown as a recommended step in Android Studio
when the update to Android Gradle Plugin 7.2.2 was
suggested:
> *Remove jni source directory from sourceSets*
>
> The jni block in an android
> sourceSet does nothing, and will be removed in Android Gradle Plugin
> version 8.0.0.
Change-Id: I3378926047d5ad86548d0bf800e022b74efb5e09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137942
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
restrict this to a very short length to reset ofz Timeout to force
ofz to report a new issue when restored later
Change-Id: Ibbdbb60f16ddca8367355d4c855e58aa16ea5f4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137944
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
you get one of these by starting with a normal text box form control
and changing its "text type" property to multi-line with formatting
Change-Id: If922b6b9fdc49b78fa379dbb3e5974a73f6095ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137933
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
which flushes out some more places where we were implicitly
construcing temporaries
Change-Id: I2eee5f99071cd8c155de1be369ba89ec1d732bae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137921
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
It is a small object, and in these places is already contained
inside a heap object.
Change-Id: Ib9aba6feaf0dd2c24659c03e55fc8a872610cc00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137920
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Before commit 95ebd24a62
Author Mike Kaganski <mike.kaganski@collabora.com>
Date Thu May 27 13:00:10 2021 +0300
editengine-columns: ODF support [API CHANGE]
SwXTextColumns crtor took SwFormatCol, and stored line width in the
same units as in SwFormatCol - in twips; conversion to mm100 only
happened at export stage in SwXTextColumns::getPropertyValue.
The mentioned commit changed to SvxXTextColumns::setPropertyValue,
passing the line width from SwFormatCol also without any conversion;
but SvxXTextColumns::setPropertyValue expects mm100, so the result
was wrong.
So perform the proper conversion at SwFormatCol::QueryValue and
SwFormatCol::PutValue, and also store the line width in mm100 in
SvxXTextColumns, to avoid useless extra conversion.
Change-Id: Idfd62a7563f9d3aa5947c1149572a8b8b696b179
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137931
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
It is a small object, and in these places is already contained
inside a heap object.
Change-Id: I930d87827104e04fff2ad6b481ed94348a49701d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137930
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
It is a small object, and in these places is already contained
inside a heap object.
Change-Id: I63eee5390e4ab1d1a66197a100e3876f96f95944
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137928
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
