Using a parameter to select point/mark makes the code much harder to
read
Change-Id: Ic24098a6045ff2262d4c808228ded7bf8206fe8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138085
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Using a parameter to select point/mark makes the code much harder to
read
Change-Id: I4ac8b904ac423e2b99253b7e4b6adc72c8afe1a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138083
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
as part of the process of hiding the internals of SwPosition.
This just changes the places we are passing nNode to the constructor of
SwNodeIndex
Change-Id: I3dffba5df6c044a69da27b6a1254592695b976af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138200
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
only need to check for max when we are incrementing the level
Change-Id: Ic8ae07783b6085c7566239d949cf351a11d0875f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138236
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
It looks like MS always provides an sprm that confirms
this, but Kingsoft was saving without that sprm.
Something similar ought to be done for ImportOLE,
but it doesn't have a ready option for specifying
that, so I just left it because I don't care about OLE.
Change-Id: I0ae304a08b381c8c29f3db24f791f25f5e33b0c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138234
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
part of the process of hiding the internals of SwPosition
Change-Id: I58e20facfb8987a31e354542a9a5e7824daa0b26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138235
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: Ib2ac69352ca7e37117ad449fa7cb9f7cd69dd333
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138232
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: I08f28a918c0d165ef4d143b8121d0aad5771dec0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138231
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: Ic24e646571eec0ff764d307e20e784d39d8411e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138230
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: Icaecb1c2eee09baf3f1630937bca9a96556eb023
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138225
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: I0b2dd3e24c82c1551a7275ffc78991823354858a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138224
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
and
cid#1507935 Big parameter passed by value
Change-Id: I11c2868960a22ca09c82aba9ee343535ac2c5ae8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138228
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
part of the process of hiding the internals of SwPosition
Change-Id: Iddf8af8c7c9242bd3d9a48a59059b1cc8321be16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138223
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Error: attempt to dereference a past-the-end iterator.
Probably this only crashes in the assert(iter->pNode...) as the rest of
the function already checks that "iter == end".
(regression from commit 46e04a712e)
Change-Id: If652a15d1cdebb21fbce028fceeaee8dce8f7f6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138205
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
part of the process of hiding the internals of SwPosition
Change-Id: I84fd5fbb800c822868840710e1b9fda3de2abaf5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138173
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: I23b23f23f2aeb559861f1328a2d795de5c54a013
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138220
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: Ia3b2563c23aaaf86f58b56bcdd60ded3c9d8404f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138219
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
SwOutlineNodes does not need to be allocated separately.
Change-Id: I134d3293b9b9c489c327b8c283b324875705541f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138215
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: I00501617d8e602f51fbe6c79ba92654292e30f0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138214
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
tweak the python script to code with some clang weirdnes
Change-Id: I88fc9f901748ff44af2b67704cc437b770ef0737
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138196
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
rather than two that have to be kept in sync
Change-Id: Ic6443a6af80f63cc40570665d6680f9a49cdb8ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138174
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
part of the process of hiding the internals of SwPosition
Change-Id: Id56cbeaa67cdbfc620d26c8590f1c9eeaea26281
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138172
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
GetListFormat DEPENDS on having managed prefix/suffix itself,
since it uses their getLength to modify the sListFormat.
So any modification via SetPrefix/Suffix
(potentially) invalidates the ListFormat.
I added some code to ensure this doesn't get out of sync.
One place that still uses PREFIX/SUFFIX is old ODT files.
After import they are updated, but during import they use
the old UNO properties, so I didn't add any assert here.
Change-Id: I3bab780fb8e8e985c3573075bc7aac9216d116d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138073
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-by: Justin Luth <jluth@mail.com>
