Commit graph

327126 commits

Author SHA1 Message Date
Kohei Yoshida
f3f0ae12f9 Keep track of current block position when pasting a range of cells.
This avoids re-starting the search for insertion position in the cell
text attribute array, on every single cell insertion. Instead of always
searching from the first position, it starts the seaarch from the previous
insertion position.

This reduces the paste time from the previous 3.5 seconds to 1.7 seconds
on my machine.

Here is the scenario.

1) Put =A1 in B1, and leave B2 empty.
2) Select B1:B2 and copy it via Ctrl-C.
3) Select B3:B50000, and paste via Ctrl-V.

Because of the empty cells interspersing the destination range, this makes
the data array highly partitioned, which makes the position lookup very
very expensive without the position hint.

Still, I was hoping the duration would become a fraction of a second. 1.7
seconds still seems a bit too slow...

Change-Id: I7742ce7e22935b6d0e082e4569d53dbd2072c4e5
2013-05-20 20:13:08 -04:00
Kohei Yoshida
f8ed5c3ffe Move the column element block definitions out of ScColumn.
so that I can reference it in another class.

Change-Id: I035cc1d37ec219c3e3da2e180a0337fb3c6fba8a
2013-05-20 20:13:07 -04:00
Kohei Yoshida
b7c84a69bf Slightly shorter way of getting the element value.
Change-Id: I9f56c7a54405a805cb843321bdab660a3ab22fd6
2013-05-20 20:13:07 -04:00
Kohei Yoshida
bad98d1b26 Avoid expensive element position lookup twice.
This moderately improves the performance of pasting a large array
of formula cells.

Change-Id: I27a59ff348cb715df15db80693cb7d193e67ec2e
2013-05-20 20:13:07 -04:00
Kohei Yoshida
bb77c4b5e6 Remove unused function argument.
Change-Id: I0b4deec7f4b10c7b14e482f61c667972caa30bc8
2013-05-20 20:13:07 -04:00
Kohei Yoshida
e8741c80e2 Move all clip params into the new context class. We don't need two buckets.
Change-Id: Ida0542583242ebcdd7f1448931e31656aa542457
2013-05-20 20:13:06 -04:00
Kohei Yoshida
3014160a8a Introduce copy-from-clip context for copy handling code.
It's not used yet, and is currently empty.

Change-Id: Ia377994ae042fc8b19d269adc2f94830422770f1
2013-05-20 20:13:06 -04:00
Kohei Yoshida
ef03feefcc Reduce indentation level by early bail-out.
Change-Id: I5e108efa0219620696d15a304d2f4e3566d58d57
2013-05-20 20:13:06 -04:00
Kohei Yoshida
3a9b560825 Add perf test for removal of large array of formula cells.
Change-Id: I2fdf38b23e74a9f4cad7abd9a943e8817f39474c
2013-05-20 20:13:06 -04:00
Kohei Yoshida
063d91ee77 Fix memory leak.
Change-Id: I90e419d19f4565f7f20603358308fd7aeba83190
2013-05-20 20:13:06 -04:00
Kohei Yoshida
504615c541 Remove duplicate code blocks.
Change-Id: I945c7ae834393c760d8a552043c391ff0eb9ce22
2013-05-20 20:13:05 -04:00
Kohei Yoshida
81e1e8e21f Unit test for range deletion of broadcasters.
Change-Id: I615c9f9e95a44149c8079754e9aa6497f34c76cf
2013-05-20 20:13:05 -04:00
Kohei Yoshida
1d3d107a76 Keep track of empty broadcaster segments, and delete them all in one go.
This massively speeds up the deletion of a large group of adjacent formula
cells. As an example, on machine, deletion of formula cells over B2:B109101
(109100 cells in total) got reduced from 4.7 seconds to 0.09 seconds).

Change-Id: Ib72da42a6644421601111907cf7c899d828c2996
2013-05-20 20:13:05 -04:00
Kohei Yoshida
410154e76c Collect all empty broadcasters and remove them in one go later.
This is to avoid repeated calls to set_empty() on the broadcaster array
which causes array reallocation on each call. Instead, we can store the
segments of broadcasters to be deleted later, and call set_empty() on
those segments to reduce the number of calls to set_empty().

The meat of this is not implemented yet, as EndListeningContext is still
empty.

Change-Id: I914bc2881acee3902c4fec0f6c21aaf4d2489df8
2013-05-20 20:13:05 -04:00
Kohei Yoshida
180c2fe743 Move this code into ScDocument, for later refactoring.
Change-Id: I4c34cd4b352dfafe7f423ab8e85f0d93c0368349
2013-05-20 20:13:04 -04:00
Kohei Yoshida
7476ad63d1 First (?) performance regression unit test against clearing of a sheet.
I screwed this up earlier which made this operation take almost 50 seconds
to complete. It should finish in 0.00001 seconds or less.  The test checks
against 1 second, which should be enough of a buffer for slower machines.

Change-Id: I9923033045111c75a0740b6bb30a518fe93e01d2
2013-05-20 20:13:04 -04:00
Kohei Yoshida
0fb3bfcae4 Consolidate the text width and script type arrays into one.
Since they are always in sync...

Change-Id: Ic07f57e1804d76ae801c7947d18df5fd0d729632
2013-05-20 20:13:04 -04:00
Kohei Yoshida
c9bfa396e3 Block definition for CellTextAttr.
This block will be used to merge the text width and script type vectors
that are currently separate.  Text widths and script types should really
be stored together.

Change-Id: I6783769cc03180b513319e0a98a0773bd20ba941
2013-05-20 20:13:04 -04:00
Kohei Yoshida
cb706bac6a Rename header: mtvelement -> multi_type_vector (mtv) elements.
This header hosts custom element types and blocks used in
multi_type_vector.

Change-Id: I32481a2354d8c66eb877b4005a260a79183cd714
2013-05-20 20:13:04 -04:00
Rene Engelhard
9e2605566e fix mdds check: remove extraneous "test"
Change-Id: I2c20a52e7f7688359172c9ccbd46b4b012bd4c02
2013-05-21 00:25:00 +02:00
Fridrich Štrba
23ddec8b51 This is most probably the way to get the mdds check right
Change-Id: I65a6018c442769f89f17ee0023510c45373407e7
2013-05-21 00:11:38 +02:00
Jian Fang Zhang
0063e19b33 #i121134#, more fix for i119657, fallback to old logic to use current AbstractNum when the desired one can not find
Found by: Li Lin Yi
Patch by: Jinlong Wu,wujinlong@gmail.com
Review by: zhangjf
(cherry picked from commit aa53b457faaf0fc50a8b38d17bf219de427a1044)
2013-05-20 23:04:45 +02:00
Jian Fang Zhang
40a5d22fd4 Related: #i119657#, importing docx, add code to handle the problem...
that an AbstracNum references to a style, which references to another Num

Found by: xiao ting xiao
Patch by: Jinlong Wu,wujinlong@gmail.com
Review by: zhangjf

(cherry picked from commit d6870e145cc7373a422b414c31380cc1399e64cc)

Conflicts:
	writerfilter/source/dmapper/DomainMapper.cxx
	writerfilter/source/dmapper/NumberingManager.cxx

Change-Id: I9be0b82d601bf43da31842edb02c4b0d4e50e84f
2013-05-20 23:04:45 +02:00
Andras Timar
de00b8bb67 Updated core
Project: translations  6148d0296697632af52c5e39787cd09c2a748fd7
2013-05-20 19:24:11 +00:00
Khaled Hosny
c761fcfd7e Fix fdo#64751 – Header & footer blue tags empty
No idea FontMetric::GetHeight() is supposed to mean, probably the code
here meant GetLineHeight(). What it actually need is GetAscent(), so use
it instead (which is the same as GetLineHeight() - GetDescent()).

Change-Id: Ic467e56ed6b8d245ac7800f94e6d40030833328b
Reviewed-on: https://gerrit.libreoffice.org/3980
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-20 19:08:57 +00:00
Julien Nabet
76fbba8259 sw: convert some usage of Point::X/Y to Point::set/getX/Y, take two
69c52bc5b7 had some typos, and got
reverted in 78123a504b, this does the
same, except those typos corrected, so vertical layout is still OK.

Change-Id: I79fe610e4cc8bbbddbd8415198d6309a93f4ba18
Reviewed-on: https://gerrit.libreoffice.org/3929
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-20 18:59:38 +00:00
Radu Ioan
bd888a331b fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*

Change-Id: I0054bc90fdcaa2fef7e1d98a0528277be4fc341e
Reviewed-on: https://gerrit.libreoffice.org/3917
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-20 18:58:25 +00:00
Joren De Cuyper
43aee4c0a0 resolve fdo#64446 Repeat shortcut isn't showed correctly in menu entry
Change-Id: I991185f6b4efd305dc55c9ad85f92222f706f8a0
Reviewed-on: https://gerrit.libreoffice.org/3850
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-20 18:57:27 +00:00
Joren De Cuyper
8165805982 fdo#30715 Several commands are under the wrong category
Placing "insert" commands under category "insert" is more logical

Change-Id: Ib322aaace39cd160cc81ef4945abd2047e6c4c12
Reviewed-on: https://gerrit.libreoffice.org/3854
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-20 18:57:01 +00:00
Mark Wielaard
7e98b46c08 valgrind support is useful independent from DBGUTIL support.
Especially when valgrinding an optimized libreoffice build.

Change-Id: I7d2ac5476ba8561ce6afbf8c9472550fbe959c76
Reviewed-on: https://gerrit.libreoffice.org/3966
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-20 18:55:07 +00:00
Mark Wielaard
d95456fc4c Fix memory leak in mapToFontConfigLangTag.
FcGetLangs() will return a new FCStrSet that needs to be freed after usage.

Change-Id: Ie7fe0dd160fa59077d6a90878e70d0e034680812
Reviewed-on: https://gerrit.libreoffice.org/3967
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-20 18:54:52 +00:00
Andras Timar
d044918751 fdo#46553 Update embedded manifest on win32 builds to declare dpiAware
Change-Id: I71a3960b21f2c996b97e1a5707f20b30819fd6bd
Reviewed-on: https://gerrit.libreoffice.org/3981
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-05-20 18:48:38 +00:00
Rodolfo Ribeiro Gomes
e673655ba7 Make some uses of OUStrings a little more readable
Change-Id: I2e85fa39abbff86918464aae67b4b9eacd3bf7a4
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/3949
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-05-20 18:47:03 +00:00
Faisal M. Al-Otaibi
a53efad8de fdo#63878 fix the zoom bug on RTL sheet
fix the X position after check if the sheet are RTL

Change-Id: Icbb9ce44508698e0f03898b202e033c07ae2de70
Reviewed-on: https://gerrit.libreoffice.org/3954
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-05-20 18:00:30 +00:00
David Tardon
514d69eff3 put common vars into standalone makefile
Change-Id: Iab78a95bc8588b89fb10dc96b6c2c25e864fc1f4
2013-05-20 18:28:35 +02:00
Tor Lillqvist
2283f76ec1 WaE: use of unary operator that may be intended as compound assignment
Change-Id: Ib1718e5d3a0f7f1e4d1941674743900be12d4e1f
2013-05-20 18:09:11 +03:00
Caolán McNamara
7e7ccea7cc go back to 8 colorvalueset columns
Change-Id: I9e345b3dea1d4a13ac2307bcebda19d753ecd7d0
2013-05-20 15:56:19 +01:00
Jianyuan Li
0982b526bf Resolves: #i120554# Shape Gradient MS2003 import/export Enhancement
Reported by: Jianyuan Li
Patch by: Jianyuan Li
Review by: SunYing

(cherry picked from commit 09c33de80a0e5fa321979e53bf88c4d17271eba8)

Conflicts:
	filter/inc/filter/msfilter/escherex.hxx
	filter/inc/filter/msfilter/msdffimp.hxx
	filter/source/msfilter/escherex.cxx
	filter/source/msfilter/msdffimp.cxx

Change-Id: I80a60af4862eb99523ea59e4f788b685d6de1fbd

WaE fixes: reorder initialization, handle all cases in switch, ...

(cherry picked from commit 350f294badf378806348e77e6a8ed0b5f1d5b77d)

Conflicts:
	filter/source/msfilter/msdffimp.cxx

Change-Id: I4f1bde463921d48d1e014d0521427eaa9294663e

Add default to switch statements to avoid compiler warnings.

Patch by: Jianyuan Li

(cherry picked from commit f1302af0d803ca969022e69bcf7deeb62459f789)

Change-Id: I4e78e3b565d5922d452d2cfd1bf473af1587d29b
2013-05-20 15:56:19 +01:00
Marcos Paulo
bbfc9999db fdo#38838 Replacement of the String with OUString
Change-Id: Ib6fda987be15525d939cfe5c3e65f881aff83131
Reviewed-on: https://gerrit.libreoffice.org/3968
Reviewed-by: Ricardo Montania <ricardo@linuxafundo.com.br>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-05-20 14:41:06 +00:00
Tor Lillqvist
7281b2b67d WaE: variable ´res´ set but not used
Change-Id: I5f252f75d22f041c76c7d3cfcdd36f69becf086f
2013-05-20 17:30:09 +03:00
Mark Wielaard
9b76439dff sal osl_getGlobalTimer: Don't confuse start and current time.
Change-Id: I575dd70d6b80d4f3279476037e509550cfa23fde
Reviewed-on: https://gerrit.libreoffice.org/3979
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2013-05-20 14:25:15 +00:00
Andre Fischer
c6e576da95 Resolves: #i122329# Disable undocking of stylist in the sidebar
(cherry picked from commit 8dc875f17c0cdd41e7ba6ad2f4c1ea3bda1a8be2)

Change-Id: I1a19135d3496463c8759e341449fa51d389fa264
(cherry picked from commit 048eca411083bc8a2ef95e5701bf7eba5d232a2d)
2013-05-20 15:02:38 +01:00
Andre Fischer
05b2cd0814 Resolves: #i122321# Fix processing of scroll wheel...
to not block other events

(cherry picked from commit 0a5d252c19fdd4e1e705668a604fb319dc6ceccb)

Change-Id: Ib1a3fa50e071688df41983ce8e2cb6b1c93e18c9
(cherry picked from commit 58da1dc5061fcd9abc7dd296d0d7d04d651dc10f)
2013-05-20 15:02:31 +01:00
Andre Fischer
2e52faf39b Resolves: #i122320# Show closer after docking sidebar.
Prevent sidebar from being docked above or below edit view.

(cherry picked from commit ca7264d7ab7e8b70693362d60227c7dd7626df8b)

Change-Id: I634e0b68c27039613054160b7add5d2d07b666cd
(cherry picked from commit 3c451f893663c118201ccdd4688fe97f1524d21e)
2013-05-20 15:02:20 +01:00
Andre Fischer
7d56c8d077 Resolves: #i122271# Provide accessible for panels that...
includes the panel title.

(cherry picked from commit e785c5125994bbfdb4e69108b5a73a184b3ced49)

Change-Id: I97cf9f5f78382dfbd69dcff33b7066380d47313d
(cherry picked from commit 35c18dc890a8883b974ff73c585033fc3ee3b73e)
2013-05-20 15:02:12 +01:00
Armin Le Grand
82f418d2d9 Resolves: i122145 Multiselection with mix of DrawObjects and OLE...
will allow LineStyle and FillStyle panel, single selection of OLE offers these,
too, but in default closed state

(cherry picked from commit 8a2531d3d98ad3afb2b233be2d5dd7b67febeba6)

Change-Id: Iba8f99afb4324d33be0469e3b0835f08fe142b0a
(cherry picked from commit 3c33a28233dfbb0db44553f13511107976f18363)
2013-05-20 15:02:00 +01:00
Caolán McNamara
3cc0f7b992 restore white next to black in the color palette drop-down
i.e. restore e206f8b7a2

Change-Id: I9c9647ae9e42bcb09a6acd8755bcb170006818f0
2013-05-20 14:58:52 +01:00
Armin Le Grand
6c65af22ee Related: #i121520# changed a 2nd 'Blue 9' entry to 'Blue nine'
to solve the conflict

(cherry picked from commit 81c3404d82cb72b9d183e2b38034334e9b65fd22)

Change-Id: Ic368478dac25d9dce8e7c80bd3a7a33fdc68f3b0
2013-05-20 14:58:51 +01:00
Armin Le Grand
efd10664b7 Resolves: #i121520# changed basic color palette as described...
in the task and discussed on the list under '[proposal] Adopt palette to
Symphony palette partially', also corrected typos on gradient
definitions

(cherry picked from commit 57811cc1cd5e49c1e87fb2a9d79f8a3941a025e3)

Conflicts:
	extras/source/palettes/standard.soc

Change-Id: I54fa27963f7c9732211b7bded5a343b9c05449ab
2013-05-20 14:58:51 +01:00
Armin Le Grand
3061fa41af Related: #i121511# Reordered for more user convenience
(cherry picked from commit 687205925cf94cff2daeb6e399ea7b05fd8213dd)

Change-Id: I6a24d55471fe56175ce1bd8358e6a433f3940e78
2013-05-20 14:58:51 +01:00