so only call it once at the start of the loop. Shaves 1% off the cost of
loading complex documents with lots of shapes.
Change-Id: Ieb985b2523f6b4db3313eb000cf64e9c689e65c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170820
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This patch improves the following in vertical tabs:
1) Selected entries are painted natively when possible
2) Entries are a bit taller
3) Text is now vertically centered (for items that are text-only)
4) In native controls a mark is drawn on the selected tab
Change-Id: I42a8e002130030d1484c4149b146258921436af9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170554
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
and
cid#1557287 Use of auto that causes a copy
cid#1558003 Use of auto that causes a copy
cid#1557568 Use of auto that causes a copy
cid#1556546 Use of auto that causes a copy
cid#1557377 Use of auto that causes a copy
cid#1608325 Use of auto that causes a copy
Change-Id: I84e59d2b14bb1e5856f9cac521ad6542b1784243
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170821
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Some default styles ("Filled Blue", "Filled Red", "Filled Yellow",
"Outlined Blue", "Outlined Red", "Outlined Yellow") were modified. But
when slide is copied to other presentation, these new styles are
replaced by default styles.
This change duplicates the formats to preserve them when slides are
copied outside Candy template.
Change-Id: I38ccacbe65912c5b2cfecfa0d309a412bc34a867
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169661
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
The problem was, that the function only considered the target XSQLVAR's
sqltype, ignoring sqlsubtype. This led to a situation when assignment
to NUMERIC or DECIMAL was treated as assignment to an underlying type,
like SQL_LONG, performed without taking scale into account.
Use ColumnTypeInfo and its getSdbcType, which provides the correct type,
and add missing cases to setString. Fix setObjectWithInfo to make sure
that the resulting number is correct.
This also fixes export of NUMERIC/DECIMAL in HSQL migration. Previously
it miscalculated the position of decimal separator, which accidentally
went unnoticed in the existing unit test, because it was compensated by
broken handling in Firebird SDBC for the specific numbers in the test.
OResultSet::makeNumericString was also fixed; it didn't handle properly
the case of zero fractional part: initial number 1200 with scale 2 was
converted to a string "12.000" instead of expected "12.00".
Change-Id: I5adac59737d21f91c782fe867d4827fb880fd62a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170812
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
It's unnecessary to obtain system time twice or thrice and also prevents
different today values when looping over midnight.
Change-Id: Ifcf4917769bb1d853e326049711e295d54408eef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170699
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
reduces the load time of a complex document from 18s to 16s
Change-Id: I5382e27bf1b6beaf7276ef46f10d43d5bf9822d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170795
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
- Add the Histogram selection to the UI
- Histogram bars showing with No Gap
- Convert X and Y axis to group data into bins and frequency
- Adjusted failing UI test (tdf138556) as a new chart type was added
Change-Id: Id1f161adac943ead5e17c7fbb7e14c9ab7f1655e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167068
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* Update helpcontent2 from branch 'master'
to de354a5e67e0e079d471c3ba7d806044f997c238
- use same names of XMATCH arguments as in UI
Change-Id: I1ce3a68d071bdccb1caa9af3c4389d8c0db82979
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170805
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Jenkins
window when adding a change in the document (Track changes mode),
round 2
Addresses two situations where the list still jumps to the top:
Situation 1:
When an entry is added to the end of the changes list.
Situation 2:
After editing a comment for a change list entry with the 'Comment'
dialog.
Change-Id: I4a75e6bcba13fb9cc735cf78756fe736b9d4665d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170598
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
The problem was unhandled exception thrown from destructor, resulting
in a crash.
Change-Id: Ib9d2deb2fe9745bf8df060c4e5bf6436b4ca468d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170790
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
and
cid#1607722 Use of auto that causes a copy
cid#1557606 Use of auto that causes a copy
cid#1557569 Use of auto that causes a copy
cid#1556239 Use of auto that causes a copy
cid#1556043 Use of auto that causes a copy
cid#1554961 Use of auto that causes a copy
cid#1554818 Use of auto that causes a copy
Change-Id: I9f74c7bc4da2c6b1df80d0fb4504dd4d03eb1053
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170784
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
std::vector::clear() appears to delete elements in the
reverse order added. In the case of tdf#161729, a style
sheet's SfxItemSet can have a parent SfxItemSet and that
parent is the SfxItemSet for a style sheet added later.
Deleting from the end of the vector deletes a style sheet
and its SfxItemSet. If the now deleted SfxItemSet is a
parent SfxItemSet of a style sheet that was added earlier,
the style sheet added earlier will now have an SfxItemSet
with its parent set to an already deleted pointer. And so
a crash will occur when that earlier style sheet is deleted.
rxStyleSheet.clear();
Change-Id: I8ce7023fce8b01432cb3c9288a8f83e7a2f0f2d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170707
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The problem was, that importing an HTML table into Firebird, and creating
a primary key, called OParameterUpdateHelper::updateInt for each record's
primary key field. Since commit c07548447a
(Related: tdf#108057 Use autoincrement for automatically added primary key,
2024-03-20), the type of autocreated primary key in Firebird databases is
SQL_INT64, and before this change, OPreparedStatement::setInt failed when
the real field's type wasn't strictly SQL_LONG.
This allows Firebird SDBC's integral OPreparedStatement::set* methods to
promote to larger numeric types capable to represent the values.
Change-Id: I7615c8e9ffa29271d04cf264bb950cb76946dfd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170787
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Also add a test for uno.DeleteAllAnnotation
Change-Id: Icc8cfbad50879b5bc0e9e2b9996666cff0a85cb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170780
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Open the bugdoc, the first paragraph is meant to be sans and the second
paragraph is meant to be serif, but both of them are serif.
The bugdoc uses the fonts 'IBM Plex Sans' and 'IBM Plex Serif', which is
not something we bundle, so the font fallback is expected, but the
fallback should have a matching font family (roman vs swiss).
Fix the problem by implementing support for <w:family w:val="..."> in
the DOCX import, which was just ignored previously.
Now the DOCX import result in on par with the ODT import result.
Change-Id: I321b9fc6f63126ca5ad61af57af8a5bc7456d5b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170772
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This will link libgssapi_krb5.so.2 which is in krb5-libs (ABI CL1 in
RHEL8, ABI CL2 in RHEL9).
Change-Id: I2dbaa64e70f4502c5a47c6c85123c94b9ad41277
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170758
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Make the generated unique ID random for new content controls.
This way if we copy paste them from different documents,
they may still be unique.
Change-Id: I2adb6577e08b5798ae88a63b6178352aa76280d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170773
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
