...to fix false clang-cl warnings like
> C:/lo-clang/core/cppuhelper/source/compat.cxx(113,29): error: externally available entity 'ClassData' is not previously declared in an included file (if it is only used in this translation unit, put it in an unnamed namespace; otherwise, provide a declaration of it in an included file) [loplugin:external]
> struct SAL_DLLPUBLIC_EXPORT ClassData {
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
Change-Id: Iacf96569e27772aa9e27221619516b1fb84dd665
Reviewed-on: https://gerrit.libreoffice.org/84514
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Do pass that as actual mm100 then.
Change-Id: Ifc9608aeee838172a18cc07aa1dbe0d7f3f5fb6a
Reviewed-on: https://gerrit.libreoffice.org/84473
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit a69f5b1386)
Reviewed-on: https://gerrit.libreoffice.org/84522
Tested-by: Jenkins
* See comment at head of compilerplugins/clang/unusedmember.cxx for description.
* Moved isAllRelevantCodeDefined from loplugin:fakebool to PluginHandler for
reuse. (Made it a member function so that it can reuse its two
RecordCompleteMap instances across different loplugins. Probably safer
lifecycle-wise to have them as PluginHandler members than to have them as
static local variables in function isAllRelevantCodeDefined.)
* Need Plugin::ignoreLocation overload for TypeLoc now, thanks to
UnusedMember::VisitElaboratedTypeLoc.
* UETT_PreferredAlignOf was split off UETT_AlignOf with <https://github.com/
llvm/llvm-project/commit/6822bd79ac43f267613f1615bf60407103e24dba> "PR26547:
alignof should return ABI alignment, not preferred alignment".
* RecursiveASTVisitor::TraverseAlignedAttr traverses into the attribute's
argument only since <https://github.com/llvm/llvm-project/commit/
f26d551387f032e05e5e6551605b150f38c3f5b2> "Do not look through pack
expansions when looking for unexpanded parameter packs".
Change-Id: Ic2702b03d4567fa2533333766de7920f3c524a69
Reviewed-on: https://gerrit.libreoffice.org/84416
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
("public virtual function just calls public parent")
Change-Id: Ifd8d6c794ae32af1fe5d2a97389ec87394fdffbc
Reviewed-on: https://gerrit.libreoffice.org/84512
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
using "InternetLink" in hyperlink/r/rPr/rStyle instead of the actual
character style, and keep actual character formatting in
hyperlink/r/rPr/rFonts, like MSO does.
Change-Id: Ic75c907eff422efbf96badcd2af50562cc3cbf25
Reviewed-on: https://gerrit.libreoffice.org/83676
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
To prevent calls to Qt5FilePicker::updateAutomaticFileExtension,
it is simply made virtual with an empty override. This is needed,
because the KF5 file picker has its own automatic extension
handling.
The main motivation is the fix for tdf#129071, which will result
in some major changes to XExecutableDialog::execute, so this will
prevent larger code duplication later.
Change-Id: I5f747f0828cb8a65b4e7043f3ee68ebd31973e6a
Reviewed-on: https://gerrit.libreoffice.org/84297
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This avoids complaints of non-circular circles when inserted, and
trades them for complaints about non-elliptical ellipses; degeneracy.
Change-Id: I8a870b75ba1b8b7b2a7f9cc3de213e215ed5b95a
Reviewed-on: https://gerrit.libreoffice.org/84377
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 71f03dceb9)
Reviewed-on: https://gerrit.libreoffice.org/84392
Tested-by: Jenkins
...after that file got re-enabled for Windows builds recently
Change-Id: I67c9e1676344d3754293595ec5a3c6093c0959c1
Reviewed-on: https://gerrit.libreoffice.org/84510
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Update helpcontent2 from branch 'master'
- IsObject is not limited to OLE objects
Change-Id: I9506691e4f61c5b51a51b79a956db53aa59f95ac
Reviewed-on: https://gerrit.libreoffice.org/84548
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
("function definition with pure-specifier is a Microsoft extension"). Keeping
it pure but implicitly defined (by dropping the "{}" part) would cause
unresolved symbols during linking, so keep it explicitly defined inline but non-
pure (which should be fine as the class still has other pure members).
Change-Id: Ieff73fd5c9010164c202f752605890b78809caa6
Reviewed-on: https://gerrit.libreoffice.org/84507
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Caused build breaker on Windows at least with clang-cl and --disable-pch:
> In file included from C:/lo-clang/core/vcl/skia/gdiimpl.cxx:25:
> C:/lo-clang/core/include\vcl/svapp.hxx(487,5): error: declaration does not declare anything [-Werror,-Wmissing-declarations]
> static void Yield();
> ^~~~~~~~~~~
Change-Id: Ibadd59c99040c318c874d0eb6747006bfb5e248f
Reviewed-on: https://gerrit.libreoffice.org/84505
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
From some reason it does not work, so let's do the same we are doing on
iOS; at least for now.
Change-Id: I915f8683a112548fc3defc1114f9dce3aa7be30e
Reviewed-on: https://gerrit.libreoffice.org/84067
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/84204
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
so is of no use
Change-Id: Ibb1187183abff6b8dc26ed5011b43af1a86a7d04
Reviewed-on: https://gerrit.libreoffice.org/84458
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
