…and from a quick glance similar features are not exposed to userland
applications on arm64:
https://docs.kernel.org/arm64/cpu-feature-registers.html
"The ARM architecture defines a set of feature registers, which describe
the capabilities of the CPU/system. Access to these system registers is
restricted from EL0 and there is no reliable way for an application to
extract this information to make better decisions at runtime.[…]"
Thus the CPU information would have to be gathered from the OS, probably
from the Windows registry, at least it should be possible to read the
name/model that way…
Change-Id: I39e3679a7c4c581d8e3e4f71842d7ea7cdc2ba67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138380
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
we can get the ScDocument another way
Change-Id: Ie1953b911d34a647fbac1923bc9166f67f346a69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138483
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This reverts commit d40bfecddc for
a different approach
Change-Id: I8e058efbff214456b91346ce16e7eba7a89a8a53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138480
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Any time there is numbering, we expect to see an
optional sListFormat set.
This solves a few different cases found by:
assert(false && "depricated format still exists
and is unhandled. Inform Vasily or Justin");
Change-Id: I127e100a003c46c7a9dfa681014ffc11ceda24ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138452
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
* Update helpcontent2 from branch 'master'
to 21c64d4e09d23bf8933f8d513a857d4df3029cfa
- Update LO7.4 new features video
Change-Id: Ic1290ef2d90aca04f1bf6df1aae5d19f64f5919f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138486
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
This patch removes the fixed size of the Templates dialog in pixels so it works better in HiDPI displays.
This patch also makes the dialog a bit wider and non-resizable.
Change-Id: I256d8d5c8b76c8e32a4f008f3a235f80bf59634d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136922
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Full text of legend labels could overflow the chart area,
if the legend text was too long. If it's longer than
520 characters, strip it at the first space from the
500th character (or if there is no space, at the 500th
character). This results better XLSX interoperability, too.
Change-Id: I23a94f6baaf620b40e9b2819738eba5c5a921722
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137492
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
Multiline last words, e.g. long URLs resulted crashing
using the new hyphenation option "Don't hyphenate last word".
Follow-up to commit 8c018910ae
"tdf#149248 sw offapi xmloff: add option to not hyphenate last word".
Note: .fodt format is not applicable for unit testing.
Change-Id: I8633af1517f09003b40a06825ad14f3ed7f882a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138296
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
...with recent Clang 16 trunk since
<7068aa9841>
"Strengthen -Wint-conversion to default to an error", causing
> workdir/UnpackedTarball/epoxy/src/gl_generated_dispatch.c:114547:77: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'GLhandleARB' (aka 'void *') [-Wint-conversion]
> GEN_THUNKS(glAttachObjectARB, (GLhandleARB containerObj, GLhandleARB obj), ((uintptr_t)containerObj, (uintptr_t)obj))
> ^~~~~~~~~~~~~~~~~~~~~~~
> workdir/UnpackedTarball/epoxy/src/dispatch_common.h:150:40: note: expanded from macro 'GEN_THUNKS'
> GEN_GLOBAL_REWRITE_PTR(name, args, passthrough) \
> ^~~~~~~~~~~
> workdir/UnpackedTarball/epoxy/src/dispatch_common.h:95:14: note: expanded from macro 'GEN_GLOBAL_REWRITE_PTR'
> name passthrough; \
> ^~~~~~~~~~~
etc.
That only hit on macOS because of the different
> #ifdef __APPLE__
> typedef void *GLhandleARB;
> #else
> typedef unsigned int GLhandleARB;
> #endif
in OpenGL's glext.h, which
<0cfb0a044b>
"Fix most GLhandleARB warnings on OS X with a big comment in our code" had tried
to address by adding "a cast to uintptr_t to shut up the compiler" in its
src/gen_dispatch.py (but without stating what compiler diagnostics exactly were
supposed to be silenced by that cast that now started to cause the above issues
with Clang 16 trunk).
It turns out that at least my macOS build with Clang 16 trunk builds fine
without that cast, so just drop it for good. (And patching epoxy's
src/gen_dispatch.py means that UnpackedTarball_epoxy needs to switch from
gb_UnpackedTarball_set_pre_action to gb_UnpackedTarball_set_post_action.)
Change-Id: I2c87bca2cc5510d17098028d4532989f48e349a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138407
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
- better symbol positioning taking symbol height and cell height
into account.
- symbol height depends on font size (as with the legend)
- take symbol aspect ratio into account
- remove hardcoded values
Change-Id: I3537d82538035cd31b928d4bb6fc5572914fcd13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138463
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
The CharBackColor should only be set when the fill style has the
value "FillStyle_SOLID", otherwise don't set it as we can't handle
any other fill style.
Change-Id: Icaec8996d47966bb32bd8cf88b8c5aad70ab07a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138462
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
in places where we are using the result with operator<
Change-Id: I3440d1204e69e30f21eaf833c2d0c42cde59e55c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138454
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
in places where we are using the result with operator<
Change-Id: I2aae14e9130efc31f5afd3450defdf6df4099950
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138403
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
in places where we are using the result with operator==
Change-Id: I28f8f6fa2c3754ec6612ab2334c3a58b61ecd065
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138401
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
In drop cap layout, set smaller size for all glyphs positioned
over the baseline, e.g. dashes (dash, en-dash, em-dash, figure dash),
bullet, asterisks and quotation marks by extending the bounding box
of the glyph to the baseline, like MSO does.
Add "DropCapPunctuation", a new default compatibility option for this.
Only old ODT files loads the old layout (which was partially broken:
e.g. dashes were too long, often missing from the drop cap area or
the drop cap was disabled). New ODT and imported DOCX documents
use the new default layout for better typesetting and interoperability.
Change-Id: I3aba0727fd15f6edb9245e31f523e12f407d189e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138356
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
This commit reverts 3749d9af37
which removes the dependency on the external library cuckoo
Without using cuckoo the same file in tdf#130795 takes
real 0m4,892s
user 0m5,298s
sys 0m0,449s
With it, it takes
real 0m4,914s
user 0m5,276s
sys 0m0,444s
pretty much the same time
Change-Id: I4cc9000ac5bf26de22bb9835283ae8d5b3230196
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138435
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This reverts commit 7548748e34.
No longer necessary after doing a fresh pull of llvm, so llvm
is at commit 4c244b2833bdc51bbb7970ea6433e844dfddf622
Change-Id: I6dc721b47a905f553b227db3a036899173b35bae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138408
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
After the first delete, there is a single redline from 170,0 to 177,9,
which contains a section.
[ 169] 0x6133358 TextNode "b) 9 (Robin Cook, Jack Straw, Margaret Beckett, David Milliband, William Hague, Philip Hammond, Boris Johnson, Jeremy Hunt, Dominic Raab)",
[ 170] 0x61349d8 TextNode "Hangul script is used to write which language?",
[ 171] 0x61396f0 SectionNode ,
[ 172] 0x6138cc8 TextNode "Japanese",
[ 173] 0x613ab58 TextNode "Vietnamese",
[ 174] 0x613ad78 TextNode "Korean",
[ 175] 0x613bc28 TextNode "Chinese",
[ 176] 0x24a61c0 EndNode ,
[ 177] 0x6139568 TextNode "c) Korean",
Then the next delete is from 169,137 to 170,0 and it is combined in
AppendRedline() with the existing one, removing the existing one.
Now the code for tdf#119571 at the end of AppendRedline() that splits up
the one redline into 4 redlines, with the section start node and section
end node not covered by any of them.
AppendRedline() of a delete redline causing previously deleted nodes to
become un-deleted is a situation that UpdateFramesForAddDeleteRedline()
doesn't expect.
Additionally there seems to be an issue with CheckParaRedlineMerge()
setting the Section's m_bHiddenFlag, which was unintentional, it should
only set m_eMerge flag, but fixing that isn't sufficient.
Reportedly this crashes since commit
6433dc223f but the problem appears older.
Change-Id: Ic83a93d5aaec4ee562fb960693b52bd7b25cb1a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138411
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* the fly-at-fly case didn't work, iteration also skips it
* delete the bad redline section in the nodes array
Change-Id: I21d3635fb53068e79984b0ea74a0a0913513bd51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138434
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
This commit is mainly about the introduction of
a new internal method:
_ComputeFilter(range, filterformula, filterscope)
A FilterFormula is a Calc formula that returns TRUE or FALSE
The formula is expressed in terms of
- the top-left cell of the range when FilterScope = "CELL"
- the topmost row of the range when FilterScope = "ROW"
- the leftmost column of the range when FilterScope = "COLUMN"
After pasting, the relative and absolute references
will be interpreted correctly.
The FilterScope indicates the way the formula is applied,
once by row, column or individual cell.
The concept of FilterFormula was already used by CompactUp()
and CompactLeft(). Their implicit (Filter)scopes were resp.
"ROW" and "COLUMN".
The _ComputeFilter() method returns an array of subranges
contained in the initial range that match the filter.
The isolation the code for the management of filters
applied on ranges makes the later use of the concepts of
FilterFormula and FilterScope reusable for other methods.
CompactUp() and CompactLeft() are functionally unchanged.
No impact on documentation.
Change-Id: I7c4e890b54f315486f29b5434a3c236167e2f9ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138368
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
This simplifies and deduplicates call sites, and also makes sure that
we don't lookup strings until we need that. Also helps adding a check
for Math in a follow-up.
Change-Id: I6b073253f19afbb9a95f29806ab306c6a9f63f18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138413
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
