strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

actualizacion-master-2024-12-02 #3

Merged
iapz merged 121 commits from actualizacion-master-2024-12-02 into master 2024-12-02 13:56:07 -06:00
Conversation 0 Commits 121 Files changed 426 +10686 -3305
iapz commented 2024-12-02 06:11:41 -06:00
Member
Copy link
No description provided.
iapz added 121 commits 2024-12-02 06:11:42 -06:00 
Change-Id: I3813d8ebcb1e678ece2e3c3554bb0ddb7b546b34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177490
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I2708f103cb9e63294cd2ee056dc490c734285a31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177487
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
This change adds loext:margin-left and loext:margin-right, which
implement margins that support font-relative units.

See tdf#36709 for additional details.

Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
... and use a non-const pointer when iterating instead.

Change-Id: I165b0ce907cadacc76562bff974ff913a3a711da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177480
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
  to aa5fa6c008064ee28c01354b1f40920b2de83b2c
  - Mute L10N in Navigator context help page
    
    Change-Id: I5211d028909ca140fbe2d9eed6fa57cbf57b84c5
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177510
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Insert/Edit table, insert lists, insert AutoText
automatic spell checking

Change-Id: Iccef3965316dc6079ea56a0283023c5a658512cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165031
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Change-Id: I596245603c0945438a940465122cb4c3e6954e81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177140
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
When we save - we block UI. In the lok we disable that for
some cases like in commit e005690e9c
lok: avoid sending jsdialog messages during background save.

But we also use save file to generate previews of shapes what happens
on eg. resize in Online. Then we trigger disable and enable cycle
for frames - and we end with FontNameBox enabled!

That was causing the JSDialog combobox still being locked - because
frame unlock was using direct VCL API, not weld:: one in the
InterimItemWindow. Let's fix that with proper StateChanged handling.

So now it is functional. But still I think there is some error in the
logic - as after save we should beg the "before save" state of control
not "always enabled". But it's different problem.

Change-Id: Ia8e5c8c864156271b5f68d482234e83eb57b0deb
(cherry picked from commit cbe229ec219e56ce1bb5dd9598f9052a98504249)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177489
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Interlingua currently translated at 75.8% (88 of 116 strings)

Change-Id: I6f6529872aa3c3cf3553eacebe280195fa5f0699
Co-authored-by: Weblate <noreply@documentfoundation.org>
Co-authored-by: eduver <hmcb2080@gmail.com>
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/
Translation: android-viewer/android-strings
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177478
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
* Update helpcontent2 from branch 'master'
  to dc50ebde81a0e9266806878b69de81da422ec39c
  - Revert "enable help for Tagalog (tl)"
    
    This reverts commit 3d37519d37c1ac9e5d30b45f1cd922c73107d4d1.
    
    Reason for revert: apparently not all files have been added for master
    
    Change-Id: Ia0979a8abca4aa598563598276c9a9c0e0518a33
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177515
    Tested-by: Jenkins
    Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
    Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
regression from
    commit 6c2f827697
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Sun Oct 20 15:07:41 2024 +0200
    improve style searching in SvXMLStylesContext

Two problems - the original code was searching by DisplayName,
not Name, so add another index for DisplayName,
and the prefix matching was not properly matching.

Change-Id: Ifd43bdb89d33067954298115c8700b87c7f93050
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177488
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
looks like a stray line I think

Change-Id: I065a35d6e161c37d832e308f7ed1ce239e4e2bbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177516
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
#2  SwView::GetPostItMgr (this=<error reading variable: Cannot access memory at address 0xc8>) at sw/inc/view.hxx:659
 #3  SwXTextDocument::getPostIts(tools::JsonWriter&) () at sw/source/uibase/uno/unotxdoc.cxx:3351
 #4  0x00007f6238ac7cc8 in getPostIts (pThis=0x36aa6cb0) at /opt/rh/devtoolset-12/root/usr/include/c++/12/ext/atomicity.h:111
 #5  doc_getCommandValues () at desktop/source/lib/init.cxx:6739
 #6  0x00000000005863e0 in lok::Document::getCommandValues (pCommand=<optimized out>, this=<optimized out>)
    at /home/collabora/jenkins/workspace/package_cool_24.04_rpm/rpmbuild/BUILD/coolwsd-24.04.9.2snapshot/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx:492
 #7  ChildSession::getCommandValues(StringVector const&) () at kit/ChildSession.cpp:1180

Change-Id: Ib2a3c2e7eb1a108ad969588f6c313cade145e8ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176600
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit c0542a438d91051bcdab1f5bc19ee46c90bd91a7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177517
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I634a88af23116fd823b9b595cdb801a032593688
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177518
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I128a60a312fe15a3333bd7dad37257c80fb20d70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177521
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I1b41a57ccdda4cdbd8a3a8ab3dbde495a51df80e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177508
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since we have slide size in twips we need shape bounding box in twips
too.

Change-Id: I41e4658278e7b36b87a6bccc72b429944ef27e4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177522
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
adding two A11y issue level: Error and warning level, and
categorizing our accesibility issues based on how the
PAC 2024 tools and WCAG behave with the different warnings/errors.

Change-Id: If4e4800497340318bb990326c64de655f24a47e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177389
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
This variable is passed by a reference to the 'readArguments' function in which its value will be utilized. Inspect the fifth argument.

Change-Id: I39d71ac5e76d3d9a808fa08a430af9aa0686684d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177494
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
This adds PDFEncryptorR6 and adds R6 hash implementation and makes
sure it is correct with a test.

Change-Id: I11ca746a6b676bb294723b4ef76069f1d4f3a182
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177384
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
Change-Id: Ife0e974d66d5ddbe3c831c64e4da28442e476da4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177234
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
* Update dictionaries from branch 'master'
  to 0fdcd7916f2e59da20419d408cad8bcb909c5ae5
  - Updated the English dictionaries: GB+ZA
    
    Change-Id: Ifea0bef5714162def9b5adc7dd20c1d6d69d05e0
    Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/175966
    Reviewed-by: Aron Budea <aron.budea@collabora.com>
    Tested-by: Aron Budea <aron.budea@collabora.com>
real symlinks require admin-rights or developer mode, and the other
fallback mechanisms won't work for the version of git that comes with
git-bash. Either spawning the process failes or worse it silently fails
and basically ignores the hook.
MSYS uses regular file copy when using "ln -s" which means to make sure
the current version of a hook is used the hooks need to replaced
everytime or the file contents need to be compared. When using hardlinks
instead it is enough to check whether the source and target share the
same inode.

Change-Id: Ib2e325048779828313afc7fc9d120661d55fc3a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177498
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
Crashreport signature:

> SIG   Fatal signal received: SIGSEGV code: 1 for address: 0x0
> program/libmergedlo.so
>       SfxLokHelper::notifyOtherViewsUpdatePerViewId(SfxViewShell const*, int)
>               sfx2/source/view/lokhelper.cxx:1098
> program/libswlo.so
>       SwSelPaintRects::Show(std::vector<rtl::OString, std::allocator<rtl::OString> >*)
>               sw/source/core/crsr/viscrs.cxx:514
...
> program/libswlo.so
>       SwWrtShell::SwWrtShell(SwDoc&, vcl::Window*, SwView&, SwViewOption const*)
>               sw/source/uibase/wrtsh/wrtsh1.cxx:2032
...
> program/libmergedlo.so
>       framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&)
>               framework/source/services/desktop.cxx:592

I.e. it can happen that during load we don't yet have a view, similar to
commit a2b22f5b551cb2030cd29d3dd3510fca42a0bfc1 (sfx2 lok: fix crash in
SfxLokHelper::notifyUpdate(), 2024-11-26).

Change-Id: Id17a61296a181a2ba4909b633d46a3c9d7aacb02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177525
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
The label in the search bar has a notification a11y role
in order for the text (like "Search key not found") to
be announced when screen readers receive an event indicating that the
notification became visible (an object:state-changed:showing
event for AT-SPI on Linux).

However,

    commit 48ba98a51f
    Date:   Wed Nov 29 14:29:57 2023 +0100

        Resolves tdf#158412 - Don't show chevron in quick find bar

caused this event to be triggered also when the label has no
text, which resulted in Orca just saying "Notification", without
any indication what that notification might be.

Avoid that by not setting the label to hidden at the beginning
of LabelItemWindow::set_label if the label text is empty, so setting
it to visible again doesn't have any effect if it's already visible
when the method gets called.

An alternative might be to switch to using dedicated
notification events instead of using a label with
a notification a11y role, now that that kind of event
is available in AT-SPI2 since at-spi2-core-commit [1]

    commit 26835da29918be2c0da6c08fb70d893de22891d2
    Author: Mike Gorse <mgorse@suse.com>
    Date:   Thu Aug 4 12:38:27 2022 -0500

            Add an "announcement" event/signal to allow objects to send notifications

            Fixes #63

[1] 26835da299

Change-Id: Ia4fbf9544f72e10c74e92487619222d59f55cfa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177523
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
When dragging a selection box on an empty background in
Impress and only with Skia/Metal, the selection box
would not keep up with the pointer. The selection box
would repaint sporadically or not at all if the pointer
was dragged rapidly and the status bar was visible.

Apparently, flushing a graphics doesn't actually do much
of anything with Skia/Raster and Skia disabled so the
selection box repaints without any noticeable delay.
However, with Skia/Metal every flush of a graphics
creates and queues a new CAMetalLayer drawable. During
rapid dragging, this can lead to creating and queueing
up to 200 drawables per second leaving no spare time for
the Impress selection box painting timer to fire.

So with Skia/Metal, throttle the rate of flushing by
calling display on the view.

Also, with the reduced Skia/Metal flushing load from this
fix, the color conversion when drawing to an NSBox appears
to be no longer needed. The converted color appeared less
saturated, at least to me, so accept the (hopefully now
imperceptible) performance hit of drawing an NSBox with
native colors.

Change-Id: I55b4ab763bf20c6c2acad65587b703fc6f645264
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177530
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
probably since:

commit 65129e0bc5
CommitDate: Tue Feb 2 22:06:18 2021 +0100

    tdf#137081, tdf137082 fixes shape handling in RTL sheets

Change-Id: Ife720a0ccbff0029ace822d246dc227e01846734
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177537
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I6fef2b6818018b8a0f82125ef2d8220688d642a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177536
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
1. SwContentFrame::MakeAll() needs some more checks to ensure that it
   never Formats a hidden text frame. This fixes the reported problem
   that turning off "Hidden Paragraphs" in Tools->Options->Writer->View
   results in bad layout (extra completely empty page at the end).

3. This means HideAndShowObjects() must be called manually in that case
   as it was previously called inside Format(), see
   testHiddenSectionFlys.

2. SwTextFrame::Prepare() as called from calcing some upper (table cell)
   in the bugdoc needs to avoid invalidating a hidden frame so it isn't
   formatted (triggered new assert).

4. SwLayAction::IsShortCut() had what looks like an obvious and ancient
   mistake that was causing a crash in testTdf155011.

5. SwTabFrame::MakeAll() should not calc the next if it's hidden, that
   was causing a problem in testThemeCrash where a hidden frame moved
   back into an overfull body and immediately forward again, triggering
   the new asserts.

6. SwTextFrame::IsHiddenNow() caused interesting problem where some
   ancient (CVS import) check for a 0 width would skip the invalidating
   due to the 2. change when called from SwViewShell::Reformat() ...
   lcl_InvalidateContent() in testParagraphMarkInCell; unclear why this
   check exists, let's avoid it for the cases where we definitely know
   that only doc model should determine visibility.

7. JunitTest_sw_unoapi_1 triggers new asserts because MakePos() in a
   cell ends up invalidating the text frame; fix it up again.

(presumably regression from commit
 0c96119895 or one of its follow-ups)

Change-Id: I619f4be852eca5124f49d9a91e1de658b7070074
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177486
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Change-Id: I3026788bc8a239dc467b0a43c865c9659f392108
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177540
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Restores abbreviation handling to spell checking.

Regression from commit 44699b3de3
 "tdf#49885 BreakIterator rule upgrades".

Change-Id: I2883f984952aa3e54cfe800590a16c0de74ae0e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177506
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
Change-Id: Idedd1680b03f6b62ff80ad7d0fd74c11d1675053
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177533
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
When a hidden paragraph is split across pages, there is nothing that
joins its follow (SwContentFrame::MakePrtArea() has code to do it but it
wasn't called even before the previous commit?) and when the follow is
formatted is doesn't move back.

So just join all follows asap in SwContentFrame::MakeAll().

(presumably regression from commit
 0c96119895 or one of its follow-ups)

Change-Id: Icecdf17c1c1e11a3b62c7e5bf2c6624f234c94f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177500
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
There are 2 as-char flys with 2 hidden paragraphs each, and when turning
off show hidden paragraphs, the paragraphs shrink to height 0 but the
flys don't - this is because due to other hidden paragraphs earlier, the
position of the flys change and Shrink() is called before MakePos() and
then it uses the old position to check and that results in a negative
nRstHeight, so the upper doesn't actually shrink.

Fix this by always calling MakePos() before MakeValidZeroHeight().

(presumably regression from commit
 0c96119895 or one of its follow-ups)

Change-Id: I9a4ffadff02b6a2bc59c6a37aa15abec429e1068
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177524
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
clearly we do not often have combobox's that have nothing selected,
otherwise these issues would have arisen sooner.

The immediate cause of fixing this was the assert
VCLXListBox::getSelectedItemPos which was triggered when using X-ray to
examine a writer document

Change-Id: Ia5ec713ef54a841010a9b680d4520f7160d48167
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177532
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
because it took me a while to figure out the magic value here

Change-Id: I9a188d23a1f5aaac1bff10f795a916bc30cfb7ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177534
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
... is required to be utilized. A memory leak is possible.

Change-Id: Iae82c6a9dd124ac073c0eb99141d4104b1e05101
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177551
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Change-Id: Ic8622a035fcd3c8a4a9883db9df8275cf6b10a30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176801
Tested-by: Jenkins
Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Change-Id: I4b02c5b4dca22bce5653dad1d179ea2a1b249a8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176798
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
Change-Id: I03e682093bff3b743b074d0d1dc68994f31ae707
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176800
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Change-Id: I2e047407e771b75323898ecf096721b8f3600ead
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176799
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Change-Id: I8b71f1af2841846bfbdc7a1f63e7014f338bf41d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177543
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
I stumbled across GetNextValue while looking how I could optimize
GetValue's use of Search. Since this function needs to iterate
through every single entry, it was relatively expensive to
"Search" for the beginning row each time, when we know it will be index++.

Change-Id: I1bc7b6b041b7836aebc4cd2bfd9214851804bf31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177561
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Previously, Danish words ending with hyphens were not handled correctly
during spell checking. This change fixes the issue by modifying the
da_DK locale to reference the existing breakiterator rules for languages
with word-final hyphens.

Change-Id: I9b08fb5246b5b846814dc3b4b9ba249b29fc7a84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177504
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
without the translations, the screenshots for all languages will only
have the English strings

Change-Id: I9a82da905c74457c0813ca3efb2d6d0ba31a0f86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177563
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
Most of the UI is covered by themes. The icon theme changes
automatically to light or dark based on the window color. Further
improvements will be based on the feedback from the users.

Change-Id: Ia63ee608fe7870bc7cc86abb892f5fd5d6f1d8ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168829
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
Tested-by: Jenkins
This was left as a TODO in commit cb890ae43b
(oox: export Math objects to PPTX files, 2016-01-15). Now after commit
7cfff4751b (Related: tdf#129061 Avoid formula
import and use fallback for now, 2024-09-11), that relied on the fallback
being present, our exported documents lost the formulas completely on load.
So the fallback export became a necessity.

Change-Id: I52d4ef0400ce72ee10fda10a1131b4ba29ea56be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177564
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Change-Id: I2495fa1ad081ad75bd8e79a22bdeaa97217aa398
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177581
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Implement a small subset of the QtInstanceTreeView
methods - basically what is used by Calc's
"Sheets" -> "Show Sheets" dialog for which
support will be declared in an upcoming commit.

In QtBuilder, ignore "GtkCellRendererText" and
"GtkTreeSelection" objects, just as VclBuilder
does.
For now, also don't implement logic for handling
"GtkTreeViewColumn" objects yet, but add a warning
that this is still missing.

Use QStandardItemModel for the tree view's
model.

For those methods where not all possible
parameters are handled yet, add asserts
that will trigger when called with currently
still unsupported ones, so this can easily
be identified when working on support for
dialogs using more complex tree views in the
future.

QtInstanceTreeView::get_height_rows logic
to return the required height to show n
entries also still needs some thought, so the
method simply warns and returns 0 for now, which
means that the tree view might not be shown with
the ideal initial height, but resizing the dialog
is sufficient to work around that for now if needed.

Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.

This is the first supported dialog making use of
weld::TreeView.

To trigger the dialog:

* start Calc
* add more sheets
* hide some of the sheets (e.g. by right-clicking them
  in the bar at the bottom, "Hide Sheet")
* select "Sheet" -> "Show Sheet" in the menubar

Change-Id: I4c4c0dca67dd6325f7145254f40452cc7000a783
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177542
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
To trigger the dialog:

* start Calc
* add more sheets
* hide some of the sheets (e.g. by right-clicking them
  in the bar at the bottom, "Hide Sheet")
* select "Sheet" -> "Show Sheet" in the menubar

Change-Id: Ie2f92c0b86ec47cf5bab85c9ea3c8096023a11de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177545
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move this helper function to the base class, for reuse
in QtBuilder in an upcoming commit.

Change-Id: Ide125c87bd4ebf63f70f94239a9bc42c3eab3c98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177546
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Take into account the "headers-visible" property
for "GtkTreeView" in .ui files.

With this in place, Calc's "Sheets" -> "Show Sheet"
dialog no longer shows an unexpected "1" title
above the list of hidden sheets.

Change-Id: I054cca7e2b379782cf3548cb822ecdba0f5553d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177547
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Evaluate the GtkTreeView:show-expanders property [1]
and set the QTreeView::rootIsDecorated propert accordingly [2]:

> This property holds whether to show controls for expanding and
> collapsing top-level items
>
> Items with children are typically shown with controls to expand and
> collapse them, allowing their children to be shown or hidden. If this
> property is false, these controls are not shown for top-level items.
> This can be used to make a single level tree structure appear like a
> simple list of items.

With this in place, there are no more expanders shown for
Calc's "Sheets" -> "Show Sheet" dialog for the native Qt
version, just like with the gtk3 or gen versions.

[1] https://docs.gtk.org/gtk3/property.TreeView.show-expanders.html
[2] https://doc.qt.io/qt-6/qtreeview.html#rootIsDecorated-prop

Change-Id: I11bcdd39695d230866abddf6d4b305dd6af52f59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177548
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This is the "Paste Special" dialog that shows
when pasting using Ctrl+Shift+V.

Change-Id: I7a3166251111a4fd568ad8c395e4d4053ae1f868
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177566
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Use QStandardItem::setData with a custom role
(ROLE_ID, with a value sufficiently larger than
Qt::UserRole to avoid any accidental overlap, as
e.g. QStandardItem::setData would use a default
role of Qt::UserRole + 1) to set the ID.

Implement QtInstanceTreeView::get_id
to get the ID for the entry with a given index.

Change-Id: If1c8cecac44fb3eb9ca2152abb05c3864240383a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177567
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Still untested.

Change-Id: I2124852eb00bc515264ae99798e4b05a37c7266b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177568
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Change-Id: I6a732606c6bf762033744824e857f861077b0237
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177569
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Declare support for the "Paste Special" dialog
that appears when copying something using Ctrl+Shift+V.

This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.

At least copying text from a browser gives the expected
result when copying as either HTML or plain text in a quick
test.

Change-Id: I967f5edd00b19e7ee70f1f7ef4d55240ae700e2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177570
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Change-Id: Ib95cc7d4c2b60d3b426b76573ff06917637d838e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177572
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
When the current (focus) item in the tree view changes,
call weld::TreeView::signal_changed to notify about this.

While QTreeView doesn't have a signal for that itself,
its QItemSelectionModel does, so connect to that one.

With this in place, SvPasteObjectDialog::SelectHdl
now gets called when switching between items in the
"Past Special" dialog when using the qt6 VCL plugin
with native Qt widgets, as is the case with the gtk3
VCL plugin.

Change-Id: I5aab68055f711480d56b043252d15621f18c4919
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177573
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
... and use it in misc places instead of calling
QTreeView::selectionModel repeatedly.

Change-Id: I9d9ee622bb98bf3267d858ee484128b364d14ad2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177574
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Change-Id: I3479b138a0986f1fbac7745e575e318bf63c1911
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177576
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
None of the weld::Box methods are used, so having a pointer
to the weld::Container subclass is sufficient in the
"Find and Replace" dialog implementation.

Change-Id: I1219dd657ab8fb6067c90aabdc27b2b84c0a1443
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177577
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
That was apparently forgotten in

    commit 0a4ec73c23
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Oct 25 10:04:10 2024 +0200

        tdf#130857 qt weld: Add a QtInstanceFrame

and none of the dialogs declared as supported this
far was actually calling any method making use
of it, as that would have triggered nullptr
dereference.
(Seen now while experimenting with adding support for
the "Search and Replace" dialog.)

Change-Id: I84ec83f4d4af8b2828e5033f366037b3114629d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177578
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Before

    commit 2e509b886f
    Date:   Sun Jun 12 17:42:05 2022 +0200

        Convert ImplWindowStateFromStr to WindowData(str)

, `rData` was a method param for ImplWindowStateFromStr.

Now, using it instead of just using `this` is
unnecessary.

Change-Id: I7974161990375e44d4d78097e49a9f42e118bcce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177579
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Add new `extractBoolEntry` helper that takes the
map, key and a default value to return if the
map doesn't contain the key.

Use that new helper to deduplicate the various
methods implementing the same logic over and over
again.

Change-Id: Id0cd9ca29ee0cbd638f90a32434b1ce6b4200e6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177584
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This is similar to

    Change-Id: Id0cd9ca29ee0cbd638f90a32434b1ce6b4200e6b
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Sat Nov 30 10:24:30 2024 +0100

        tdf#130857 VclBuilder: Deduplicate extract* methods returning bool

, but for methods extracting an OUString value instead
of a bool one.

Change-Id: Ic90ac0c630ee7454b8a7fa4f34383f8635d21ff3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177585
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Use an internal property for that, alowing to pass the option from the
import site to SdrOle2Obj::AddOwnLightClient. Maybe there is some more
proper way to do this, but I couldn't find it.

Change-Id: I74c881c5c35689a7b58d44d8d65c1010d202c98d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177586
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I10a21d1d62afa6118b665c031cb6d70b1bc006ba
Co-authored-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177497
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Fix bad condition with ++std::npos in the following !WithChildren
inline heading branch:

else if( pOutlNdsInline && ++nEndPosInline < pOutlNdsInline->size() )

The problem was reported by Caolán McNamara.

Remove also an unused variable in docnum.cxx.

Follow-up to commit 32398232e9
"tdf#164074 sw inline heading: add up/down outline moving".

Change-Id: I61d75451adeb13fe8e74ce586c4668a8caf0105b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177580
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Change-Id: I8a17b5a782aedd8784595c7febbacc24921bce1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169357
Tested-by: Jenkins
Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
Change-Id: Iaf4fdba3696669763511aa476e53a0fea36a05c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177589
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ic4b47f0dd0f5d24026a4ce001d52d1fd29a0c656
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177590
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
and

cid#1635784 Using invalid iterator
cid#1635785 Using invalid iterator

Change-Id: I88ca7325b45a556638dc7b7ee01e78cf0238a0de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177591
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
and

cid#1607135 COPY_INSTEAD_OF_MOVE

Change-Id: If8f36744c53bb0515516a23589ffdb389aaec02c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177592
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
and

cid#1606986 COPY_INSTEAD_OF_MOVE
cid#1557969 COPY_INSTEAD_OF_MOVE
cid#1557837 COPY_INSTEAD_OF_MOVE
cid#1557772 COPY_INSTEAD_OF_MOVE
cid#1557735 COPY_INSTEAD_OF_MOVE
cid#1557672 COPY_INSTEAD_OF_MOVE
cid#1557664 COPY_INSTEAD_OF_MOVE
cid#1557650 COPY_INSTEAD_OF_MOVE
cid#1557642 COPY_INSTEAD_OF_MOVE
cid#1557639 COPY_INSTEAD_OF_MOVE
cid#1557628 COPY_INSTEAD_OF_MOVE
cid#1557623 COPY_INSTEAD_OF_MOVE
cid#1557581 COPY_INSTEAD_OF_MOVE
cid#1557489 COPY_INSTEAD_OF_MOVE
cid#1557473 COPY_INSTEAD_OF_MOVE
cid#1557317 COPY_INSTEAD_OF_MOVE
cid#1557261 COPY_INSTEAD_OF_MOVE
cid#1557146 COPY_INSTEAD_OF_MOVE
cid#1557135 COPY_INSTEAD_OF_MOVE
cid#1557134 COPY_INSTEAD_OF_MOVE
cid#1557079 COPY_INSTEAD_OF_MOVE
cid#1557063 COPY_INSTEAD_OF_MOVE
cid#1557052 COPY_INSTEAD_OF_MOVE
cid#1556982 COPY_INSTEAD_OF_MOVE
cid#1556977 COPY_INSTEAD_OF_MOVE
cid#1556950 COPY_INSTEAD_OF_MOVE
cid#1556943 COPY_INSTEAD_OF_MOVE
cid#1556804 COPY_INSTEAD_OF_MOVE
cid#1556736 COPY_INSTEAD_OF_MOVE
cid#1556658 COPY_INSTEAD_OF_MOVE
cid#1556621 COPY_INSTEAD_OF_MOVE
cid#1556590 COPY_INSTEAD_OF_MOVE
cid#1556579 COPY_INSTEAD_OF_MOVE
cid#1556534 COPY_INSTEAD_OF_MOVE
cid#1556524 COPY_INSTEAD_OF_MOVE
cid#1556478 COPY_INSTEAD_OF_MOVE
cid#1556467 COPY_INSTEAD_OF_MOVE
cid#1556422 COPY_INSTEAD_OF_MOVE
cid#1556314 COPY_INSTEAD_OF_MOVE
cid#1556309 COPY_INSTEAD_OF_MOVE
cid#1556258 COPY_INSTEAD_OF_MOVE
cid#1556143 COPY_INSTEAD_OF_MOVE
cid#1556119 COPY_INSTEAD_OF_MOVE
cid#1556101 COPY_INSTEAD_OF_MOVE
cid#1556097 COPY_INSTEAD_OF_MOVE
cid#1556039 COPY_INSTEAD_OF_MOVE
cid#1555966 COPY_INSTEAD_OF_MOVE
cid#1555948 COPY_INSTEAD_OF_MOVE
cid#1555915 COPY_INSTEAD_OF_MOVE
cid#1555836 COPY_INSTEAD_OF_MOVE
cid#1555748 COPY_INSTEAD_OF_MOVE
cid#1555644 COPY_INSTEAD_OF_MOVE
cid#1555582 COPY_INSTEAD_OF_MOVE
cid#1555478 COPY_INSTEAD_OF_MOVE
cid#1555475 COPY_INSTEAD_OF_MOVE
cid#1555409 COPY_INSTEAD_OF_MOVE
cid#1555372 COPY_INSTEAD_OF_MOVE
cid#1555334 COPY_INSTEAD_OF_MOVE
cid#1555330 COPY_INSTEAD_OF_MOVE
cid#1555310 COPY_INSTEAD_OF_MOVE
cid#1555257 COPY_INSTEAD_OF_MOVE
cid#1555247 COPY_INSTEAD_OF_MOVE
cid#1555147 COPY_INSTEAD_OF_MOVE
cid#1555120 COPY_INSTEAD_OF_MOVE
cid#1555059 COPY_INSTEAD_OF_MOVE
cid#1555016 COPY_INSTEAD_OF_MOVE
cid#1554880 COPY_INSTEAD_OF_MOVE
cid#1554824 COPY_INSTEAD_OF_MOVE
cid#1554808 COPY_INSTEAD_OF_MOVE
cid#1546189 COPY_INSTEAD_OF_MOVE

Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Declare support for the "Split Cells" dialog that
can e.g. be triggered using the "Table" -> "Split Cells"
menu entry in Writer while the cursor is inside of a
table cell.

This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.

Change-Id: I5b994698ea46e9ede763169d21fe53527b3b369b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177597
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Declare support for the "Split Table" dialog that
can be triggered using the "Table" -> "Split Table"
menu entry in Writer while the cursor is inside of a
table cell.

This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.

Change-Id: Iae4855027de533ff7f9a4148f8101a56c281abcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177598
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Declare support for the "Insert Breaks" dialog that
can be triggered using the "Insert" -> "More Breaks" ->
"Manual Break" menu entry in Writer.

This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.

Change-Id: I338b017d082532a831168f1c6d0e3e5147e04a39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177599
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
The extra complexity was introduced for #i94994# in commit
3266965986 (CWS-TOOLING: integrate CWS
ab61, 2009-02-11).

Change-Id: If5a69984e3c2c963d4eea2824373fbf1e8a47fef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177603
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Having a map, two vectors, and a counter for what is a job for a single
map is a bit too much.

Change-Id: I50d29f03a2463e6f63ed8e645c36b4c77aa1413a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177604
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
DocBookTemplate.ott
Simply copy makefile of extra/templates
fix bug tdf#161930: mimetype is zipped only once

Modifications to DocBookTemplate.stw:
- change fonts to bundled fonts: Liberation Serif, Noto Sans CJK, Noto Sans Devanagari
(not so useful as used fonts are defined in
docbooktosoffheadings.xsl and sofftodocbookheadings.xsl)
- remove language and country tags
- remove page size
- remove writing mode tags
- remove content.xml
- remove meta.xml
- simplify settings.xml
- remove unused namespaces

Change-Id: Ic2a2284c3d890b8a6b7b4e29bdab18c33d40dcee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174847
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
it's there to speed up later read of it, but in normal situations we
shouldn't use it anymore IIUC

Change-Id: Ia075e32cd4820729b341d4d47dbfb9126a363559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177601
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ib9260ec6ba148f0de248753148309a6c578e796d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177600
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Change-Id: I922b150f2c1682ec48331319bbf6222482c6cd3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177595
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Change-Id: Ia48a24d1696aaf2ee7e49f5e8c9f9dcc0ae9e8e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177606
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
For some reason, SfxLibrary's own interfaces were used outside of
WeakComponentImplHelper; and derived classes didn't use inheritance
helper.

Change-Id: Ib0b6cf5cfa559fe5eedc4d05247655aca1bfc4b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177607
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: I63ba583ef990dd2bbfb7f44af613fce1d8d1b411
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177608
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Update translations from branch 'master'
  to 685db476dad288f6635917ae0ca05d5369c64c15
  - update translations for master / 25.2
    
    and force-fix errors using pocheck
    
    Change-Id: Iad27f4c2f514466569dcb982849dee099b6c77d7
and

cid#1556101 COPY_INSTEAD_OF_MOVE
cid#1555475 COPY_INSTEAD_OF_MOVE
cid#1555310 COPY_INSTEAD_OF_MOVE

Change-Id: Ibabd8fd59a5435b8ab6c33d78c1303e5e1bdfd9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177609
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
and

cid#1557189 Data race condition

Change-Id: I6ee6dd60d7b0eccca3042ad5ff7846f77f16feec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177610
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
its an out only param, not in-out

Change-Id: I4e969bf06bed41a7e04497880f8ea51a3f784feb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177612
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ia8a5eef35c7a4ccdc9d7747fbb408f670777a49b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177613
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Change-Id: Iea1bd3bb7df6466aeee480d8e44659b71bef580e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177614
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
with:

commit 8a2149c105
CommitDate: Fri May 20 07:55:30 2016 +0000

    clang-tidy misc-assign-operator-signature

Change-Id: I9ffbfd4cfa5742b4fa62b616591c19ebe3fc1f0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177615
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Change-Id: I5bd1e8c4974616289b563bfd4893bf9616c04a59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177618
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I1aaa2ca5711b932676621ee37b00fd0683593214
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177619
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
the intl data for firebird has been added with
07cc2fdc3d (and the associated config file
later moved to Resources with dfa78d2eac)

Change-Id: I4fe666076c42bae21b371fe0ea9495ebc915bd21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177617
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
mergelibs have been added to the LibreOfficeMacOSX distro config in
e6e22bee15, but AppleRemote has been
disabled in the sandboxing case since 2013
4fe9ef81aa "The AppleRemote code is
blocked by sandboxing so bypass it in that case"
(unclear to me whether fundamentally not working or whether it was
disabled to get sandboxing as a whole in a working state quickly, since
there was an earlier entitlement for mac.remotecontrols)

Change-Id: I8514319b1d9ffa3a993267eaebac0c2ff058740f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177621
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Change-Id: I56f07a62ed3d2388eede16a85e673027cfed8158
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177616
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(make from 5 existing only one)

Much of what makes up this patch is adapted from existing code that is
used to organize and select macros and to assign macros to shortcut
keys. Comments in the patch say where code is borrowed from.

Known issues:

+ Scripting framework library rename for BeanShell, Java, and JavaScript
always returns fail when there are no macro entries in the library even
though it actually succeeds. The same thing happens using
SvxScriptOrgDialog::renameEntry.

+ Deleting Basic macros from the Macro Manager dialog is not implemented
yet.

Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Controls/shapes and images/objects have a display option in tools/options/
Writer/View and in print dialog there is "Form controls" and
"Images and other graphic objects". With this change the options
will actually be applied again.

Change-Id: I52389a8519d863792a7cd126a95a389c90c05a5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171905
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Don't suppress a11y events when setting the new
position string in the combobox in Calc's formula
toolbar.

Suppressing events was added in

    commit 38fe580341
    Author: Malte Timmermann [mt] <malte.timmermann@oracle.com>
    Date:   Thu Jan 20 16:34:26 2011 +0100

        accfixes: added more accessibility information and fixed tab orders in multiple dialogs (sc module)

for unclear reasons.

The only potential reason I can come up with could be
to avoid announcement by screen readers, but they
usually don't announce text/value changes to non-focused
controls anyway, and neither Orca on Linux nor NVDA
on Windows announcement changed with this change in place
when moving focus between cells in Calc.

Without this change in place, having the combobox's
"text" child selected in Accerciser's treeview
of LO's a11y hierarchy, the text shown in the "Text"
interface section would not automatically update to display
the newly selected location due to the missing
event when using the qt6 VCL plugin. With this change in
place, it is updated as expected.

Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177638
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Unused now after

    Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon Dec 2 03:28:50 2024 +0100

        sc a11y: Don't suppress a11y events when setting new pos

Change-Id: I4359c903d1d1902671de87121161e0ca74b88251
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177639
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
All callers use the default of `true` for the
`bTraverseParentPath` param since

    Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon Dec 2 03:28:50 2024 +0100

        sc a11y: Don't suppress a11y events when setting new pos

, so simplify this by dropping the param altogether.

Change-Id: If47333f096d31afc3fb2c57dcc03d8e342ae4aa5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177640
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Change-Id: I8ef1df248d3ed9fbc804e53897ca934cce9683e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176779
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This is a follow up for:
* https://gerrit.libreoffice.org/c/core/+/164570/2

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If748aac779767174d14dde33efab62d980b115ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172114
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176287
Tested-by: Jenkins
Change-Id: I5ddda383f41095a96597d57ab635dbab500aabc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177220
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Change-Id: I08c84cd3fdc1a1606bbfedbbf5a4987f923cefa8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177467
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Change-Id: Idd8907bd5e10d374f32f7ec9ba7ecf39c9031b0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177454
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Change-Id: I3d8b65f0ef386eed2ada12664aa33d2efd53fb65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177641
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Change-Id: If8222286f36cda3071d63a14896d8d89c5802437
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177650
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Change-Id: Ibcd898e25c8807dba36226d0ec7126588ba38837
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177631
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
seems to already exist in oldest version I have

Change-Id: I3f3652952476678c121cbe3f800b7adf7f7aa1a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177626
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Similar to commit d248d8f527
(CppunitTest_sw_tiledrendering2: try to make this more stable,
2024-11-20), but note that the problematic assert at e.g.
<https://ci.libreoffice.org/job/gerrit_linux_gcc_release/178813/console>
is before the early return, so move the early assert below the early
return.

Change-Id: I0ed9168840defcc567e2e2fa8262bdf32489b54a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177652
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
A data array is a 1D array of 1D subarrays.
All arrays are presumed zero-based.
Usages:
- the content of a range of Calc cells returned
  by the UNO XCellRange.getDataArray() or
  XCellRange.getFormulaArray() methods
- the output of SF_Session.ExecuteCalcFunction()
- a tuple of (sub)tuples returned by a Python script

3 methods are added to the Array service:

1) ConvertFromDataArray(DataArray, [IsRange], [FillValue])
  Convert a data array to a scalar, a vector or a 2D array.
  On request, the individual items are reduced
  to strings or doubles only.

2) ConvertToDataArray(Data, [IsRange], [Rows], [Columns)
  Create a data array from a scalar, a 1D array or a 2D array.
  The returned data array is zero-based and compatible
  with the XCellRange.DataArray property when IsRange = True.

3) ConvertToRange(Data, [Direction])
  Create a valid cells range content from a scalar,
  a 1D array, a 2D array or a data array.
  The individual items are always reduced to strings
  or doubles. Including booleans or dates.
  The returned scalar or array is a valid argument
  of the SF_Session.ExecuteCalcFunction() method.

They replace the internal _ConvertFromDataArray()
and _ConvertToDataArray() that were present in
the Calc service, called by SetValue(),
SetFormula() etc. methods.

This change is Basic only and has no effect in Python.

The documentation about the Array service
should be completed with these new 3 methods.

Change-Id: Idc5b6417648e4574b0f9c7c6e2438ff7dfce1829
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177620
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
See tdf#94879 for motivation.

Change-Id: If10c0d7a40536f27fb18f7624c91092471d45996
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177651
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
After
commit 2145204724
Author: Andreas Heinisch <andreas.heinisch@yahoo.de>
Date:   Mon Nov 25 09:17:45 2024 +0100

    tdf#163325 - Check Lower() frame during ToC preview

Change-Id: Ie34e4d433e747ad68264f618047b49b4a826eaa7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177667
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
this is temporary fix for caching the old values in
the text fields like page number. to be removed, we
need separate layers with awareness of fields

Change-Id: I74d8186441912ad110bff4bc6f46faff79a20cd8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177664
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
actualizacion automatica 2024-12-02
Some checks failed
Repo Lockdown / point-to-upstream (pull_request_target) Has been cancelled
Details
6a8868a2cc
iapz merged commit 1b7308303f into master 2024-12-02 13:56:07 -06:00
iapz deleted branch actualizacion-master-2024-12-02 2024-12-02 13:56:08 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: strepsirrhini/office-gobmx#3
No description provided.
Delete branch "actualizacion-master-2024-12-02"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?