062b4bee5e
This fixes WHEN the helpful pop-up notifies about the cursor
being over top of a smart-tag, and suggesting that the user
can CTRL-clicking to activate the smart tag.
Prior to this patch, it would start half-a-character too soon,
and end half-a-character too early.
It similarly fixes WHEN the helpful cursor pointer changes into a finger
when holding ctrl and moving into the start or end of the smarttag.
Smart tags REQUIRE a plugin, so a unit test is out of the question.
The impact could be MUCH LARGER than just smart tags,
but they were the impetus for the change,
because smart tags are not portions while the other
things (redlines, fields, refs/footnotes, formulas) are.
The net effect on other IsAttrAtPos SHOULD be nothing,
so that still doesn't leave me with anything unit testable.
If I ONLY removed the --index from itrcrsr,
then unit tests in uiwriter9 fail.
Adding aTmpState.m_bPosMatchesBounds = true
(which is the fix for smart tags) makes it not fail.
Adding bPosMatchesBounds OUGHT to obsolete an initial-import --index hack?
While I don't NEED to remove the (what looks to me) hack
(and it actually is super dangerous to remove it)
I really think it is obsolete and thus deserves removal.
Easy to restore if it proves a regression...
So bFieldInfo and bPosMatchesBounds end up doing much of the same thing.
This is one of only two places which sets m_bFieldInfo = true,
the other being a EnhancedPDFExportHelper.cxx which tests pEnd inclusively.
cms.m_bFieldInfo = true;
auto const [pStart, pEnd] = rShell.GetCursor_()->StartEnd();
if (rShell.GetLayout()->GetModelPositionForViewPoint(&pos, center, &cms)
&& *pStart <= pos && pos <= *pEnd)
make CppunitTest_vcl_pdfexport CPPUNIT_TEST_NAME=testTdf157816
is not a good test for this - it passes without --index and !FieldInfo
Change-Id: I77df5e054879eb3bbc82907962b77386811bceac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161034
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Justin Luth <jluth@mail.com>
|
||
|---|---|---|
| .git-hooks | ||
| .github | ||
| .vscode | ||
| accessibility | ||
| android | ||
| animations | ||
| apple_remote | ||
| avmedia | ||
| basctl | ||
| basegfx | ||
| basic | ||
| bean | ||
| bin | ||
| binaryurp | ||
| bridges | ||
| canvas | ||
| chart2 | ||
| cli_ure | ||
| codemaker | ||
| comphelper | ||
| compilerplugins | ||
| config_host | ||
| configmgr | ||
| connectivity | ||
| cppcanvas | ||
| cppu | ||
| cppuhelper | ||
| cpputools | ||
| cui | ||
| dbaccess | ||
| desktop | ||
| dictionaries@ef5ed1ca0e | ||
| distro-configs | ||
| docmodel | ||
| drawinglayer | ||
| editeng | ||
| embeddedobj | ||
| embedserv | ||
| emfio | ||
| eventattacher | ||
| extensions | ||
| external | ||
| extras | ||
| filter | ||
| forms | ||
| formula | ||
| fpicker | ||
| framework | ||
| helpcompiler | ||
| helpcontent2@27088ec11f | ||
| hwpfilter | ||
| i18nlangtag | ||
| i18npool | ||
| i18nutil | ||
| icon-themes | ||
| idl | ||
| idlc/test/parser | ||
| include | ||
| instsetoo_native | ||
| io | ||
| ios | ||
| javaunohelper | ||
| jurt | ||
| jvmaccess | ||
| jvmfwk | ||
| l10ntools | ||
| librelogo | ||
| libreofficekit | ||
| lingucomponent | ||
| linguistic | ||
| lotuswordpro | ||
| m4 | ||
| msicreator | ||
| nlpsolver | ||
| o3tl | ||
| odk | ||
| offapi | ||
| officecfg | ||
| oovbaapi | ||
| oox | ||
| opencl | ||
| osx | ||
| package | ||
| pch | ||
| postprocess | ||
| pyuno | ||
| qadevOOo | ||
| readlicense_oo | ||
| registry | ||
| remotebridges | ||
| reportbuilder | ||
| reportdesign | ||
| ridljar | ||
| sal | ||
| salhelper | ||
| sax | ||
| sc | ||
| scaddins | ||
| sccomp | ||
| schema | ||
| scp2 | ||
| scripting | ||
| sd | ||
| sdext | ||
| setup_native | ||
| sfx2 | ||
| shell | ||
| slideshow | ||
| smoketest | ||
| solenv | ||
| soltools | ||
| sot | ||
| starmath | ||
| static | ||
| stoc | ||
| store | ||
| svgio | ||
| svl | ||
| svtools | ||
| svx | ||
| sw | ||
| swext | ||
| sysui | ||
| test | ||
| testtools | ||
| toolkit | ||
| tools | ||
| translations@2a46004be9 | ||
| ucb | ||
| ucbhelper | ||
| udkapi | ||
| uitest | ||
| UnoControls | ||
| unodevtools | ||
| unoidl | ||
| unoil | ||
| unotest | ||
| unotools | ||
| unoxml | ||
| ure | ||
| uui | ||
| vbahelper | ||
| vcl | ||
| winaccessibility | ||
| wizards | ||
| writerfilter | ||
| writerperfect | ||
| xmerge | ||
| xmlhelp | ||
| xmloff | ||
| xmlreader | ||
| xmlscript | ||
| xmlsecurity | ||
| .buckconfig | ||
| .buckversion | ||
| .clang-format | ||
| .editorconfig | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .gitpod.dockerfile | ||
| .gitpod.yml | ||
| .gitreview | ||
| antivirusDetection.vbs | ||
| autogen.sh | ||
| BUCK | ||
| config.guess | ||
| config.sub | ||
| config_host.mk.in | ||
| config_host_lang.mk.in | ||
| configure.ac | ||
| COPYING | ||
| COPYING.LGPL | ||
| COPYING.MPL | ||
| cpp.hint | ||
| download.lst | ||
| g | ||
| install-sh | ||
| install_deps.sh | ||
| leak-suppress.txt | ||
| Library_merged.mk | ||
| logerrit | ||
| Makefile.fetch | ||
| Makefile.gbuild | ||
| Makefile.in | ||
| README.cross | ||
| README.help.md | ||
| README.md | ||
| README.Solaris | ||
| Repository.mk | ||
| RepositoryExternal.mk | ||
| RepositoryFixes.mk | ||
| RepositoryModule_build.mk | ||
| RepositoryModule_host.mk | ||
| sanitize-ubsan-excludelist | ||
| setup.cfg | ||
| TEMPLATE.SOURCECODE.HEADER | ||
| tsan-suppress.txt | ||
LibreOffice
LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.
A quick overview of the LibreOffice code structure.
Overview
You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.
The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.
The Build Chain and Runtime Baselines
These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:
- Windows:
- Runtime: Windows 7
- Build: Cygwin + Visual Studio 2019 version 16.10
- macOS:
- Runtime: 10.15
- Build: 12 (13 for aarch64) + Xcode 14
- Linux:
- Runtime: RHEL 8 or CentOS 8 and comparable
- Build: either GCC 12; or Clang 12 with libstdc++ 8.5
- iOS (only for LibreOfficeKit):
- Runtime: 11.4 (only support for newer i devices == 64 bit)
- Build: Xcode 9.3 and iPhone SDK 11.4
- Android:
- Build: NDK r23 and SDK 30.0.3
- Emscripten / WASM:
- Runtime: a browser with SharedMemory support (threads + atomics)
- Build: Qt 5.15 with Qt supported Emscripten 1.39.8
- See README.wasm
Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.
The baseline for Java is Java Development Kit (JDK) Version 17 or later.
If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.
You can find the TDF configure switches in the distro-configs/ directory.
To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.
For more information see the build instructions for your platform in the TDF wiki.
The Important Bits of Code
Each module should have a README.md file inside it which has some
degree of documentation for that module; patches are most welcome to
improve those. We have those turned into a web page here:
However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:
| Module | Description |
|---|---|
| sal/ | this provides a simple System Abstraction Layer |
| tools/ | this provides basic internal types: Rectangle, Color etc. |
| vcl/ | this is the widget toolkit library and one rendering abstraction |
| framework/ | UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files |
| sfx2/ | legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc. |
| svx/ | drawing model related helper code, including much of Draw/Impress |
Then applications
| Module | Description |
|---|---|
| desktop/ | this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop |
| sw/ | Writer |
| sc/ | Calc |
| sd/ | Draw / Impress |
There are several other libraries that are helpful from a graphical perspective:
| Module | Description |
|---|---|
| basegfx/ | algorithms and data-types for graphics as used in the canvas |
| canvas/ | new (UNO) canvas rendering model with various backends |
| cppcanvas/ | C++ helper classes for using the UNO canvas |
| drawinglayer/ | View code to render drawable objects and break them down into primitives we can render more easily. |
Rules for #include Directives (C/C++)
Use the "..." form if and only if the included file is found next to the
including file. Otherwise, use the <...> form. (For further details, see the
mail Re: C[++]: Normalizing include syntax ("" vs
<>).)
The UNO API include files should consistently use double quotes, for the benefit of external users of this API.
loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.
Finding Out More
Beyond this, you can read the README.md files, send us patches, ask
on the mailing list libreoffice@lists.freedesktop.org (no subscription
required) or poke people on IRC #libreoffice-dev on irc.libera.chat -
we're a friendly and generally helpful mob. We know the code can be
hard to get into at first, and so there are no silly questions.