Test repository to check push and ssh key
Find a file
Mike Kaganski 0d82ddb39e tdf#160898: check for nullptr
Regression after commit d81379db73
(tdf#154877 sw: generalise ExtendedSelectAll(), 2023-05-09)

Change-Id: I9289171647fca8bd1b696399ff7c43a2ac7b8b30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166990
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-05-02 08:56:47 +02:00
.git-hooks
.github
.vscode
accessibility loplugin:ostr in accessibility 2024-04-30 19:35:48 +02:00
android
animations
apple_remote
avmedia
basctl WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 15:29:44 +02:00
basegfx cid#1596705 Unused value 2024-05-02 00:13:41 +02:00
basic use more OUString literal in getBasicTypeName 2024-05-02 08:18:59 +02:00
bean
bin reduce symbol visibility 2024-04-29 12:54:43 +02:00
binaryurp
bridges WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 22:04:11 +02:00
canvas WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 22:04:11 +02:00
chart2 Extended loplugin:ostr manual changes 2024-04-28 11:29:52 +02:00
cli_ure WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 09:17:34 +02:00
codemaker WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 14:48:15 +02:00
comphelper elide some OUString creation in GetContentPart 2024-05-02 08:17:47 +02:00
compilerplugins Drop unused instance variable. 2024-05-02 08:41:17 +02:00
config_host
configmgr
connectivity WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 10:50:11 +02:00
cppcanvas
cppu elide some OUString temporaries 2024-05-02 02:51:23 +02:00
cppuhelper elide some OUString temporaries 2024-05-02 02:51:23 +02:00
cpputools Drop uses of css::uno::Sequence::getConstArray in cppuhelper .. cui 2024-04-29 23:15:40 +02:00
cui Resolves tdf#141778 - Size issues on view options UI 2024-05-01 09:26:29 +02:00
dbaccess Drop uses of css::uno::Sequence::getConstArray in dbaccess 2024-04-29 23:15:48 +02:00
desktop next is never passed a null pointer, use a reference 2024-05-01 17:11:10 +02:00
dictionaries@8c5b63124f
distro-configs
docmodel
drawinglayer Prepare to run (select) tests during Emscripten build 2024-05-02 07:52:03 +02:00
editeng WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 13:25:04 +02:00
embeddedobj
embedserv
emfio ofz#68234 emf XForm isnan members 2024-04-23 13:20:54 +02:00
eventattacher
extensions WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 22:04:11 +02:00
external WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 13:24:20 +02:00
extras run zip via wsl in wsl-as-helper case 2024-04-26 14:01:43 +02:00
filter elide some OUString temporaries 2024-05-02 02:51:23 +02:00
forms
formula tdf#126573 Add Excel2021 array function SEQUENCE to Calc 2024-04-26 09:33:23 +02:00
fpicker WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 15:29:44 +02:00
framework
helpcompiler WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 09:17:34 +02:00
helpcontent2@0d4e0c0452 Update git submodules 2024-04-29 20:51:44 +02:00
hwpfilter
i18nlangtag
i18npool WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 10:50:11 +02:00
i18nutil
icon-themes
idl use more OUString in sfx slots 2024-05-01 19:29:37 +02:00
idlc/test/parser
include use more OUString compile time literals in xmloff 2024-05-02 08:20:23 +02:00
instsetoo_native use strawberry perl for installation packaging in wsl-as-helper case 2024-04-26 14:02:37 +02:00
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit
lingucomponent
linguistic
lotuswordpro tdf#145614 Convert #define to enum 2024-04-30 08:39:15 +02:00
m4
msicreator
nlpsolver Double values comparison changed to compare method. 2024-04-29 15:40:27 +02:00
o3tl
odk tdf#143122 Port Java TerminationTest example to C++ 2024-04-30 15:01:19 +02:00
offapi Embind: Fix out-param handling 2024-04-30 07:53:11 +02:00
officecfg Related tdf#87676 Enable text formatting toolbar when in a text box 2024-04-25 18:23:40 +02:00
oovbaapi
oox tdf#148616 Speed up finding custom shape guide value 2024-05-02 06:32:02 +02:00
opencl
osx
package loplugin:ostr in package 2024-04-30 10:40:22 +02:00
pch
postprocess fix mismatching gb_Trace_StartRange and gb_Trace_EndRage 2024-04-25 21:49:11 +02:00
pyuno
qadevOOo
readlicense_oo update credits 2024-04-29 20:38:43 +02:00
registry WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 22:04:11 +02:00
remotebridges
reportbuilder
reportdesign
ridljar
sal we dereference pProfile->m_Lines on the next line anyway 2024-04-30 13:41:19 +02:00
salhelper
sax Extended loplugin:ostr manual changes 2024-04-28 11:29:52 +02:00
sc Save with newer Glade version 2024-05-02 08:30:53 +02:00
scaddins
sccomp
schema
scp2 MSI: Fix use of illegal character in table Binary 2024-04-26 13:11:34 +02:00
scripting WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 10:50:11 +02:00
sd Save with newer Glade version 2024-05-02 08:30:38 +02:00
sdext run gperf via wsl in wsl-as-helper case 2024-04-26 14:01:51 +02:00
setup_native WaE: C6011 Dereferencing NULL pointer warnings from unchecked malloc 2024-04-30 11:08:26 +02:00
sfx2 use more OUString in sfx slots 2024-05-01 19:29:37 +02:00
shell
slideshow cid#1596694 COPY_INSTEAD_OF_MOVE 2024-04-30 12:17:03 +02:00
smoketest
solenv Prepare to run (select) tests during Emscripten build 2024-05-02 07:52:03 +02:00
soltools
sot WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 09:17:27 +02:00
starmath
static Embind: Fix out-param handling 2024-04-30 07:53:11 +02:00
stoc WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 22:04:11 +02:00
store WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 13:39:32 +02:00
svgio CppunitTest_svgio: fix mid-air collision 2024-04-25 09:21:03 +02:00
svl WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 09:17:27 +02:00
svtools tdf#160867: restore HTML map export for text hyperlinks in frames 2024-04-30 19:11:32 +02:00
svx use more OUString in XPropertyList 2024-05-02 08:20:46 +02:00
sw tdf#160898: check for nullptr 2024-05-02 08:56:47 +02:00
swext
sysui Add missing file types to desktop files and alphabetize the lists 2024-04-29 08:13:36 +02:00
test [API CHANGE] a11y: Use XAccessible for relation targets 2024-04-24 23:04:35 +02:00
testtools Drop some uses of css::uno::Sequence::getConstArray ... 2024-04-30 06:20:50 +02:00
toolkit simplify and reduce OUString allocation in UnoControl 2024-05-01 19:29:19 +02:00
tools cid#1596706 Dereference after null check 2024-05-02 00:13:32 +02:00
translations@b824b552da Update git submodules 2024-05-01 11:57:12 +02:00
ucb WaE: C6011 Dereferencing NULL pointer warnings 2024-05-01 10:50:11 +02:00
ucbhelper
udkapi
uitest
UnoControls
unodevtools
unoidl WaE: C6011 Dereferencing NULL pointer warnings 2024-04-30 13:39:50 +02:00
unoil
unotest Embind: Fix out-param handling 2024-04-30 07:53:11 +02:00
unotools use more OUString in StarSymbolToMSMultiFontImpl 2024-05-02 08:19:24 +02:00
unoxml
ure
uui
vbahelper Extended loplugin:ostr manual changes 2024-04-28 11:29:52 +02:00
vcl jsdialog: fix updating on container "reorder_child" or "move" 2024-05-02 07:47:49 +02:00
winaccessibility [API CHANGE] a11y: Use XAccessible for relation targets 2024-04-24 23:04:35 +02:00
wizards
writerperfect Prepare to run (select) tests during Emscripten build 2024-05-02 07:52:03 +02:00
xmerge
xmlhelp
xmloff use more OUString compile time literals in xmloff 2024-05-02 08:20:23 +02:00
xmlreader
xmlscript
xmlsecurity Drop unused instance variable. 2024-05-02 08:41:17 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in fix some hardcoded use of wsl.exe and fix some typos 2024-04-27 10:16:39 +02:00
config_host_lang.mk.in
configure.ac fix some hardcoded use of wsl.exe and fix some typos 2024-04-27 10:16:39 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint Add some entries into cpp.hint 2024-04-24 09:43:42 +02:00
download.lst libgpg-error: Upgrade to 1.49 2024-04-26 12:47:24 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch Fail early when external tarball can't be fetched 2024-04-26 10:46:04 +02:00
Makefile.gbuild
Makefile.in add --with-keep-awake switch to prevent going into sleep/suspend 2024-04-26 23:10:22 +02:00
README.cross
README.help.md
README.md fix broken link to OSI image in README.md 2024-04-22 23:26:08 +02:00
README.Solaris
Repository.mk tdf#97448 Add helper script to generate Addons.xcu 2024-04-25 10:58:49 +02:00
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.