Test repository to check push and ssh key
Find a file
Stephan Bergmann 728ff63903 Bad hack to silence UBSan nullptr-with-offset
...since e912a44621 "tiff: use more complicated
apis to need a smaller buffer during read" in CppunitTest_vcl_filters_test,

> [_RUN_____] TiffFilterTest::testCVEs
[...]
> tif_getimage.c:998:21: runtime error: applying zero offset to null pointer
>     #0 0x7f487da9d408 in gtStripContig /workdir/UnpackedTarball/libtiff/libtiff/tif_getimage.c:998:21
>     #1 0x7f487da97c27 in TIFFRGBAImageGet /workdir/UnpackedTarball/libtiff/libtiff/tif_getimage.c:512:12
>     #2 0x7f487bd1a56c in ImportTiffGraphicImport(SvStream&, Graphic&) /vcl/source/filter/itiff/itiff.cxx:219:19
>     #3 0x7f485d820126 in TiffFilterTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) /vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx:70:12
>     #4 0x7f485a49ffa0 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /unotest/source/cpp/filters-test.cxx:132:20
>     #5 0x7f485a4a3a52 in test::FiltersTest::testDir(rtl::OUString const&, std::basic_string_view<char16_t, std::char_traits<char16_t> >, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /unotest/source/cpp/filters-test.cxx:157:5
>     #6 0x7f485d8206f9 in TiffFilterTest::testCVEs() /vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx:76:5

(<https://ci.libreoffice.org/job/lo_ubsan/2406/>).

(If UBSan or some other tool starts to flag this too, we'll probably need to
pass in a nullptr after all and teach libtiff to treat that case specially and
not advance it.)

Change-Id: I4477e6c7036c3c5f2782c2c90c612d98fee60468
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134822
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-23 18:17:10 +02:00
.git-hooks
.github
.vscode
accessibility new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
android android: Drop 'android.enableJetifier=true' 2022-05-21 09:18:38 +02:00
animations
apple_remote
avmedia tdf#148923 PPTX import: fix incorrect image in media file 2022-05-19 10:26:01 +02:00
basctl resave with latest glade 2022-05-18 09:45:55 +02:00
basegfx basegfx: add test for 2D vector classes B2DVector, B2IVector 2022-05-20 15:53:26 +02:00
basic Extend loplugin:redundantcast to trivial reinterpret_cast from T to itself 2022-05-18 10:52:59 +02:00
bean
bin build libtiff 2022-05-20 22:29:00 +02:00
binaryurp cid#1504543 Silence unhelpful, aggressive UNINIT_CTOR 2022-05-23 10:55:45 +02:00
bridges clang-tidy modernize-pass-by-value in bridges 2022-05-21 17:29:53 +02:00
canvas clang-tidy modernize-pass-by-value in canvas 2022-05-21 21:55:31 +02:00
chart2 instantiate Title directly in chart 2022-05-23 11:58:54 +02:00
cli_ure
codemaker clang-tidy modernize-pass-by-value in codemaker 2022-05-18 14:08:28 +02:00
comphelper comphelper: -Werror=class-memaccess 2022-05-23 09:42:24 +02:00
compilerplugins new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
config_host
configmgr clang-tidy modernize-pass-by-value in configmgr 2022-05-23 10:52:11 +02:00
connectivity add SvStream::ReadLine(OStringBuffer... to reduce OString allocation 2022-05-13 11:11:27 +02:00
cppcanvas
cppu Extend '-Werror=attributes' workaround to GCC versions < 12.1 2022-05-23 08:46:50 +02:00
cppuhelper
cpputools
cui sd theme: add UI (area dialog) for shape fill color effects 2022-05-19 09:11:27 +02:00
dbaccess no need to take a lock when returning static data 2022-05-18 20:14:32 +02:00
desktop sw content controls, picture: add LOK API 2022-05-23 18:04:09 +02:00
dictionaries@3cfa1a0899 Update git submodules 2022-05-17 15:21:18 +02:00
distro-configs Adapt flatpak build to recently introduced dependencies 2022-05-18 09:10:59 +02:00
drawinglayer EMF+ Simplify and optimize the code 2022-05-16 17:27:24 +02:00
editeng new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
embeddedobj tdf#121740 cache hashcode in SequenceAsHashMap 2022-05-14 19:14:19 +02:00
embedserv
emfio tdf#143876 EMF+ Add DrawClosedCurve and FillClosedCurve support 2022-05-16 17:26:20 +02:00
eventattacher
extensions
external README libtiff 2022-05-23 18:16:43 +02:00
extras
filter reserve vector in FilterCache::getMatchingItemsByProps 2022-05-19 22:18:44 +02:00
forms
formula
fpicker tdf#62776 expand tooltips for + and - 2022-05-16 03:44:10 +02:00
framework tdf#149176 tdf#149178 fix Save autorecovery information.. option 2022-05-23 08:59:45 +02:00
helpcompiler
helpcontent2@35d09673e7 Update git submodules 2022-05-20 12:45:59 +02:00
hwpfilter ofz#47473 OOM just skip the unused "reserved" data on read 2022-05-16 09:57:23 +02:00
i18nlangtag
i18npool elide some OUString allocation 2022-05-17 18:45:56 +02:00
i18nutil
icon-themes
idl clang-tidy modernize-pass-by-value in idl/idlc 2022-05-18 18:18:14 +02:00
idlc clang-tidy modernize-pass-by-value in idl/idlc 2022-05-18 18:18:14 +02:00
include sw content controls, picture: add LOK API 2022-05-23 18:04:09 +02:00
instsetoo_native Get make_installer calls to run in parallel 2022-05-22 21:35:42 +02:00
io
ios
javaunohelper
jurt
jvmaccess clang-tidy modernize-pass-by-value in jvmaccess 2022-05-23 11:46:13 +02:00
jvmfwk
l10ntools
librelogo
libreofficekit sw content controls, picture: add LOK API 2022-05-23 18:04:09 +02:00
lingucomponent
linguistic HyphenatedWord and PossibleHyphens do not need locking 2022-05-19 09:30:21 +02:00
lotuswordpro
m4
nlpsolver
o3tl
odk
offapi
officecfg sw content controls, picture: add insert UI 2022-05-20 16:55:16 +02:00
onlineupdate
oovbaapi
oox tdf#66228 PPTX export: fix lost U-shaped connectors 2022-05-23 10:59:10 +02:00
opencl
osx
package fix OWriteStream implementing XUnoTunnel 2022-05-20 18:49:14 +02:00
pch
postprocess Fix typo 2022-05-14 14:08:53 +02:00
pyuno
qadevOOo
readlicense_oo add libtiff to notices 2022-05-20 18:16:24 +02:00
registry
remotebridges
reportbuilder
reportdesign speed up simple use of NamedValueCollection 2022-05-12 18:03:46 +02:00
ridljar
sal rename osl_getSystemPathFromFileURL_Ex->getSystemPathFromFileURL_Ex 2022-05-23 17:26:15 +02:00
salhelper
sax
sc tdf#132293: Removing unused imports from uitests files. 2022-05-23 14:35:38 +02:00
scaddins
sccomp
schema sw content controls, picture: add ODT filter 2022-05-19 17:07:42 +02:00
scp2 tdf#149106 Remove RenamePrgFolder and RemovePrgFolder custom msi actions 2022-05-18 22:50:53 +02:00
scripting new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
sd tdf#149141 - Added default object creation when drag size too low 2022-05-23 15:12:04 +02:00
sdext
setup_native tdf#149106 Remove RenamePrgFolder and RemovePrgFolder custom msi actions 2022-05-18 22:50:53 +02:00
sfx2 tdf#84502 related: Show keyboard shortcut in sidebar tab bar tab button 2022-05-22 03:13:20 +02:00
shell Library_syssh must link against expat when using StaticLibrary_shell_xmlparser 2022-05-11 16:16:35 +02:00
slideshow
smoketest
solenv instantiate Title directly in chart 2022-05-23 11:58:54 +02:00
soltools
sot reserve vector in StgCache::Commit() 2022-05-19 15:37:42 +02:00
starmath elide some OUString allocation 2022-05-23 15:25:42 +02:00
static
stoc officecfg,stoc: allow running JVM UNO components out-of-process 2022-05-13 16:33:39 +02:00
store store: add unit tests 2022-05-16 18:23:14 +02:00
svgio
svl svl: spurious GCC12 -Werror=maybe-uninitialized 2022-05-23 10:40:54 +02:00
svtools
svx elide some OUString allocation 2022-05-23 15:25:42 +02:00
sw sw content controls, picture: add LOK API 2022-05-23 18:04:09 +02:00
swext
sysui tdf#140215 Improve the Comment strings in .desktop files 2022-05-23 12:57:52 +02:00
test
testtools
toolkit new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
tools elide temporary OUStringBuffer in INetURLObject 2022-05-20 19:54:57 +02:00
translations@9ef7b8c2ec Update git submodules 2022-05-12 13:05:26 +02:00
ucb osl::Mutex->std::mutex in DataSupplier 2022-05-20 17:16:36 +02:00
ucbhelper elide some OUString allocation 2022-05-23 15:25:42 +02:00
udkapi
uitest Improve version check 2022-05-17 14:12:58 +02:00
UnoControls
unodevtools
unoidl clang-tidy modernize-pass-by-value in unoidl 2022-05-18 14:45:27 +02:00
unoil
unotest
unotools cache ref to GlobalEventConfig 2022-05-23 15:26:12 +02:00
unoxml Extend loplugin:redundantcast to trivial reinterpret_cast from T to itself 2022-05-18 10:52:59 +02:00
ure
uui flatten UUIInteractionHandler 2022-05-21 11:17:44 +02:00
vbahelper
vcl Bad hack to silence UBSan nullptr-with-offset 2022-05-23 18:17:10 +02:00
winaccessibility
wizards ScriptForge - (SF_Calc) FIX CompactUp/Left whan range is 1 row/col 2022-05-16 16:22:55 +02:00
writerfilter sw: copy grab bags in mail merge 2022-05-23 10:54:16 +02:00
writerperfect
xmerge
xmlhelp
xmloff sw content controls, picture: add ODT filter 2022-05-19 17:07:42 +02:00
xmlreader
xmlscript new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
xmlsecurity Simplify an "ImportGraphic" method by removing useless pExtHeader (WmfExternal) 2022-05-19 10:55:06 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore Add mold linker temp files to .gitignore 2022-05-13 15:15:12 +02:00
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in Get make_installer calls to run in parallel 2022-05-22 21:35:42 +02:00
config_host_lang.mk.in
configure.ac qt6 configure: Consider more paths to find Qt 6 moc 2022-05-23 17:40:38 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst update Skia to chrome/m103 2022-05-21 10:56:27 +02:00
g
hardened_runtime.xcent.in
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch build libtiff 2022-05-20 22:29:00 +02:00
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md
README.Solaris
Repository.mk
RepositoryExternal.mk tiff: enable webp 2022-05-21 20:06:24 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.13
    • Build: 11.0 + Xcode 12.5
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 8.0.1 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.