Test repository to check push and ssh key
Find a file
Caolán McNamara 82584fe1b9 cid#1619686 Invalid iterator comparison
Change-Id: I731cc791b1efab895bddbea9a235a9add3288058
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173893
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-09-25 15:37:07 +02:00
.git-hooks
.github
.vscode
accessibility use less dynamic_cast when broadcasting SfxHint 2024-09-05 08:10:26 +02:00
android android-viewer translated using Weblate 2024-08-14 17:52:09 +02:00
animations loplugin:ostr avmedia 2024-05-06 15:14:09 +02:00
apple_remote Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
avmedia tdf#158510 Added fallback for media files in MediaWindowImpl 2024-08-14 00:19:23 +02:00
basctl use more concrete UNO in basic 2024-09-18 15:02:58 +02:00
basegfx cid#1607355 silence Overflowed constant 2024-09-18 21:24:57 +02:00
basic no need to do UNO_QUERY here 2024-09-20 19:12:27 +02:00
bean
bin .NET Bindings: Create nuget package for LO SDK 2024-09-18 08:08:31 +02:00
binaryurp cid#1557276 COPY_INSTEAD_OF_MOVE 2024-08-20 21:14:18 +02:00
bridges Fix typo 2024-09-18 16:59:07 +02:00
canvas cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
chart2 tdf#163084: add Histogram chart in sidebar 2024-09-22 11:29:17 +02:00
cli_ure Only use -Wv:18 in Visual Studio 2019 2024-07-01 11:02:37 +02:00
codemaker cid#1607989 Overflowed constant 2024-09-23 09:32:54 +02:00
comphelper cid#1555574 drop unused copy ctor 2024-09-18 11:45:21 +02:00
compilerplugins drop unused eventtesting cmd line option 2024-09-06 12:25:32 +02:00
config_host Confine a hack to known-broken --enable-pch 2024-09-25 15:13:11 +02:00
configmgr Related: tdf#161599 ChildAccess::asValue() must return Reference<XInterface> 2024-08-27 21:09:35 +02:00
connectivity cid#1607586 explicitly return after JNI ThrowNew 2024-09-24 13:27:48 +02:00
cppcanvas cid#1608541 bogus Overflowed constant 2024-08-11 18:20:20 +02:00
cppu cid#1555847 COPY_INSTEAD_OF_MOVE 2024-08-22 22:42:37 +02:00
cppuhelper throw more useful exception from OPropertySetHelper::getPropertyValue 2024-09-05 13:51:34 +02:00
cpputools loplugin:ostr in various 2024-05-20 22:09:56 +02:00
cui Resolves tdf#162979 - Avoid oversized online update options 2024-09-24 07:24:32 +02:00
dbaccess use more concrete UNO types in dbaccess 2024-09-24 12:13:47 +02:00
desktop cool#9992 lok doc sign: store signing cert in the view 2024-09-24 10:55:58 +02:00
dictionaries@75f5dff8c9 Update git submodules 2024-09-13 07:51:26 +02:00
distro-configs add a --with-system-java-websocket 2024-09-20 17:43:42 +02:00
docmodel cid#1554709 COPY_INSTEAD_OF_MOVE 2024-07-16 15:13:41 +02:00
drawinglayer tdf#163131 CairoSDPR: 2024-09-25 10:56:34 +02:00
editeng tdf#163105 Consolidated duplicated kashida justification code 2024-09-25 01:25:07 +02:00
embeddedobj Avoid deadlock 2024-09-04 16:56:07 +02:00
embedserv Simplify a bit 2024-06-16 08:59:33 +02:00
emfio tdf#119785 Implement the EMF TA_RTLREADING alignment flag 2024-09-18 05:59:51 +02:00
eventattacher loplugin:ostr in various 2024-05-20 22:09:56 +02:00
extensions use more concrete UNO in extensions 2024-09-18 12:40:04 +02:00
external libtiff: upgrade to release 4.7.0 2024-09-19 09:43:17 +02:00
extras tdf#162878 Freshes template: autosize for title 2024-09-24 07:58:04 +02:00
filter use more concrete UNO types in filter 2024-09-15 16:35:36 +02:00
forms Fix typos 2024-09-16 19:21:25 +02:00
formula tdf#161543 Enhance the searching functionality in FD & FW 2024-09-03 09:59:16 +02:00
fpicker cid#1606833 Overflowed constant 2024-09-16 09:53:43 +02:00
framework use more concrete UNO type in framework 2024-09-11 16:14:54 +02:00
helpcompiler cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
helpcontent2@db426f52a9 Update git submodules 2024-09-24 14:26:36 +02:00
hwpfilter cid#1607586 Overflowed return value 2024-09-24 13:27:26 +02:00
i18nlangtag tdf#158556 avoid a ton of temporary OUString 2024-08-28 19:35:08 +02:00
i18npool tdf#130924 use SAL_INFO/WARN instead of f/printf 2024-08-22 15:46:36 +02:00
i18nutil tdf#163105 Require kashida after Seen, even before a final Yeh 2024-09-25 07:15:23 +02:00
icon-themes tdf#163086 Resize SVG pin icons to 24x24 and clean them up 2024-09-23 06:34:18 +02:00
idl cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
idlc/test/parser
include Confine a hack to known-broken --enable-pch 2024-09-25 15:13:11 +02:00
instsetoo_native tdf#162921 on this error dialog there is 'Abort' button, not 'Cancel' 2024-09-12 09:42:35 +02:00
io loplugin:ostr in io 2024-05-09 12:48:17 +02:00
ios
javaunohelper loplugin:ostr in javaunohelper 2024-05-09 17:59:45 +02:00
jurt makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
jvmaccess Fix typo 2024-07-24 22:36:07 +02:00
jvmfwk Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
l10ntools cid#1607175 Overflowed constant 2024-09-22 20:10:23 +02:00
librelogo cui, dbaccess, desktop, external, filter, librelogo: fix issues found by 2024-07-27 12:51:55 +02:00
libreofficekit cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
lingucomponent cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
linguistic reset m_bEnd after use to quit lcl_workerfunc 2024-09-18 22:13:23 +02:00
lotuswordpro cid#1608296 silence Overflowed integer argument 2024-08-25 17:36:28 +02:00
m4
msicreator comphelper, msicreator, odk: fix issues found by Ruff linter 2024-07-27 15:42:26 +02:00
net_ure .NET Bindings: Native bridge for .NET 2024-09-18 08:10:36 +02:00
nlpsolver Double values comparison changed to compare method. 2024-04-29 15:40:27 +02:00
o3tl tsan: fix data race in o3tl::cow_wrapper 2024-07-09 20:12:54 +02:00
odk .NET Bindings: Ported examples for Native bridge 2024-09-18 08:11:26 +02:00
offapi [API CHANGE] XDocumentDigitalSignatures: remove deprecated / unused functions 2024-09-13 10:27:14 +02:00
officecfg Resolves tdf#161574 - Individual labels for TOXes in the UI 2024-09-25 10:39:25 +02:00
oovbaapi Fix VBA Table's *Padding properties type 2024-06-29 22:47:38 +02:00
oox in OUString find functions, assert that fromIndex >= 0 2024-09-24 12:09:41 +02:00
opencl workaround segfault in compiler on macos-clang-intel 2024-07-25 15:03:36 +02:00
osx
package package: add unit tests with invalid zip packages 2024-09-19 09:42:41 +02:00
pch
postprocess loplugin:ostr in various 2024-05-20 22:09:56 +02:00
pyuno Remaining GCC -Wcast-function-type issues 2024-09-19 07:35:49 +02:00
qadevOOo cid#1557158 Unguarded read 2024-09-17 13:23:25 +02:00
readlicense_oo update credits 2024-09-23 13:17:42 +02:00
registry loplugin:ostr in various 2024-05-20 22:09:56 +02:00
remotebridges loplugin:ostr in various 2024-05-20 22:09:56 +02:00
reportbuilder cid#1608462 XML external entity processing enabled 2024-08-04 20:05:02 +02:00
reportdesign reportdesign: Use NC_ to create a TranslateId 2024-09-23 15:39:27 +02:00
ridljar makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
sal cid#1606864 Overflowed constant 2024-09-19 15:43:19 +02:00
salhelper Do not try to notify, if the thread is already killed 2024-08-20 11:14:01 +02:00
sax Optimize TokenMap and AttributeList in oox and xo 2024-09-12 23:09:23 +02:00
sc tdf#163091: check rParam.mnX before passing it to RowInfo::cellInfo 2024-09-25 07:15:49 +02:00
scaddins cid#1607355 silence Overflowed constant 2024-09-18 21:24:57 +02:00
sccomp cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
schema ODF 1.4: Add ODFVER_014 and ODFSVER_014 2024-09-24 14:49:55 +02:00
scp2 scp2: simplifiy language snippet creation rules 2024-09-02 21:16:10 +02:00
scripting use more concrete UNO classes in scripting 2024-09-12 12:35:00 +02:00
sd cid#1619686 Invalid iterator comparison 2024-09-25 15:37:07 +02:00
sdext tdf#101611, tdf#108813, tdf#86211, sdext,pdfimport: Clip fills 2024-08-29 14:29:47 +02:00
setup_native makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
sfx2 cool#9992 lok doc sign: store signing cert in the view 2024-09-24 10:55:58 +02:00
shell Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
slideshow lok: render the whole slide temporary (with bg and master content) 2024-09-24 14:33:52 +02:00
smoketest cid#1555415 COPY_INSTEAD_OF_MOVE 2024-08-06 09:13:52 +02:00
solenv Adapting basegfx.py due to blocking in some situations 2024-09-25 10:56:18 +02:00
soltools Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
sot tdf#158556 use more comphelper::ByteReader 2024-08-27 09:10:04 +02:00
starmath Related tdf#160226 - Math inline editing Off by default 2024-08-26 10:38:28 +02:00
static Explicitly .delete() one more interface object in uno.js 2024-09-02 10:57:36 +02:00
stoc use more concrete UNO type in stoc 2024-09-10 17:17:36 +02:00
store cid#1608100 silence Overflowed array index read 2024-08-12 20:52:11 +02:00
svgio vcl: migrate BitmapArithmeticBlendFilter to use BitmapFilter class 2024-09-20 22:53:17 +02:00
svl cid#1607355 silence Overflowed constant 2024-09-18 21:24:57 +02:00
svtools Make replacement graphic management more atomic 2024-09-21 14:57:52 +02:00
svx svx: prefix members of SdrPolyEditView 2024-09-23 09:30:29 +02:00
sw Resolves tdf#161574 - Individual labels for TOXes in the UI 2024-09-25 10:39:25 +02:00
swext makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
sysui Adapt to RPM 4.20 2024-09-22 22:26:18 +02:00
test ODF 1.4: schema: rename to OpenDocument-v1.3* 2024-09-24 14:21:15 +02:00
testtools testtools, wizards, xmlsecurity: fix issues found by Ruff linter 2024-07-29 16:56:57 +02:00
toolkit cid#1607469 Data race condition 2024-09-11 18:13:35 +02:00
tools cid#1607586 Overflowed return value 2024-09-24 13:27:26 +02:00
translations@42ecd2971a Update git submodules 2024-09-17 13:54:31 +02:00
ucb Make an exceptin message more informative 2024-09-24 07:54:51 +02:00
ucbhelper use more concrete UNO type in ucbhelper 2024-09-10 17:17:43 +02:00
udkapi Move org.libreoffice.embindtest from udkapi to offapi 2024-04-11 15:22:40 +02:00
uitest Related tdf#160226 - Math inline editing Off by default 2024-08-26 10:38:28 +02:00
UnoControls loplugin:ostr in various 2024-05-20 22:09:56 +02:00
unodevtools cid#1607989 Overflowed constant 2024-09-23 09:32:54 +02:00
unoidl cid#1607362 Overflowed constant 2024-09-18 18:03:24 +02:00
unoil .NET Bindings: Switch for old windows CLI bindings 2024-06-22 00:11:16 +02:00
unotest Surround printed struct/exception members with {...} 2024-09-24 07:55:00 +02:00
unotools ODF 1.4: Add ODFVER_014 and ODFSVER_014 2024-09-24 14:49:55 +02:00
unoxml sfx2: move rdf java test to CppUnittest 2024-09-21 09:44:05 +02:00
ure
uui cool#9956 uui lok: avoid showing the password dialog for now 2024-09-03 11:28:13 +02:00
vbahelper use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
vcl tdf#163105 sw: Add some whitespace expansion to kashida justification 2024-09-25 03:22:38 +02:00
winaccessibility wina11y: Drop CAccImage::GetXInterface 2024-09-17 21:41:58 +02:00
wizards cid#1606653 PA: Public Attribute 2024-09-24 18:09:38 +02:00
writerperfect use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
xmerge cid#1616070 XML external entity processing enabled 2024-08-09 10:52:57 +02:00
xmlhelp O[U]String overloads that return view for rest parameter 2024-07-25 13:29:11 +02:00
xmloff tdf#162686: Adapt to ODF 1.4 2024-09-24 14:50:36 +02:00
xmlreader loplugin:ostr in various 2024-05-20 22:09:56 +02:00
xmlscript BootstrapFixture: get rid of mxComponentContext 2024-07-02 15:35:00 +02:00
xmlsecurity cool#9992 lok doc sign: fix import of the private key 2024-09-25 13:14:42 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh Add a note about autogen.input into autogen.sh --help output 2024-07-13 22:18:14 +02:00
BUCK
config.guess
config.sub
config_host.mk.in add a --with-system-java-websocket 2024-09-20 17:43:42 +02:00
config_host_lang.mk.in
configure.ac Confine a hack to known-broken --enable-pch 2024-09-25 15:13:11 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint sw: remove unused DECLARE_RTFEXPORT_TEST() 2024-06-06 09:58:39 +02:00
download.lst libtiff: upgrade to release 4.7.0 2024-09-19 09:43:17 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit When no branch is specified, fallback to the tracked branch first 2024-04-11 14:08:29 +02:00
Makefile.fetch Bundle fonts of Google's DocRepair Project 2024-07-05 15:37:11 +02:00
Makefile.gbuild use gb_StaticLibrary_WORKDIR and gb_Library_DLLDIR more consistently 2024-06-19 20:00:39 +02:00
Makefile.in .NET Bindings: Add DotnetTest class to gbuild 2024-08-03 12:07:11 +02:00
README.cross
README.help.md
README.md README.md: add Python baseline 2024-06-13 21:28:53 +02:00
README.Solaris
Repository.mk .NET Bindings: Native bridge for .NET 2024-09-18 08:10:36 +02:00
RepositoryExternal.mk add a --with-system-java-websocket 2024-09-20 17:43:42 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk .NET Bindings: Add DotnetLibrary class to gbuild 2024-06-12 18:48:07 +02:00
RepositoryModule_host.mk .NET Bindings: Add DotnetLibrary class to gbuild 2024-06-12 18:48:07 +02:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt update tsan suppressions 2024-07-11 13:04:30 +02:00

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.