Test repository to check push and ssh key
Find a file
Michael Weghorn 9a249103de android: Switch order of these if/else statements
I find

    if (a == b) {
        // statement 1
    } else {
        // statement 2
    }

more straightforward than

    if ( a != b) {
        // statement 2
    } else {
        // statement 1
    }

since it doesn't require logically negating twice
(else block is for `!(a != b)`) in the second form), and this
also prepares for a follow-up commit where one of the conditions
will be extended further.

Change-Id: I1d2177bdcf662994e757b626983a9f9626c66aa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133988
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-05-08 08:23:29 +02:00
.git-hooks
.github
.vscode
accessibility Just use Any ctor instead of makeAny in accessibility 2022-05-05 07:14:56 +02:00
android android: Switch order of these if/else statements 2022-05-08 08:23:29 +02:00
animations osl::Mutex->std::mutex in TimeContainerEnumeration 2022-05-07 14:24:10 +02:00
apple_remote
avmedia Just use Any ctor instead of makeAny in avmedia 2022-05-05 07:57:49 +02:00
basctl loplugin:unusedvariableplus 2022-05-05 17:35:08 +02:00
basegfx ofz#46070 Out-of-memory 2022-05-07 22:53:21 +02:00
basic tdf#148358 - Compare Non-ASCII variable names case-insensitive 2022-05-07 16:00:50 +02:00
bean
bin Drop --with-iwyu option 2022-05-04 16:48:25 +02:00
binaryurp
bridges use more o3tl::getToken 2022-05-05 12:57:00 +02:00
canvas Just use Any ctor instead of makeAny in canvas 2022-05-05 07:12:19 +02:00
chart2 remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
cli_ure Just use Any ctor instead of makeAny in cli_ure 2022-05-04 22:43:37 +02:00
codemaker Revert "use more string_view in codemaker" 2022-04-29 11:12:54 +02:00
comphelper remove dead item cleanup from NumberedCollection::impl_searchFreeNumber 2022-05-07 14:23:51 +02:00
compilerplugins loplugin:unusedvariableplus 2022-05-05 17:35:08 +02:00
config_host Rename #define HAVE_LIBCXX -> HAVE_LIBCPP 2022-05-03 12:00:29 +02:00
configmgr Adapt function's interface to change from OUString to std::u16string_view 2022-04-26 15:43:59 +02:00
connectivity loplugin:unusedvariableplus 2022-05-05 17:35:08 +02:00
cppcanvas
cppu Just use Any ctor instead of makeAny in cppu 2022-05-04 21:45:59 +02:00
cppuhelper Remove duplicated includes 2022-05-06 07:07:10 +02:00
cpputools use more string_view in various 2022-05-01 08:30:18 +02:00
cui Remove duplicated includes 2022-05-06 07:07:10 +02:00
dbaccess loplugin:unusedvariableplus 2022-05-05 17:35:08 +02:00
desktop use more o3tl::getToken 2022-05-05 12:57:00 +02:00
dictionaries@e0a820ca5c
distro-configs Drop unused LanguageTool extension 2022-04-26 10:08:54 +02:00
drawinglayer osl::Mutex->std::mutex in VDevBuffer 2022-05-07 14:21:58 +02:00
editeng tdf#107765: Check the updated language and apply it to the cell. 2022-05-07 04:52:50 +02:00
embeddedobj Just use Any ctor instead of makeAny in embeddedobj 2022-05-04 14:39:24 +02:00
embedserv Just use Any ctor instead of makeAny in embedserv 2022-05-04 14:38:29 +02:00
emfio
eventattacher
extensions loplugin:unusedvariableplus 2022-05-05 17:35:08 +02:00
external Upgrade external/boost to latest Boost 1.79.0 2022-05-05 21:39:05 +02:00
extras tdf#143956 Remove page size of Writer templates 3 2022-04-26 09:42:26 +02:00
filter osl::Mutex->std::mutex in filter::config::CacheUpdateListener 2022-05-07 18:00:56 +02:00
forms Just use Any ctor instead of makeAny in forms 2022-05-04 12:11:29 +02:00
formula add o3tl::toUInt32 2022-04-26 19:37:20 +02:00
fpicker tdf#62776 - Add tooltip for folder location shortcuts 2022-05-07 11:09:32 +02:00
framework osl::Mutex->std::mutex in framework::StatusBarManager 2022-05-07 20:55:33 +02:00
helpcompiler use more o3tl::getToken 2022-05-05 12:57:00 +02:00
helpcontent2@886426b32d Update git submodules 2022-05-05 14:03:52 +02:00
hwpfilter GCC 12 is still just as broken 2022-05-07 16:54:52 +02:00
i18nlangtag use more string_view in i18nlangtag 2022-04-28 11:45:56 +02:00
i18npool add o3tl::equalsAscii 2022-05-03 09:12:32 +02:00
i18nutil add o3tl::toUInt32 2022-04-26 19:37:20 +02:00
icon-themes tdf#144788 Split up footnotes and endnotes in Navigator 2022-04-28 10:48:38 +02:00
idl
idlc Remove duplicated includes 2022-05-06 07:07:10 +02:00
include tdf#107765: Check the updated language and apply it to the cell. 2022-05-07 04:52:50 +02:00
instsetoo_native
io Just use Any ctor instead of makeAny in io 2022-05-04 11:46:07 +02:00
ios
javaunohelper Just use Any ctor instead of makeAny in javaunohelper 2022-05-04 10:10:41 +02:00
jurt
jvmaccess
jvmfwk use more o3tl::getToken 2022-05-05 12:57:00 +02:00
l10ntools use more o3tl::getToken 2022-05-05 12:57:00 +02:00
librelogo
libreofficekit
lingucomponent use more o3tl::getToken 2022-05-05 12:57:00 +02:00
linguistic Just use Any ctor instead of makeAny in linguistic 2022-05-04 11:57:57 +02:00
lotuswordpro use more string_view in various 2022-05-01 08:30:18 +02:00
m4 configure: default to --with-system-nss on Linux 2022-04-29 20:24:58 +02:00
nlpsolver
o3tl remove the o3tl::lru_map "unlimited" hack 2022-05-03 06:54:54 +02:00
odk
offapi tdf#99708 Save formula bar height to document 2022-05-03 14:52:07 +02:00
officecfg tdf#121740 increase DrawingEngine::OLE_Objects cache limit 2022-05-07 08:10:49 +02:00
onlineupdate
oovbaapi
oox Revert "tdf#147919 PPTX export: fix curved and bent connector shape" 2022-05-07 15:40:49 +02:00
opencl
osx
package tdf#121740 reduce cost of OStorage_Impl::GetElementNames 2022-05-06 14:22:15 +02:00
pch
postprocess
pyuno Just use Any ctor instead of makeAny in pyuno 2022-05-04 08:41:43 +02:00
qadevOOo
readlicense_oo update credits 2022-05-06 16:08:23 +02:00
registry
remotebridges
reportbuilder
reportdesign use more o3tl::getToken 2022-05-05 12:57:00 +02:00
ridljar
sal output error code when SymFromAddr fails 2022-05-06 11:04:33 +02:00
salhelper
sax remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
sc tdf#107765: Use the correct sheet index. 2022-05-07 16:48:12 +02:00
scaddins Pick better variable types 2022-04-26 16:24:26 +02:00
sccomp remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
schema sd theme: add ODP import/export for shape fill color effects 2022-05-05 08:07:49 +02:00
scp2 Drop unused LanguageTool extension 2022-04-26 10:08:54 +02:00
scripting Just use Any ctor instead of makeAny in scripting 2022-05-04 06:55:38 +02:00
sd Revert "tdf#147919 PPTX export: fix curved and bent connector shape" 2022-05-07 15:40:49 +02:00
sdext Just use Any ctor instead of makeAny in sdext 2022-05-04 08:10:52 +02:00
setup_native Drop unused LanguageTool extension 2022-04-26 10:08:54 +02:00
sfx2 remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
shell Just use Any ctor instead of makeAny (Linux, sequel) 2022-05-05 11:44:48 +02:00
slideshow Just use Any ctor instead of makeAny in slideshow 2022-05-04 06:54:45 +02:00
smoketest
solenv Drop --with-iwyu option 2022-05-04 16:48:25 +02:00
soltools
sot Just use Any ctor instead of makeAny in sot 2022-05-04 08:10:23 +02:00
starmath tdf#148962 starmath's UnicodeNotationToggle (alt+x) getting called twice 2022-05-06 17:17:23 +02:00
static
stoc remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
store
svgio add o3tl::matchIgnoreAsciiCase 2022-05-03 16:30:01 +02:00
svl cid#1504313 Uninitialized pointer read 2022-05-07 21:23:59 +02:00
svtools use more o3tl::getToken 2022-05-05 12:57:00 +02:00
svx tdf#107765: Check the updated language and apply it to the cell. 2022-05-07 04:52:50 +02:00
sw Drop excess +1 2022-05-07 17:19:47 +02:00
swext
sysui
test Just use Any ctor instead of makeAny in test 2022-05-03 20:03:32 +02:00
testtools Just use Any ctor instead of makeAny in testtools 2022-05-03 20:02:54 +02:00
toolkit use more o3tl::getToken 2022-05-05 12:57:00 +02:00
tools This condition is apparently fatal 2022-05-07 17:23:53 +02:00
translations@87be4f00f4 Update git submodules 2022-05-04 14:16:23 +02:00
ucb loplugin:unusedvariableplus 2022-05-05 17:35:08 +02:00
ucbhelper tdf#121740 fast path in cancelCommandExecution 2022-05-07 15:26:06 +02:00
udkapi
uitest
UnoControls
unodevtools use more string_view in unodevtools 2022-04-28 11:45:30 +02:00
unoidl
unoil
unotest unotest: fix NSS initialization for CentOS7 system NSS 2022-04-29 20:23:02 +02:00
unotools use more o3tl::getToken 2022-05-05 12:57:00 +02:00
unoxml osl::Mutex->std::mutex in librdf_NamedGraph 2022-05-07 12:50:20 +02:00
ure
uui
vbahelper Just use Any ctor instead of makeAny in vbahelper 2022-05-03 13:35:43 +02:00
vcl ofz#47289 attempt to allocate negative len 2022-05-07 22:53:01 +02:00
winaccessibility Just use Any ctor instead of makeAny in winaccessibility 2022-05-03 10:07:33 +02:00
wizards Access2Base - (access2base.py) FIX remove duplicate 2022-04-26 10:28:04 +02:00
writerfilter remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
writerperfect Just use Any ctor instead of makeAny in writerperfect 2022-05-02 22:01:00 +02:00
xmerge
xmlhelp Just use Any ctor instead of makeAny in xmlhelp 2022-05-02 20:02:03 +02:00
xmloff remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
xmlreader
xmlscript Just use Any ctor instead of makeAny in xmlscript 2022-05-02 17:24:32 +02:00
xmlsecurity remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in Drop --with-iwyu option 2022-05-04 16:48:25 +02:00
config_host_lang.mk.in
configure.ac use VCL_FLOAT_DEVICE_PIXEL for fuzzers 2022-05-07 22:54:32 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
download.lst Upgrade external/boost to latest Boost 1.79.0 2022-05-05 21:39:05 +02:00
g
hardened_runtime.xcent.in
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
lo.xcent
logerrit
Makefile.fetch Drop unused LanguageTool extension 2022-04-26 10:08:54 +02:00
Makefile.gbuild
Makefile.in Drop --with-iwyu option 2022-05-04 16:48:25 +02:00
README.cross
README.help.md
README.md Warn if Visual Studio 2019 version is < 16.10 2022-05-05 17:26:12 +02:00
README.Solaris
Repository.mk Drop unused CT2N extension 2022-04-26 10:08:30 +02:00
RepositoryExternal.mk use proper MSVC runtime lib for libwebp 2022-05-03 06:54:08 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.13
    • Build: 11.0 + Xcode 12.5
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 8.0.1 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.