strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
office-gobmx/sd
History
Stephan Bergmann 323df76698 Revert "tdf#147919 PPTX export: fix curved and bent connector shape" 
This reverts commit 1f8c6efbfe, as it caues

> warn:legacy.tools:12871:12871:tools/source/generic/poly.cxx:1581: Polygon::[]: nPos >= nPoints
> =================================================================
> ==12871==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x603000445080 at pc 0x7f6303ec7854 bp 0x7ffd23271600 sp 0x7ffd232715f8
> READ of size 8 at 0x603000445080 thread T0
>     #0 0x7f6303ec7853 in Point::X() const /include/tools/gen.hxx:83:51
>     #1 0x7f63045baaa1 in oox::drawingml::lcl_GetConnectorAdjustValue(com::sun:⭐:uno::Reference<com::sun:⭐:drawing::XShape> const&, tools::Polygon, com::sun:⭐:drawing::ConnectorType, std::__debug::vector<std::pair<int, int>, std::allocator<std::pair<int, int> > >&) /oox/source/export/shapes.cxx:1556:27
>     #2 0x7f63045b731f in oox::drawingml::ShapeExport::WriteConnectorShape(com::sun:⭐:uno::Reference<com::sun:⭐:drawing::XShape> const&) /oox/source/export/shapes.cxx:1701:13
>     #3 0x7f63045984e7 in oox::drawingml::ShapeExport::WriteShape(com::sun:⭐:uno::Reference<com::sun:⭐:drawing::XShape> const&) /oox/source/export/shapes.cxx:1956:5
>     #4 0x7f62b399ad3b in oox::core::PowerPointExport::WriteShapeTree(std::shared_ptr<sax_fastparser::FastSerializerHelper> const&, PageType, bool) /sd/source/filter/eppt/pptx-epptooxml.cxx:1658:22

during CppunitTest_sd_export_tests-ooxml3
CPPUNIT_TEST_NAME=SdOOXMLExportTest3::testTdf114848
(<https://ci.libreoffice.org/job/lo_ubsan/2388/consoleFull#-1714579836d893063f-7f3d-4b7e-b56f-4e0f225817cd>)

Change-Id: I7eab9d3ef8e6604a57d3e59a77905edf6ce6e6ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133870
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-07 15:40:49 +02:00
..
inc add o3tl::equalsAscii 2022-05-03 09:12:32 +02:00
qa Revert "tdf#147919 PPTX export: fix curved and bent connector shape" 2022-05-07 15:40:49 +02:00
res
sdi
source use more o3tl::getToken 2022-05-05 12:57:00 +02:00
uiconfig
util
workben
xml
xsl
AllLangMoTarget_sd.mk
CppunitTest_sd_activex_controls_tests.mk
CppunitTest_sd_dialogs_test.mk
CppunitTest_sd_export_tests-ooxml1.mk
CppunitTest_sd_export_tests-ooxml2.mk
CppunitTest_sd_export_tests-ooxml3.mk
CppunitTest_sd_export_tests.mk
CppunitTest_sd_filter_eppt.mk
CppunitTest_sd_filters_test.mk
CppunitTest_sd_html_export_tests.mk
CppunitTest_sd_import_tests-smartart.mk
CppunitTest_sd_import_tests.mk
CppunitTest_sd_import_tests2.mk
CppunitTest_sd_layout_tests.mk
CppunitTest_sd_misc_tests.mk
CppunitTest_sd_pdf_import_test.mk
CppunitTest_sd_png_export_tests.mk
CppunitTest_sd_svg_export_tests.mk
CppunitTest_sd_tiledrendering.mk
CppunitTest_sd_uiimpress.mk
CppunitTest_sd_uimpress.mk
export_setup.mk
import_setup.mk
IwyuFilter_sd.yaml
JunitTest_sd_unoapi.mk
Library_sd.mk
Library_sdd.mk
Library_sdfilt.mk
Library_sdui.mk
Makefile
Module_sd.mk
Package_opengl.mk
Package_web.mk
Package_xml.mk
README.md
README_REMOTE
UIConfig_sdraw.mk
UIConfig_simpress.mk
UITest_impress_tests.mk
UITest_sd_findReplace.mk

README.md

LibreOffice Impress / Draw Application

The core directory for the impress/draw applications.

Think of impress as a hack on top of draw.

sd module contains impress/draw specific code, non-shared UI and part of ppt and pptx filter, few other filters too.

the slideshow UI lives here as well, the slideshow engine is in slideshow module though (including the 3D transitions engine slideshow/source/engine/opengl).

the most used filters are ODF's odp, binary ppt and OOXML's pptx. their locations are listed below:

  • odp import and export filters are in xmloff module (mostly xmloff/source/draw)

  • ppt import is in sd/source/filter/ppt (big shared chunks are also in svx)

  • ppt export is in sd/source/filter/eppt (big shared chunks are also in svx)

  • pptx import is in oox/source/ppt (and uses a lot of oox/source/drawingml and oox/source/*)

  • pptx export is in sd/source/filter/eppt (mostly in pptx-* source files) and shared part is in oox/source/export

PPTX Export / Import Filters

PPTX export filter is split into 2 parts. Impress related part is in sd/source/filter/eppt/pptx-* and the other part is in oox/source/export/ because it contains mostly code related to DrawingML, which is shared with writer and calc ooxml export.

The export filter was written in 2009 IIRC and was not much extended feature-wise lately.

Future Works

Add custom shapes export (see below). enhance text output, we don't write text style for indentation levels now, need to export a:lvl1pPr, a:lvl2pPr, ... elements.

PPTX import was written by Sun/Oracle and then extended in LibreOffice a lot during bug fixing. It is located in oox/source/ppt and oox/source/drawingml. The areas with most bugs (at least until today) were shape placeholders and text style inheritance.