Test repository to check push and ssh key
Find a file
Noel Grandin 9b902cfa55 clang-tidy modernize-pass-by-value in sot
Change-Id: I1ff31ae1291a82630ae32185077e369bbdfd3a0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135127
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30 16:12:34 +02:00
.git-hooks
.github rdm#3572 update github-repo lockdown 2022-05-10 10:24:33 +02:00
.vscode Fix typos 2022-03-13 19:17:37 +01:00
accessibility Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
android android: Update Android Gradle Plugin to 7.2.1 2022-05-28 13:28:10 +02:00
animations osl::Mutex->std::mutex in TimeContainerEnumeration 2022-05-07 14:24:10 +02:00
apple_remote
avmedia tdf#148923 PPTX import: fix incorrect image in media file 2022-05-19 10:26:01 +02:00
basctl resave with latest glade 2022-05-18 09:45:55 +02:00
basegfx clang-tidy modernize-pass-by-value in basegfx 2022-05-27 18:20:07 +02:00
basic cid#1504574 Resource leak 2022-05-30 16:00:35 +02:00
bean
bin bin: add script to retrieve info about crashreports... 2022-05-26 13:07:10 +02:00
binaryurp cid#1504543 Silence unhelpful, aggressive UNINIT_CTOR 2022-05-23 10:55:45 +02:00
bridges clang-tidy modernize-pass-by-value in bridges 2022-05-21 17:29:53 +02:00
canvas clang-tidy modernize-pass-by-value in canvas 2022-05-21 21:55:31 +02:00
chart2 add GetItemState to SfxItemIter, the same way I did to SfxWhichIter 2022-05-28 17:37:07 +02:00
cli_ure Just use Any ctor instead of makeAny in cli_ure 2022-05-04 22:43:37 +02:00
codemaker clang-tidy modernize-pass-by-value in codemaker 2022-05-18 14:08:28 +02:00
comphelper cid#1504574 Resource leak 2022-05-30 16:00:35 +02:00
compilerplugins new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
config_host enable Skia on big-endian too 2022-05-09 09:14:11 +02:00
configmgr clang-tidy modernize-pass-by-value in configmgr 2022-05-23 10:52:11 +02:00
connectivity Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
cppcanvas tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro 2022-05-09 20:42:03 +02:00
cppu New o3tl::intcmp.hxx 2022-05-29 19:38:46 +02:00
cppuhelper tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro 2022-05-09 20:42:03 +02:00
cpputools use more string_view in various 2022-05-01 08:30:18 +02:00
cui tdf#127294 (related: tdf#147524) add ToD about Customize toolbars 2022-05-27 13:55:00 +02:00
dbaccess Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
desktop desktop: fix type of the last argument of lok_preinit_2() 2022-05-26 08:25:04 +02:00
dictionaries@3cfa1a0899 Update git submodules 2022-05-17 15:21:18 +02:00
distro-configs Adapt flatpak build to recently introduced dependencies 2022-05-18 09:10:59 +02:00
drawinglayer use more Primitive2DContainer::append and more std::move 2022-05-30 10:07:47 +02:00
editeng add ClearItem to the SfxItemSet iterators 2022-05-28 20:50:40 +02:00
embeddedobj elide some OUString allocation 2022-05-24 13:13:00 +02:00
embedserv Just use Any ctor instead of makeAny in embedserv 2022-05-04 14:38:29 +02:00
emfio tdf#143876 EMF+ Add DrawClosedCurve and FillClosedCurve support 2022-05-16 17:26:20 +02:00
eventattacher
extensions Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
external We actually want to divide by 257 here 2022-05-24 09:54:36 +02:00
extras tdf#143956 Remove page size of Writer templates 3 2022-04-26 09:42:26 +02:00
filter elide some OUString allocation 2022-05-25 19:00:44 +02:00
forms Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
formula add o3tl::toUInt32 2022-04-26 19:37:20 +02:00
fpicker tdf#62776 expand tooltips for + and - 2022-05-16 03:44:10 +02:00
framework cid#1504574 Resource leak 2022-05-30 16:00:35 +02:00
helpcompiler use more o3tl::getToken 2022-05-05 12:57:00 +02:00
helpcontent2@76f954f62c Update git submodules 2022-05-30 15:20:14 +02:00
hwpfilter ofz#47473 OOM just skip the unused "reserved" data on read 2022-05-16 09:57:23 +02:00
i18nlangtag convertLanguageToLocaleImpl() speed-up a gazillion en-US fallback cases 2022-05-26 01:48:31 +02:00
i18npool clang-tidy modernize-pass-by-value in i18npool 2022-05-26 18:30:04 +02:00
i18nutil Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
icon-themes Breeze: tdf#149368 ^ radio & checbox button to follow up latest Plasma UI 2022-05-30 06:44:56 +02:00
idl clang-tidy modernize-pass-by-value in idl/idlc 2022-05-18 18:18:14 +02:00
idlc clang-tidy modernize-pass-by-value in idl/idlc 2022-05-18 18:18:14 +02:00
include clang-tidy modernize-pass-by-value in sot 2022-05-30 16:12:34 +02:00
instsetoo_native make_installer: convert Win to Unix path for cygwin 2022-05-27 09:33:45 +02:00
io URE Library_io should not depend on Library_comphelper 2022-05-09 17:56:47 +02:00
ios
javaunohelper Just use Any ctor instead of makeAny in javaunohelper 2022-05-04 10:10:41 +02:00
jurt
jvmaccess clang-tidy modernize-pass-by-value in jvmaccess 2022-05-23 11:46:13 +02:00
jvmfwk use more o3tl::getToken 2022-05-05 12:57:00 +02:00
l10ntools use more o3tl::getToken 2022-05-05 12:57:00 +02:00
librelogo LibreLogo: add basic HTML formatting support to LABEL 2022-04-22 20:46:35 +02:00
libreofficekit sw content controls, picture: add LOK API 2022-05-23 18:04:09 +02:00
lingucomponent use more o3tl::getToken 2022-05-05 12:57:00 +02:00
linguistic Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
lotuswordpro use more string_view in various 2022-05-01 08:30:18 +02:00
m4 configure: default to --with-system-nss on Linux 2022-04-29 20:24:58 +02:00
nlpsolver
o3tl remove the o3tl::lru_map "unlimited" hack 2022-05-03 06:54:54 +02:00
odk Add Makefile for the FirstUnoContact C++ SDK example 2022-05-25 09:02:29 +02:00
offapi framework: fix crash on Writer startup when using --enable-ext-wiki-publisher 2022-05-30 12:08:03 +02:00
officecfg tdf#65911 add accelerators for style editing 2022-05-25 12:10:51 +02:00
onlineupdate
oovbaapi vba: add support for Application.WindowState + test 2022-01-27 07:38:09 +01:00
oox tdf#149128 PPTX export: fix <stCxn> and <endCxn> connector properties 2022-05-30 12:48:03 +02:00
opencl
osx
package elide some OUString allocation 2022-05-25 19:00:44 +02:00
pch
postprocess Fix typo 2022-05-14 14:08:53 +02:00
pyuno Just use Any ctor instead of makeAny in pyuno 2022-05-04 08:41:43 +02:00
qadevOOo qa: Fix occlusion check coordinates in _XAccessibleComponent.java 2022-05-10 16:13:03 +02:00
readlicense_oo add libtiff to notices 2022-05-20 18:16:24 +02:00
registry
remotebridges
reportbuilder
reportdesign directly instantiate IndexedPropertyValuesContainer 2022-05-25 19:01:03 +02:00
ridljar
sal Avoid uninitialized temp_file_handle 2022-05-30 12:48:28 +02:00
salhelper Recheck modules s[a-c]* with IWYU 2022-02-14 15:25:30 +01:00
sax clang-tidy modernize-pass-by-value in sax 2022-05-27 12:55:23 +02:00
sc in ScOutputData::DrawFrame, we can skip the intermediate container 2022-05-30 10:07:28 +02:00
scaddins Pick better variable types 2022-04-26 16:24:26 +02:00
sccomp remove unnecessary sequenceToContainer 2022-05-06 21:52:00 +02:00
schema sw content controls, date: add current date handling 2022-05-27 12:11:46 +02:00
scp2 tdf#149106 Remove RenamePrgFolder and RemovePrgFolder custom msi actions 2022-05-18 22:50:53 +02:00
scripting new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
sd CppunitTest_sd_filter_eppt also needs the ASan hack 2022-05-30 14:08:36 +02:00
sdext framework: fix crash on Writer startup when using --enable-ext-wiki-publisher 2022-05-30 12:08:03 +02:00
setup_native tdf#149106 Remove RenamePrgFolder and RemovePrgFolder custom msi actions 2022-05-18 22:50:53 +02:00
sfx2 use the new SfxWhichIter::GetItemState feature 2022-05-28 17:36:49 +02:00
shell Library_syssh must link against expat when using StaticLibrary_shell_xmlparser 2022-05-11 16:16:35 +02:00
slideshow tdf#149068 don't call any OpenGL if the context is initially 'invalid' 2022-05-25 16:35:01 +02:00
smoketest
solenv use at least assertions mode if libc++ debug mode is not usable 2022-05-26 07:55:50 +02:00
soltools
sot clang-tidy modernize-pass-by-value in sot 2022-05-30 16:12:34 +02:00
starmath fix another domain 2022-05-30 11:40:12 +02:00
static
stoc officecfg,stoc: allow running JVM UNO components out-of-process 2022-05-13 16:33:39 +02:00
store store: add unit tests 2022-05-16 18:23:14 +02:00
svgio we can std::move the data out of TextBreakupHelper 2022-05-29 19:15:03 +02:00
svl add ClearItem to the SfxItemSet iterators 2022-05-28 20:50:40 +02:00
svtools Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
svx use more Primitive2DContainer::append and more std::move 2022-05-30 10:07:47 +02:00
sw use more SfxWhichIter::GetItemState 2022-05-30 16:12:20 +02:00
swext
sysui tdf#140215 Improve the Comment strings in .desktop files 2022-05-23 12:57:52 +02:00
test Just use Any ctor instead of makeAny in test 2022-05-03 20:03:32 +02:00
testtools Just use Any ctor instead of makeAny in testtools 2022-05-03 20:02:54 +02:00
toolkit new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
tools tdf#147021 Use std::size() instead SAL_N_ELEMENTS macro 2022-05-30 12:24:17 +02:00
translations@baa28fb3a6 Update git submodules 2022-05-25 13:29:52 +02:00
ucb std::unordered_set->o3tl::sorted_vector in TaskManager 2022-05-23 18:48:25 +02:00
ucbhelper elide some OUString allocation 2022-05-24 13:13:00 +02:00
udkapi
uitest Improve version check 2022-05-17 14:12:58 +02:00
UnoControls Recheck modules [uU]* with IWYU 2022-04-12 15:20:47 +02:00
unodevtools use more string_view in unodevtools 2022-04-28 11:45:30 +02:00
unoidl clang-tidy modernize-pass-by-value in unoidl 2022-05-18 14:45:27 +02:00
unoil
unotest unotest: fix NSS initialization for CentOS7 system NSS 2022-04-29 20:23:02 +02:00
unotools cache ref to GlobalEventConfig 2022-05-23 15:26:12 +02:00
unoxml Extend loplugin:redundantcast to trivial reinterpret_cast from T to itself 2022-05-18 10:52:59 +02:00
ure Provide unoidl-write also for the SDK 2022-02-25 16:46:26 +01:00
uui flatten UUIInteractionHandler 2022-05-21 11:17:44 +02:00
vbahelper Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
vcl tdf#147021 Use std::size() instead SAL_N_ELEMENTS macro 2022-05-30 12:21:52 +02:00
winaccessibility Just use Any ctor instead of makeAny in winaccessibility 2022-05-03 10:07:33 +02:00
wizards ScriptForge - (SF_Calc) FIX CompactUp/Left whan range is 1 row/col 2022-05-16 16:22:55 +02:00
writerfilter sw content controls, date: add DOCX import 2022-05-30 09:36:51 +02:00
writerperfect modernize and improve PropertySetInfo 2022-05-24 14:02:09 +02:00
xmerge
xmlhelp Just use Any ctor instead of makeAny in xmlhelp 2022-05-02 20:02:03 +02:00
xmloff tdf#145178 xmloff: ODF import: fix another bad attribute 2022-05-28 16:47:09 +02:00
xmlreader
xmlscript new loplugin:unnecessary locking 2022-05-20 08:03:27 +02:00
xmlsecurity Use o3tl::make_unsigned in some places 2022-05-24 16:50:03 +02:00
.buckconfig
.buckversion Add build toolchain to upload LibreOffice API to Maven Central 2015-12-03 23:32:11 +00:00
.clang-format clang-format: don't sort using declarations 2020-02-26 09:12:49 +01:00
.editorconfig We have some Objective-C source files, too 2017-12-01 12:59:43 +02:00
.git-blame-ignore-revs
.gitattributes
.gitignore Add mold linker temp files to .gitignore 2022-05-13 15:15:12 +02:00
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview git-review: Use the hostname instead of alias. 2019-05-15 15:13:47 +02:00
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub Fix typo 2020-08-07 17:11:39 +02:00
config_host.mk.in use at least assertions mode if libc++ debug mode is not usable 2022-05-26 07:55:50 +02:00
config_host_lang.mk.in
configure.ac use at least assertions mode if libc++ debug mode is not usable 2022-05-26 07:55:50 +02:00
COPYING Licencing files 2011-01-11 21:49:39 +00:00
COPYING.LGPL
COPYING.MPL Targetted text updates, with seasonable changes before l10n freeze. 2013-12-13 17:00:07 +00:00
download.lst upgrade harfbuzz to 4.3.0 2022-05-24 16:21:28 +02:00
g
hardened_runtime.xcent.in Fix typos 2021-08-16 23:34:24 +02:00
install-sh
install_deps.sh Make some scripts more portable 2021-08-20 12:32:22 +02:00
leak-suppress.txt
Library_merged.mk
lo.xcent Fix typos 2021-08-16 23:34:24 +02:00
logerrit
Makefile.fetch build libtiff 2022-05-20 22:29:00 +02:00
Makefile.gbuild
Makefile.in Drop --with-iwyu option 2022-05-04 16:48:25 +02:00
README.cross Add missing autogen.input entries to README.cross 2020-03-25 16:25:14 +01:00
README.help.md configure: Improve help-options handling 2021-06-22 14:25:51 +02:00
README.md Warn if Visual Studio 2019 version is < 16.10 2022-05-05 17:26:12 +02:00
README.Solaris
Repository.mk Drop unused CT2N extension 2022-04-26 10:08:30 +02:00
RepositoryExternal.mk workdir/UnpackedTarball/libtiff/libtiff/tiff.h is generated 2022-05-24 10:00:04 +02:00
RepositoryFixes.mk WASM more initial bits and pieces 2022-01-19 10:49:40 +01:00
RepositoryModule_build.mk
RepositoryModule_host.mk serialize linking of large libraries only if USE_LD is not set 2022-04-21 14:17:58 +02:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt more tsan suppressions 2022-03-01 14:46:30 +01:00

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.13
    • Build: 11.0 + Xcode 12.5
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 8.0.1 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r19c and SDK 22.6.2
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.