strepsirrhini/office-gobmx
9
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
office-gobmx/include
History
Noel Grandin 08489c211a almost nobody is using the oox::AttributeList::get methods properly 
Most of the call sites just ignore the fact that we are returning an
optional value here.
Which means that when an attribute is missing, they get an empty string
or zero.
And we seem to be fine with that.

So make a plugin that warns about calling value() on a temporay OptValue.

And add a utility method so we don't have to pay the cost of passing
a default value to getString()

The need for this is driven by wanting to change to std::optional, which
will throw an exception if code attempts to read an empty std::optional

Change-Id: Idb0a5ad1eac66b5caa93d6195928bad9e0b2ad70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136283
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-24 10:40:19 +02:00
..
android
animations
apple_remote
avmedia clang-tidy modernize-pass-by-value in avmedia 2022-06-02 17:43:58 +02:00
basegfx basegfx: extend basegfx::B2DHomMatrix::decompose() documentation 2022-06-21 10:37:55 +02:00
basic tdf#149622: also clear return value before calling method from SbxObject::Call 2022-06-20 12:46:27 +02:00
canvas clang-tidy modernize-pass-by-value in canvas 2022-05-21 21:55:31 +02:00
codemaker clang-tidy modernize-pass-by-value in codemaker 2022-05-18 14:08:28 +02:00
com/sun/star/uno optimise Any::operator=(&&) a little 2022-05-20 09:40:38 +02:00
comphelper Use more appropriate type for LocationAccess::nOwnClassVectorIndex 2022-06-02 21:33:17 +02:00
connectivity clang-tidy modernize-pass-by-value in connectivity 2022-06-13 18:11:03 +02:00
cppcanvas
cppu Let loplugin:nullptr look into template instantiations 2022-01-15 15:58:07 +01:00
cppuhelper Add XWeak constructor and operator= to uno::WeakReference 2022-02-22 12:27:55 +01:00
cppunittester
cui clang-tidy modernize-pass-by-value in cui 2022-06-03 15:04:41 +02:00
dbaccess clang-tidy modernize-pass-by-value in dbaccess 2022-06-13 20:37:35 +02:00
desktop
drawinglayer tdf#128150 Implement/add SlideBackgroundFill visualization 2022-06-20 10:36:15 +02:00
editeng tdf#128150 Add OOXML import/export for "use background fill" 2022-06-16 15:44:53 +02:00
embeddedobj tdf#147590 update OLE object after document refresh 2022-05-10 09:02:01 +02:00
filter clang-tidy modernize-pass-by-value in filter 2022-06-01 18:52:21 +02:00
formula clang-tidy modernize-pass-by-value in formula 2022-06-23 09:58:23 +02:00
fpicker tdf#114150: Remove duplication of strings found in file dialogs 2022-03-11 13:10:45 +01:00
framework clang-tidy modernize-pass-by-value in framework 2022-06-02 12:12:15 +02:00
helpcompiler clang-tidy modernize-pass-by-value in helpcompiler 2022-06-21 11:58:12 +02:00
i18nlangtag clang-tidy modernize-pass-by-value in i18nutil 2022-05-19 09:30:40 +02:00
i18npool
i18nutil clang-tidy modernize-pass-by-value in i18nutil 2022-05-19 09:30:40 +02:00
jvmaccess clang-tidy modernize-pass-by-value in jvmaccess 2022-05-23 11:46:13 +02:00
jvmfwk
LibreOfficeKit sw content controls, date: add LOK API 2022-06-01 09:09:40 +02:00
linguistic clang-tidy modernize-pass-by-value in linguistic 2022-05-18 20:56:00 +02:00
o3tl Suppress unhelpful cid#1506515 2022-06-20 10:33:20 +02:00
onlineupdate
oox almost nobody is using the oox::AttributeList::get methods properly 2022-06-24 10:40:19 +02:00
opencl
osl Drop config_global.h from osl/module.h 2022-01-18 19:23:36 +01:00
package loplugin:constmethod 2021-10-01 20:58:11 +02:00
registry [API CHANGE] Deprecate css.registry.XSimpleRegistry::mergeKey 2022-06-11 09:58:49 +02:00
rtl OUStringBuffer: add append via operator<<(T&&) 2022-06-21 13:39:40 +02:00
sal use SAL_UNLIKELY to make logging a little more efficient 2022-06-21 18:23:54 +02:00
salhelper revert part of "loplugin:flatten in filter..include" 2021-12-22 13:54:21 +01:00
sax loplugin:unusedmethods 2022-06-09 12:08:15 +02:00
sfx2 tdf#125040 Make single mode toolbar context aware 2022-06-13 18:47:01 +02:00
sot clang-tidy modernize-pass-by-value in sot 2022-05-30 16:12:34 +02:00
store store: remove useless comments from store 2022-06-20 08:54:08 +02:00
svl SfxStyleSheetBasePool::Find can be const 2022-06-20 14:41:48 +02:00
svtools tdf#149401 show "Restart LibreOffice" dialog changing AutoRecovery 2022-06-23 17:07:00 +02:00
svx tdf#128150 Properly show/hide widgets when "use slide background" is selected 2022-06-24 08:12:25 +02:00
systools/win32 Move BSTR wrapper to systools, and fix some wrong BSTR uses 2022-03-22 22:23:56 +01:00
test Fix some DPI-dependent tests 2022-03-07 12:53:27 +01:00
toolkit GetComponentServiceName can be const 2022-03-05 15:19:15 +01:00
tools Rectangle: split SetSize into SetWidth/SetHeight 2022-06-17 20:41:28 +02:00
typelib [API CHANGE] Deprecate unused typelib_setCacheSize and make it a no-op 2022-05-29 16:42:33 +02:00
ucbhelper simplify construction 2022-05-14 08:41:17 +02:00
uno Remove empty docpp doxygen comments around namespaces 2021-12-17 08:28:45 +01:00
unoidl clang-tidy modernize-pass-by-value in unoidl 2022-05-18 14:45:27 +02:00
unotest Fix the test failing when invalid certificate is in cert store 2022-03-01 15:17:55 +01:00
unotools Revert "Load the locales from config file for languagetool" 2022-06-15 08:27:18 +02:00
vbahelper Just use Any ctor instead of makeAny in vbahelper 2022-05-03 13:35:43 +02:00
vcl Add support for exporting SVGZ in Writer 2022-06-22 14:12:23 +02:00
xmloff tdf#128150 xmloff: ODF import/export of fill-use-slide-background 2022-06-20 10:36:55 +02:00
xmlreader improve the script for reducing symbol exports 2021-12-01 12:13:59 +01:00
xmlscript improve the script for reducing symbol exports 2021-12-01 12:13:59 +01:00
default.rc
IwyuFilter_include.yaml Recheck include/[s-x]* with IWYU 2021-12-24 01:44:48 +01:00
postmac.h
postwin.h
premac.h
prewin.h
version.hrc