Test repository to check push and ssh key
Find a file
Justin Luth b63a12d481 tdf#148540 Revert "tdf#109790 RTF import: keep remembering...
... paragraph style between \cell and \row"
This reverts 5.4.1 commit aaa6a5202a,
and rtfexport7's tdf109790.rtf unit test still passes.
I also did a visual test, which looks good.

After \cell, we normally get more \cells, so an impending
\row is completely unexpected most of the time.
I'm not really sure why that patch was ever thought to be good.

The problem was that \pard was not removing the paragraph style
that was assigned to an earlier column. The end result seemed
innocent (no bad formatting noticed),
but that is probably based on other work
done in the meantime which allows the unit test to still pass
even after all of "its code" has been reverted.

[If this causes a regression, perhaps m_pLastCharacterContext
could be of value?]

Change-Id: Ide9b65f5e5fa39c21bac6d8ed354bb88e0bbefe5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160233
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2023-12-05 08:49:33 +01:00
.git-hooks Revert "Drop allownonascii check from pre-commit checks" 2023-12-02 21:55:33 +01:00
.github
.vscode vscode-ide-integration: add license-header template (snippet) 2023-11-06 13:55:12 +01:00
accessibility tdf#112661 tdf#112662 a11y: Fix toggling button via a11y action 2023-11-02 15:54:24 +01:00
android android: Update Android Gradle Plugin to 8.2.0 2023-12-01 20:34:02 +01:00
animations animations : remove useless use of XComponentContext 2023-09-23 11:29:24 +02:00
apple_remote
avmedia loplugin:stringstatic, lopluign:ostr (clang-cl) 2023-11-08 18:58:40 +01:00
basctl c++20: use std::erase instead of std::removed followed by erase (part 1) 2023-11-18 18:38:01 +01:00
basegfx tdf#157664 Drop operator !=, where respective operator == is defined 2023-11-03 07:48:19 +01:00
basic Extended loplugin:ostr: basic 2023-11-20 09:17:06 +01:00
bean
bin Use "set logging enabled on/off" instead of deprecated "set logging on/off" 2023-11-30 13:47:53 +01:00
binaryurp c++20: use std::erase instead of std::removed followed by erase (part 1) 2023-11-18 18:38:01 +01:00
bridges Extended loplugin:ostr: bridges 2023-11-20 09:40:49 +01:00
canvas Extended loplugin:ostr: canvas 2023-11-20 10:00:14 +01:00
chart2 cid#1546422 COPY_INSTEAD_OF_MOVE 2023-12-04 10:48:59 +01:00
cli_ure
codemaker cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
comphelper Extended loplugin:ostr: comphelper 2023-11-29 23:23:45 +01:00
compilerplugins Extended loplugin:ostr 2023-11-30 14:35:13 +01:00
config_host Re-introduce build config to version info reported by LOK 2023-11-13 10:57:02 +01:00
configmgr Simplify implementation of getTypeByHierarchicalName 2023-11-26 13:19:56 +01:00
connectivity cid#1545810 Using invalid iterator 2023-12-04 20:28:26 +01:00
cppcanvas tdf#157792 followup 2023-10-18 13:38:36 +02:00
cppu cid#1546503 Using invalid iterator 2023-12-03 22:12:17 +01:00
cppuhelper Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: cppuhelper 2023-10-19 14:41:21 +02:00
cpputools loplugin:external -> loplugin:conststringvar -> loplugin:redundantstatic 2023-11-08 22:49:47 +01:00
cui cid#1546021 Using invalid iterator 2023-12-04 19:21:31 +01:00
dbaccess cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
desktop Use "set logging enabled on/off" instead of deprecated "set logging on/off" 2023-11-30 13:47:53 +01:00
dictionaries@fa49c03d49 Update git submodules 2023-11-30 06:46:54 +01:00
distro-configs Update solenv/flatpak-manifest.in 2023-11-25 19:31:25 +01:00
docmodel tdf#146619 Recheck include/d* with IWYU 2023-09-23 07:22:53 +02:00
drawinglayer Split the *Bitmap::CopyPixel functions 2023-12-03 17:39:43 +01:00
editeng cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
embeddedobj Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: embeddedobj 2023-10-19 20:32:23 +02:00
embedserv loplugin:stringstatic, lopluign:ostr (clang-cl) 2023-11-08 18:58:40 +01:00
emfio Extended loplugin:ostr: emfio 2023-11-20 08:25:16 +01:00
eventattacher
extensions Extended loplugin:ostr: extensions 2023-11-20 07:26:11 +01:00
external Upgrade lcms2 to 2.15 2023-12-04 00:05:56 +01:00
extras tdf#158017 Freshes Impress template: color font 2023-12-04 18:50:59 +01:00
filter Split the *Bitmap::CopyPixel functions 2023-12-03 17:39:43 +01:00
forms cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
formula Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]String 2023-10-23 11:04:42 +02:00
fpicker c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 4) 2023-11-18 18:38:36 +01:00
framework cid#1546422 COPY_INSTEAD_OF_MOVE 2023-12-04 10:48:59 +01:00
helpcompiler cid#1546485 COPY_INSTEAD_OF_MOVE 2023-12-04 10:47:42 +01:00
helpcontent2@d20e738f1a Update git submodules 2023-12-04 15:21:59 +01:00
hwpfilter Extended loplugin:ostr: hwpfilter 2023-11-30 09:53:24 +01:00
i18nlangtag Extended loplugin:ostr: i18nlangtag 2023-11-30 09:00:14 +01:00
i18npool cid#1546422 COPY_INSTEAD_OF_MOVE 2023-12-04 10:48:59 +01:00
i18nutil Extended loplugin:ostr: i18nutil 2023-11-29 21:37:25 +01:00
icon-themes tdf#158126 UI: Scalable buttons for Impress navigation bar 2023-11-22 21:20:09 +01:00
idl cid#1545810 Using invalid iterator 2023-12-04 20:28:26 +01:00
idlc/test/parser
include vcl: add unit tests for a mixture of CJK and latin characters 2023-12-05 04:39:05 +01:00
instsetoo_native Missing parenthesis 2023-11-17 09:59:25 +01:00
io
ios
javaunohelper enable unchecked lint for our java code 2023-11-09 14:27:47 +01:00
jurt
jvmaccess
jvmfwk Extended loplugin:ostr: jvmfwk 2023-11-20 07:26:38 +01:00
l10ntools Extended loplugin:ostr: l10ntools 2023-11-30 09:00:00 +01:00
librelogo tdf#157388: LibreLogo sqrt undefined 2023-09-24 13:32:45 +02:00
libreofficekit lok: a11y: implemented support for notifying core log to client 2023-11-11 22:22:52 +01:00
lingucomponent tdf#158117: encode the username sent to LanguageTool 2023-11-23 22:30:29 +01:00
linguistic Extended loplugin:ostr: linguistic 2023-11-20 07:26:24 +01:00
lotuswordpro changed sal_uInt8 to BenError (enum) 2023-10-24 09:41:12 +02:00
m4
msicreator createmsi: retrieve file handle explicitely so we can close it at the end 2023-11-17 17:34:52 +01:00
nlpsolver
o3tl Extended loplugin:ostr: o3tl 2023-11-20 07:27:41 +01:00
odk Cleanup make files for Java/C++ SDK examples 2023-11-21 13:31:36 +01:00
offapi [API CHANGE] Add OOXML way of curved connector routing 2023-12-01 08:44:01 +01:00
officecfg tdf#33201 Checkbox Implementation for Col/row Highlight 2023-12-04 16:22:54 +01:00
onlineupdate
oovbaapi
oox cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
opencl Extended loplugin:ostr: opencl 2023-11-19 22:35:12 +01:00
osx
package tdf#96401: allow to detect a broken ZIP package 2023-11-26 21:04:30 +01:00
pch
postprocess [API CHANGE] Drop unused ScriptRuntimes config set 2023-11-24 15:58:06 +01:00
pyuno Extended loplugin:ostr: pyuno 2023-11-19 20:39:16 +01:00
qadevOOo Disallow crash reporting in UITests 2023-12-04 18:36:43 +01:00
readlicense_oo update credits 2023-11-28 12:56:36 +01:00
registry Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]String 2023-10-23 11:04:42 +02:00
remotebridges
reportbuilder tdf#157716 - Rename "Language settings" to "Languages and Locales" 2023-11-18 16:01:33 +01:00
reportdesign cid#1546021 Using invalid iterator 2023-12-04 19:21:31 +01:00
ridljar enable unchecked lint for our java code 2023-11-09 14:27:47 +01:00
sal Extended loplugin:ostr: sal 2023-11-29 19:38:09 +01:00
salhelper
sax Extended loplugin:ostr: sax 2023-11-29 17:43:08 +01:00
sc cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
scaddins tdf#157716 - Rename "Language settings" to "Languages and Locales" 2023-11-18 16:01:33 +01:00
sccomp Make NC_ constexpr-friendly 2023-10-12 18:17:49 +02:00
schema sw floattable, per-frame wrap-on-all-pages mode: add ODT filter 2023-11-28 09:53:13 +01:00
scp2 On Linux dictionaries are packaged separately 2023-11-11 16:49:26 +01:00
scripting cid#1546422 COPY_INSTEAD_OF_MOVE 2023-12-04 10:48:59 +01:00
sd cid#1545810 Using invalid iterator 2023-12-04 20:28:26 +01:00
sdext cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
setup_native tdf#157716 - Rename "Language settings" to "Languages and Locales" 2023-11-18 16:01:33 +01:00
sfx2 tdf#158404 Start Center: remove ability to do multiselections 2023-12-04 20:16:06 +01:00
shell tdf#146386 deprecate, remove usage of Inet::Settings::ooInetFTPProxyName 2023-11-16 19:15:26 +01:00
slideshow cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
smoketest
solenv move the SfxItemPoolCache to sc/ 2023-12-01 07:16:16 +01:00
soltools cid#1546021 Using invalid iterator 2023-12-04 19:21:31 +01:00
sot Fix typo 2023-11-01 12:52:55 +01:00
starmath cid#1546422 COPY_INSTEAD_OF_MOVE 2023-12-04 10:48:59 +01:00
static expert config: Proper editing support for numbers 2023-11-16 08:03:32 +01:00
stoc cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
store
svgio Extended loplugin:ostr: svgio 2023-11-19 20:37:38 +01:00
svl move the SfxItemPoolCache to sc/ 2023-12-01 07:16:16 +01:00
svtools Always send theme-change in kit-mode even if the global theme is the same 2023-11-28 09:36:08 +01:00
svx Put back the message in assert after b50da6f3a9 2023-12-04 20:28:02 +01:00
sw tdf#148540 Revert "tdf#109790 RTF import: keep remembering... 2023-12-05 08:49:33 +01:00
swext swext: MediaWiki: implement AllowInsecureProtocols 2023-11-09 16:53:55 +01:00
sysui tdf#146386 deprecate, remove usage of Inet::Settings::ooInetFTPProxyName 2023-11-16 19:15:26 +01:00
test tdf#126084 support writing SVG images into OOXML using the MS OOXML extension 2023-12-04 10:33:34 +01:00
testtools 'new Character' is deprecated in Java 2023-11-02 14:47:25 +01:00
toolkit cid#1545597 Using invalid iterator 2023-12-04 22:10:20 +01:00
tools Extended loplugin:ostr: tools 2023-11-29 16:40:53 +01:00
translations@5c0f8a2035 Update git submodules 2023-12-04 17:08:58 +01:00
ucb cid#1545566 COPY_INSTEAD_OF_MOVE 2023-12-04 10:49:13 +01:00
ucbhelper tdf#158321 No error message when file doesn't exist 2023-11-23 12:07:09 +01:00
udkapi Typo in comment "af"->"of" in XReference.idl 2023-10-20 14:03:07 +02:00
uitest uitest: Clean up redundant usage of gb_UITest_use_oneprocess 2023-11-06 09:26:43 +01:00
UnoControls Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]String 2023-10-23 11:04:42 +02:00
unodevtools Extended loplugin:ostr: unodevtools 2023-11-19 17:29:19 +01:00
unoidl Manual extended loplugin:ostr change 2023-11-17 08:12:20 +01:00
unoil
unotest
unotools Prevent attempts to create UCB content from .component URIs 2023-11-28 22:29:03 +01:00
unoxml tdf#158302 fix build against system-libxml-2.12 2023-11-27 16:09:13 +01:00
ure Add a FunctionBasedURPConnection and a websocket URP connector 2023-09-01 16:55:37 +02:00
uui tdf#157518: enforce password policy on setmasterpassworddlg 2023-11-15 22:02:16 +01:00
vbahelper loplugin:fieldcast in VbShapeRangeEnumHelper 2023-11-08 08:17:55 +01:00
vcl Drop own mutex to prevent lock order problem 2023-12-05 05:40:32 +01:00
winaccessibility wina11y: Drop "using namespace css:accessibility::AccessibleRole" 2023-11-14 08:09:25 +01:00
wizards ScriptForge (SF_Dataset) fix GetRows() in chunks 2023-12-01 13:43:45 +01:00
writerfilter tdf#148540 Revert "tdf#109790 RTF import: keep remembering... 2023-12-05 08:49:33 +01:00
writerperfect Extended loplugin:ostr: writerperfect 2023-11-19 15:23:17 +01:00
xmerge
xmlhelp Extended loplugin:ostr: xmlhelp 2023-11-29 19:37:57 +01:00
xmloff cid#1546422 COPY_INSTEAD_OF_MOVE 2023-12-04 10:48:59 +01:00
xmlreader
xmlscript Extended loplugin:ostr: xmlscript 2023-11-19 17:28:56 +01:00
xmlsecurity tdf#158302 fix build against system-libxml-2.12 2023-11-27 16:09:13 +01:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in fix --enable-wix switch - that didn't do anything 2023-11-16 23:32:20 +01:00
config_host_lang.mk.in
configure.ac bump product version to 24.2.0.0.alpha1+ 2023-11-23 13:18:48 +01:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint Add some entries into cpp.hint 2023-10-07 17:20:38 +02:00
download.lst Upgrade lcms2 to 2.15 2023-12-04 00:05:56 +01:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch tdf#157518: external: bundle zxcvbn-c 2023-10-30 08:17:05 +01:00
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md Bump Java build baseline from JDK 9 to 17 2023-10-17 13:45:59 +02:00
README.Solaris
Repository.mk Fix packaging with --disable-curl 2023-11-10 21:38:00 +01:00
RepositoryExternal.mk Fix packaging with --enable-mpl-subset 2023-11-10 21:38:08 +01:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt update tsan-suppress 2023-10-30 17:38:16 +01:00

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 8.5
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.