Test repository to check push and ssh key
Find a file
Mike Kaganski ba0ea7c7fb Refactor impl_packLocalizedProperties
Make it more C++ish.
The change made two functional modifications:

1. It now doesn't filter out non-string values of the localized
properties. Since commit a5649055a0
(INTEGRATION: CWS xmlfilter01 (1.38.18); FILE MERGED, 2003-04-04),
'OUString sLocaleValue' intermediate local variable was used for
values taken from XNameAccess::getByName before storing it to the
Sequence<PropertyValue>. It contradicts the documentation of the
impl_packLocalizedProperties function, created in commit
4bbc40bf5c (#84766# new mode for
locale=*, 2001-04-11), which explicitly tells that the value type
"depends from cfg entry". The commit message of the later commit
is not clear, mentioning some "repair ALLO_LOCALE mode"; but it
likely refers to the change of CONFIG_MODE_ALL_LOCALES check that
was made bitwise, instead of direct ==. I think that sLocaleValue
was used during debugging, to check the value, similar to another
debug variable - sLocaleName - also introduced in that commit; it
was simply erroneously kept in the final patch.

2. When lOutValues has an XInterface, but not XNameContainer, it
now is copied to the out sequence (it was dropped before). Likely
it won't really happen in practice, but the limitation reason was
unclear.

The use of a sequence declared out of the loop, and realloc'd in
the loop, is in fact pessimization, because such a realloc would
need to copy the existing values, only to discard them later.

Change-Id: I726c7dbeae58cbf92b53233ae4eeb3cd070375ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172507
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-08-28 20:52:53 +02:00
.git-hooks
.github
.vscode
accessibility cid#1608497 Double lock 2024-08-27 09:41:17 +02:00
android
animations
apple_remote
avmedia
basctl SbClassModuleObject never take a non-null arg 2024-08-27 09:41:48 +02:00
basegfx Related: ofz#70815 Timeout, don't need this copy 2024-08-18 11:04:35 +02:00
basic SbClassModuleObject never take a non-null arg 2024-08-27 09:41:48 +02:00
bean
bin
binaryurp cid#1557276 COPY_INSTEAD_OF_MOVE 2024-08-20 21:14:18 +02:00
bridges
canvas cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
chart2 tdf#90733 - support invertIfNegative for bar and bubble chart 2024-08-27 09:21:35 +02:00
cli_ure
codemaker Avoid slicing in operator== 2024-08-22 14:39:05 +02:00
comphelper tdf#158556 use more comphelper::ByteReader 2024-08-27 09:10:04 +02:00
compilerplugins cid#1608296 silence Overflowed integer argument 2024-08-25 17:36:28 +02:00
config_host Add a CUPS config header 2024-08-27 07:30:03 +02:00
configmgr Related: tdf#161599 ChildAccess::asValue() must return Reference<XInterface> 2024-08-27 21:09:35 +02:00
connectivity cid#1608296 silence Overflowed integer argument 2024-08-25 17:36:28 +02:00
cppcanvas
cppu cid#1555847 COPY_INSTEAD_OF_MOVE 2024-08-22 22:42:37 +02:00
cppuhelper
cpputools
cui tdf#161805 cui: Populate line tab menus when page gets created 2024-08-27 20:13:19 +02:00
dbaccess cid#1606904 silence Overflowed constant 2024-08-28 13:12:51 +02:00
desktop lok: elide various unhelpful events during background save. 2024-08-28 16:15:16 +02:00
dictionaries@2ae8fab6fe Update git submodules 2024-08-25 13:21:05 +02:00
distro-configs tdf#161941 add --with-docrepair-fonts option 2024-08-25 21:45:06 +02:00
docmodel
drawinglayer tdf#161983 Page background image follows scrolled view 2024-08-28 19:35:30 +02:00
editeng tdf#158556 make SvxAdjustItem hashable 2024-08-24 09:01:29 +02:00
embeddedobj Make OleEmbeddedObject locking stricter 2024-08-22 12:06:43 +02:00
embedserv
emfio cid#1557694 COPY_INSTEAD_OF_MOVE 2024-08-19 15:15:54 +02:00
eventattacher
extensions Simplify a bit 2024-08-21 15:47:26 +02:00
external MSAN: Use-of-uninitialized-value 2024-08-27 16:39:22 +02:00
extras
filter vcl,filter: replace about 5 hard-coded JPEG PDF export qualitys 2024-08-27 17:19:44 +02:00
forms
formula Make help button in FW has a fixed width 2024-08-20 08:35:13 +02:00
fpicker cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
framework cid#1608206 Double lock 2024-08-26 22:39:57 +02:00
helpcompiler cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
helpcontent2@4a27fa4167 Update git submodules 2024-08-28 01:07:14 +02:00
hwpfilter cid#1616925 Unintended sign extension 2024-08-28 13:13:43 +02:00
i18nlangtag tdf#158556 avoid a ton of temporary OUString 2024-08-28 19:35:08 +02:00
i18npool tdf#130924 use SAL_INFO/WARN instead of f/printf 2024-08-22 15:46:36 +02:00
i18nutil Drop newly unused ToggleUnicodeCodepoint::CharsToDelete 2024-08-28 20:52:12 +02:00
icon-themes tdf#162491 tdf#125032 add hyphenation settings to sidebar 2024-08-16 12:35:41 +02:00
idl
idlc/test/parser
include Refactor impl_packLocalizedProperties 2024-08-28 20:52:53 +02:00
instsetoo_native
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit
lingucomponent cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
linguistic cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
lotuswordpro cid#1608296 silence Overflowed integer argument 2024-08-25 17:36:28 +02:00
m4
msicreator
net_ure
nlpsolver
o3tl
odk
offapi tdf#161347 Harmonise API docs for UserDefinedAttributes a bit 2024-08-19 16:02:42 +02:00
officecfg related tdf#68274: switch on MAR-based auto-updater by default 2024-08-26 16:11:45 +02:00
oovbaapi
oox tdf#90733 - support invertIfNegative for bar and bubble chart 2024-08-27 09:21:35 +02:00
opencl
osx
package cid#1618664 Self assignment 2024-08-28 12:16:46 +02:00
pch
postprocess
pyuno
qadevOOo
readlicense_oo
registry
remotebridges
reportbuilder
reportdesign
ridljar
sal cid#1607030 silence Overflowed integer argument 2024-08-16 09:29:51 +02:00
salhelper Do not try to notify, if the thread is already killed 2024-08-20 11:14:01 +02:00
sax
sc cid#1556212 COPY_INSTEAD_OF_MOVE 2024-08-28 14:04:28 +02:00
scaddins
sccomp cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
schema
scp2
scripting cid#1554835 COPY_INSTEAD_OF_MOVE 2024-08-26 16:30:58 +02:00
sd cid#1607037 silence Overflowed constant 2024-08-28 12:17:06 +02:00
sdext
setup_native
sfx2 lok: avoid sending jsdialog messages during background save. 2024-08-28 16:15:09 +02:00
shell
slideshow cid#1555812 COPY_INSTEAD_OF_MOVE 2024-08-21 09:31:36 +02:00
smoketest
solenv Put back the mkdir 2024-08-28 09:07:23 +02:00
soltools
sot tdf#158556 use more comphelper::ByteReader 2024-08-27 09:10:04 +02:00
starmath Related tdf#160226 - Math inline editing Off by default 2024-08-26 10:38:28 +02:00
static +WARN is the default with an unset SAL_LOG env var, anyway 2024-08-26 16:30:12 +02:00
stoc
store
svgio
svl tdf#158556 prevent lambda from allocating on heap 2024-08-27 17:24:44 +02:00
svtools fix(invert): Avoid spurious LOK invalidations 2024-08-28 09:41:18 +02:00
svx Resolves tdf#162582 - Muted color for search info on dark themes 2024-08-27 14:46:31 +02:00
sw tdf#162657: re-check the result of combining surrogates 2024-08-28 20:52:04 +02:00
swext
sysui
test fixed tdf#162471: display comment time in ods if available 2024-08-15 17:14:21 +02:00
testtools
toolkit cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
tools allow an exemption to be made for a specific host 2024-08-23 21:52:26 +02:00
translations@d2facdfc4e Update git submodules 2024-08-23 14:05:44 +02:00
ucb tdf#158556 use more comphelper::ByteReader 2024-08-27 09:10:04 +02:00
ucbhelper cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
udkapi
uitest Related tdf#160226 - Math inline editing Off by default 2024-08-26 10:38:28 +02:00
UnoControls
unodevtools
unoidl cid#1555812 COPY_INSTEAD_OF_MOVE 2024-08-21 09:31:36 +02:00
unoil
unotest 'use strict' is of no use here... 2024-08-26 16:29:28 +02:00
unotools Refactor impl_packLocalizedProperties 2024-08-28 20:52:53 +02:00
unoxml
ure
uui
vbahelper
vcl tdf#127610 subtract width of shortcuts from width available for tab items 2024-08-28 15:23:19 +02:00
winaccessibility tdf#91739 wina11y: Implement IAccessible2_2::get_relationTargetsOfType 2024-08-23 07:40:17 +02:00
wizards cid#1608542 PA: Public Attribute 2024-08-26 15:02:22 +02:00
writerperfect
xmerge
xmlhelp
xmloff cid#1606710 Overflowed constant 2024-08-28 13:13:22 +02:00
xmlreader
xmlscript
xmlsecurity Fix the test failing when invalid certificate is in cert store 2024-08-15 16:24:15 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in tdf#161941 add --with-docrepair-fonts option 2024-08-25 21:45:06 +02:00
config_host_lang.mk.in
configure.ac Add a CUPS config header 2024-08-27 07:30:03 +02:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint
download.lst tdf#162589: Revert "nss: 3.101.2 is the ESR release" 2024-08-28 15:01:32 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md
README.Solaris
Repository.mk tdf#161941 add --with-docrepair-fonts option 2024-08-25 21:45:06 +02:00
RepositoryExternal.mk Add a CUPS config header 2024-08-27 07:30:03 +02:00
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.