Test repository to check push and ssh key
Find a file
Miklos Vajna caff013bee cool#9992 lok doc sign: async DocumentDigitalSignatures::signDocumentContent()
Currently SfxObjectShell::CheckIsReadonly() has a hack for the LOK case
to show the signatures dialog read-only, as only that is async.

The next step is to make
DocumentDigitalSignatures::signDocumentContent() async, but passing an
std::function via the UNO API is tricky.

Notice how DocumentDigitalSignatures in xmlsecurity/ also implements
sfx2::DigitalSignatures, add a new SignDocumentContentAsync() there and
adapt all uses of signDocumentContent() to go with that instead.

This requires introducing some lambdas for code after
signDocumentContent() in general and for ODF/OOXML specific code in
particular, to avoid code duplication.

Change-Id: If771ced711041364988af45ad9dd0dd1a2a8660d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173060
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-09 17:30:28 +02:00
.git-hooks Revert "Drop allownonascii check from pre-commit checks" 2023-12-02 21:55:33 +01:00
.github
.vscode
accessibility use less dynamic_cast when broadcasting SfxHint 2024-09-05 08:10:26 +02:00
android android-viewer translated using Weblate 2024-08-14 17:52:09 +02:00
animations loplugin:ostr avmedia 2024-05-06 15:14:09 +02:00
apple_remote Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
avmedia tdf#158510 Added fallback for media files in MediaWindowImpl 2024-08-14 00:19:23 +02:00
basctl cool#9992 lok doc sign: make SfxMedium::SignContents_Impl() async 2024-09-06 12:25:48 +02:00
basegfx ImplB2DPolygon could do with a move constructor 2024-09-01 15:19:01 +02:00
basic use less dynamic_cast when broadcasting SfxHint 2024-09-05 08:10:26 +02:00
bean
bin tdf#161826 - Add uniform Glow effect for texts in shapes 2024-08-29 19:59:24 +02:00
binaryurp cid#1557276 COPY_INSTEAD_OF_MOVE 2024-08-20 21:14:18 +02:00
bridges tdf#160945: queryInterface must pass back indirect return value address in x0 2024-09-03 14:21:55 +02:00
canvas cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
chart2 tdf#90733 - support invertIfNegative for bar and bubble chart 2024-08-27 09:21:35 +02:00
cli_ure Only use -Wv:18 in Visual Studio 2019 2024-07-01 11:02:37 +02:00
codemaker Avoid slicing in operator== 2024-08-22 14:39:05 +02:00
comphelper tsan:lock-order-inversion in forms 2024-09-09 16:08:42 +02:00
compilerplugins drop unused eventtesting cmd line option 2024-09-06 12:25:32 +02:00
config_host Add a CUPS config header 2024-08-27 07:30:03 +02:00
configmgr Related: tdf#161599 ChildAccess::asValue() must return Reference<XInterface> 2024-08-27 21:09:35 +02:00
connectivity tdf#155751: dBase: BETWEEN won't include first and last value in queries 2024-09-08 12:53:52 +02:00
cppcanvas cid#1608541 bogus Overflowed constant 2024-08-11 18:20:20 +02:00
cppu cid#1555847 COPY_INSTEAD_OF_MOVE 2024-08-22 22:42:37 +02:00
cppuhelper throw more useful exception from OPropertySetHelper::getPropertyValue 2024-09-05 13:51:34 +02:00
cpputools loplugin:ostr in various 2024-05-20 22:09:56 +02:00
cui cid#1619147 Dereference before null check 2024-09-07 22:43:32 +02:00
dbaccess tdf#162833: don't use an OUStringBuffer directly in a concat to assign itself 2024-09-07 21:48:38 +02:00
desktop drop unused eventtesting cmd line option 2024-09-06 12:25:32 +02:00
dictionaries@2ae8fab6fe Update git submodules 2024-08-25 13:21:05 +02:00
distro-configs tdf#161941 add --with-docrepair-fonts option 2024-08-25 21:45:06 +02:00
docmodel cid#1554709 COPY_INSTEAD_OF_MOVE 2024-07-16 15:13:41 +02:00
drawinglayer drawinglayer: getHeight() -> getWidth() 2024-09-05 20:06:21 +02:00
editeng tdf#162803 editeng: Fix invalid kashida array after layout 2024-09-09 15:43:42 +02:00
embeddedobj Avoid deadlock 2024-09-04 16:56:07 +02:00
embedserv Simplify a bit 2024-06-16 08:59:33 +02:00
emfio drawinglayer: getHeight() -> getWidth() 2024-09-05 20:06:21 +02:00
eventattacher loplugin:ostr in various 2024-05-20 22:09:56 +02:00
extensions tsan:lock-order-inversion in forms 2024-09-09 16:08:42 +02:00
external lok: add SAL_DISABLE_FSYNC environment to disable fsync. 2024-09-07 11:15:47 +02:00
extras Update Freshes Impress template 2024-09-08 19:19:53 +02:00
filter tdf#162782 SVG export: fix handling of semi-transparent text inside a list 2024-09-04 16:07:34 +02:00
forms tsan:lock-order-inversion in forms 2024-09-09 16:08:42 +02:00
formula tdf#161543 Enhance the searching functionality in FD & FW 2024-09-03 09:59:16 +02:00
fpicker cid#1606757 Overflowed constant 2024-08-30 12:37:11 +02:00
framework cid#1608206 Double lock 2024-08-26 22:39:57 +02:00
helpcompiler cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
helpcontent2@d1c125b79b Update git submodules 2024-09-08 13:40:15 +02:00
hwpfilter cid#1616925 Unintended sign extension 2024-08-28 13:13:43 +02:00
i18nlangtag tdf#158556 avoid a ton of temporary OUString 2024-08-28 19:35:08 +02:00
i18npool tdf#130924 use SAL_INFO/WARN instead of f/printf 2024-08-22 15:46:36 +02:00
i18nutil Drop newly unused ToggleUnicodeCodepoint::CharsToDelete 2024-08-28 20:52:12 +02:00
icon-themes Resolves tdf#162732 - Donate label not vertical centered 2024-09-03 15:17:22 +02:00
idl cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
idlc/test/parser
include cool#9992 lok doc sign: async DocumentDigitalSignatures::signDocumentContent() 2024-09-09 17:30:28 +02:00
instsetoo_native Emscripten: Support --disable-gui 2024-08-28 23:02:51 +02:00
io loplugin:ostr in io 2024-05-09 12:48:17 +02:00
ios
javaunohelper loplugin:ostr in javaunohelper 2024-05-09 17:59:45 +02:00
jurt makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
jvmaccess Fix typo 2024-07-24 22:36:07 +02:00
jvmfwk Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
l10ntools tdf#145538 Use range based for loops 2024-07-22 17:59:03 +02:00
librelogo cui, dbaccess, desktop, external, filter, librelogo: fix issues found by 2024-07-27 12:51:55 +02:00
libreofficekit cid#1558088 COPY_INSTEAD_OF_MOVE 2024-08-11 20:14:54 +02:00
lingucomponent cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
linguistic cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
lotuswordpro cid#1608296 silence Overflowed integer argument 2024-08-25 17:36:28 +02:00
m4
msicreator comphelper, msicreator, odk: fix issues found by Ruff linter 2024-07-27 15:42:26 +02:00
net_ure .NET Bindings: Fix netmaker and net_basetypes 2024-08-14 13:14:01 +02:00
nlpsolver Double values comparison changed to compare method. 2024-04-29 15:40:27 +02:00
o3tl tsan: fix data race in o3tl::cow_wrapper 2024-07-09 20:12:54 +02:00
odk No LibreOfficeKit headers and examples for macOS 2024-08-03 10:04:51 +02:00
offapi cool#9992 lok doc sign: async DocumentDigitalSignatures::signDocumentContent() 2024-09-09 17:30:28 +02:00
officecfg Move mnemonic to logical, unique place 2024-09-07 08:20:05 +02:00
oovbaapi Fix VBA Table's *Padding properties type 2024-06-29 22:47:38 +02:00
oox tdf#161826 - Add uniform Glow effect for texts in shapes 2024-08-29 19:59:24 +02:00
opencl workaround segfault in compiler on macos-clang-intel 2024-07-25 15:03:36 +02:00
osx
package Use unique_ptr to pass ownership of ZipEntry 2024-09-07 17:11:48 +02:00
pch
postprocess loplugin:ostr in various 2024-05-20 22:09:56 +02:00
pyuno pyuno,unotest,xmlsecurity: copy GPG test files for UITtest 2024-08-01 11:18:30 +02:00
qadevOOo cid#1606535 PA: Public Attribute 2024-07-08 20:37:59 +02:00
readlicense_oo update credits 2024-09-09 12:16:46 +02:00
registry loplugin:ostr in various 2024-05-20 22:09:56 +02:00
remotebridges loplugin:ostr in various 2024-05-20 22:09:56 +02:00
reportbuilder cid#1608462 XML external entity processing enabled 2024-08-04 20:05:02 +02:00
reportdesign tsan:lock-order-inversion in forms 2024-09-09 16:08:42 +02:00
ridljar makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
sal lok: add SAL_DISABLE_FSYNC environment to disable fsync. 2024-09-07 11:15:47 +02:00
salhelper Do not try to notify, if the thread is already killed 2024-08-20 11:14:01 +02:00
sax Fix "lets" -> "let's" 2024-07-19 14:40:23 +02:00
sc sc: make SelectRange dialog async 2024-09-09 15:16:22 +02:00
scaddins loplugin:ostr in various 2024-05-20 22:09:56 +02:00
sccomp cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
schema Related: tdf#161826 - Add uniform Glow effect for texts in shapes 2024-09-03 22:52:53 +02:00
scp2 scp2: simplifiy language snippet creation rules 2024-09-02 21:16:10 +02:00
scripting cid#1608218 silence Overflowed return value 2024-09-02 21:14:37 +02:00
sd sd: fix deref before null check 2024-09-07 21:51:28 +02:00
sdext tdf#101611, tdf#108813, tdf#86211, sdext,pdfimport: Clip fills 2024-08-29 14:29:47 +02:00
setup_native makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo) 2024-05-03 16:06:14 +02:00
sfx2 cool#9992 lok doc sign: async DocumentDigitalSignatures::signDocumentContent() 2024-09-09 17:30:28 +02:00
shell Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
slideshow cid#1555812 COPY_INSTEAD_OF_MOVE 2024-08-21 09:31:36 +02:00
smoketest cid#1555415 COPY_INSTEAD_OF_MOVE 2024-08-06 09:13:52 +02:00
solenv Emscripten: Move -sEXPORT_EXCEPTION_HANDLING_HELPERS to gb_LinkTarget_LDFLAGS 2024-09-03 21:04:51 +02:00
soltools Drop C/C++ DEBUG macro 2024-03-21 16:30:59 +01:00
sot tdf#158556 use more comphelper::ByteReader 2024-08-27 09:10:04 +02:00
starmath Related tdf#160226 - Math inline editing Off by default 2024-08-26 10:38:28 +02:00
static Explicitly .delete() one more interface object in uno.js 2024-09-02 10:57:36 +02:00
stoc cid#1557980 COPY_INSTEAD_OF_MOVE 2024-08-14 09:27:19 +02:00
store cid#1608100 silence Overflowed array index read 2024-08-12 20:52:11 +02:00
svgio Fix wrong / misleading uses of fTools::(more|less|equal) with literal 0 2024-08-02 11:31:00 +02:00
svl Deduplicate some code 2024-09-06 09:36:43 +02:00
svtools Resolves: tdf#162113 prefer restoring explicit font style selection 2024-09-09 16:07:58 +02:00
svx tsan:lock-order-inversion in forms 2024-09-09 16:08:42 +02:00
sw sw: remove long commented out code 2024-09-09 16:51:30 +02:00
swext makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo) 2024-05-06 11:40:45 +02:00
sysui Remove duplicate vnd.stardivision.writer-global MimeType 2024-06-25 16:20:06 +02:00
test fixed tdf#162471: display comment time in ods if available 2024-08-15 17:14:21 +02:00
testtools testtools, wizards, xmlsecurity: fix issues found by Ruff linter 2024-07-29 16:56:57 +02:00
toolkit cid#1557699 COPY_INSTEAD_OF_MOVE 2024-08-18 11:04:45 +02:00
tools ofz#70815 optimize this a little 2024-09-01 12:11:53 +02:00
translations@fdf5842af4 Update git submodules 2024-09-06 21:45:06 +02:00
ucb tdf#158556 use more comphelper::ByteReader 2024-08-27 09:10:04 +02:00
ucbhelper cid#1557618 COPY_INSTEAD_OF_MOVE 2024-08-16 09:30:37 +02:00
udkapi Move org.libreoffice.embindtest from udkapi to offapi 2024-04-11 15:22:40 +02:00
uitest Related tdf#160226 - Math inline editing Off by default 2024-08-26 10:38:28 +02:00
UnoControls loplugin:ostr in various 2024-05-20 22:09:56 +02:00
unodevtools Remove now unneeded osl/diagnose.h 2024-07-20 10:20:31 +02:00
unoidl cid#1555812 COPY_INSTEAD_OF_MOVE 2024-08-21 09:31:36 +02:00
unoil .NET Bindings: Switch for old windows CLI bindings 2024-06-22 00:11:16 +02:00
unotest 'use strict' is of no use here... 2024-08-26 16:29:28 +02:00
unotools tdf#161543 Enhance the searching functionality in FD & FW 2024-09-03 09:59:16 +02:00
unoxml unoxml: port checkCVE_2012_0037 from java to CppUnittest 2024-07-03 19:10:49 +02:00
ure
uui cool#9956 uui lok: avoid showing the password dialog for now 2024-09-03 11:28:13 +02:00
vbahelper use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
vcl sc: make SelectRange dialog async 2024-09-09 15:16:22 +02:00
winaccessibility wina11y: Drop unused default params for AccObject ctor 2024-08-30 21:05:20 +02:00
wizards Fix typo 2024-09-09 08:40:45 +02:00
writerperfect use less exception throwing for flow control 2024-08-13 19:36:37 +02:00
xmerge cid#1616070 XML external entity processing enabled 2024-08-09 10:52:57 +02:00
xmlhelp O[U]String overloads that return view for rest parameter 2024-07-25 13:29:11 +02:00
xmloff xmloff: fix deref before null check 2024-09-07 21:50:12 +02:00
xmlreader loplugin:ostr in various 2024-05-20 22:09:56 +02:00
xmlscript BootstrapFixture: get rid of mxComponentContext 2024-07-02 15:35:00 +02:00
xmlsecurity cool#9992 lok doc sign: async DocumentDigitalSignatures::signDocumentContent() 2024-09-09 17:30:28 +02:00
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile Upgrade .gitpod.dockerfile to Ubuntu focal 2021-05-22 19:35:47 +02:00
.gitpod.yml
.gitreview
antivirusDetection.vbs tdf#84553 Correctly handle failures while getting a WMI Object. 2020-02-12 09:14:03 +01:00
autogen.sh Add a note about autogen.input into autogen.sh --help output 2024-07-13 22:18:14 +02:00
BUCK
config.guess
config.sub Update config.guess & .sub to latest 2022-12-12 15:46:46 +00:00
config_host.mk.in tdf#161941 add --with-docrepair-fonts option 2024-08-25 21:45:06 +02:00
config_host_lang.mk.in
configure.ac python: upgrade to 3.10.15 2024-09-07 16:33:18 +02:00
COPYING
COPYING.LGPL Licencing files 2011-01-11 21:49:39 +00:00
COPYING.MPL
cpp.hint sw: remove unused DECLARE_RTFEXPORT_TEST() 2024-06-06 09:58:39 +02:00
download.lst python: upgrade to 3.10.15 2024-09-07 16:33:18 +02:00
g
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
logerrit When no branch is specified, fallback to the tracked branch first 2024-04-11 14:08:29 +02:00
Makefile.fetch Bundle fonts of Google's DocRepair Project 2024-07-05 15:37:11 +02:00
Makefile.gbuild use gb_StaticLibrary_WORKDIR and gb_Library_DLLDIR more consistently 2024-06-19 20:00:39 +02:00
Makefile.in .NET Bindings: Add DotnetTest class to gbuild 2024-08-03 12:07:11 +02:00
README.cross Add missing autogen.input entries to README.cross 2020-03-25 16:25:14 +01:00
README.help.md
README.md README.md: add Python baseline 2024-06-13 21:28:53 +02:00
README.Solaris
Repository.mk Fix Repository.mk after 'add --with-docrepair-fonts option' (tdf#161941) 2024-08-29 11:54:13 +02:00
RepositoryExternal.mk Add a CUPS config header 2024-08-27 07:30:03 +02:00
RepositoryFixes.mk Experimental support for latest Emscripten (and Qt6) 2024-01-29 19:51:57 +01:00
RepositoryModule_build.mk .NET Bindings: Add DotnetLibrary class to gbuild 2024-06-12 18:48:07 +02:00
RepositoryModule_host.mk .NET Bindings: Add DotnetLibrary class to gbuild 2024-06-12 18:48:07 +02:00
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER Make it clear that the text is in addition to the previous 2021-01-27 08:02:35 +01:00
tsan-suppress.txt update tsan suppressions 2024-07-11 13:04:30 +02:00

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 8 or CentOS 8 and comparable
    • Build: either GCC 12; or Clang 12 with libstdc++ 10
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 17 or later.

The baseline for Python is version 3.11. It follows the version available in SUSE Linux Enterprise Desktop and the Maintenance Support version of Red Hat Enterprise Linux.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.