6a7e1abd10
Implement QtInstanceWidget::get_preferred_size by returning the
size of the QWidget::sizeHint property [1]:
> This property holds the recommended size for the widget
With this in place, opening the "Help" -> "About LibreOfficeDev"
dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list
of .ui files in QtInstanceBuilder::IsUIFileSupported now triggers
the assert in QtInstanceImage::set_image because that's no implemented
yet, while this was not reached at all before, because
const tools::Long nWidth(m_pCopyrightLabel->get_preferred_size().getWidth());
at the beginning of AboutDialog::AboutDialog would previously
set a preferred width of 0, and with that, there was no attempt to
set the images at all.
[1] https://doc.qt.io/qt-6/qwidget.html#sizeHint-prop
Change-Id: I6eaedf07f73ea5e71a36d3e9bc9a0f55e515ffe7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175665
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
450 lines
12 KiB
C++
450 lines
12 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <QtInstanceWidget.hxx>
|
|
|
|
#include <vcl/transfer.hxx>
|
|
#include <vcl/qt/QtUtils.hxx>
|
|
|
|
/** Name of QObject property used for the help ID. */
|
|
const char* const PROPERTY_HELP_ID = "help-id";
|
|
|
|
QtInstanceWidget::QtInstanceWidget(QWidget* pWidget)
|
|
: m_pWidget(pWidget)
|
|
{
|
|
assert(pWidget);
|
|
}
|
|
|
|
void QtInstanceWidget::set_sensitive(bool bSensitive)
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
rQtInstance.RunInMainThread([&] { set_sensitive(bSensitive); });
|
|
return;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
m_pWidget->setEnabled(bSensitive);
|
|
}
|
|
|
|
bool QtInstanceWidget::get_sensitive() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
bool bSensitive = false;
|
|
rQtInstance.RunInMainThread([&] { bSensitive = get_sensitive(); });
|
|
return bSensitive;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
return m_pWidget->isEnabled();
|
|
}
|
|
|
|
bool QtInstanceWidget::get_visible() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
bool bVisible = false;
|
|
rQtInstance.RunInMainThread([&] { bVisible = get_visible(); });
|
|
return bVisible;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
return m_pWidget->isVisible();
|
|
}
|
|
|
|
bool QtInstanceWidget::is_visible() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
bool bVisible = false;
|
|
rQtInstance.RunInMainThread([&] { bVisible = is_visible(); });
|
|
return bVisible;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
|
|
QWidget* pTopLevel = m_pWidget->topLevelWidget();
|
|
assert(pTopLevel);
|
|
return m_pWidget->isVisibleTo(pTopLevel) && pTopLevel->isVisible();
|
|
}
|
|
|
|
void QtInstanceWidget::set_can_focus(bool bCanFocus)
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
rQtInstance.RunInMainThread([&] { set_can_focus(bCanFocus); });
|
|
return;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
if (bCanFocus)
|
|
m_pWidget->setFocusPolicy(Qt::FocusPolicy::StrongFocus);
|
|
else
|
|
m_pWidget->setFocusPolicy(Qt::FocusPolicy::NoFocus);
|
|
}
|
|
|
|
void QtInstanceWidget::grab_focus()
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
rQtInstance.RunInMainThread([&] { grab_focus(); });
|
|
return;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
m_pWidget->setFocus();
|
|
}
|
|
|
|
bool QtInstanceWidget::has_focus() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
bool bFocus = false;
|
|
rQtInstance.RunInMainThread([&] { bFocus = has_focus(); });
|
|
return bFocus;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
return m_pWidget->hasFocus();
|
|
}
|
|
|
|
bool QtInstanceWidget::is_active() const { return has_focus(); }
|
|
|
|
bool QtInstanceWidget::has_child_focus() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
bool bChildFocus = false;
|
|
rQtInstance.RunInMainThread([&] { bChildFocus = has_child_focus(); });
|
|
return bChildFocus;
|
|
}
|
|
|
|
QWidget* pFocusWidget = QApplication::focusWidget();
|
|
if (!pFocusWidget)
|
|
return false;
|
|
|
|
QWidget* pParent = pFocusWidget->parentWidget();
|
|
while (pParent)
|
|
{
|
|
if (pParent == m_pWidget)
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
void QtInstanceWidget::show()
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
rQtInstance.RunInMainThread([&] { show(); });
|
|
return;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
m_pWidget->show();
|
|
}
|
|
|
|
void QtInstanceWidget::hide()
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
rQtInstance.RunInMainThread([&] { hide(); });
|
|
return;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
m_pWidget->hide();
|
|
}
|
|
|
|
void QtInstanceWidget::set_size_request(int, int) {}
|
|
|
|
Size QtInstanceWidget::get_size_request() const { return Size(); }
|
|
|
|
Size QtInstanceWidget::get_preferred_size() const
|
|
{
|
|
SolarMutexGuard g;
|
|
|
|
Size aPreferredSize;
|
|
GetQtInstance().RunInMainThread([&] { aPreferredSize = toSize(m_pWidget->sizeHint()); });
|
|
|
|
return aPreferredSize;
|
|
}
|
|
|
|
float QtInstanceWidget::get_approximate_digit_width() const { return 1.0; }
|
|
|
|
int QtInstanceWidget::get_text_height() const { return 1; }
|
|
|
|
Size QtInstanceWidget::get_pixel_size(const OUString&) const { return Size(); }
|
|
|
|
vcl::Font QtInstanceWidget::get_font() { return vcl::Font(); }
|
|
|
|
OUString QtInstanceWidget::get_buildable_name() const { return OUString(); }
|
|
|
|
void QtInstanceWidget::set_buildable_name(const OUString&) {}
|
|
|
|
void QtInstanceWidget::setHelpId(QWidget& rWidget, const OUString& rHelpId)
|
|
{
|
|
SolarMutexGuard g;
|
|
GetQtInstance().RunInMainThread(
|
|
[&] { rWidget.setProperty(PROPERTY_HELP_ID, toQString(rHelpId)); });
|
|
}
|
|
|
|
void QtInstanceWidget::set_help_id(const OUString& rHelpId) { setHelpId(*m_pWidget, rHelpId); }
|
|
|
|
OUString QtInstanceWidget::get_help_id() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
OUString sHelpId;
|
|
rQtInstance.RunInMainThread([&] { sHelpId = get_help_id(); });
|
|
return sHelpId;
|
|
}
|
|
|
|
const QVariant aHelpIdVariant = m_pWidget->property(PROPERTY_HELP_ID);
|
|
if (!aHelpIdVariant.isValid())
|
|
return OUString();
|
|
|
|
assert(aHelpIdVariant.canConvert<QString>());
|
|
return toOUString(aHelpIdVariant.toString());
|
|
}
|
|
|
|
void QtInstanceWidget::set_grid_left_attach(int) {}
|
|
|
|
int QtInstanceWidget::get_grid_left_attach() const { return 1; }
|
|
|
|
void QtInstanceWidget::set_grid_width(int) {}
|
|
|
|
void QtInstanceWidget::set_grid_top_attach(int) {}
|
|
|
|
int QtInstanceWidget::get_grid_top_attach() const { return 1; }
|
|
|
|
void QtInstanceWidget::set_hexpand(bool) {}
|
|
|
|
bool QtInstanceWidget::get_hexpand() const { return true; }
|
|
|
|
void QtInstanceWidget::set_vexpand(bool) {}
|
|
|
|
bool QtInstanceWidget::get_vexpand() const { return true; }
|
|
|
|
void QtInstanceWidget::set_margin_top(int) {}
|
|
|
|
void QtInstanceWidget::set_margin_bottom(int) {}
|
|
|
|
void QtInstanceWidget::set_margin_start(int) {}
|
|
|
|
void QtInstanceWidget::set_margin_end(int) {}
|
|
|
|
int QtInstanceWidget::get_margin_top() const { return 1; }
|
|
|
|
int QtInstanceWidget::get_margin_bottom() const { return 1; }
|
|
|
|
int QtInstanceWidget::get_margin_start() const { return 1; }
|
|
|
|
int QtInstanceWidget::get_margin_end() const { return 1; }
|
|
|
|
void QtInstanceWidget::set_accessible_name(const OUString& rName)
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
rQtInstance.RunInMainThread([&] { set_accessible_name(rName); });
|
|
return;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
m_pWidget->setAccessibleName(toQString(rName));
|
|
}
|
|
|
|
void QtInstanceWidget::set_accessible_description(const OUString& rDescription)
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
rQtInstance.RunInMainThread([&] { set_accessible_description(rDescription); });
|
|
return;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
m_pWidget->setAccessibleDescription(toQString(rDescription));
|
|
}
|
|
|
|
OUString QtInstanceWidget::get_accessible_name() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
OUString sName;
|
|
rQtInstance.RunInMainThread([&] { sName = get_accessible_name(); });
|
|
return sName;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
return toOUString(m_pWidget->accessibleName());
|
|
}
|
|
|
|
OUString QtInstanceWidget::get_accessible_description() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
OUString sDescription;
|
|
rQtInstance.RunInMainThread([&] { sDescription = get_accessible_description(); });
|
|
return sDescription;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
return toOUString(m_pWidget->accessibleDescription());
|
|
}
|
|
|
|
OUString QtInstanceWidget::get_accessible_id() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
OUString sId;
|
|
rQtInstance.RunInMainThread([&] { sId = get_accessible_id(); });
|
|
return sId;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
#if QT_VERSION >= QT_VERSION_CHECK(6, 9, 0)
|
|
return toOUString(m_pWidget->accessibleIdentifier());
|
|
#else
|
|
return OUString();
|
|
#endif
|
|
}
|
|
|
|
void QtInstanceWidget::set_accessible_relation_labeled_by(weld::Widget*) {}
|
|
|
|
void QtInstanceWidget::set_tooltip_text(const OUString& rTip)
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
rQtInstance.RunInMainThread([&] { set_tooltip_text(rTip); });
|
|
return;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
m_pWidget->setToolTip(toQString(rTip));
|
|
}
|
|
|
|
OUString QtInstanceWidget::get_tooltip_text() const
|
|
{
|
|
SolarMutexGuard g;
|
|
QtInstance& rQtInstance = GetQtInstance();
|
|
if (!rQtInstance.IsMainThread())
|
|
{
|
|
OUString sToolTipText;
|
|
rQtInstance.RunInMainThread([&] { sToolTipText = get_tooltip_text(); });
|
|
return sToolTipText;
|
|
}
|
|
|
|
assert(m_pWidget);
|
|
return toOUString(m_pWidget->toolTip());
|
|
}
|
|
|
|
void QtInstanceWidget::set_cursor_data(void*) {}
|
|
|
|
void QtInstanceWidget::grab_add() {}
|
|
|
|
bool QtInstanceWidget::has_grab() const { return true; }
|
|
|
|
void QtInstanceWidget::grab_remove() {}
|
|
|
|
bool QtInstanceWidget::get_extents_relative_to(const Widget&, int&, int&, int&, int&) const
|
|
{
|
|
return true;
|
|
}
|
|
|
|
bool QtInstanceWidget::get_direction() const { return true; }
|
|
|
|
void QtInstanceWidget::set_direction(bool) {}
|
|
|
|
void QtInstanceWidget::freeze() {}
|
|
|
|
void QtInstanceWidget::thaw() {}
|
|
|
|
void QtInstanceWidget::set_busy_cursor(bool) {}
|
|
|
|
std::unique_ptr<weld::Container> QtInstanceWidget::weld_parent() const { return nullptr; }
|
|
|
|
void QtInstanceWidget::queue_resize() {}
|
|
|
|
void QtInstanceWidget::help_hierarchy_foreach(const std::function<bool(const OUString&)>&) {}
|
|
|
|
OUString QtInstanceWidget::strip_mnemonic(const OUString&) const { return OUString(); }
|
|
|
|
OUString QtInstanceWidget::escape_ui_str(const OUString& rLabel) const
|
|
{
|
|
// preserve literal '&'
|
|
return rLabel.replaceAll("&", "&&");
|
|
}
|
|
|
|
VclPtr<VirtualDevice> QtInstanceWidget::create_virtual_device() const { return nullptr; }
|
|
|
|
css::uno::Reference<css::datatransfer::dnd::XDropTarget> QtInstanceWidget::get_drop_target()
|
|
{
|
|
return css::uno::Reference<css::datatransfer::dnd::XDropTarget>();
|
|
}
|
|
|
|
css::uno::Reference<css::datatransfer::clipboard::XClipboard>
|
|
QtInstanceWidget::get_clipboard() const
|
|
{
|
|
return GetSystemClipboard();
|
|
}
|
|
|
|
void QtInstanceWidget::connect_get_property_tree(const Link<tools::JsonWriter&, void>&) {}
|
|
|
|
void QtInstanceWidget::get_property_tree(tools::JsonWriter&) {}
|
|
|
|
void QtInstanceWidget::call_attention_to() {}
|
|
|
|
void QtInstanceWidget::set_stack_background() {}
|
|
|
|
void QtInstanceWidget::set_title_background() {}
|
|
|
|
void QtInstanceWidget::set_toolbar_background() {}
|
|
|
|
void QtInstanceWidget::set_highlight_background() {}
|
|
|
|
void QtInstanceWidget::set_background(const Color&) {}
|
|
|
|
void QtInstanceWidget::draw(OutputDevice&, const Point&, const Size&) {}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|