Test repository to check push and ssh key
Find a file
Caolán McNamara ee03f6453e cid#1521509 Logically dead code
and

cid#1521507 Logically dead code

Change-Id: I1d2c9ee4a4099fadb5da7a6850b4124488e2ebe8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147687
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-26 14:51:38 +00:00
.git-hooks
.github
.vscode
accessibility
android android: Update com.google.android.material to 1.8.0 2023-02-17 12:06:49 +00:00
animations
apple_remote
avmedia
basctl tdf#146518 Implement commands to toggle Watch/Stack windows 2023-02-23 12:34:21 +00:00
basegfx MCGR: Adapted GradientRadial to make use of MCGR 2023-02-24 16:22:36 +00:00
basic BaseMutex->std::mutex in SfxLibrary 2023-02-24 19:40:10 +00:00
bean
bin
binaryurp
bridges android: Switch from GNU binutils to support NDK 23.x, require 21.x 2023-02-16 20:31:39 +00:00
canvas BaseMutex->std::mutex in vclcanvas::TextLayout 2023-02-24 19:39:59 +00:00
chart2 tdf#153533 Fix chart2_import test failure on HiDPI display 2023-02-24 22:58:08 +00:00
cli_ure
codemaker
comphelper create new OPropertyChangeListener2 and use it in FmFieldWin 2023-02-22 12:43:55 +00:00
compilerplugins Extend loplugin:cppunitassertequals to more argument types 2023-02-23 07:04:09 +00:00
config_host
configmgr unlock during dispose in configmgr::configuration_provider::Service 2023-02-23 12:13:42 +00:00
connectivity osl::Mutex->std::mutex in OSQLParseNodesContainer 2023-02-22 09:16:10 +00:00
cppcanvas
cppu
cppuhelper
cpputools
cui Missing ":" for "Background color" option in Area/Hatch 2023-02-26 14:17:29 +00:00
dbaccess Fix build in a specific VS2022 environment 2023-02-24 17:05:49 +00:00
desktop Remove duplicated include 2023-02-25 11:41:16 +00:00
dictionaries@bcf7f04931
distro-configs ignore bidi-chars warning in callgrind config 2023-02-23 10:48:50 +00:00
docmodel
drawinglayer Fix typo 2023-02-25 10:36:59 +00:00
editeng editeng: split SvxLRSpaceItem into 1 class per attribute 2023-02-24 07:32:10 +00:00
embeddedobj
embedserv
emfio
eventattacher
extensions cid#1521188 Uninitialized scalar variable 2023-02-20 12:51:34 +00:00
external upgrade zxing-cpp to 2.0.0 2023-02-24 20:09:12 +00:00
extras
filter BaseMutex->std::mutex in PDFErrorRequest 2023-02-24 12:00:34 +00:00
forms BaseMutex->std::mutex in ListenerMultiplexerBase 2023-02-22 11:47:11 +00:00
formula Obtain actual 0-parameter count for OR(), AND() and 1-parameter functions 2023-02-17 02:24:08 +00:00
fpicker
framework BaseMutex->std::mutex in PopupMenuControllerBase 2023-02-22 13:24:47 +00:00
helpcompiler
helpcontent2@e08030ec02 Update git submodules 2023-02-25 22:35:34 +00:00
hwpfilter
i18nlangtag Add Saraiki {skr-PK} [0x06B0] to language list, CTL, RTL 2023-02-17 22:52:15 +00:00
i18npool
i18nutil
icon-themes tdf#152595 Colibre: Update icons in Start Center to match new branding 2023-02-26 08:56:06 +00:00
idl tdf#114441 Convert sal_uLong to a better type 2023-02-24 12:29:38 +00:00
idlc/test/parser
include Hide Quickstarter from General options in Windows store apps 2023-02-26 11:19:46 +00:00
instsetoo_native
io
ios
javaunohelper
jurt
jvmaccess
jvmfwk
l10ntools
librelogo
libreofficekit
lingucomponent
linguistic
lotuswordpro
m4
nlpsolver
o3tl Only specialize CppUnit::assetion_traits<T>::toString member functions 2023-02-16 21:16:12 +00:00
odk Quote some Windows shell settings 2023-02-17 15:18:07 +00:00
offapi
officecfg Resolves tdf#153578 - Duplicate mnemonics 2023-02-25 05:44:00 +00:00
onlineupdate
oovbaapi word vba: tie "Word" to VBAGlobals 2023-02-25 16:37:17 +00:00
oox tdf#153791: paragraph's/character's shd overrides shape style's fontRef 2023-02-24 15:00:08 +00:00
opencl
osx
package osl::Mutex->std::mutex in OHierarchyElement_Impl 2023-02-17 07:33:24 +00:00
pch
postprocess
pyuno
qadevOOo
readlicense_oo update credits 2023-02-22 20:47:03 +01:00
registry
remotebridges
reportbuilder
reportdesign
ridljar
sal Unify osl_{g,s}etThreadTextEncoding implementation across platforms 2023-02-24 18:27:25 +00:00
salhelper
sax
sc improved fix for CppunitTest_sc_uicalc 2023-02-24 12:37:38 +00:00
scaddins
sccomp Extend loplugin:cppunitassertequals to more argument types 2023-02-23 07:04:09 +00:00
schema sw floattable: teach the ODT filter about SwFormatFlySplit 2023-02-23 09:32:08 +00:00
scp2
scripting
sd BaseMutex->std::mutex in SdStyleSheet 2023-02-24 20:30:29 +00:00
sdext
setup_native
sfx2 tdf#153802: make it possible to change the UI with read-only docs 2023-02-26 08:49:57 +00:00
shell
slideshow BaseMutex->std::mutex in slideshow::EventMultiplexerListener 2023-02-24 07:12:50 +00:00
smoketest
solenv Fix build in a specific VS2022 environment 2023-02-24 17:05:53 +00:00
soltools
sot osl::Mutex->std::mutex in OLESimpleStorage 2023-02-24 10:07:39 +00:00
starmath tdf#152850: Fix bad scoping of MathML frac command 2023-02-21 12:11:06 +00:00
static
stoc
store
svgio
svl refactor DocPosUpdate, part 2 2023-02-25 11:45:06 +00:00
svtools BaseMutex->std::mutex in PopupMenuControllerBase 2023-02-22 13:24:47 +00:00
svx a11y: Fix focused state for special char dialog item 2023-02-24 22:29:27 +00:00
sw cid#1521509 Logically dead code 2023-02-26 14:51:38 +00:00
swext
sysui
test Fix typos 2023-02-25 10:38:00 +00:00
testtools
toolkit toolkit: Port AccessibleStatusBarTest to test::AccessibleTestBase 2023-02-22 16:53:41 +00:00
tools Only specialize CppUnit::assetion_traits<T>::toString member functions 2023-02-16 21:16:12 +00:00
translations@70a23c0afa Update git submodules 2023-02-22 19:20:47 +00:00
ucb tdf#153642 ucb: fix broken save with cached DAVOptions 2023-02-24 09:43:55 +00:00
ucbhelper osl::Mutex->std::mutex in ucbhelper::FdInputStream 2023-02-20 17:45:49 +00:00
udkapi
uitest tdf#152850: Fix bad scoping of MathML frac command 2023-02-21 12:11:06 +00:00
UnoControls
unodevtools
unoidl
unoil
unotest qa: call ProcessEventsToIdle inside dispatchCommand 2023-02-21 20:20:29 +00:00
unotools osl::Mutex->std::mutex in FmSearchConfigItem 2023-02-21 11:02:47 +00:00
unoxml
ure
uui
vbahelper VBA: Remove conversions in writer from OORGBTOXLRGB (XLRGB is actually BGR!) 2023-02-20 16:55:31 +00:00
vcl tdf#143148 Use pragma once in vcl 2023-02-25 10:50:12 +00:00
winaccessibility
wizards
writerfilter tdf#153526 writerfilter: catch exception from no NumberingRules 2023-02-22 22:35:06 +00:00
writerperfect Extend loplugin:cppunitassertequals to more argument types 2023-02-23 07:04:09 +00:00
xmerge
xmlhelp fix deadlock in xmlhelper::Databases 2023-02-22 13:12:04 +00:00
xmloff sw floattable: teach the ODT filter about SwFormatFlySplit 2023-02-23 09:32:08 +00:00
xmlreader
xmlscript
xmlsecurity
.buckconfig
.buckversion
.clang-format
.editorconfig
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitmodules
.gitpod.dockerfile
.gitpod.yml
.gitreview
antivirusDetection.vbs
autogen.sh
BUCK
config.guess
config.sub
config_host.mk.in android: Use libc++_shared path that works for NDK 25, too 2023-02-16 20:32:46 +00:00
config_host_lang.mk.in
configure.ac Refer directly to static library files for Graphite2 and HarfBuzz on Linux 2023-02-23 14:38:11 +00:00
COPYING
COPYING.LGPL
COPYING.MPL
cpp.hint
download.lst upgrade zxing-cpp to 2.0.0 2023-02-24 20:09:12 +00:00
g
hardened_runtime.xcent.in
install-sh
install_deps.sh
leak-suppress.txt
Library_merged.mk
lo.xcent.in
logerrit
Makefile.fetch
Makefile.gbuild
Makefile.in
README.cross
README.help.md
README.md Update Android baseline in README.md 2023-02-16 20:33:15 +00:00
README.Solaris
Repository.mk
RepositoryExternal.mk
RepositoryFixes.mk
RepositoryModule_build.mk
RepositoryModule_host.mk
sanitize-ubsan-excludelist
setup.cfg
TEMPLATE.SOURCECODE.HEADER
tsan-suppress.txt

LibreOffice

Coverity Scan Build Status CII Best Practices Translation status

LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs and Developers Guide. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The Build Chain and Runtime Baselines

These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:

  • Windows:
    • Runtime: Windows 7
    • Build: Cygwin + Visual Studio 2019 version 16.10
  • macOS:
    • Runtime: 10.15
    • Build: 12 (13 for aarch64) + Xcode 14
  • Linux:
    • Runtime: RHEL 7 or CentOS 7
    • Build: either GCC 7.0.0; or Clang 8.0.1 with libstdc++ 7.3.0
  • iOS (only for LibreOfficeKit):
    • Runtime: 11.4 (only support for newer i devices == 64 bit)
    • Build: Xcode 9.3 and iPhone SDK 11.4
  • Android:
    • Build: NDK r23 and SDK 30.0.3
  • Emscripten / WASM:
    • Runtime: a browser with SharedMemory support (threads + atomics)
    • Build: Qt 5.15 with Qt supported Emscripten 1.39.8
    • See README.wasm

Java is required for building many parts of LibreOffice. In TDF Wiki article Development/Java, the exact modules that depend on Java are listed.

The baseline for Java is Java Development Kit (JDK) Version 11 or later. It is possible to build LibreOffice with JDK version 9, but it is no longer supported by the JDK vendors, thus it should be avoided.

If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 12.0.1. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.

You can find the TDF configure switches in the distro-configs/ directory.

To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.

For more information see the build instructions for your platform in the TDF wiki.

The Important Bits of Code

Each module should have a README.md file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

https://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

Module Description
sal/ this provides a simple System Abstraction Layer
tools/ this provides basic internal types: Rectangle, Color etc.
vcl/ this is the widget toolkit library and one rendering abstraction
framework/ UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/ legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/ drawing model related helper code, including much of Draw/Impress

Then applications

Module Description
desktop/ this is where the main() for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/ Writer
sc/ Calc
sd/ Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

Module Description
basegfx/ algorithms and data-types for graphics as used in the canvas
canvas/ new (UNO) canvas rendering model with various backends
cppcanvas/ C++ helper classes for using the UNO canvas
drawinglayer/ View code to render drawable objects and break them down into primitives we can render more easily.

Rules for #include Directives (C/C++)

Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)

The UNO API include files should consistently use double quotes, for the benefit of external users of this API.

loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.

Finding Out More

Beyond this, you can read the README.md files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.libera.chat - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.