History

Hossein 573863d78a tdf#153533 Fix chart2_import test failure on HiDPI display The test checks that the text shape width is smaller than the chart wall. This test fails on HiDPI displays. For example: -------------------- lode/dev/core/chart2/qa/extras/chart2import.cxx(2207) : error : Assertion Test name: Chart2ImportTest::testFixedSizeBarChartVeryLongLabel double equality assertion failed - Expected: 4800 - Actual : 4632 - Delta : 100 Failures !!! Run: 85 Failure total: 1 Failures: 1 Errors: 0 -------------------- Now, instead of testing the exact value of the text shape width, I have used CPPUNIT_ASSERT_LESS() to make sure that the above condition holds: CPPUNIT_ASSERT_LESS(xChartWall->getSize().Width, xXAxis->getSize().Width) This is done in two different tests: * Chart2ImportTest::testFixedSizeBarChartVeryLongLabel() * Chart2ImportTest::testAutomaticSizeBarChartVeryLongLabel() Both tests are among those that can be invoked with: cd chart2 && make CppunitTest_chart2_import Change-Id: Ifb28fcf91da451aecdadff7a95aa810ef16fc510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146815 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>		2023-02-24 22:58:08 +00:00
..
inc	osl::Mutex->std::mutex in ChartView	2023-02-16 09:00:28 +00:00
qa	tdf#153533 Fix chart2_import test failure on HiDPI display	2023-02-24 22:58:08 +00:00
source	BaseMutex->std::mutex in UpDownBarWrapper	2023-02-24 11:06:11 +00:00
uiconfig
workbench/addin
AllLangMoTarget_chart.mk
CppunitTest_chart2_common_functors.mk
CppunitTest_chart2_dialogs_test.mk
CppunitTest_chart2_dump.mk
CppunitTest_chart2_export.mk
CppunitTest_chart2_export2.mk
CppunitTest_chart2_export3.mk
CppunitTest_chart2_geometry.mk
CppunitTest_chart2_import.mk
CppunitTest_chart2_import2.mk
CppunitTest_chart2_pivot_chart_test.mk
CppunitTest_chart2_trendcalculators.mk
CppunitTest_chart2_uichart.mk
CppunitTest_chart2_xshape.mk
export_setup.mk
import_setup.mk
IwyuFilter_chart2.yaml
JunitTest_chart2_unoapi.mk
Library_chartcontroller.mk
Library_chartcore.mk
Makefile
Module_chart2.mk
README.md
UIConfig_chart2.mk

README.md

Chart Implementation for LibreOffice Calc

The chart2 denotes a second generation re-write done to rid us of the foul and twisted legacy chart code.

Debugging

Shortcuts

CTRL + F12 creates a layout dump based on the XShapeDumper based on SAL_WARN("chart2", ...