Commit graph

24715 commits

Author SHA1 Message Date
c763982026 Merge branch 'actualizacion-master-2024-07-19' into 'master'
Some checks failed
CodeQL scanning - action / Analyze (push) Has been cancelled
Release Charts / release (push) Has been cancelled
IRC Notification / test (push) Has been cancelled
Pull de upstream

See merge request strepsirrhini/collabora-online!2
2024-07-19 19:01:39 +00:00
Artukryp
7e618aff78 Merge remote-tracking branch 'upstream/master' into actualizacion-master-2024-07-19 2024-07-19 12:47:07 -06:00
Gökay Şatır
8e2c4e7696 Set the properties of CellCursor so it isn't drawn over the Calc headers.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ifff79fc47849687151098914a3c78a22ffcf9037
2024-07-19 17:41:53 +02:00
Pedro Pinto Silva
287bcb0d45 Username popups: Add round corners and shadow
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia28c46c2621c74e4e5a2fbb85265d236b44b64f5
2024-07-19 17:02:58 +02:00
Pedro Pinto Silva
8a319d2a04 Username popups: Do not rely on browser's font defaults
Before this commit, in some browsers, the font-family was being set to
serif. Make use of existing CSS variables.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I50925252b2a7d01c0e445035500a7dcf1392307a
2024-07-19 17:02:58 +02:00
Skyler Grey
a7121252c0 fix(hooks): Replace git diff-index call
git-diff-index isn't always provided separately to the main git binary,
so we can't necessarily use that as the command. We should always be
able to use `git diff-index`, as the git binary will find files named
`git-foo` when you run command `git foo`, so this will work whether the
binary is separate or not

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Id705855eedfd7e12c0706a9c7638e0bfb911b3fd
2024-07-19 16:20:19 +02:00
Pedro Pinto Silva
27927a08c9 Fix dropdow arrows changing depending on users font stack
With *45bd9c6 merged an improved was introduced but it still didn't
fix the alignment for all cases. Example if an integrator uses a
different font stack or the user doesn't have the 1st and the 2nd
default font it would fall back to something else. These differences
in font would change how the dropdown is aligned due to line-height.

On top of that, we were not accounting for the transparent border when
aligning. Set margin-top to 4px so to offset the existent transparent
border: 4px.

*45bd9c6:
- Vertical align dropdown arrows
- 45bd9c6009

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie695fa3a4a3a7edf3ec2f15ba2565bb2079d16fa
2024-07-19 16:15:34 +02:00
Darshan-upadhyay1110
ad5db34dd2 Adjust upper bound value for assertScrollbarPosition
- Added the correct bound value for updated slimmer status bar

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ia272b3bd02710720004821f144b5408042e61d02
2024-07-19 13:42:07 +02:00
Pedro Pinto Silva
b2937725ea Status bar: Search input field add missing font-size
Set the field to the same size as the status bar labels

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5ecbac96a22797cec0beb39e0125b800439a54dc
2024-07-19 13:42:07 +02:00
Pedro Pinto Silva
13d971e98f Status bar: Make the bar slimmer
No need to have a so tall status bar (with added padding). Instead,
make it more discreet by removing the extra padding.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5eafc37003ae03ce0423ef4d1248f34fee8bfbc5
2024-07-19 13:42:07 +02:00
Pedro Pinto Silva
206c9a049d Status bar: Search input field should match the set height
Before this commit the search input field's height was resulting in a
taller height (not 22px but 22px plus anything that is added
afterwards, padding etc).

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I09e44b6589ba5ebe4986227022b33c55795939be
2024-07-19 13:42:07 +02:00
Gökay Şatır
ff1db886ed Adjust the drawing order of other views' cell cursors so they don't overlap with column & row headers.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ieec85030018afa7219abe4a50a1d85f9eb7a35fe
2024-07-19 13:27:53 +02:00
Gökay Şatır
8a9a15a8e2 Harden the visibility check of user popup (other view cell cursor).
Also, don't show the popup for newly added sessions. Coordinates are at the origin at the time.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ib2cab1c2735ab734513b284e8ea84fae4549bf71
2024-07-19 13:26:58 +02:00
Gökay Şatır
6fe02feb3b Adjust other view cell cursor pop up position when needed.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I64e1a2a2c31c06579e312da4d97e185a5e4c84b6
2024-07-19 13:26:58 +02:00
Patrick Luby
107a836fd4 Fix failure to load documents in iOS app
The iOS app (and presumably the Android app) do not have jails. Instead,
they read and write files directly from the user's local file system.

Also, running the iOS in trace mode is nearly unusable so move the key
"To JS" and "To Online" iOS messages to LOG_DBG and run the app with
"debug" instead of "trace" by default.

Signed-off-by: Patrick Luby <guibomacdev@gmail.com>
Change-Id: Ic8aabc09b297b15207be49c0e674e8006bcaa367
2024-07-19 08:40:56 +01:00
Szymon Kłos
df56d78ca2 SlideShow: introduce fallback option
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibfdda5574f38a08a765552c1cbcadc5d8d9c015b
2024-07-19 09:05:56 +02:00
Pedro Pinto Silva
bd64dbe7aa Statusbar: Zoom: set different icons via data.icon
Better to opt for a more minimal icon set for the zoom controls in the
statusbar otherwise we end up remanding too much attention for what it
should be instead a secondary control set.
- Improve minus and plus svgs and use them instead of the
normal (lc_zoomout and lc_zoomin) that are used in view tab
- Create zoomreset icon to be also used only on the statusbar

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I24afe1b9e8e6098d1cb93d6d9ad246af8381609d
2024-07-18 17:44:51 +02:00
Gökay Şatır
c9528f5f7a Renam docevents.ts to app/DocEvents.ts.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I6881376c2ba165c8ccd587fad948acd6d849d887
2024-07-18 17:34:46 +02:00
Gökay Şatır
bb731614ae Update the call to "closeURLPopup" function.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I426a24433b8aeaa1bf4ab5278c1617775ccff9fa
2024-07-18 17:29:02 +02:00
Gökay Şatır
43cf873703 Remove unused file.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I7c7f21ed2981b215dc09c8027e600b2cd589d91e
2024-07-18 17:29:02 +02:00
Skyler Grey
7e1532cc2a fix: Reorder resize event listeners
As event listeners are called in the order they are registered, and both
the resize listener I have moved and the one registered directly above
its new location call this._update, this._update is called *before* the
second event listener (whichever it is) gets a chance to execute. In the
old case, this causes us to request tiles for a different view level,
which at the start of the program requests tiles for a default position
and zoom level. In Android this triggers a core bug that sends us blank
tiles. These tiles are then later treated as valid for the section and
lead to a blank render.

Got all that? Good, because that confusion you feel is exactly why this
fix isn't a particularly good one! This "fix" is hacky, hard to
understand, and does it all through something I can reasonably describe
as "spooky action at a distance". The direct problem I've been working
on is fixed, but other nasty effects as well as rendering issues in core
are not.  Additionally, this commit has the downside of introducing a
commit that's unfortunately challenging to understand, and possibly
quite fragile if people don't come across it before changing stuff
around here in future

Finally, I also don't know that I'm not missing something that
necessitates a different order. It's entirely possible that I have

The structure of this makes me think somewhat of a DAG - a "directed
acyclic graph" - where we have various dependencies from all over the
place and need to execute them in an order that doesn't end up munging
them... maybe that could be a nice solution to this part of the puzzle

Sadly, for now, this appears to be an improvement with far less effort

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I05870f65a822a66e963407fcf461f18f5748ad1c
2024-07-18 15:14:36 +00:00
Michael Weghorn
f0fd253a32 README: Fix links to other READMEs
In the top-level README.md, fix links to
other READMEs:

* adjust the reference to the wsd one to include the
  `.md` suffix as the file was renamed in commit
  79b667a331

* Use the path to the actual file for the URL/target,
  not just to the parent directory, as just browsing
  to the containing directory when clicking on the link
  text showing a specific file name is rather unexpected

Signed-off-by: Michael Weghorn <m.weghorn@posteo.de>
Change-Id: I81ceb48193bc5a7b00ceaedc6852696719fb90e6
2024-07-18 11:50:44 +02:00
Caolán McNamara
aebb43f48d set 'make run' to default to using mount namespaces
which don't use coolmount and coolforkit, but instead use linux
mount spaces with coolforkitns instead.

That doesn't need sudo, so drop automatically calling that in
make to setcaps on coolmount + coolforkit for an easier developer
experience.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I6f8ddaf1053d084ec8c1f22adf830a677e80cadc
2024-07-18 09:54:06 +02:00
Artukryp
0ed191b863 Cambio de extension de archivo MexGob 2024-07-17 15:35:58 -06:00
Andras Timar
549421a713 Update Helm Chart with new release 24.04.5.2
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I78ba383023623f8eff88389b931a6251be3db06c
2024-07-17 23:19:01 +02:00
Szymon Kłos
b745b2efd8 SlideShow: activate LayersCompositor
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1a95751b1e9821dde7de7adf03883d3ba8b7b54d
2024-07-17 20:13:38 +02:00
Szymon Kłos
514f929785 Avoid passing both factors and product
Simplify a logic too, to not check the tokens number
multiple times and generate nice error.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I613bbc63ef5d1f19acc484ba36eac887cb21e535
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
2faa12c355 enable jscpd ignore for prevent duplication error
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: I458fd8b631e4ece1da49f2d9d9ef44a2a16862e3
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
ea3c6f2ae3 Slideshow: Reduce Duplicated Code
- Remove redundant vertex shader.
- Call prepareTransition from Transition2d.
- Fix canvas width for VenetianTransition.

Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: Iaa06b0f63726a6e8a982f7e3df68d0e4b4c47e82
2024-07-17 20:13:38 +02:00
Szymon Kłos
6ec2d9b6dc Update formatting with prettier
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I46c8e244752e06b3d7fb233fb8b4205aa726c077
2024-07-17 20:13:38 +02:00
Tomaž Vajngerl
e9fee9e9c7 We should not transition when going to the previous slide
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I73ba4ab5b6c42eb7ed13b9dbd30bd5d7f31e3ad1
2024-07-17 20:13:38 +02:00
Tomaž Vajngerl
781abd872e Remove duplication of setting up the VAO (Vertex Array Object)
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I297b4c4296546552b76288c16525f61b1dbff9e9
2024-07-17 20:13:38 +02:00
Tomaž Vajngerl
d091f56f28 fix slide rendering when videos aren't available (undefined)
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I3018012b59d9e2a31d4b7aa0634f94b84d8bbd7b
2024-07-17 20:13:38 +02:00
Tomaž Vajngerl
a1de2aa11c render video on top of the slide, if there is any declared
Adds video playback as a texture in WebGL. if there is some video
declared in the presentationInfo JSON from core and is accesible
through the public url. For such videos we create a video element
which can be then added as a texture to the WebGL and rendered on
top of the slide.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: Ie0b003e98c566c560280e8bf2dfbcc408d7d93f7
2024-07-17 20:13:38 +02:00
Tomaž Vajngerl
90e9ec22ae convert video urls to public urls for presentationInfo JSON
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I03706c3fb5c2da8e1a8ae103b74d13babebde35d
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
87671481c4 slideshow: apply prettier rules
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: I773a2b119c26544de6f5d6ce09896b2616ed6f57
2024-07-17 20:13:38 +02:00
Tomaž Vajngerl
b87d392a8a Render current slide, not just when we tranition
This change adds rendering of the current slide when the image
becomes available. So rendering of the sldie is also performed
when we don't transition from one slide to the other.

To make this possible part of Transition2d code was factored
out to a new RenderContext class and the SlideRenderer is
responsible to set up the rendering...

Also change the transitions to use a class transitionParameter
instead of a bunch of mostly the same parameters used by the
transition sub-classes.

Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: If670baf9e6dbe273e4a68d1c9cc0c5bad7bb604d
2024-07-17 20:13:38 +02:00
Szymon Kłos
e791f10c54 SlideShow: use LayerDrawing only to generate image
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib4ffcdba419a2561cb1eca9162297be7f49f1042
2024-07-17 20:13:38 +02:00
Szymon Kłos
a15d56a0d1 SlideShow: run LayerDrawing on presentation start
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I27413fbaf243511e8cf4ae11885bf33aa6910b2c
2024-07-17 20:13:38 +02:00
Marco Cecchetti
8497f11e3e SlideShow: typescript refactoring + slide layer message handling
Refactored code as typescript.

Implemented support for:
- handling of slidelayer messages according to the group they belong
to
- initial caching (store and retrieve layer info and content)
- exploiting slide and layer info for extracting the correct content
to render a slide.
- draw to a 2d canvas
- in case of solid color background, the background is drawn by the
client

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Idb68c58ed50ddd42f9d176241f45040ed0da0fd8
2024-07-17 20:13:38 +02:00
Szymon Kłos
93df205cc6 SlideShow: don't send messages from user input in slideshow
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I133050bb38ae7fe404a0520baa17765f44ee259f
2024-07-17 20:13:38 +02:00
Marco Cecchetti
b8d67500dc fixup: PresentationHelper
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I0e6bc5c709ebe20022a3ef2b5c5d3b4cbdc060e9
2024-07-17 20:13:38 +02:00
Marco Cecchetti
80dfec2126 PresentationHelper implementation
Provide support for slide information and slide layer messages.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I436f7e3f8eb9e89eb6050f2470f72809e6bd12b6
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
5357ff2aa2 slideshow: enable slide transition duration
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: Ie82d4389be6088acdb4a9d3b2690a4880901a53f
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
36164ee6db slideshow: add next slide timer enable
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: Iff1be8665dc76850d4ce763184ed771de8943d36
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
df678df224 slideshow: add transitionDuration and highResDuration properties into SlideInfo
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: Idff475162fb322800da95fbfa2841023fe24550a
2024-07-17 20:13:38 +02:00
Marco Cecchetti
3de68da98b handle incoming slide message as windowpaint and tile messages
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I0323a6015fcd65932d315a77b9024a54835d42f9
2024-07-17 20:13:38 +02:00
Marco Cecchetti
1aebb4f40a kit: getslide message + renderSlide/renderNextSlideLayer implementation
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ib6da153427f244f50787d28f93e58137b95b7bdb
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
55601cf74e slideshow: Code refactoring for Venetian Transition and prettier change
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: Ic0e6f5945caa6cc0bdf031c15afa9a88ca5f9fa4
2024-07-17 20:13:38 +02:00
Javiya Vivekkumar Dineshbhai
aa17f575c5 slideshow: Code refactoring for Split Transition based on transition type
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
Change-Id: I227923a1dd27bc01ec3140ba542d17d88f12157b
2024-07-17 20:13:38 +02:00