Commit graph

22902 commits

Author SHA1 Message Date
Neil Guertin
0686e6a2cf Add Tile Data debug tool
Merge tile update data tracked in several places into one tool

Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Iabf63ca30795d8791894e575fc631ccc9f676183
2024-02-09 17:48:00 -05:00
Neil Guertin
4ca1ebb852 Fix ping measurement from tile invalidations tool
Rename variables and functions
Move server ping to separate tool
Fix keypress detection for timing

Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I15efed25ccacac19e6e96fdff767d332e8cc5fcd
2024-02-09 17:48:00 -05:00
Neil Guertin
c9252e1574 Minor debug improvements
Rename and reduce scope of variable associated with
tile invalidations debug tool

Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I3e22d69e9c5867d1194a42520b35231e20b1ca01
2024-02-09 17:48:00 -05:00
Martin Srebotnjak
c8fc81e9a0 Translated using Weblate (Slovenian)
Currently translated at 100.0% (573 of 573 strings)

Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I910a4d881a9c8bb8cd573e15fe63dae730ec6595
2024-02-09 20:37:31 +01:00
Rhoslyn Prys
b0a8987713 Translated using Weblate (Welsh)
Currently translated at 100.0% (573 of 573 strings)

Translated using Weblate (Welsh)

Currently translated at 100.0% (22 of 22 strings)

Translated using Weblate (Welsh)

Currently translated at 99.3% (569 of 573 strings)

Translated using Weblate (Welsh)

Currently translated at 59.0% (13 of 22 strings)

Translated using Weblate (Welsh)

Currently translated at 100.0% (110 of 110 strings)

Co-authored-by: Rhoslyn Prys <rprys@posteo.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/cy/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/cy/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/cy/
Translation: Collabora Online/Android app
Translation: Collabora Online/Android lib
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I1fd5c876897b291e9ec7ff035f480edde9188c3d
2024-02-09 20:37:31 +01:00
Ashod Nakashian
7bba9b5b7d wsd: refactor findOrCreateDocBroker
This separates error-reporting to the client
through the WebSocket from the actual logic
of finding or creating a DocBroker.

This should be useful in creating a DocBroker
without having the client's WebSocket.

Change-Id: I66fc8ac09264fcbdb79ddf62867b8551a72929d6
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 15:50:50 +00:00
Ashod Nakashian
055b3535a0 wsd: optional timeout to getHttpSession helper
Change-Id: Ic7bfc332a7ce43884219fd04abe6d82b8c66007c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 15:50:50 +00:00
Ashod Nakashian
92e52e663c wsd: support sendMessage with string literals
Change-Id: I1caaf408c424c1cb11fec6aaf9d894dac7f99f93
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 15:50:50 +00:00
Ashod Nakashian
a449b8d229 wsd: simplify WebSocketHandler::sendErrorAndShutdown
Socket::shutdown() already does ignoreInput().

Change-Id: I75004ae881c481440d3e3cd31a96ba75ddbad22d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 15:50:50 +00:00
Ashod Nakashian
3a109537ee wsd: exclude WopiStorage in mobile builds
This excludes Wopi handling (as much as possible)
from mobile builds.

Change-Id: I4abb00f02e77b5d89d56ced49ce19a37ae93c13e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 15:50:50 +00:00
Ashod Nakashian
ae1c28c325 wsd: test: allow more time for repair dialog messages
Change-Id: If841daf76f1f7fb220205a3a04d695b261540eb4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 15:13:40 +00:00
Ashod Nakashian
0b47d8fc2a wsd: test: wait longer to load exoticlocale test
For some reason, the exoticlocale test takes
significantly longer to load. It often times
out when the CPU throttles or when it's
too loaded. Extending the timeout eliminates
the issue for me (no timeout over 175 runs).

Change-Id: I07cb099776af38206c0567f603cb6cc424eb0b93
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 15:13:40 +00:00
Ashod Nakashian
d28aab5020 wsd: test: empty file-substitution test
Change-Id: I192e54e7e850d1e4697f09e87b6397ae26c9391a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 15:13:40 +00:00
Neil Guertin
5df8021738 Random user formatting marks and sidebars
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I7692bb07adf7fc50ef72c4e933584573755295ad
2024-02-09 14:13:47 +00:00
Michael Meeks
0391c0a02f refactor: split out CSS image visiting.
We use this for the richdocumentscode case, but it is more
generally useful, this should be a pure re-factor.

Change-Id: I3a7f09d3da902a85dc2b362f7a160f07c90b97c6
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-02-09 13:51:04 +00:00
Skyler Grey
f522c2f828 Replace dead chat links
The libera.chat matrix bridge shut down a while ago, so links to our
room on matrix load forever. Additionally, we use matrix rather than the
IRC room so we should not be advertising it when they will only need to
be redirected to the right place if they join.

I run a matrix homeserver (clicks.codes) and have set up a room address
on there. By telling people this room address instead of the libera.chat
one they can join the existing room even though libera.chat is not
hosting matrix.

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I8a4224f1a856e7295325196f1b1a80f860ed7962
2024-02-09 12:53:09 +00:00
Méven Car
95cc0f6dd4 browser: move impl of savecomments command to Toolbar dispatch
Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: Ifcb34977b72bb0eccd23667deb4750637810e569
2024-02-09 13:27:27 +01:00
Neil Guertin
7416d2a3bd Debug menu cleanup
Extract "splits section" tool
It doesn't seem to do anything though
Also minor edits to "tile pixel grid section" tool

Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I008acc087e99d83225c1ba3184743e6e5a60e283
2024-02-09 11:41:25 +00:00
Szymon Kłos
111d782d14 es2015: bump uglify-js version
so it will allow es2015

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic4d572905c274a88323a98d6cb2bb01cba623f46
2024-02-09 12:14:19 +01:00
Szymon Kłos
e6683d4d72 es2015: arrow function test
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5f6c377b404d735515870e1c223f8e83f3b3989c
2024-02-09 12:14:19 +01:00
Szymon Kłos
cc29bdefe0 es2015: use const in Control.Header.ts
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I834cfd100b6da8541f8108fbb9041a37fea4d9af
2024-02-09 12:14:19 +01:00
Szymon Kłos
7216290881 es2015: eslint: CStyleData is defined but never used
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0027ac6fb9bfecb47d07c55e8eebbca0e363f9cc
2024-02-09 12:14:19 +01:00
Szymon Kłos
f7482d806e es2015: bump eslint version
- allow ES2015 in JS

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2f0f17d6fbb49d8205d9825f0bdf74b3076afacc
2024-02-09 12:14:19 +01:00
Ashod Nakashian
d3905698b0 wsd: detect unencoded WOPISrc
We should always have an encoded WOPISrc.
We add detection logic to make sure
that all URIs that contain WOPISrc have
it encoded properly. We do this by
comparing the decoded WOPISrc with
the original URI.

Change-Id: Ia0c2a79b009ce105321ad35db3d4f81006e81cb3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2024-02-09 03:57:04 -05:00
Gökay Şatır
a809541878 Introduce redlinedDeletion type for comments.
When a comment is deleted while tracking is on, we need to show it if showChanges is also on.
This PR improves the handling of tracked changes for comments.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I2f6956fa18504995f91e6e1c0fa3d633f4317f5c
2024-02-09 12:52:19 +05:30
Neil Guertin
d1822e4298 Cypress test logging improvements
Print full test name in beforeEach and afterEach
Hide xhr requests
Hide repeated actual and expected values on passed assertions
Add information to failure message

Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Ic1a20481c05afb05b9c29d0bd428b59615d49dc7
2024-02-08 11:55:06 -05:00
Patrick Luby
3bbedaac01 Add iOS build file to .gitignore
Signed-off-by: Patrick Luby <guibomacdev@gmail.com>
Change-Id: Iaac1714a7427b2aaa0998b75e7f377149ed2e43c
2024-02-08 16:19:47 +01:00
Pranam Lashkari
6ec5056ffd annotation: scroll sheet if comments are not fully in view on hovering
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I3c5a3267947e0dfc8f53663ccdc7032ebd1819c3
2024-02-08 17:33:31 +05:30
Skyler Grey
7658c3f774 Fix video position in safari presentation mode
237d9c084a fixed videos rendering in the
wrong place on Safari (and all iOS browsers) in edit mode.
Unfortunately, it made the oversight of missing presentation mode, which
gets its SVGs from a completely different place 🤦.

This commit fixes presentation mode.

After this commit, you will see the video in the right place. Please
note that the white border present in edit mode is not there in
presentation mode, so if you line the video edge up with something in
the presentation you may think the video is offset: I suggest lining
something in the video up rather than the edge of the video object.

Known caveats:
- This commit seems to be a few pixels off with larger border sizes.
  It's a lot better than before, but still not perfect

This commit does not include detection for the upcoming Layer-Based SVG
engine <https://wpewebkit.org/blog/05-new-svg-engine.html>. This means
that this commit will *break* video if this is enabled in Safari debug
mode.  If this commit is merged as-is we need to make a followup to fix
this as soon as possible or we will end up with a similar-but-opposite
bug when that flag is toggled on by default.

Follow-up-to: I205e692e7027ad917bd6f29aa96b0ac70a4c9e04
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Ifeea18874d189c80cbb96029706a6f71d6125898
2024-02-08 11:22:10 +00:00
Darshan-upadhyay1110
1ffc8745f3 Add visual hint for freeze pane Lines
- added row/col divider with a transparent gradient over the area where cells are concealed
- shadow color will change accroding to UI theme (Dark/Light)
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I3fe6f3b35ec84cda5d93fe9a094765cfb75b906c
2024-02-08 09:58:54 +01:00
Caolán McNamara
64a4dab516 we never have an empty std::unique_ptr for .second
and don't check for it in the other cases, so drop it in these ones

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie343178869cadc127ee898968fef8f798b6068d5
2024-02-08 08:51:46 +01:00
Caolán McNamara
95c98805a0 cid#336284 COPY_INSTEAD_OF_MOVE
and

cid#336290 COPY_INSTEAD_OF_MOVE
cid#336288 COPY_INSTEAD_OF_MOVE
cid#336282 COPY_INSTEAD_OF_MOVE
cid#318980 COPY_INSTEAD_OF_MOVE
cid#318853 COPY_INSTEAD_OF_MOVE

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Icf6447b8298432359ec37242427ce595f8de4160
2024-02-08 08:49:26 +01:00
Miklos Vajna
944491024f cypress, desktop/writer/top_toolbar_spec.js, 'Insert Special Character.': add conditional 3rd click
My local run failed in this test, because scrolling to the right just
twice resulted in a partially clicked toolbar item, so:

cy.cGet('#Home-container .unospan-CharmapControl').click();

failed. Force the clicking so a half-visible toolbar item also gets the
click.

An alternative would be to add a 3rd click if scrolling to the right is
still possible, but that looks less clean.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I4caa3dc79df1bbbd5bd0c7e88ef1baea8ae4b17e
2024-02-08 08:25:55 +01:00
Michael Meeks
7387d9cc04 Reduce noise of somewhat excessive trace debug.
Given the surrounding debug we should be able infer the same
state from its absence.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Id20de40f67ed52dc5535585aec9b5888131d6324
2024-02-07 21:17:48 +00:00
Caolán McNamara
d8041e9516 use a path name unrelated to the parent dir name
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I622bc1569c775c57d7f268a063195706bb12be7b
2024-02-07 20:34:51 +00:00
Andras Timar
fd6eabf976 Bump version to 24.04.0.0
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id4b4f65772cab6ebeea6843044b8bdc3be5f07f7
2024-02-07 20:44:51 +01:00
Neil Guertin
4312908312 Add automated user tool to insert rows/columns
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I4f0e39784e82ce332b344f71456ac90bbd92a7d6
2024-02-07 17:29:04 +00:00
Neil Guertin
724698adaa Clarify Automated User menu
Move Typer and Randomize User Settings to "Functionality" menu
Rename main toggle to "Enable"

Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I75709124f835c46ae741c4d51e14ed0b868528ae
2024-02-07 17:24:56 +00:00
Michael Meeks
720ac3d5a6 check: perform simple & quick eslint check before others.
Should save time in CI for simple JS errors.

Change-Id: Ib7e1ab68795cab12f8f5ec461cfed6e84986f440
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-02-07 17:13:48 +00:00
Michael Meeks
6c9fb23081 refactor: inline CRS.Simple into CRS.
Cleanup un-used wrapping.

Change-Id: I510f8244e51f2d6f56fdb0aee4046ebfd894c9e1
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-02-07 17:13:48 +00:00
Michael Meeks
a30df0f583 js: remove obsolete CRS.Earth references.
Change-Id: I3c5a25bd3ff1ee7af01c6190244400ec8d68e47c
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-02-07 17:13:48 +00:00
Miklos Vajna
c41cfb1999 test: fix -Werror,-Winconsistent-missing-override in WhiteBoxTests
WhiteBoxTests.cpp:660:10: error: 'updateActivityHeader' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
    void updateActivityHeader() const
         ^
../kit/ChildSession.hpp:89:18: note: overridden virtual function is here
    virtual void updateActivityHeader() const = 0;
                 ^

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I12f21fd9fbe0ba77d2196bfcd1cbdb5ef07e5d06
2024-02-07 15:10:07 +00:00
Neil Guertin
090a52cece Remove cSetLevel (unused)
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Ic1eaae123ae70f5f09553d6c69bfa699a02a921f
2024-02-07 07:16:37 -05:00
codewithvk
43db77e66d Add loading indicator for document title saving
To address the lack of visual feedback during the delayed saving of document titles, a loading bar has been introduced below the document name/title input field. This provides users with a clear indication of the ongoing save operation. Additionally, the delay that previously occurred after entering a new document name and pressing Enter has been eliminated, streamlining the save process.

Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: I9c5a41f999d02dcfaa24e7925029499cf310b2e0
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
2024-02-07 13:09:13 +01:00
Neil Guertin
e3714480f4 Adjust zoom limits for random user
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Id6ba3e351214f9bd2676b4935baa8105646d12c0
2024-02-07 11:38:54 +00:00
Hubert Figuière
adbe12783f Fix warning for unocommands.py
This resolves the following Python warning.
unocommands.py:319: SyntaxWarning: invalid escape sequence '\('
  f.write('''};

Also make sure the output depends on the script

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I11f1e028c9c132f4afc66f9b5a6137b478f00774
2024-02-06 17:50:09 -05:00
Michael Meeks
29fa4a40a1 signal activity dumping: enrich with session details and state.
Cue up some basic state for being signal safe dumped on crash/abort.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibc6713aef2a0e7b878b178b05f0e13c8d40b47fc
2024-02-06 19:29:28 +00:00
Neil Guertin
d209ec78cc Upgrade to Cypress 13
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I8edbcbb72e1ad016df0ff6a2466d20865f517683
2024-02-06 10:05:11 -04:00
Méven Car
5df8a3eeb9 browser: CanvasSectionContainer initialize boundsList
Also move its declaration to the top of the class section with other
class members.

Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: I506423078423074171ab00efb6f2d3fab0c68796
2024-02-06 13:20:33 +01:00
Szymon Kłos
d0e2bdc8db Fix error on clipboard download fail
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If2ea2bb7b756812cffa2125eff54b6526af6b79b
2024-02-06 10:59:50 +01:00