When the Kit dies and there is no data saved to
disk to upload, there is nothing to do but unload
DocBroker and log the fact.
With unit-test that simulates the situation by
killing the Kit of a modified document.
Change-Id: I7dcc0583c053d7166935d15d045fcf6624e43b4e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
also move paste special popup code to the clipboard.js
so it is easiet to share code
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I86bb1696ff78e3cef5425478cc3fb56cf47916b8
Before we were showing edit button only if the snackbar was not present
in the DOM. The goal here was to avoid overlapping elements (bar + FAB).
However and since the infobar can be present in the DOM but set to
display none this would cause another problem: no edit button and no
infobar visible to the user.
Solution:
- Make use of the existent css class .hidden (which sets it to display
none) so we can then in the css side show the Edit FAB only after them
snacbar is dismissed.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I31be2dfeb1bcb08b971074466a24db719320f8f4
fix typo on clearList loop that prevents skipping trackchange
comments from being deleted
Also I removed the line in WriterTileLayer.js containing
clearList because clearList is already called on importComments
function so it was unnecessary
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ic4086a80b126aec62e382078f53d68bc17da8a1c
so now real locked_host settings will be applied if the document accessed with alias
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib76704a4bf2c3da5dc7b83bbad98fe40b5c03316
Follow the same order as anywhere else such as annotations, JSdialog or
even tunneled dialogs:
primary action aligned to the left
Also update cypress test: Do not target button position related classes
instead, rely solely on main classes
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iac209aa343f22ddfdbd5662eba43d7adaa3f0892
Since the hostname argument is passed
to both the base class of SslStreamSocket
and SSL_set_tlsext_host_name, and since
the base class's getter, also called
hostname(), is hidden by the argument,
we cannot move it.
An empty hostname can result in 403 Forbidden
from the server due to missing Server Name
Indication (SNI).
Change-Id: I27990f64f17ec3c81a4dd543a078807629cd0c20
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Fixes problem with:
- showing wrong slide number in statusbar
- inserting comment at correct page
in pdfs where we see slides in continuous mode.
Sending slide id from online to server is much easier
than calculating based on visible area on the server
where we have to put that data into TabControl widget
which is used in different places.
It updates visible slide on scroll and also when selected
from the previews bar.
Signed-off-by: Szymon Kłos <eszkadev@gmail.com>
Change-Id: I7f8a9458e415e17391a4a249e19fd97f8541debd
- Make sure the close button is always place at the last position so even
if integrator adds additional icons the close button should always
appear afterwards and make sure it does get shrunk
- Force closebuttonwrapper to be positioned at the end (far left side)
by grow #userListHeader (even if invisible)
- Avoid positioning closebutton image with background-position
- Simplify by just fixing the parent and centering the image
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I851744c75c132957b8754ce7a105e57625f986bc
Remove the now necessary max-width from tablets
- We now have those parent elements being set as flex box
and thus we have now no need to limit the max width of this container
- Plus by limiting the max-width we were hiding more of the tabs while
not gaining anything useful in return
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1ef477902fd95a4751009f8bf08350b6ce88aa97
modify and reply causes relayouting due to expansion of the
commentsections but it is based on whether they are selected or not
currently. If they are already selected we dont relayout them again
and it causes overlapping. To avoid that we can simply unselect
comments just before reply or modify.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ifc2e546504b36b46f98a9b22ce791b4279239457
commit eb387cc7b1
At least in current master it is possible to right click on the link and
select 'Edit hyperlink' context menu item and the edit dialog(JS)
appears. So it seems there is no need for this workaround edit button
inside the warning 'JS' dialog box anymore.
Additional reason is that when help button is clicked on any
dialog(tunnelled or not) it shows a warning 'link' dialog that it is
about to open a external url, but this dialog has an unneeded edit
button because of the original commit.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I2d8434746c698deefe69b38bf9947202f4f95862
We need to use a lighter/ highlight color for hover so we then be able
to use darker backgrounds for disabled status and even pressed status
(active)
Also this automatically fixes the hover status for on/off switchers on
the toolbar (e.g.:sidebar trigger). Now they also react onmouseover
With this change
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5efc41e3e7d13c10cf2d714acefee08f99e6af1a
This commit does not change functionality
Add generic 'button-secondary' and 'button-primary' to buttons
- so we don't need to hunt each button from annotations
(cancel, save, reply)
additional plus: targeting any css class that has button-primary allow
to target in the future cases like vex-dialog-button-primary
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie70867e3248ff70afdbe154593e4d02ec24c46df
With bda34c9096 those btns are already
generated with the proper generic classes that hold those styles so,
no need to keep individually targeting them
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I87912913d3f7340b5ed4b06b8c658791eda56d4e
- Better to keep everything related to buttons in the btn.css file
- Also all margins are already being set in the btn.css file anyhow
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic1d9f7e2b895604367571a93f593ef359659c57c
- add possibility to specify name alias for icons that are
generated via jsbuilder (sidebar, notebookbar). The goal here is to
avoid having multiple duplicated icons with different names:
Example: 2 identical SVG files were being used just because of their
name.
Context: When unifying icons between sidebar and toolbar PR #4426 ,
9576137df51725b677342c606dcad8749eaf0622 we end up with icons without
images on:
- Calc: Notebookbar
- Calc: Sidebar
This happens because even though we want to use the same icons the uno
commands are actually different from ones used in writer and elsewhere
(uno.AlignLeft <> uno.LeftPara)
Note: Since the sidebar uno.commands come from core we really need to
use icon url alias. If that was not the case we could have used here the
newest compatibilityAliases introduced in
7e6f3d5590
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I49647f8a32665d0363259151c09131d8c5063783
- Partly revert 7e705fcf09
- RGB expects rgb values. Hex annotation does not work: renders it
transparent
- Avoid low contrast between font and background (white with light bg)
- Use instead primary color
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iad24d6bf30d2e62505254c70b174e9b9971cbeb1
