Otherwise, if the user selects all the document,
the clipboard blocks Page Up or Page Down cursor jumps.
Change-Id: Ia9c432646c51063775bb7cca6a998e7d1cdcdbf2
Signed-off-by: Henry Castro <hcastro@collabora.com>
Also corrects the counting of number of active
sessions when broadcasting messages.
Change-Id: I5ab5995ed2cbc18b215542d0b2c9568957fd6a3a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We should always set the shutdown flag first.
Otherwise, we run afoul of a race condition.
Change-Id: Ic99793d68b3b943496ff932b4bdafd336fef7f82
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The static instances cause a lot of grief
when they aren't called in the correct order.
Worse, when we are cleaning up, we don't
even initialize some of them (Admin, for one).
This means that a normal exit will destroy
what isn't created, in some cases (Admin) it
will even force creating instances when we
are destroying others.
This avoid all this by simply exiting bluntly.
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 231fae4ebd990cb344143759cbdfa19c4f30d4f2)
Change-Id: I6a9443ca5ab999ed6ca1d27314136472cfc6ddb6
As Tor noted on IRC, this was forgotten when the actual protocol
commands were introduced.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I548ac73348bceb469484ce934f7548ddb4091b63
Subcontainer `root-container notebookbar` was not able to vertical align
contents even thought it has vertical-align: middle
- Fix it by removing parents' (notebookbar-options-section) height and
padding
The alignment is still off due to:
sub cell is inheriting automatic padding (useful in all other places)
- Fix it by remove padding for the cell under
.notebookbar-options-section
Display inline seems not be needed here, we can just inherit it.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iafb4f83acfff5ae0923afb972cefe1201080c79e
- prevent from multiple onDocLoaded calls
- use snackbar to ask user first before showing main dialog
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1afb67c7bb403aa05c8e33ef48c0d55fa57350dd
so we don't have to change 2 places
also I've noticed only one place had
proxy support
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I64af9dac9bd8449fba0de3b05e0c2102e440788b
we added AllHosts to give admin the err log that host is not in alias_groups but now as we removed the host list entries from configuration we don't need that log
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I8b5e9e6b7df7df59befb496c12966c7ddc60c707
which is the same color as other container elements inside of it. If
we want to use a "neutral" color that can either be light or dark (due
to future plans on dark mode) then better to just create another var
for dialog backgrounds. For now better to fix (so we can avoid dialogs
such as the pivot table to be with multiple background and with less
brightness then the document that seats behind)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I848392e3c1194963273f2950a22022eeaadbe8f0
radio buttons were being render with a border surrounding them, example:
insert pivot table, all disabled radio buttons have a border around it
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I003280ec929b49c8f8f0a1b9a4ca361c87a9224f
This was impacting alignments on dialogs. Example Find and replace,
checkbox were being pushed tot he side. Better to rely on parent
padding or table structure
also with 496256a96b -table is no longer
in use
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I60b29f818e8ec53f5c66a2772f4cda82de0011bf
Example: macro select dialog is getting set with multiple inner margins
- Simplify the CSS so we only target one sub element
- Remove unnecessary code (no need to add exception for sidebar and
formulabar)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibc35e6b8c37badbbe27b411c21986ddda0e27ef3
with 496256a96b we no longer need the
pre fix -table in the ids plus better to just remove any non essential
bits and share more CSS between places
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ica8ef3db2ed52a379cb75437d7b147c8b42bbd7b
from: 496256a96b
- let's not target absent ids on the CSS side
- Also better avoid target boxN (e.g.: box3)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I41bf1540c634dcde8111ae0192a70772153c592b
This went wrong when the forward-port of commit
b96e8b7c77 (wsd: correct use the exit code
from UnitWSD, 2021-11-29) didn't adapt the string to the updated
filename.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ica8047dc05dedf9e075663f405dea89913cf789a
Identified the faulty test, on heavy load the test gets stuck on waitUntil command
skipped the test for now
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia4b7ca081098e7e5b6f15135304131521629e524
@media (prefers-color-scheme: dark) setting
is available by use color-scheme-dark.css
instead of color-scheme.css
sure the scheme need some update
but there are other open points like
use dark color for document
use dark colibre icons
this is only the .css change
so no full dark mode update
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I5c2adcbb75583a952f419af507d7cfe5c1343e3c
remove padding-top: 5px so there is no scrolling
needed for two rows.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I9a0450074cc55486d0f7de8a39b7edff8e66c752
border on left and right so it work also for RTL languages
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ic973cfee4c8fd563008477ab38a9e4e3e69c8300
Signed-off-by: andreas kainz <kainz.a@gmail.com>
This way, there is only one entry point for all the remote
configuration, and the remote_font_config does not have to be specified
in coolwsd.xml, in case the remote_config JSON specifies that.
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
Change-Id: I857bab3d300ddb5c0c3df0a9f62eda20f43c3ff7
Currently translated at 100.0% (444 of 444 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (444 of 444 strings)
Co-authored-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Co-authored-by: Pedro Silva <pedro.silva@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pt_BR/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I23cc55c918f72a8cc91429c03fa86f4e101a664c
Currently translated at 100.0% (444 of 444 strings)
Translated using Weblate (Slovenian)
Currently translated at 99.7% (443 of 444 strings)
Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie519a835e45d5308e3dac9eb19b879f19dc1b726
Currently translated at 68.4% (313 of 457 strings)
Translated using Weblate (Dutch)
Currently translated at 67.6% (309 of 457 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (444 of 444 strings)
Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Co-authored-by: sebastiaanveld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/nl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5690268d76c984a1920fc232c5b405b7e02a9806
Without knowing whether the write succeeded
or failed, we cannot trust errno has our
error or some earlier and unrelated error.
This was caught when there were two sockets,
one of which disconnected. The write to the
disconnected one returned -1 and set errno
to ECONNRESET. We subsequently wrote to the
second socket, which succeeded. However,
because errno wasn't reset, and since
writeOutgoingData didn't return anything
to indicate the success, errno's ECONNRESET
value meant the second socket was also
disconnected, which was incorrect.
writeOutgoingData now returns the last return
value from writeData so we can make informed
decision as to whether to check errno or not.
Also, to avoid incorrecly propagating errno,
we now capture errno only when readData and
writeData return -1. This has the nice
side-effect that we reset errno to 0 when
no errors occur during our call.
Change-Id: I911b31390f37cc71938bc4a6ae75393dbf24bb9d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
