Commit graph

21462 commits

Author SHA1 Message Date
Rash419
41bdf1ece8 admin: remove fixed width and height attr from svg
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I39df378a0bcba2199d625dd5bf7a202b15354b0f
2023-08-15 11:11:01 +05:30
Rash419
65f6f46093 admin: use humanizeMem in adminClusterOverview.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I323735c989e3a4448f57d896ea635dcdeb6bbe8b
2023-08-15 11:11:01 +05:30
Pedro Pinto Silva
555a07db70 AdminCluster: Use proper card headers for title instead
and round cards

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I632ca5a3053247ce4d12c4e028e0322ee1545124
2023-08-14 21:38:32 +05:30
Ashod Nakashian
efe874f89c wsd: simplify shutdown and termination flagging
With the use of a single flag for both, the
logic is now less ambiguous, as we cannot have
termination flagged without also implying
shutting down.
The assertions are no longer needed.

Now that setting the termination flag
explicitly implies having the shut down flag
as well, the checks are simpler. We only
need to check that the shutdown is not set
to continue running as normal, since having
the termination flag must perfoce mean shut
down is also set, there is no need to check
both.

Change-Id: I99e22f5668385182b0594040a8e3354b55e74642
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-08-14 16:32:50 +02:00
Ashod Nakashian
35dda35f9d wsd: move statics into anonymous namespace
Change-Id: I97b0cd7de96eced1a4023e55171b1e35b52a95c7
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-08-14 16:32:50 +02:00
Gökay Şatır
e660bb8e66 When document layer is not ready and socket message is not delayed, message is lost.
Wait for doclayer to be ready in this case.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ib3e9427a89e8be7d97f7baf92bdcb6295c695ca2
2023-08-14 16:17:19 +03:00
Gökay Şatır
8570a03555 Correct menubutton control id calculation.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ief7692cbdc479a651d350d7beab2e558e6d27b4b
2023-08-14 14:24:46 +03:00
Gökay Şatır
3d1725ea44 Cypress updates.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ieefdcae70be0fce920e2e2b3d3b6ba1b179a6857
2023-08-14 14:24:46 +03:00
Gökay Şatır
7d084e40cb Update cypress tests.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I1c60f89d6ab68e4a61861d77383010dd7f22480a
2023-08-14 14:24:46 +03:00
Gökay Şatır
a3d9abcc20 Move all accessibility definitions from notebookbaraccessibilitydefinitions into control.notebookbarwriter.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I8db815859e91a65dc5452a0c3c0307701088514c
2023-08-14 14:24:46 +03:00
Gökay Şatır
7d0f7d7378 writer insert tab keys are added.
Replaced id based checks with uno command ones.
Removed unnecessary function from notebookbaraccessibility. We don't use automatic id assignments any more.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I3ad69916dea72d0e7e37430e629d74763c79005c
2023-08-14 14:24:46 +03:00
Gökay Şatır
1a2500c8d3 Merge accessibility definitions with notebookbar definitions.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I752eb0a2f44a892ed2cb7b2fd770c4d3ab997830
2023-08-14 14:24:46 +03:00
Gökay Şatır
939a7a0301 Simplify notebookbarwriter and tab page containers.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If923c06ffd6b7bca77d25008497c390b8f3dcac8
2023-08-14 14:24:46 +03:00
Gökay Şatır
2cc714705a Remove access key assignments from jsdialogs.
Tabs' access keys are defined by notebookbar accessibility definitions class.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ie04782aa5b747ea9f3b7bd3f84a33bf0554648dd
2023-08-14 14:24:46 +03:00
Gökay Şatır
f8e53bd851 Assign tab ids while defining tabs.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I51dbadb5d168f7b7f762a20a445773c6d53a511e
2023-08-14 14:24:46 +03:00
Caolán McNamara
6682a2a527 cid#318900 Out-of-bounds write
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I18f30bbe7271a93a44ce798e358277add9876454
2023-08-14 12:31:55 +02:00
Caolán McNamara
307818ba1c cid#318834 Missing move assignment operator
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I798c0e6610afca9d0d503514b33e75c35a7ccb33
2023-08-14 12:31:55 +02:00
Caolán McNamara
f7e121e2ea cid#318953 COPY_INSTEAD_OF_MOVE
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I863ce92808f93e98fecb6022324228b5acdba141
2023-08-14 12:31:55 +02:00
Szymon Kłos
4b9cbab33d jsdialog: fix spinfield precision detection
Use string based approach to avoid errors.
Eg. 36.37 was a problematic value when multiplied by 100.
This fixed indent spinfield in sidebar.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iae25acbf59cedfd20cbcb0677fd87e08d06c3f6d
2023-08-14 12:30:02 +02:00
Szymon Kłos
eee6e49e8a cypress: fix unstable alignment test
sometimes svg generation takes more time it seems

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0e6ad493cb452a9725235f2c01c6792126b8de9c
2023-08-13 11:35:40 +02:00
Szymon Kłos
697f4a6109 cypress: fix failing table tests
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6132ec3a794de75caa6d1ba0c94e730cda94ea0b
2023-08-13 11:35:40 +02:00
Szymon Kłos
b85eb1b03f cypress: fix svg text-decoration detection
this was changed in the core:
commit 0a549b2c9595cd076e3b503b67df93bff380885a
svg: export text decoration for text run not paragraph

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8906ee07c7ff88c9dcdbebe73d2c620e797a8b3a
2023-08-12 10:34:15 +02:00
Shehr Bano
e6a06eae1c FIX #7037: JSDialog: label vs textarea vs input field inconsistent paddings
Signed-off-by: Shehr Bano <shehr.bano@collabora.com>
Change-Id: I53494733c47b35d59133979c456665b4174e393c
2023-08-11 12:15:19 +02:00
Pedro Pinto Silva
16b8bead39 Revert "Add action for detecting code duplicates"
This reverts commit 8ce751a3ca.

- Any PR coming from fork fails
  - User needs to manually go to:
  settings > Actions: General > "Workflow permissions" and allow write permissions
- Right now we have too big of a threshold (26 lines) to be as useful as we would hope

Probably best to remove this action for now and instead use directly
the npm package (https://www.npmjs.com/package/jscpd#usage). Advantages:
  - More control over what is analyzed
  - It can be add as a step in make check
  - User can run it locally using make check; CI can also use that.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3c112218a83fd6e56e7fb2f47b24315347a74cdd
2023-08-11 11:45:21 +02:00
Rash419
47f4305050 fix: cursor jump when hyperlink popup clicked in mobileview
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I4c5f1f2923f894156f5f05382b0f54476dea8a56
2023-08-10 17:38:22 +05:30
Caolán McNamara
912dfcd08e autofill onMouseDown doesn't generate working event position for hidpi
so the autofill handle in hidpi didn't work

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I718d9a8d3954a441705849eba174fe6b5b2983c4
2023-08-10 11:41:24 +01:00
Ashod Nakashian
a42adac98f wsd: add the web-server URL to the media-src list
We need to allow loading media sources from
the web-server URL. This seems to be necessary
at least on iOS.

Change-Id: Ic7b23c4f80b975460de9311a67f3c5cb51758d14
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-08-10 12:24:08 +02:00
Andras Timar
85ee03f98f CollaboraOnline#6546 enable automatic color in default paragraph style
use the xml token "use-window-font-color" to toggle auto color on.

https: //github.com/CollaboraOnline/online/issues/6546
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ib14b144ce6f593114a8130f5816f479d5cd4fe85
2023-08-10 12:22:26 +02:00
Pedro Pinto Silva
c89cccfc7a Welcome: allow scroll bar
Otherwise content is not reachable.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibef06bd7ee18702674e41e8f942449ef49ffdd62
2023-08-10 11:48:36 +02:00
Marco Cecchetti
96a7cfb25e a11y: provide info about current table and cell to screen reader
When we get in one or more tables screen reader reports row and column
count.
When we get out one or more table screen report reports "out of table"
for each table.
When the fosused cell changes screen reader reports new row/col index.
Screen reader reports cell paragraph content, too.
Added also cypress tests for checking that the table/cell description
string is correct.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I078b29a2f76f91df479f75db76113c80405f7169
2023-08-10 09:29:09 +02:00
Darshan-upadhyay1110
7825f82ce1 Remove open_local_editor button in tablet view
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I18908150ee537bfe7dd36b0b94f8baa11d2739ea
2023-08-10 12:51:40 +05:30
Caolán McNamara
5185b7bedf cid#318934 silence Untrusted loop bound
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Icd7a7d3394dda93045f97481b109498fca3c01c8
2023-08-10 08:47:25 +02:00
Caolán McNamara
d79d86ed91 cid#318844 Dereference before null check
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie3b4da580b86f4f313825dabb6d73af1508432d9
2023-08-10 08:47:25 +02:00
Caolán McNamara
2a8910a941 addPollFor default arg is now always explicitly passed
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ic9a822835ace44a1dee0c3dc4c8eb64d8e929b4d
2023-08-10 08:47:25 +02:00
Caolán McNamara
c593a0bde5 replaySync is unused
since:

commit 96adaa15d1
Date:   Thu Apr 14 19:05:26 2022 -0400

    wsd: kill coolwsd_fuzzer

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id4b2275fbb0680a82ae29848a182de06a2de0d04
2023-08-10 08:47:25 +02:00
Caolán McNamara
b6f87b06e3 cid#322475 COPY_INSTEAD_OF_MOVE
configure currently requires a min of c++17

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I613dac6e66c3e77183d46623346969179bccc489
2023-08-10 08:47:25 +02:00
Caolán McNamara
1cd88f217e cid#321976 AUTO_CAUSES_COPY
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I2207cc530e1773f29cf540ea2ff9c6f44c4c237b
2023-08-10 08:47:25 +02:00
Rash419
5dcce1965e android: enable dark mode in documents
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I108601f78f4d7bbf704b5f5f89b20c8f8a597355
2023-08-09 17:37:16 +02:00
Pedro Pinto Silva
c2192b4a67 Screen reader doesn't properly report tab names in Tab View UI
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0ebe938080fa0e6865d4bf18e5dd33b0eb6a1567
2023-08-09 17:21:58 +02:00
Caolán McNamara
0c611649e5 cid#318854 Unchecked return value
check this one like we check all the others

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id8379c6873fe7dd6466dc265cea6847d120aa0ce
2023-08-09 13:39:23 +02:00
Caolán McNamara
6d873d6837 cid#318919 Dereference after null check
map is never null so make it a reference

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I9f6ad863d0a1102dd7e26a5668b1c6ba71249580
2023-08-09 13:39:23 +02:00
Caolán McNamara
b1f88c4cb2 cid#318875 Dereference after null check
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I40c824e26183f0c0c17e1503dc1c438ba1d2ce5c
2023-08-09 13:39:23 +02:00
Caolán McNamara
2119a19881 cid#321981 AUTO_CAUSES_COPY
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I6c2d30c8db254beb6b20aae7891b089a986a4df8
2023-08-09 13:39:23 +02:00
Henry Castro
a2b924033d admin: rename ACCESS_TOKEN -> JWT_TOKEN
To avoid confusion with the WOPI access token.
.

Change-Id: Ie38e0f11d0655e89eb1c7f1e20b73a9b8756ba21
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-08-08 08:27:30 -04:00
Gökay Şatır
441d064b7a Make insert shapes menu accessible.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I7421cbf8e745b0dd973c7f99b985e8bf98b4859f
2023-08-08 10:07:09 +03:00
Rash419
340bbb0328 admin: increase font-size of y-axis
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I0439d79d487329bea8162762854430bac0b51448
2023-08-08 10:10:53 +05:30
Pedro Pinto Silva
3f0c9d5c55 admin: imprv ui sizes of adminClusterOverview.html
- Graph axis text is too small (10px) better to set it to 1em based on
parent div (16px). Good to also set any group within svg to 1em to
avoid any surprises
- Currently tablets from one card is spilling over to the next card
when there is not enough space. Better to allow scrolling.
- The left pane should be hidden even before reaching the mobile
size. This will fix the lack of space for cards and avoid everything
being so small

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I58c88385875469b56542703663e570ab4d63fbdc
2023-08-08 10:10:53 +05:30
Gökay Şatır
c12885c6ec Make insert table popup accessible.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I8dfa71208e22bd26257f2133a85a407afb2fd364
2023-08-07 15:19:00 +03:00
Gökay Şatır
345c8c7d48 Fix js error - notebookbar accessibility.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ic17054cf6e195d8d1d6acb8b5c2a92112084e0de
2023-08-07 15:19:00 +03:00
Paris Oplopoios
a003126a65 Give new sockets a canonical view id in tests
Signed-off-by: Paris Oplopoios <paris.oplopoios@collabora.com>
Change-Id: I0c8a534fccb8088ab303852304802b4926369058
2023-08-05 12:00:08 +03:00