Had to disable a crash test due to incorrect
modification check before unloading.
Because we think there are modifications to
the doc, we issue a save, which will fail
because the kit is killed in said test.
Will be re-enabled when isPossiblyModified
is improved.
Change-Id: I0dd7931308e66e9a12d891a979d54e3f373ef99b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
And now UnitSaveOnExitUnmodified verifies that
we do not unnecessarily upload unmodified
documents because always-save-on-exit is set.
Always-save-on-exit is meaningful only when there
are modifications. Otherwise, we create identical
copies as separate revisions.
Change-Id: I933069d31d3d273c41734b58e0849680566e591a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This improves the disconnected session cleanup
and fixes a corner-case with the last editor
disconnecting before read-only sessions.
Change-Id: Iecb553d7f5be2c63fc55111e60e22b3d8aa668f6
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
After change to dark mode in notebookbar focus will stays to `view` tab.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Id0df0ded18a5858efa15eb0942b1ec69b6a716c2
instead of using hardcoded pixel distance...
affects eg. feedback dialog which was impossible to
access in very small windows due to position outside window
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2a85defcd2aabf1bdb8ec88d70b6e6a873dec75f
Snackbar shoudn't block user interactions with other
UI components. This fixes regression introduced with
vex rework to JSDialogs where snackbar become modal.
This fixes problem with "send feedback" and "Zotero"
snackbars which block users for ~10s from editing.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I71a2d1654b58a89162679346208409124f24b14e
problem:
unselecting shape would make document jump to position where
cursor was before selecting the shape
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I4aa75932631de51e84e3aca9b439f1a9a945e2d3
this patch assumes that dialog ids are incremental,
and no two dialogs are open at the same time unless
one dialog(parent dialog) has triggered another dialog
i.e: calc advance filter dialog triggers warning dialogs,
if entered an invalid range and closing the advance filter dialog
before the warning dialog causes a crash of LOK
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ic4ba3b4553fb0ee089b1ab9b50b1c023801b674a
- hard to find exception if browser logs error at info level
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I9f354480e1ee1d2da8a85973acd7b6563df83291
as far as I can see they are only written to, they are
not read from anywhere.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0faf8f2b087c4b4228ac40e6804694be0f83eb54
problem:
In safari and gnome web when you scroll using scroll bar,
DOM elements on the slidebar and documents would get selected
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I222d246148d5d84a5c0b3cfdb1890350f428e696
Also logs unhandled exceptions from iframe cool.html
Change-Id: I6f7b7d1340c8818d3f81916d42d6d9ed2920e35c
Signed-off-by: Henry Castro <hcastro@collabora.com>
Setting a baseURL cypress verify if the server is
running and prevents to refresh when command cy.visit()
Change-Id: I1cffc0932d6a1ec4ee9793eb3935f60e02ca2545
Signed-off-by: Henry Castro <hcastro@collabora.com>
It has a bug, it executes twice beforeEach function
if fails or unhandled exception.
Change-Id: I005815d440af0309cf797e52fbfb3693896418a9
Signed-off-by: Henry Castro <hcastro@collabora.com>
If it is a remote 'coolwsd' server,
there is no way to rename or copy files.
Change-Id: Ic38302de5ecf3fa08fedd485d6060ede320867bc
Signed-off-by: Henry Castro <hcastro@collabora.com>
If it is already running remote "coolwsd"" server,
there is no way to create a remote work folder.
Change-Id: I17932fcca321e2f7e0cdfcab2ad678dbcffc56ed
Signed-off-by: Henry Castro <hcastro@collabora.com>
It is useful inspect logs and run unit test
with an already running coolwsd instance.
Change-Id: I6b01316d552e3d12bf63db9cc7e813adb33a20c0
Signed-off-by: Henry Castro <hcastro@collabora.com>
"Could not find a Cypress configuration file in this folder""
Change-Id: I7d5b2094d6cd10ca3da2a099650f830bee31dfb1
Signed-off-by: Henry Castro <hcastro@collabora.com>
Helper functions:
checkAccessibilityEnabledToBe
check accessibility state independently from current desktop ui
setAccessibilityState
set accessibility state independently from current desktop ui
Both helper functions check that ui state and a11y support in text
input element are in sync.
Enable/Disable Accessibility Support
test state toggling and state preservation when switching ui
Typing after switching accessibility state
check editable area content after toggling accessibility support
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Icce5ae148024a8abf9b65a90229915f28f720554
Now A11yTextInput inherits from TextInput.
Added hasAccessibilitySupport to both TI and ATI
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ic296afb840824e7901202c9c089c4025c6bb8ab2
Pulled in changes performed by commit:
24c83b9e Rash419 refactor: consolidate mentions-related code in
TextInput.js
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I37577163ec2a8abf0131e276df83d6710dec4f73
Pulled in changes performed by commits:
847ade24 Szymon Kłos Mention popup focus fix
a006c917 Gökay Şatır Focus on the selected comment with keyboard.
02616ed3 Gökay Şatır Don't auto show the comment on Calc.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Icdc510f6d90af1b6f2379b6cbd4317940f0ac0ad
