Commit graph

21462 commits

Author SHA1 Message Date
Marco Cecchetti
24727deee3 remove dup code: TextInput: uniformed code fragments to A11yTextInput
Uniformed code:
  getValueAsCodePoints
  _setupStyles
  _setPos
  _onInput: this._deleteHint
  getValue
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>

Change-Id: I6b5424e0afe3202d65abaf2d5b785b95cc9346c9
2023-07-10 16:02:18 +02:00
Marco Cecchetti
bc782c6b71 remove dup code: TI: _onCommandResult: clear content in desktop case too
TextInput:
undoing something does not trigger any input method
this causes the editable area content not to be a substring
of the document text

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I803c32d243c6331dc21685a6d2ee03919e21a8cf
2023-07-10 16:02:18 +02:00
Marco Cecchetti
b2c8cb32e5 remove dup code: TI: keep _hasWorkingSelectionStart for logging only
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Id8de738846a796be37184ecbc083fbd796620739
2023-07-10 16:02:18 +02:00
Marco Cecchetti
73c10a1d08 remove dup code: A11yTextInput: removed unused code
A11yTextInput:
_tabHint: removed unused property
_isTextContentEmpty: removed unused method
_onComposingContent: removed unused properties
_onCommandResult is no more used since on undoing editable area
content is updated by core through some accessibility message
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ifc31a994661827d4f53891f85c6f7229bea758a5
2023-07-10 16:02:18 +02:00
Marco Cecchetti
abca8e5dd3 Adding support for enabling/disabling a11y support from the ui
Added toggle button/menu entry for enable/disable accessibility support.
This ui feature is available for Online Writer only.
The button/menu entry is added only when accessibility is enabled at
server level.
That allows to enable/disable accessibility per view.
By default, the accessibility support is disabled.
Anyway the accessibility support state is saved to local storage
if available.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: If5968a47f17922038b9da3d320cbed84ebb7688b
2023-07-10 16:02:18 +02:00
Alexander Gabilondo
2ec2f7bcce Translated using Weblate (Basque)
Currently translated at 99.5% (461 of 463 strings)

Translated using Weblate (Basque)

Currently translated at 99.3% (460 of 463 strings)

Co-authored-by: Alexander Gabilondo <alexgabi@openmailbox.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/eu/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic84fed0a093017e8eb3d9b8669ea4c772d3d10bb
2023-07-09 15:07:12 +02:00
Sebastiaan Veld
3dfa51a234 Translated using Weblate (Dutch)
Currently translated at 100.0% (507 of 507 strings)

Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2aa565735b80609e557e2c6e3cdbb081a7f83968
2023-07-09 15:07:12 +02:00
gallegonovato
f030eec328 Translated using Weblate (Spanish)
Currently translated at 100.0% (507 of 507 strings)

Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ibf47f5ccf709c8458ac6e37836fc8bbb103529b5
2023-07-09 15:07:12 +02:00
Michael Meeks
e6c7bf7dc1 tile debug: cleanup and make more consistent tile debugging.
Remove rather bogus timings per-tile; instead in future we should
track how long a tile has been invalid for I suspect, which we
can do more helpfully.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I790ad324b2dba2bc253e4c37c42ddb487666e455
2023-07-08 21:11:25 +02:00
Michael Meeks
b1b35b3a5e tile debug: render directly on the canvas - avoid popup overlay.
Popup overlay performance is far from great, and they can leak too.

Change-Id: Id84391d702e20d067a98349fa96e7a495f02752c
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 21:11:25 +02:00
Michael Meeks
343fcf0306 tile debug: improve alignment and cropping handling.
various offset problems fixed.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I15a039d192353c172a6e88563f791c334731c0eb
2023-07-08 21:11:25 +02:00
Michael Meeks
ebdfc61341 calm down debugging verbosity with debug overlay.
No need to dump entire delta / keyframe content as hex.

Change-Id: I2e3e1bed693a8d33f1cc1f49ddf9f082b5d458b5
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 21:11:25 +02:00
Michael Meeks
02701df2b6 tile debug: remove blue calc grid overlay & re-layer.
Grid is all done on the client side by default now anyway, so
no need to have this anymore.

Change-Id: I92966cbd2953a404575cb71575e3e782acccd694
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 21:11:25 +02:00
Caolán McNamara
902aba1fb7 Extend what we request to include enough to populate a page scroll
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id961b362dec5ce0a9b362dc8ee5a73ceb9eaa1dc
2023-07-08 18:18:46 +01:00
Caolán McNamara
bbc7f2af12 factor out _getMissingTiles as a standalone thing
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I08c2c4f34b2a2114c2906453ee9daeac04b6f441
2023-07-08 18:18:46 +01:00
Caolán McNamara
357f7cf2db bump to latest fzstd release
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I79bcfce90a858ad5a6f432ba8e36b0936c505bf3
2023-07-08 17:20:24 +02:00
Michael Meeks
b963cde3c7 FileServer::LocalFileInfo re-work local file-list management.
Calling a PUT before a GET would cause a SEGV around managing the
internal list of files.

Re-factor to ensure we always have a valid LocalFileInfo to
work with, and simplify and cleanup code-paths.

Change-Id: I2b206bb8bdebc3c44cd55c61048da9b0dc30dbd5
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 13:08:59 +01:00
Michael Meeks
a7d7eeead9 Having an empty canvas doesn't mean a tile has content.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4b568570e0028ea07127acdceb4cb148042e436e
2023-07-08 13:08:59 +01:00
Michael Meeks
d48e332fb0 Render tile debugging on top of tiles + traffic light & delta chart.
top-left rectangle should give a state of the tile:
	green - up-to-date
	amber - present but stale
	red - not present.
Next bar-chart shows the number of deltas applied.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4968a0b23bf34b888eb1de0a960f33d7bc2e8076
2023-07-08 13:08:59 +01:00
Michael Meeks
c5d1bdb2aa Avoid exception during debug mode for update: messages.
Change-Id: I5d77389668428527c3512b3beb6758ad57015d9e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 13:08:59 +01:00
Caolán McNamara
5aa0296d4d fix getPartFromInvalidateMessage
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Idd2cf3a7bf118ff82aaf0ed50c5f8fdd97fe5ee3
2023-07-08 13:08:59 +01:00
Michael Meeks
24d033fd4c tile rendering: pure refactor.
Take all canvas tile rendering through the same function.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I68f1a53d01b1dff9ed9f5d62e4538171e1cfafc1
2023-07-08 13:08:59 +01:00
Michael Meeks
052fbf01a1 Remove obsolete tile grid debugging.
We now have CSections.Debug.TilePixelGrid.name to debug mis-aligned
CSS that doesn't pixel align our canvas.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I9f087cae60b757a67eae5dd6f464c16f1f66f20b
2023-07-08 13:08:59 +01:00
Michael Meeks
48afa99f1c remove unused method.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: If3239be4b4255e5f8b0731c4ecc4d65cceb7b853
2023-07-08 13:08:59 +01:00
Michael Meeks
58659d6ada Ensure that tile.coords.mode is not undefined.
Otherwise tile-cache invalidation fails in impress as we compare.

Change-Id: Ifcf4acbeebe0f384c4fe0de337402c93cb0337f9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 13:08:59 +01:00
Caolán McNamara
4ca9ff6ab9 parse invalidatetiles with optional wid token and preserve it on forward
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I01820d9f74bb12dc75314fc6006666cecdf08da3
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 13:08:59 +01:00
Michael Meeks
789dd2963c Append the wid properly to invalidatetiles and parse it too.
also re-work parseInvalidateMsg to not use std::pair<> returns.

Change-Id: I724783b7050a1ee251dfbe9b2f1e0ea02e7d45f2
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 13:08:59 +01:00
Michael Meeks
6d697de175 tilecache: update the wireId on the last keyframe/delta if necessary.
A zero size delta means we're effectively up-to-date for this new
wireId.

Change-Id: I96abdf00648f7c2f833ffd56bd43980265b8d490
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 13:08:59 +01:00
Michael Meeks
3203db2be2 Cleanup includes.
Change-Id: I062579fc7dee2283e6ac62e67c844cf89c3a3188
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-08 13:08:59 +01:00
Ashod Nakashian
1cac1f1698 wsd: test: do not advance to next test on failure
Change-Id: I2831c90e088064f5a254ef8a9809796e8320ed04
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
7fdc33b916 wsd: no default parameters for DocumentBroker::autoSave
Change-Id: Id343cc36886c2768b4af7ee61d9524678c83dc69
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
12bae02ad0 wsd: separate out canSaveToDisk from needToSaveToDisk
Suppressing needToSaveToDisk silently when we cannot
save, because there is no Kit f.e., is unhelpful.

Now we have these two states separated out and
we log appropriate information in each case.

Change-Id: If38798578a7b88600e3f07c88e0bcbf833ae53f0
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
037099fe32 wsd: cosmetic improvements to ClipboardCache
Change-Id: Ie3ccc015203463fcd9f4a9a26826e0d894f9ec50
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
b1d68e4b3a wsd: better context logging for clipboard activity
Change-Id: I83935df41492e0267b924893594002e6665a671d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
e2b8388dfa wsd: test: logging in UnitWOPIFailUpload
Change-Id: I4c51e6a56e5cf28b11a5652b5849ca54c25ee53b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
3fef73a33f wsd: DocumentBroker logging improvements
Change-Id: I9c6f32c087275f48ac559c2fbb05d04da4e00a08
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
22292d630f wsd: test: minor improvements to UnitCopyPaste
Change-Id: I0fe2390806ee736f44d76ab128e911b66b5e059b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
7650d5e175 wsd: remove redundant cast
Change-Id: I0cac85728cd4ade5d78b2a4cb715d0fdde17c832
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
5e343d9ffb wsd: serialize the http status-code numerically too
Change-Id: Ia5d67f295ce0426b160b64b72399950cc3723d7b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
87bce5dc5d wsd: test: merge UnitWopiUnlock into UnitWOPILock.cpp
Change-Id: If051032e2ed9d7a0ab345bdad710ba1eafe92d96
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
4453175348 wsd: improved socket dump state
Change-Id: I5b59461b17a8d94d955cdeff5b6ebbf1573db0bf
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
d50b4e4b1c wsd: test: dump state on test failure
Seems a useful thing to capture the internal
state when a test fails, as it might help
understand what was going on.

Change-Id: I591a88662ab86ab4dc7f39dafcc4d7d279a4d9c4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
aabe6cba8d wsd: clang-tidy warning fix
Change-Id: Id8b6d9987c03d33286c7b2f819776bd571329f3f
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
8ef57dd2ec wsd: better newChild unit-test event
Change-Id: I8403e14780ad0bf971625934b7011fba1f24f07c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Ashod Nakashian
13b6f64d59 wsd: unmount the test mount directory too
We test if mounting is possible by mounting
a test directory. This can leak in crashes
and failed tests, therefore it needs to be
cleaned up too.

Change-Id: I2638cc0863f3f5575f697bece9801d42cd321ed1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-07-08 04:19:00 -04:00
Caolán McNamara
c224a44ead TileSectionManager::_oscCtxs is unused
unlike TilesSection::oscCtxs which is

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iaad8dd61cd0e4432abcc50ca3ca71cdcb96a66db
2023-07-07 20:20:57 +01:00
Andras Timar
1f0013e811 docker: remove obsolete fix
The domain resolution problem from jails was properly solved by
bc8da0cb33
This hack is not necessary in docker.

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I59664b895d187b2a8930a34b096305e0b7c384e3
2023-07-07 19:11:01 +02:00
Gökay Şatır
df9c669c34 Activate the focused tab immediately when navigating with arrow keys.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I76f2db4340a3c832979215c18e06af3e61042a15
2023-07-07 19:12:46 +03:00
Szymon Kłos
1d7be47f03 jsdialog: share code for widget update
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifd348b62f8ca6b6b23836772c5e26d728ad8c9af
2023-07-07 11:58:38 +02:00
Darshan-upadhyay1110
66d42b7a91 Focus back to document when Escape key pressed
* Focus back to document when escape key pressed on any element in Notebookbar
 * Exception: When drop down is already open then focus back to element.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I4b34ae795465ecc402c5228478b7797298acc5a7
2023-07-07 10:52:54 +03:00