if we zoom in calc quickly that can result in still unfulfilled requests
for the first set of tiles from the earlier zoom in requestedTiles when
the new requests are compared with the existing one for duplicates, but
they are of different tilewidth/tileheight and shouldn't match as a
duplicate.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ifc3f905c5304feb6c05696835dcb4eaed7f1e546
AdminModel::cleanupResourceConsumingDocs uses SIGABRT as first
attept to kill misbehaving documents, we should give
DocumentBroker a chance to quarantine documents killed off by
SIGABRT as we do SIGSEGV/SIGBUS
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ic3a703572393050379b5a1444a5380bbeafcf2d3
we emit lots of warnings which are not important
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I59027c4d848a98ba3d9e8f4a3feafd3fcb62dec2
to make main JSDialogBuilder shorter and easier to read.
And move handler to mobile builder as control exists only
on mobile.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9a14c7050711658638d22f0fd7b47e038b5952a1
We only run one task in each thread when run() is called, then complete
the remainder of tasks in the main thread while the other threads wait.
https: //github.com/CollaboraOnline/online/issues/7374
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id4fc0a620d98b0bb55310b495eeff7411a4544b5
if we switch calc tabs quickly that can result in still unfulfilled
requests for the first tab in requestedTiles when the new requests are
compared with the existing one for duplicates.
It doesn't make sense to replace a request for a new tile with an old
request from a different part. But tilecombines are intended to share a
'part', so a single tilecombine shouldn't be synthesized from multiple
requests for different parts.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id8d40f0a7e7f9d32fed67a415756284d7f6a53d4
in which case don't send it, which then implies we might have
an empty shareFDs which we can treat the same as a nonexisting
shareFDs
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I80a78a01c69dbee5ee28a64442a5069a6c2b4dbe
Don't allow dialogs to grow taller than the web browser's viewport
instead,
- Set (for dialog's content) a max of 90% of the View height and subtract the dialog's
header. This way the header with the close button stays always visible
- Set overflow accordingly so it can be scrollable
- Needs to have !important because it seems we need by default
"overflow: hidden;" set to every ".jsdialog-container
.lokdialog.ui-dialog-content.ui-widget-content"
- introduced in afbf052bb5
possibly due to hidden elements that are part of DOM
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I61a2a41d8b1198fe00b939427cde43d247dc08bb
This is still occurring also in Firefox 118.
Anyway it seems to never occur on Windows.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I0e5c643912f2276c60bdba1b2ad1ed801785193f
Some of the options seems to not working on mobile app
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I934e446dfeeab46f26e95898522cb0b7c1cc64a2
detect if video is able to play via checking if any frames are decoded,
in other cases(i.e: file not found or corrupted file) check for the errors in source and video
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I22bfc836a98ec0eb2caa58b89332b2531d69d18f
This commit fixes videos rendering in the wrong place on Safari (and all
iOS browsers). Note that it will still need the server fixes contained
in https://github.com/CollaboraOnline/online/pull/7367 for Safari to
play video
To reproduce, load a document with an mp4 video in Safari (this may also
work with other formats, but we know of unrelated bugs with non-mp4
videos) and click on the place where the video should be.
Before this commit, you will see a white rectangle where the video
should appear. After this commit, you will see the video. If you have
this commit but not #7367 you will see a play button with a "broken
video" strikethrough. In non-Safari/iOS browsers you will see the video
both before and after this commit.
This commit does not include detection for the upcoming Layer-Based SVG
engine <https://wpewebkit.org/blog/05-new-svg-engine.html>. This means
that this commit will *break* video if this is enabled in Safari debug
mode. If this commit is merged as-is we need to make a followup to fix
this as soon as possible or we will end up with a similar-but-opposite
bug when that flag is toggled on by default.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I205e692e7027ad917bd6f29aa96b0ac70a4c9e04
The range header allows a client to specify that they would like only
part of a file, e.g. only the first 1000 bytes of a video. When playing
video on Apple devices (Macs, iPads, iPhones etc.) this is required to
avoid Safari rejecting the video as broken. This is the first part of a
fix to embedded videos on Safari.
This commit does not implement specifying multiple ranges at once (e.g.
bytes=0-9,-100 to get the first 10 and last 100 bytes).
This feature is necessary to play video on Apple devices, but it is not
sufficient. In particular, I believe some further client-side fixes will
be needed to make the video play properly.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Id89a06d374b7d0efbf2b3184d8618df61684dcb6
- don't invalidate the tiles
- don't reload the document if serverId changes
- writer: fix cursor jumps to top the document
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ie42850e77f9011cd1c820115919f10283407f216
We want to re-force the choice, i.e. people who mistakenly set
their UI to compact mode, now will get tabbed mode and can
decide, if they like it better or not.
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic5810321abf2cbc3996478816fe153d848c66c71
Now accessibility support can be enabled in Impress.
Created cypress tests for editable area in Impress
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ia2fd4e55bce3785320ec0cc9f31a6d7550ca3a82
Use new id for snackbar with progress and style it
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I24a1647f0f629b7b079aa65601f4309c339a06e8
Before this, the padding-right was being set to 0 (probably to save up
space) but this is not the way to do it. It looks weird when the focus
is set to that button.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib60b32cd9d0f5f42444cadef121be32c15941483
if complex selection was copied in one window
then we try to paste in other document, then
the same dialog appeared. this commit shows
only progressbar step for "paste" operation
as we don't need to do anything else.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id9c33261dbdfb282d142cdfdf2217b30111263b1
Reusing progressbar dialog allows us to show it's the
same process for the user. So even if it is instant he
will see 100% progressbar and that button become enabled.
Create new file for functions which manipulate existing
modal dialogs.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I765483b940f47bdfbcf8a488ea7d0ab9569ccda9
- use the same id so we can apply common styling
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0fb567fd5b77e3ca57b5ba5cd8d6e1fa29e46fc1
