Commit graph

24642 commits

Author SHA1 Message Date
Michael Meeks
5905e21fe2 Provide errors & close connection on missed unexpected requests.
Otherwise we would not respond at all, leaving the socket open;
possibly related to cool#9349

Change-Id: Iba8a29da6ab0263f2545b9495f15e20f37145de0
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-07-13 19:35:14 +01:00
Caolán McNamara
3afcf306cb use buildLocalPathToJail instead of direct JAILED_DOCUMENT_ROOT concat
e.g. download as pdf/save as pdf

move buildLocalPathToJail to FileUtil instead of JailUtil given
that the JailUtil code isn't built on mobile

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I8d727e9cdffc413c027bfb9dc6b0520a7d591b47
2024-07-12 16:23:09 +01:00
Andras Timar
0c38e4c4e6 Fix branding of COOL Lite in Admin Console
I missed this case in the previous commit.

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I48829591ce20bcfabb239e510041799c41ea50dc
2024-07-12 15:43:14 +02:00
Caolán McNamara
98ad726425 mount_namespaces option doesn't depend on experimental flag anymore
though it is still off by default

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id332a65523932183bfd0468fa3e3fd8f081a2713
2024-07-12 14:13:52 +01:00
Caolán McNamara
cd61f66935 merge duplicate capability dropping code
and add some explanation for why there is use of linux namespaces in
coolwsd itself

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I5d5687cf095de1b7d5d978dcb6ad6a97f6e9c642
2024-07-12 14:13:52 +01:00
Caolán McNamara
4e28a22dd9 allow logRotateOnOpen but sync archiving to proceed without additional thread
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I34d3cdc6e1753c8d8410db2b760035c75df020b0
2024-07-12 14:13:52 +01:00
Pedro Pinto Silva
6b8b316cfb Redesign close document button
So it's more inline with the rest of the icons. Also fix dark mode.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0b27ecc179a139d34aa574617e0af5c3ef91ae81
2024-07-12 12:25:28 +02:00
Andras Timar
c67997c1e7 Fix branding of COOL Lite when key is not present or expired
regression from 246e87fea2
we've got [ERRFMT].js and [ERRFMT].css

Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic59257fedb6d9ae6712f7f9ff16022c01f70112a
2024-07-12 11:51:29 +02:00
Michael Meeks
4a2fbe0c41 Extra trim test for documentation.
Change-Id: I5dbf95be788fd38f4bd117e4bc36cdc14a2fd153
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2024-07-12 09:23:49 +01:00
Caolán McNamara
04cf51c3e4 Drop all (local namespace) capabilities when done with them
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I7b38f33ce37d9a575d963e2ba95976f3a930f352
2024-07-12 09:14:33 +01:00
Caolán McNamara
9e2504b0d0 use a separate mount namespace for each jail process
create mount namespace with local uid 0 just before we need to do the
mounts and create another with the original uid when done.

The inner orig-uid probably doesn't amount to a whole lot in practice,
but its more reassuring to run as not-0.

Disconnect namespace config option from experimental, but continue to
default off.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ia68c1c1c0bc7a91eb158f5d189453b683fea0ef0
2024-07-12 09:14:33 +01:00
Caolán McNamara
f9a6560391 wip: disable log rotation to suppress that thread to make things simple for now
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Id7ed7ad97628558864fee9da43cdc8997d146ae9
2024-07-12 09:14:33 +01:00
Caolán McNamara
ac10c95ed6 use buildLocalPathToJail instead of direct JAILED_DOCUMENT_ROOT concat
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I911a823738a4066de9fdb771e695b717c0cbcde7
2024-07-12 09:14:33 +01:00
Caolán McNamara
1e45a4a5e7 create separate buildLocalPathToJail
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4850121b809eedfb8dc9c720e952aac4e8924b4a
2024-07-12 09:14:33 +01:00
Caolán McNamara
fb9adff2c7 everything becomes a lot easier if we use where tmp is mounted *from*
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I810fb8ed26f6add662d886b4c45fdadf352e2ea8
(cherry picked from commit 8f2bf8ecc5b4890e67b0c65b12e3f150d0f18b97)
2024-07-12 09:14:33 +01:00
Gökay Şatır
0800c9a45f Adjust the cursor heights a bit more.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Iaadc19dc93cd29d2991768ed061b7cdd4b9ab4d8
2024-07-12 10:35:47 +03:00
Gökay Şatır
14d45ca4e0 Add a counter for newly added invalidatios.
Keep only the last created invalidation rectangle.
Set transparency for the rectangles.

Delete the others with the counter.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Iee379afb62bcde519b8cde0bd8405e511344b3fa
2024-07-12 00:08:13 +03:00
Gökay Şatır
38b20a9c1c Remove unused layer.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I3723dd4b660fe53e1faae38c6d9cb7870b5195f5
2024-07-12 00:08:13 +03:00
Gökay Şatır
1ada8c9b8e Use a small section for rendering invalidation rectangles.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I837b71bab42070d744f6a61f463c315c9d4c413c
2024-07-12 00:08:13 +03:00
Michael Meeks
0e8d674617 Trim URIs if necessary, and test that.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4f8cef1fb05a6f8fa8f85010adbf8b0ccd8af9e9
2024-07-11 12:52:30 +01:00
Szymon Kłos
719d8d7b11 following: remove unused old code
we do that in the keyboard handler

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0e2facc86f1dcd63e512665b9eb5046b82afca47
2024-07-11 11:56:01 +02:00
Szymon Kłos
ca5976db0e following: detect key event as soon as possible
it can happen that we will early return from the keyboard handler
and we will not mark we want to stop following

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I28ce533b7f3c1d8c189434d0f51e727ca74cb57f
2024-07-11 11:56:01 +02:00
Gökay Şatır
04d15a170e Beautify shape handles.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I3ddac8339bfa967e82571d5306a1d27f835a7828
2024-07-11 12:54:25 +03:00
Gökay Şatır
9932ad7516 Remove unused files, variables and functions.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I2a3d802905705775ce58266a57d0d50149cf3bfa
2024-07-11 12:54:25 +03:00
Szymon Kłos
c55d429f9d following: instant jump to followed user
When we decide to follow someone - don't wait for the interaction.
Just jump to the followed cursor.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3b28164d90211dc15330d73d266e035ba49751ff
2024-07-11 09:35:48 +02:00
Jaume Pujantell
301437c27f calc: fix edit and remove hypelink outside of edit mode
Right now .uno:EditHyperlink and .uno:RemoveHyperlink only work on
edit mode or inside a draw object, but LOK_CALLBACK_HYPERLINK_CLICKED
is dispatched outside of edit mode.

Since there is no text cursor, the position of the hyperlink is
needed to discriminate the correct field.

Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com>
Change-Id: I8499b430d5e62b904caba5bb5c7c34e784a8b850
2024-07-11 08:47:48 +02:00
Darshan Upadhyay
69d8e29980 Translated using Weblate (Hindi)
Currently translated at 25.4% (155 of 610 strings)

Co-authored-by: Darshan Upadhyay <darshan.upadhyay1188@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hi/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ie76d578c5163daba67b26f6baf61f6d91db58a90
2024-07-10 18:14:12 +02:00
Rob Pearson
a63cb67bb4 Translated using Weblate (English (South Africa))
Currently translated at 100.0% (610 of 610 strings)

Translated using Weblate (English (New Zealand))

Currently translated at 100.0% (610 of 610 strings)

Translated using Weblate (English (Australia))

Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Rob Pearson <rob.dunedin@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_AU/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_NZ/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_ZA/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I547c95395b4d9aba3d33fbd49b2cfc1eb8e547e3
2024-07-10 18:14:12 +02:00
iwonder
dbb82e6ea6 Translated using Weblate (German)
Currently translated at 99.5% (607 of 610 strings)

Co-authored-by: iwonder <iwonder@users.noreply.hosted.weblate.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/de/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0805faadc93972be91ccaa311f21274dd5e94d2b
2024-07-10 18:14:12 +02:00
Sebastiaan Veld
556ac9d147 Translated using Weblate (Dutch)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0152d8d76cd20df4920358f89d14166507ca1fd6
2024-07-10 18:14:12 +02:00
Andi Chandler
47d47ef02a Translated using Weblate (English (United Kingdom))
Currently translated at 100.0% (610 of 610 strings)

Translated using Weblate (English (United Kingdom))

Currently translated at 100.0% (110 of 110 strings)

Co-authored-by: Andi Chandler <andi@gowling.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/en_GB/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_GB/
Translation: Collabora Online/Android app
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia141401c873569951400c8ae6c2c27920017c2c2
2024-07-10 18:14:12 +02:00
TY Wong
d1ff3b1121 Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (610 of 610 strings)

Translated using Weblate (Chinese (Traditional))

Currently translated at 99.5% (607 of 610 strings)

Co-authored-by: TY Wong <wongty@peoplewarehk.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/zh_Hant/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id108f73319a7a04a899b578562aff626e380d574
2024-07-10 18:14:11 +02:00
Cyan Ling
cc3d5201c9 Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (610 of 610 strings)

Translated using Weblate (Chinese (Traditional))

Currently translated at 99.5% (607 of 610 strings)

Translated using Weblate (Chinese (Traditional))

Currently translated at 97.0% (592 of 610 strings)

Translated using Weblate (Chinese (Traditional))

Currently translated at 24.0% (115 of 478 strings)

Translated using Weblate (Chinese (Traditional))

Currently translated at 96.7% (590 of 610 strings)

Co-authored-by: Cyan Ling <stepbystep.jl@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/zh_Hant/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/zh_Hant/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I93dde8bdec63c721373973580ef96fcfb41d9374
2024-07-10 18:14:11 +02:00
gallegonovato
acd30d2913 Translated using Weblate (Spanish)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I1e62c01b7ea457234506219d45d50ab6f98e1a5f
2024-07-10 18:14:11 +02:00
Ihor Hordiichuk
70c0add507 Translated using Weblate (Ukrainian)
Currently translated at 94.4% (576 of 610 strings)

Translated using Weblate (Ukrainian)

Currently translated at 100.0% (5 of 5 strings)

Translated using Weblate (Ukrainian)

Currently translated at 100.0% (110 of 110 strings)

Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/uk/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ios-app/uk/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/uk/
Translation: Collabora Online/Android app
Translation: Collabora Online/UI
Translation: Collabora Online/iOS app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9201cee111136d70a486403974fbaa782f056fd2
2024-07-10 18:14:11 +02:00
Matthaiks
d4ba9c2df1 Translated using Weblate (Polish)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Matthaiks <kitynska@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/pl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id779f108a6e08768fcf4038bd27573b2e9265e62
2024-07-10 18:14:11 +02:00
Andras Timar
8aaaebac2d Translated using Weblate (Hungarian)
Currently translated at 100.0% (610 of 610 strings)

Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hu/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I1866096cdcdeb390514c88cbaa0f45db8ceb30de
2024-07-10 18:14:11 +02:00
Rashesh Padia
a125d459a7 fix: coolwsd getting killed on kit segfault
- regression from a866719

Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: I21b20aabb4dffad3011b75de8d1f373d495a697d
2024-07-10 16:36:34 +01:00
Gökay Şatır
fe96a185e0 Use reference info for Calc other view cursors.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I3d6e198f7aec53826f1234854367c915b8e5df8c
2024-07-10 16:22:43 +01:00
Darshan-upadhyay1110
f99d5f91ad Add 'title' attribute to iframe for accessibility
- Add a 'title' attribute to each iframe element, providing a brief but clear description of the content and
purpose of the iframe
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ie2179e9d39d9f4f00be5eebf7d30509d0b31cc0b
2024-07-10 16:14:00 +01:00
Gökay Şatır
6ff578ceee Make the shape preview semi-transparent also when scaling.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I961b16e45ebe8e22b07a8a197bb6c96658715ded
2024-07-10 15:37:59 +01:00
Andras Timar
1c2684470c cool#9383: build error on FreeBSD
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I287c938bfcdbbdb76dd8f1253e52bb167b440a22
2024-07-10 15:33:30 +02:00
Michael Meeks
c9be106733 Attempted blind fix for transparent tiles / race during load.
Only seen in the wild so far on Wieland Lindenthal's browser &
server combinations; but plausibly (somehow) we could be rendering
blank tiles during a document load progress callback if we've
gone really wrong.

Also cleanup the (non functioning) _duringLoad count to improve
debugging cleanliness.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I9f32d4fa28fa4a60d8439c55b67058bd0c27ec2f
2024-07-10 12:16:53 +01:00
Michael Meeks
d65e227905 Attempt to fix curious assertion around ServerAuditUtil.
[ websrv_poll ] SIG   Fatal signal received: SIGABRT code: 18446744073709551610 for address: 0x730000696e
  Backtrace 26990 - wsd 24.04.4.4snapshot 07bc101:
    __GI_abort                                     glibc-2.27/stdlib/abort.c:81
    __GI___pthread_mutex_lock                      glibc-2.27/nptl/../nptl/pthread_mutex_lock.c:67
    ServerAuditUtil::set(std::string, std::string) /usr/include/c++/12/bits/std_mutex.h:103
    SocketDisposition::execute()                   /usr/include/c++/12/bits/std_function.h:591
    SocketPoll::poll(long)                         /usr/include/c++/12/bits/shared_ptr_base.h:1070

  Also cleanup member naming to match the COOL standard.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4fd6f4d57c3cbfe1edf7121895e5dab7e13fa4fc
2024-07-10 08:32:07 +01:00
Pedro Pinto Silva
33bda41a32 URLPopUpSection: Right align text only if preview is available
Before this commit and when there is no preview the label was being
centered without image resulting in a less than ideal layout with the
label "hanging/floating" there without any visual grouping

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2ffa9f6f97c237ad436029512122dc4d7986a167
2024-07-09 16:16:30 +03:00
Pedro Pinto Silva
c494bbe0f5 URLPopUpSection: Decrease label size and fix link alignment
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1cdc33ebf41a7eb8545851991a39367d89aa3b58
2024-07-09 16:16:30 +03:00
Pedro Pinto Silva
2c31c143ba URLPopUpSection: Set container's width
This new component (previously was being created with leaflet) was
missing the 301px width that we used to have in the legacy code. Thus,
and without it, the container was over stretching

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie9d782497af723eb9fc3768e64ff48d3826409c0
2024-07-09 16:16:30 +03:00
Andras Timar
92aed77857 Update Helm Chart with new release 24.04.5.1
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If2a79dd449ef665685d64378ac75c5f90ca8f01f
2024-07-09 10:53:12 +02:00
Caolán McNamara
e036357893 ls -lR alike filesystem listing utility
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4849dae47972be7215c50e06493f4e70d73c2eb7
2024-07-08 20:01:25 +01:00
Miklos Vajna
f543a1da9d fuzzer: initialize client context of the ssl manager
clientsession_fuzzer: ./net/Ssl.hpp:114: static ssl::CertificateVerification ssl::Manager::getClientVerification(): Assertion `isClientContextInitialized() && "client context must be initialized"' failed.
    #8 0x55885edfdc36 in ssl::Manager::getClientVerification() /home/vmiklos/git/collaboraonline/online-fuzz/./net/Ssl.hpp:114:9
    #9 0x55885eded51b in ClientSession::loadDocument(char const*, int, StringVector const&, std::shared_ptr<DocumentBroker> const&) /home/vmiklos/git/collaboraonline/online-fuzz/wsd/ClientSession.cpp:1276:13
    #10 0x55885edd3436 in ClientSession::_handleInput(char const*, int) /home/vmiklos/git/collaboraonline/online-fuzz/wsd/ClientSession.cpp:686:16
    #11 0x55885f1fd1ca in Session::handleMessage(std::vector<char, std::allocator<char>> const&) /home/vmiklos/git/collaboraonline/online-fuzz/common/Session.cpp:288:13

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: If7f346af0e6293bf042c9b211e4efe2dfedbd642
2024-07-08 15:34:51 +01:00