Commit graph

391156 commits

Author SHA1 Message Date
Stephan Bergmann
1f0e049d13 Some more sal_Bool -> bool
Change-Id: I1ddb99cf9b401d11e0701974646e1e22739c14ee
2016-04-25 16:42:02 +02:00
Stephan Bergmann
9788477e3e Some more sal_Bool -> bool
Change-Id: Ic36c3d707e75c541e443cc4c0b4da9625ae08ef3
2016-04-25 16:41:50 +02:00
Stephan Bergmann
da0e5863d8 Some more sal_Bool -> bool
Change-Id: Iaae2c92e011c55f8739ecb7972ef9a3f71300765
2016-04-25 16:41:31 +02:00
Stephan Bergmann
46a795c629 Some more sal_Bool -> bool
Change-Id: I32874fb49b361c14f33810e606ede1e49c1acd30
2016-04-25 16:41:21 +02:00
Stephan Bergmann
c21bc9e5aa Some more sal_Bool -> bool
Change-Id: I2dcc7bb0c8d5a6e205d627330735237f85fd9f9f
2016-04-25 16:41:02 +02:00
Stephan Bergmann
5258b85ff4 Some more sal_Bool -> bool
Change-Id: I997d780abb5fc02156c2e6d7a3ecc34ca46b67cb
2016-04-25 16:40:46 +02:00
Stephan Bergmann
4b9faadd86 Some more sal_Bool -> bool
Change-Id: Ie29e3610ae7fc7a489b367fd6797db7547d47c49
2016-04-25 16:40:18 +02:00
Stephan Bergmann
279f050554 Some more sal_Bool -> bool
Change-Id: I4df1afecfe4c554fa98060e6ba1507911323656c
2016-04-25 16:40:05 +02:00
Stephan Bergmann
1af499d3e7 Cannot extract Any to sal_uInt8
...which has the same underlying type as sal_Bool.  The
/org.openoffice.Office.Writer/Numbering/DefaultBulletList properties FontWeight
and FontItalic are of type xs:short, i.e., sal_Int16.

Change-Id: Id8ea7300b5fda65f7fe7df98d4f8b32c22da9886
2016-04-25 16:37:04 +02:00
Stephan Bergmann
aa04c6d20d Cannot extract Any to sal_uInt32
...which has the same underlying type as sal_Bool

Change-Id: Ief5a9b9a4d286488efe6e67ee72e7cc23d6f4075
2016-04-25 16:31:07 +02:00
Stephan Bergmann
ba84f9ce04 Cannot extract Any to sal_uInt32
...which has the same underlying type as sal_Bool

Change-Id: If0548d2830b5924dec06e487c83a468fe8567c87
2016-04-25 16:30:35 +02:00
Eike Rathke
7e0eeacd1d add English (Mauritius) [en-MU] and French (Mauritius) [fr-MU], tdf#99372
Change-Id: I98a0bc42a7d7f5c0943c9861556392399b9d0313
2016-04-25 14:51:46 +02:00
Stephan Bergmann
758e6f39d9 loplugin:passstuffbyref
Change-Id: Ic214bb8870a67314ec64bb4bc0aa869767cba3ae
2016-04-25 14:01:06 +02:00
Stephan Bergmann
8d1fa417bc loplugin:defaultparams
Change-Id: I82f73ba5a70be06c7fdac67bf8813ea4c0dded41
2016-04-25 13:59:17 +02:00
Noel Grandin
753fa20383 fix Windows build
Change-Id: I35b0d9a1ed6b4929217e75a03132f53844acd5b9
2016-04-25 13:25:29 +02:00
Jochen Nitschke
7812f966ce remove redundant initialization
DataNode has a default initializer who sets all members to 0

Change-Id: If5086fa54701394f9ba3eadd1c130ddede945fb2
Reviewed-on: https://gerrit.libreoffice.org/24331
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-04-25 10:40:10 +00:00
Noel Grandin
d8acc42e5b simplify OPropertyMap init
Change-Id: I4ac86aea7ea391c1c708308b12670005e5eb7d6f
2016-04-25 11:57:07 +02:00
Noel Grandin
a5810faae3 clang-tidy modernize-loop-convert in d*
Change-Id: I0830a41b48e884ef63d32b5873c7007195659bb9
2016-04-25 11:57:07 +02:00
Miklos Vajna
cafc53f8b4 tdf#99452 svx: fix undo of table row edge drag
The problem as seen by the user: if you have a table of 2 rows and 1 column,
and the separator line is dragged upwards by the mouse, then undo doesn't
restore the original situation.

Two items are created on the undo stack: sd::UndoGeoObject and
sdr::table::TableRowUndo. Let's say the table height is 8000 mm100 and the two
cell heights are 4000 and 4000. If the user resizes the first cell, so that its
height is 2000, then the new table height will be 6000. The problem is that
when undo is executed, first sd::UndoGeoObject resizes the table, distributing
the newly available 2000 between the existing rows, and then
sdr::table::TableRowUndo sets the row height of the first row: the height of
the second cell will be larger than expected. Fix the problem by not doing a
relayout during sd::UndoGeoObject, but doing a relayout after
sdr::table::TableRowUndo in this case.

This is done by:

1) Adding a new SdrDragStat::mbEndDragChangesLayout, so that
SdrTableObj::applySpecialDrag() can inform SdrDragObjOwn::EndSdrDrag() that
TableRowUndo will do the layout instead of UndoGeoObject. (This is done only in
case a row edge is dragged, as otherwise it's not guaranteed that a
TableRowUndo will follow the UndoGeoObject on the undo stack.)

2) Adding a new SdrUndoGeoObj::mbSkipChangeLayout, so that
SdrTableObj::applySpecialDrag() can let SdrUndoGeoObj::Undo() not do the
layout.

3) Adding a sdr::table::SdrTableObjImpl::mbSkipChangeLayout, so that
SdrUndoGeoObj::Undo() can let SdrTableObj::NbcSetLogicRect() not do the layout.

4) Marking the table model as modified in TableRowUndo::setData(), so it does
the layout at the end of the undo group.

Change-Id: I8adde3cdad5741e6fcb420e333ce336e18c77cf1
Reviewed-on: https://gerrit.libreoffice.org/24363
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-04-25 09:52:54 +00:00
Jorenz Paragas
474eca1f9b tdf#42949: clean up includes in include/oox/core using iwyu
This allows the headers in that folder to stand on their own and
not depend on any transitively included headers. All changes to
other files are needed to fix compiler errors related to missing
includes that occurred afterwards.

Change-Id: I2083b30763f0b2c1aacdff00226e5f567ae52db4
Reviewed-on: https://gerrit.libreoffice.org/24355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-25 08:51:32 +00:00
Miklos Vajna
65827ea3eb GDIMetaFile: rename members missing their prefixes
Change-Id: Ie21807952d74b89b0e8b6f376f8807737b6685f0
Reviewed-on: https://gerrit.libreoffice.org/24360
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-04-25 08:25:27 +00:00
Samuel Mehrbrodt
b68a722ff5 tdf#89953 Character spacing: Apply changes to sidebar widget also
* Step by 0.1 not 1
* Allow to enter negative values without selecting condensed/expanded

Change-Id: Ibe2898cf77f56e52a276166d2ee882fbd23452af
Reviewed-on: https://gerrit.libreoffice.org/24304
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-25 07:56:16 +00:00
Noel Grandin
adff28271b the container document commands std::set can be static
Change-Id: I00558dad4b8206e5e2a7bf004e32196a15dba3cd
2016-04-25 09:21:44 +02:00
Noel Grandin
b2e2400736 no need to copy the list of available commands on every call
Change-Id: I131f34a94c998f3dd9fd7a457fb213778040c771
2016-04-25 09:18:12 +02:00
Noel Grandin
668e3d422c use std::vector<> instead of embedding next pointers for ErrorHandler data
Change-Id: I759fc0d2bbc113873e2dda8edc8eb2eaf8036626
2016-04-25 09:13:35 +02:00
Stephan Bergmann
a82805f8f9 Kill comphelper::MakeMap
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823
Reviewed-on: https://gerrit.libreoffice.org/24344
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-25 06:11:27 +00:00
Stephan Bergmann
2b68383e44 Kill comphelper::MakeSet
Change-Id: I2e5f8c2cd67406d9d275960a37c4aa45e283eec3
Reviewed-on: https://gerrit.libreoffice.org/24343
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-25 06:11:10 +00:00
Noel Grandin
d848960a3e rename Errhdl_Impl to ErrorHandler_Impl
Change-Id: I2405c74487a869def2436f19917937f69ab32916
Reviewed-on: https://gerrit.libreoffice.org/24310
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25 06:02:27 +00:00
Noel Grandin
f4b8b9ad11 rename EDcr_Impl to DynamicErrorInfo_Impl
Change-Id: Id184df4e4466930ba75e47e257ceb75be2fab34b
Reviewed-on: https://gerrit.libreoffice.org/24309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25 06:01:56 +00:00
Caolán McNamara
924126df79 Pasting -- from a pdf from a fallback font doesn't give -- as output
Type -- into a writer document, on a machine without Courier installed
set that text to Courier. Export to pdf, select inside e.g. evince and
paste to a terminal. You don't get --

0x2D is mapped from unicode 0x2D and unicode 0xAD in the adobe
encoding. So the latter trumps the earlier one and <ADAD> is pasted
instead of <2D2D>.

Reverse the order that the encoding is mapped from unicode so lower
more "ascii" options are preferred over the higher more "unlikely"
unicode options

Change-Id: I8f251253fca468d269493801e668617a935ee15d
2016-04-24 23:46:11 +01:00
Andrea Gelmini
4721c734c1 Translate debug message (no automatic tools)
Change-Id: Ice7515b1c83c6ed7472e744badd400c46e804e26
Reviewed-on: https://gerrit.libreoffice.org/24318
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24 21:31:35 +00:00
Akash Jain
975c833943 upgrade harfbuzz version from 0.9.40 to 1.2.6
Change-Id: Iebaece9f41c92b4455b8857d1720edbcff799191
Reviewed-on: https://gerrit.libreoffice.org/24282
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-04-24 21:29:58 +00:00
Jochen Nitschke
59dc694c9f C++11: disable ctors instead of not implementing them (chart2)
replace the old declare and don't implement pattern
with C++11 delete keyword

Change-Id: I10b14cece4ecaddc5f96ee098b5fa36a8782a0fc
Reviewed-on: https://gerrit.libreoffice.org/24340
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24 21:27:04 +00:00
Jochen Nitschke
3a6e3d7811 remove comment about old compiler issue
left change in place as it improves readability
original commit was 59433cfbff
move scope of variable

Change-Id: I86f7a7c741556d75079bd4cb3cfecafcdd229d24
Reviewed-on: https://gerrit.libreoffice.org/24325
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24 21:25:01 +00:00
Jochen Nitschke
b42842c42c delete unused headers
leftover after 7f2bd81581
and follow-ups

Change-Id: I2e6e200cb085e8ecad1ee1aafc64bbd15558c68b
Reviewed-on: https://gerrit.libreoffice.org/24332
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24 21:21:35 +00:00
Arnaud Versini
6bcb322264 Don't use SolarMutexGuard for returning a constant
Change-Id: Ia6e31d7fe9d90f8094e2043de29a896c9e840c53
Reviewed-on: https://gerrit.libreoffice.org/24347
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-24 21:20:36 +00:00
Stephan Bergmann
68d88e2bda Remove unused comphelper::MakeSequence
Change-Id: I0f34fddbfd709455f1aa2f1bfaa70d72a2752f74
Reviewed-on: https://gerrit.libreoffice.org/24342
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-24 19:37:29 +00:00
Stephan Bergmann
b477a9e0b6 Kill comphelper::MakeVector
Change-Id: I6525f9189b25f007d3ffd190b37c73552a900de2
Reviewed-on: https://gerrit.libreoffice.org/24341
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-24 19:06:02 +00:00
Adolfo Jayme Barrientos
86d32551c2 Updated core
Project: help  aefc01b1da7c55698de8bbcb483c0e8f07738984

This advice is outdated since 2011 and LO 3.5

Change-Id: Ib6a9c59b05b74b47801bf620eacb46b125e4e64a
2016-04-24 17:32:14 +00:00
Eike Rathke
5291e4826a unit test for tdf#99468
Change-Id: I833ad2779d0eda6f5183b2dd062dffaa410a7937
2016-04-24 16:42:39 +02:00
Eike Rathke
ffbe1b43bf Resolves: tdf#99468 do greedy '*' match if substring match is not allowed
Change-Id: I89ac29b7e8c2e8c567e85a5025dbc1f50050465d
2016-04-24 16:42:39 +02:00
Julien Nabet
618e7622d0 tdf#99450/tdf#99462: fix insert twice the same object in Photo album
For tdf#99450, see https://bugs.documentfoundation.org/show_bug.cgi?id=99450#c6 for full details

tdf#99462 is also a consequence of this double insert.
See https://bugs.documentfoundation.org/show_bug.cgi?id=99462#c2

Change-Id: I474495457088b93e0e86ea2e504f61c383ba059d
Reviewed-on: https://gerrit.libreoffice.org/24327
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-24 07:13:55 +00:00
Adolfo Jayme Barrientos
cf9d9a3348 tdf#93060 Start Center: Update this string to dodge problematic term
I’ve never liked the chosen wording of this string; it has been merely
a decorative item, of limited usefulness. So I’ve decided to replace it
with something that describes a somewhat hidden functionality (drag’n’drop)
while avoiding the misuse of the word “sidebar” to refer to the bar
containing the application launcher buttons.

Change-Id: I299e9e1e97a4e7aa176bc7bbc24cf0e9bea5abb5
2016-04-23 18:59:31 -05:00
Eike Rathke
0c5663cfb1 first range can be anywhere before second at RPN end, tdf#96426 follow-up
... not just adjacent to the one at the end. So we actually can handle
INDIRECT("A2:C2") INDIRECT("B1:B3")

Change-Id: Ie8030ebc13bb1ae2246611f5722da97970b8c544
2016-04-24 00:11:08 +02:00
Eike Rathke
f5523a6ef4 FormulaByteToken(ocClose) was always wrong
... should be FormulaToken(svSep,ocClose) instead. Though it didn't hurt
at the end of a formula where this was generated for auto-correction.

Change-Id: I71bd8270ccc268e645eb60298e84acffe39d3a0d
2016-04-23 22:54:39 +02:00
Eike Rathke
0f8a8332a5 more differentiated significant whitespace recognition, tdf#96426 follow-up
Change-Id: I081409a82a9ff64f163115bf4597afbb9b2f5fa6
2016-04-23 22:35:31 +02:00
Eike Rathke
e0875f8e34 narrow down where a space could be an intersection, tdf#96426 follow-up
Change-Id: Ic53a4a0d19a11298895efb28e2786e48a071e72b
2016-04-23 20:42:18 +02:00
Eike Rathke
b0992e1190 fully check for adjacent RPN end, tdf#96426 follow-up
Change-Id: I886e559c6f6041bf4889fdd6d89c12a10be70e5f
2016-04-23 20:24:46 +02:00
Eike Rathke
9a0735bcf9 SC_OPCODE_STOP_... values are exclusive
... didn't harm here though as there are gaps between sections.

Change-Id: If3f4e9e5c41233dc47fde18219c8eb5bc5796d9e
2016-04-23 19:31:15 +02:00
Eike Rathke
4f8d72d068 use FormulaToken::DeleteIfZeroRef() instead of Delete() at some places
The array overflow detecting places that unconditionally deleted the
token in case of overflow should do so only if no reference is held,
i.e. the token was allocated with new and passed immediately without
being assigned to a FormulaTokenRef. Just to be on the safe side.

Change-Id: If2ccabec3725ac73fe82c23f51a291246847cfdb
2016-04-23 17:28:27 +02:00