The problem is that when a Calc tab sheet is moved from one position
to another, the ScConditionEntry aSrcPos member variable isn't updated,
and therefore when deleting a blank sheet in front of a data sheet the
deletion still thinks it's looking at the correct sheet but it is now
out-of-date and as such the conditional formatting references are
invalidated such that all math operations are tested against 0.0 instead
of the actual formula value for the condtional formatting, which has
the side effect of updating cells colors that should be uncolored as
per the conditional formats set on them. The fix is to update this
aSrcPos member variable of ScConditionEntry via the call to
ScTokenArray::AdjustReferenceOnMovedTab from
ScConditionEntry::UpdateMoveTab, which is called on tab sheet move.
This way, the aSrcPos variable is up to date when
ScConditionEntry::UpdateDeleteTab is called, which is called on tab
sheet delete.
Change-Id: I3bbc8111bb1685d6f7f307a15c852c6657f37b3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160234
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
One parameter of SfxStyleSheetBasePool::Make function was changed in
0035573ee7, but that change was not
reflected in the comment. It is now updated.
Change-Id: I89f7c1a6e0424d11acddf1f94d3af370af691b36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161611
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
Clicking the language in the popup Calc's status bar,
it will change the cell range selection language property.
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I1cc218da44eff0a4d3acee7b089e54aaad474379
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161371
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
optimal is measured with kerning on, while text is rendered with
kerning off
possibly a problem since:
commit 36eed54d3d
Date: Tue Jul 3 15:00:26 2018 +0200
Resolves: tdf#118221 whole cell kerning default is off
Change-Id: I0e6de75a89823f6ed58a74782e47feb0a44014e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161666
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
..acter for mouse pointer"
This reverts commit a7649b85f1.
I forgot to rebase this after a the Christmas break.
Change-Id: I78781808d15b81496b1572fb3bf304751ae279a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161668
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
...to: "Monitor any changes in upstream git repo $1 between revisions $2 and $3
that affect files that we copy with our
external/onlineupdate/generate-sources.sh"
(and while at it add license boilerplate and a descriptive comment to
external/onlineupdate/generate-sources.sh)
Change-Id: I2872d04c2db9d3a7226a9e744d84367ae7aa8672
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161665
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
- webtreeview widget does not have any property that define that element is a checkbox or radio button
- added `checboxtype` property
- will help to identify the element type (radio/checbox)
Change-Id: Ic8aa0c3eeb6373566f3507ebf01cee3427a57704
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161043
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161655
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This fixes WHEN the helpful mouse cursor changes to a finger
when over top of a smart-tag.
The impact is MUCH LARGER than just smart tags,
but they were the impetus for the change.
Prior to this patch, it would start half-a-character too soon,
and end half-a-character too early.
Change-Id: I84b1e91ccfac2aa18ec58ddfdea25cd199fc694a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161041
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
This fixes WHEN the helpful pop-up notifies about the cursor
being over top of a smart-tag, and suggesting that the user
can CTRL-clicking to activate the smart tag.
Prior to this patch, it would start half-a-character too soon,
and end half-a-character too early.
It similarly fixes WHEN the helpful cursor pointer changes into a finger
when holding ctrl and moving into the start or end of the smarttag.
Smart tags REQUIRE a plugin, so a unit test is out of the question.
The impact could be MUCH LARGER than just smart tags,
but they were the impetus for the change,
because smart tags are not portions while the other
things (redlines, fields, refs/footnotes, formulas) are.
The net effect on other IsAttrAtPos SHOULD be nothing,
so that still doesn't leave me with anything unit testable.
If I ONLY removed the --index from itrcrsr,
then unit tests in uiwriter9 fail.
Adding aTmpState.m_bPosMatchesBounds = true
(which is the fix for smart tags) makes it not fail.
Adding bPosMatchesBounds OUGHT to obsolete an initial-import --index hack?
While I don't NEED to remove the (what looks to me) hack
(and it actually is super dangerous to remove it)
I really think it is obsolete and thus deserves removal.
Easy to restore if it proves a regression...
So bFieldInfo and bPosMatchesBounds end up doing much of the same thing.
This is one of only two places which sets m_bFieldInfo = true,
the other being a EnhancedPDFExportHelper.cxx which tests pEnd inclusively.
cms.m_bFieldInfo = true;
auto const [pStart, pEnd] = rShell.GetCursor_()->StartEnd();
if (rShell.GetLayout()->GetModelPositionForViewPoint(&pos, center, &cms)
&& *pStart <= pos && pos <= *pEnd)
make CppunitTest_vcl_pdfexport CPPUNIT_TEST_NAME=testTdf157816
is not a good test for this - it passes without --index and !FieldInfo
Change-Id: I77df5e054879eb3bbc82907962b77386811bceac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161034
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Justin Luth <jluth@mail.com>
* The shell scripts that had once been copied from Mozilla to bin/update/*.sh
are now included in
onlineupdate-c003be8b9727672e7d30972983b375f4c200233f-2.tar.xz (which is still
generated from the same
<c003be8b97>
that was used for the original tarball in
3a445cb497 "Turn onlineupdate into
external/onlineupdate").
* The additional modifications in external/onlineupdate/lo.patch are:
** Allowing to pass the list of files into the mar tool via -f instead of on the
command line, to avoid "command line too long" errors on Windows, inspired by
the modifications once made directly in our old downstream sources with
4165dd4e46 "add a way to create mar file from
file", 8e4d49340b "use the new file based
approach for the mar creation", and fb13ed6955
"add the manifest file to the mar file". (To keep things simple for now, it
still uses a hard-coded maximum of 10000 lines in the file, marked with a
TODO.)
** Not failing when "precomplete file is missing!" (There is a comment
// Applications aren't required to have a precomplete manifest. The mar
// generation scripts enforce the presence of a precomplete manifest.
in
workdir/UnpackedTarball/onlineupdate/onlineupdate/source/update/updater/updater.cpp
and it appears to be OK that we don't have such a precomplete manifest file
and just skip that test.)
* In the Makefile.gbuild create-update-info, the create_full_mar.py script needs
to be called with a Unix pathname on Windows, or else the
#!/usr/bin/env python3
shebang in that script would get confused.
* The related Makefile.gbuild targets upload-update-info and create-partial-info
have not been addressed yet.
Change-Id: Iab4e083ddbe99e07d846e202f20c6031e2983e1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161656
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
* Update helpcontent2 from branch 'master'
to 27088ec11fbefefff49820050a411d5d21e32c6d
- tdf#158961 Remove a z-index: 100 rule to keep Safari happy
Modules navigation was not showing up in Safari because it had too
few elements to overflow. For some reason the z-index: 100 rule for
the containing div triggered this buggy behaviour.
Change-Id: I50776401b567d125d086e826ec7a23694bdf6774
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161651
Tested-by: Jenkins
Reviewed-by: Juan José González <juanjosegzl@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
RES_TXTATR_INETFMT will result in a call to GetINetFormat().dumpAsXml()
later and that contains all the info (symbol name, URL) in a repeated
form. And if more info is needed, an SwFormatINetFormat::dumpAsXml() can
be introduced.
Change-Id: I42f941fab79f96927ba6e82fe8bfa6616b67c6a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161653
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Back in 2001, this might have been the primary time
when the thumbnail was generated. Now it is also generated
on file open and file-save. This bug report is at least
one example why regenerating on exit is not desireable.
But are there examples of why a thumbnail IS needed on file exit?
One way the thumbnail can change is viewing track changes,
since toggling track changes doesn't "modify" the document.
What other things can affect the document layout
without be considered a modification?
Change-Id: Ic08fefadb7a2ff594dc2788dfc9cf9e0cc528a71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126649
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
what I'm really after is some vexating not-reproducible oss-fuzz msan
warnings when using libxml2 in the fodt2pdf fuzzer. So lets upgrade
libxml2 to the latest, which requires bumping libxslt, and then requires
a newer liblangtag because of no longer implicit includes that it
depended on.
xmlKeepBlanksDefaultValue and xmlSubstituteEntitiesDefault are
deprecated, we should get around to updating those uses
Change-Id: I8fda0dffda0a7ea65407d246a3121875cb8ad4a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161598
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Commit 401e9408d1 replaced opt.c with
ref.c also for X86_64, which was probably not intended; apply patch only
when needed.
Change-Id: Ie7ca7b88751fb2d7de4d1a27e81c7f60a98359f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161629
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
which libxml2 2.12 will fail on with error:
'Extra content at the end of the document'
Change-Id: I9d5da9fdd826cce8462ede8c510eaea7281b760f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161627
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Ever since 9043c50f5e "INTEGRATION: CWS native62
(1.68.8); FILE MERGED" and its "2006/09/15 14:51:02 is 1.68.8.2: #i67179# new
user dir for all simple-package installation sets" archive installation sets had
set the UserInstallation bootstrap variable to $ORIGIN/../... instead of the
normal $SYSUSERCONFIG/... that is used for other installation set formats.
However, I see no good reason for that, and it interferes with my current work
of making the --enable-online-update-mar `make create-update-info` work again
(which builds a mar file from an archive installation set, so contained a
boostrap ini-file with an unexpected UserInstallation value).
(I don't know about the "installed" installation set format, which also messes
with the UserInstallation setting, so I left that alone.)
Change-Id: I3bd1e00771a4149922c3ce4e4d187abd3889b4ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161650
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
* Update helpcontent2 from branch 'master'
to c8244945b9d36822a2a35edca7bb9111f39ef282
- tdf#156156: add Slide Transition sidebar deck help button's HID
and document how to access it.
Change-Id: I3f5c8e0f65f704389ed27989b29cca2cf0279302
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161107
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to af50ff49da5f2b7288f9a713bb00b89f64988b84
- tdf#155876 UI cmds Calc-Sheet menu (46)
+ Data menu for Calc, text to columns commands
+ refactoring
Change-Id: I81c84de5faab4e6fe61d6d9352fb0efe7f22f12b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161617
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Call vcl::Window::RequestHelp from LOKPostAsyncEvent for
mouse movement. Introduce LOK_CALLBACK_TOOLTIP callback
type, and send it from SwEditWin::RequestHelp.
Intention is, that the tooltip is shown by client at the
current mouse pointer position, which is hopefully not
far away from the point that generated the mouse event.
On the next movement, the client starts a timer to hide
the tooltip. If the next tooltip message arrives, the
tooltip would be updated in the new place.
Alternatively, the payload could contain the coordinates
from the HelpEvent.
Change-Id: I8e96eb6e6983ad8d13b4c5d7be4d51ff3fd11893
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161302
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
At first it seemd that sal_uInt16 may be sufficient for storing possible
values. But as elsewhere unsigned 32 bit variables are used for such
purpose, sal_uInt32 is used which allows having more space for bigger values.
Change-Id: Ic2834ffc0fcabad91175aba3753e832dc1807fbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151006
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
