In the tools module it can be used in more other modules.
Changed the instantiation to increase the counter already in the
constructor, so no need to check if the ID is 0.
Also test for UniqueID
Change-Id: I77c80461875c69496a7e218534d16d6550c168c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170061
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
It's not really needed - it sets values to defaults, which are
already set.
Change-Id: If61edace7975cd438d86ee9774535c0f14868fd5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166275
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Affects x11, qt, win, and possibly mac. Gtk fills the remaining vertical
space with or without this patch.
Change-Id: I30a8f9f97ee4de2c11b8c0c05054d9783a1fb191
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170060
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
document by highlighting the corrosponding entry in the "Manage
Changes" dialog and sidebar panel
Change-Id: I1f31580a4fe764dd800c6db1e9a4e2024db14c6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169692
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
Since a1295cb177
"python: upgrade to 3.10.14 (master only)"
Now it fails with
Traceback (most recent call last):
File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/lxml/setup.py", line 23, in <module>
import setupinfo
File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/lxml/setupinfo.py", line 7, in <module>
from distutils.command.build_ext import build_ext as _build_ext
File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/instdir/program/python-core-3.10.14/lib/distutils/command/build_ext.py", line 13, in <module>
from distutils.sysconfig import customize_compiler, get_python_version
File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/instdir/program/python-core-3.10.14/lib/distutils/sysconfig.py", line 58, in <module>
warnings.warn(
DeprecationWarning: The distutils.sysconfig module is deprecated, use sysconfig instead
make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/external/lxml/ExternalProject_lxml.mk:26: /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/ExternalProject/lxml/build] Error 1
Change-Id: I9000018390b31a65a30ef87d0c500872fc6c9343
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170069
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since a1295cb177
"python: upgrade to 3.10.14 (master only)"
Some builds started to fail with
Traceback (most recent call last):
File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/lxml/setup.py", line 15, in <module>
from setuptools import setup
ModuleNotFoundError: No module named 'setuptools'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/lxml/setup.py", line 17, in <module>
from distutils.core import setup
File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/instdir/program/python-core-3.10.14/lib/distutils/__init__.py", line 19, in <module>
warnings.warn(_DEPRECATION_MESSAGE,
DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/external/lxml/ExternalProject_lxml.mk:26: /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/ExternalProject/lxml/build] Error 1
The problem is that python 3.10 doesn't bundle setuptools so
it's not possible to replace it at the moment
Change-Id: I9a9d077b51f49e912dab4941efe8751c2fcc76e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170068
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
- Remove code duplication - Z decompress with a helper function.
- Split up the code to make it better readable.
- Default status to ERRCODE_GRFILTER_FILTERERROR and only return
ERRCODE_NONE on success.
Change-Id: I27c1ba6198120c66d5348702a6af1ffbfa7c5031
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166274
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
Otherwise, calling different tests one after the other
will fail with
warn:vcl:994718:994718:vcl/source/app/svmain.cxx:497: DeInitVCL: some top Windows are still alive
text = "lu9947181i0ytl.tmp — LibreOfficeDev Base" type = "10WorkWindow", ptr = 0x555b3ab76810
Change-Id: I6124b768e165ed841738d29c6071e7950b58229f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170058
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
UniqueID generates an unique ID (unique for all users of UniqueID)
and keeps the value for the object's life time.
Change-Id: Ic2cc1665e57b1984c231a050f82a330c9dcf1ffc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169691
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170017
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
The current logic is totally flawed.
This is one step better. Don't allow one of the special conditions
to prevent a non-special attribute from being propogated
down the style inheritance tree.
Change-Id: Ib24ba688700e3c1156449a64d89431043a5c85b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169724
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
found by doing some git grepping, we should now have values
for all items in the hierarchy
Change-Id: I397ca7e8f53f53737201385c4c8029b436895c1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170016
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Translate it to ZipIOException.
Change-Id: I7a07a59c0ba301b92f31696355c73ccbdf119ff8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170013
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
See https://fonts.google.com/?query=The+DocRepair+Project
DocRepair project intended to improve compliance with the
ISO/IEC 29500 standard by providing fallback for proprietary
fonts that minimizes text reflow in Office Open XML documents.
Agency FB -> Agdasima
Baskerville Old Face -> Bacasime Antique
Berlin Sans FB -> Belanosima
Cooper Black -> Caprasimo
Lucida Calligraphy -> Lugrasimo
Lucida Grande -> Lunasima
Lucida Handwriting -> Lumanosimo
Change-Id: I82a29bd9eeda88198290134a7906a35b6349a1b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169765
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169828
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Otherwise it fails with
EmbeddedDBPerformanceTest::testPerformance finished in: 426ms
macros_test.cxx:74:Assertion
Test name: EmbeddedDBPerformanceTest::testPerformance
assertion failed
- Expression: xComponent.is()
After this patch, the tests still fail, but for another reason.
Change-Id: I4fc11a9feef79efd71be8d6bab76f8777c92d115
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170012
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
problem:
it was very difficult to select line in online,
specifically in writer if line is very think and
it was almost impossible to select line
Change-Id: Ib641cd3d9795b93d47c78bc8f57211f51714844d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168837
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit a0612242a395e1be1fe8383537bc5a82d6b882ac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169011
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I6727def5dd42ecd5dae3ddd27d2af733b5883e09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170006
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
The issue is that we are trying to set the connector shape properties
too early, but the shapes that we want to connect to have not been created yet.
Follow-up to commit Ie95ccd5bcd4d5c3f9c45c7dcc4f88acc0c9438aa
"tdf#157172 tdf#157460 PPTX import: fix connectors adjustment values"
Change-Id: I63c76535cc718bc46d5c3ed5489b752925cd6a77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170007
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
Probably the only legitimate use of such is self-extracting archives,
irrelevant for LO.
ofz56826-1.zip is an example; given what Info-Zip unzip prints about
this file we don't want to successfully open it.
Change-Id: I9568710227e4a152f9dc7bc356184394d7da8eba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170002
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
In online the client side comments/annotations are used, so to
keep this behavior for presentations we only enable the core side
rendering of annotations when the document is a PDF. No change in
the desktop applitation.
Change-Id: I50ffd1b6d81d2fcf6ef9f821e783ae228e39e4e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169969
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
after commit 85fd526fc6
"fix and simplify the ItemInstanceManager mechanism"
The problem is that some *Item classes in sw/ and sc/
share WhichIds, and a whole bunch of SfxBoolItem
subclasses share the same SfxItemType enum value.
So we ended up mixing and matching objects
of different concrete subclasses in a given
*ItemManager collection.
Add some asserts to the global pool code to catch
issues like this earlier on.
Add unique value of the SfxItemType enum for all
the SfxBoolItem subclasses
Change-Id: I3c8d4e02be1cd412b0292e973a6498df5f8e7102
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170003
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change the condition if the documents are immediately closeable.
Now, save locked documents are not immediately closeable.
Remove the check if in quit or closing docs in SID_CLOSEDOC in
objserv.cxx as it becomes unneccessary.
Remove some extra new lines which are unnecessary changes from
before the patch.
Change-Id: Iab16629fe436f4365000fb2a016bbb1fb49c181c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169983
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Some operations, like DrawViewShell::Activate, trigger FuDraw::ForcePointer.
The latter may call SdrView::PickAnything to test if the pointer is over an
object. In SdrMarkView::CheckSingleSdrObjectHit, the bound rectangle of the
object is tested first, which doesn't need the object's deep processing. If
the point in in the rectangle, the object is processed further, which may
render the object. The hit test is performed using a tolerance.
Commit 56a1f9bea2 (sd: extend test to check
the PDF pages aren't rendered when loaded, 2020-03-26) made sure that the
rendering doesn't happen in the LOK mode. In that mode, the mouse position
is unchanged from the values set in the ImplFrameData ctor. Previously it
was enough for the test, that the initial position was [-1, -1], which made
the point outside of the bounding rectangle of the objects. But an upcoming
fix for the map mode calculations makes tolerance large enough to consider
the point inside the rectangle, which triggers rendering and fails the test.
This change makes the default position [-32767, -32737], which should be
reliably outside of the tested rectangle.
Change-Id: Ie1142729448f7ac3c628880140f123cde66b404e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170005
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This will prevent also opening with RepairPackage, would need to adapt
ZipPackage::getZipFileContents() a bit, but let's hope nobody acutally
has such files.
Also treat path that starts with "/" as invalid, presumably it's not
allowed by APPNOTE.TXT:
"The name of the file, with optional relative path."
Change-Id: Ic694ea2fb34f5de1d490a9a251cf56e4004e9673
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169994
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
