it was disabled in 731f7fe778
"disable pytest_ssl on mac" with no apparent reason
Change-Id: I7d867ad771f1459a598c4ca346390e732929d705
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169985
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(regression from commit 8b333575ee)
So it should only be set if the state is still UNKNOWN. But
SfxObjectShell::ImplGetSignatureState() is called before the repair
dialog is shown, so make sure that the second import (with
RepairPackage) finds both members as SignatureState::UNKOWN.
Change-Id: Ic914016dde6425a4d95fba7f6f66411305553930
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169989
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Limiting the contour wrapping polygon to only opaque pixels
causes clipping of any shadows or other semi-transaprent
areas in the image. So, instead of testing for fully opaque
pixels, treat pixels that are not fully transparent as opaque.
Also, tdf#161833 would cause semi-transparent pixels to be
treated as fully transparent pixels when calculating the wrap
contour for an image. To force the correct contour when loading
a document, force the contour to be recalculated by ignoring
the saved polygon if the contour is set to "recreate on edit".
Change-Id: Ibe256f54e1c82de30c2b7d5b92a69344b4a7ba10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169745
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Currently style:rotation-angle of table-cell-properties is imported
using ::sax::Converter::convertNumber. That imports only integer values
and ignores units. But ODF uses the data type 'angle'. That is a double
with optional units 'deg', 'rad' or 'grad'. A unit-less value is
treated as degrees.
The patch changes the import to use the new method
::sax::Converter::convertAngle(), that was introduced in commit
9f62c7a0f2.
Change-Id: I98c35a762e90b959a005f5bcdf810c5676cc8b6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169891
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
This makes the AnnotationObject to resize the frame to the size of
the text content, or else the text that is too big will be shown
outside the object's frame (rectangle). For some reason we need to
set the object as a "text frame" (mbTextFrame = true) or else it
will not allow to automatically adjust the frame to the text
content.
Change-Id: Ib2b9a7c07626fe8b0a2286cfd67c3bf37cf9af03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169642
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
We are doing a lot of work in ScAttrArray::SetPatternAreaImpl,
where we move the mvData vector of CellAttributeHolder around,
so inline and reduce some of the work.
The move operator= can be simplified, leaving some of the work
to the destructor (which may well be elided when moving
arrays of elements around).
Reduces time from 50s to 39s
Change-Id: I358f48fa30f785f7b3f221079db93ab0288a7f14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169941
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
we now have 16k columns, so storing a flat array of columns
where most of them are empty is bad for performance.
Rather store a sorted data-structure of all the ranges,
reduces time from > 5 mins to ~50s.
Change-Id: I92327daf06469c1b9d1f4c427b8ebf812641a8e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169940
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
The previous `if (bSelected)` body a little bit further
up in `SvxIconChoiceCtrl_Impl::PaintEntry` already
has
rRenderContext.DrawRect(CalcFocusRect(pEntry));
to draw a border around the selected entry.
One border is enough, so don't draw another one
using
`vcl::RenderTools::DrawSelectionBackground`
(pass false instead of true for the `bDrawBorder` param).
For the gen and the Qt-based VCL plugins that use
Cairo rendering by default, this avoids the
additional misplaced and not properly cleared selection
rectangle.
See tdf#144981 comment 6 for where the problematic
handling in the Cairo rendering path is, but which also
mentions that changing this would break other things.
For then gen VCL plugin using Skia (`SAL_FORCESKIA=1`)
or on Windows, I see no visual change for either the
"Hyperlink" dialog (Ctrl+K) or the "Page Style" dialog
(Alt+Shift+P) in Writer with this change in place while
moving focus between entries.
On Windows, when moving focus out of the icon choice
control (into the tab page), the border now remains
black on all sides instead of being partially black
(at least the top border) and partially blue (at least
the bottom border), so it's more consistent there as well
now.
Change-Id: I6db415344e9276ce89d41c6b40fb93fc38ddf9a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169972
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
* Drop superfluous check at the start. (Loop will
just do nothing if there are no elements.)
* Use range-based for.
Change-Id: Idbe0ba67268cf76d38b27fcf94e59eb8abd5f566
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169971
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since
commit 35775e291d
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 2 12:34:57 2024 +0200
tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectRect etc.
, that flag is never set, so there's no need to check
for that. Drop it.
Change-Id: Ibc2efdfc9b54c19bb90c2e71cc80e0cb4a0321a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169970
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
instead of generating new ones.
Change-Id: I8979eaa694642cebd552534eeddcff5483831e6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169846
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
instead of generating new ones.
Change-Id: If64690ac2aa22542e6b3939f3ed9cdc3c9f3be84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169844
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
This mechanism to manually sort the entries by setting
a link/pointer to the neighbours isn't actually used, so
drop the code to maintain a linked list.
See
Change-Id: I44eceb41866bb6d99ccea032f98637a42dabc9ee
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 3 10:44:46 2024 +0200
tdf#161853 Drop always null SvxIconChoiceCtrl_Impl::pHead
Change-Id: Ib939145999725232d803103dc1fd0b49fa2d425a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169916
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
With
Change-Id: I13ae34ffc51972bef746e53fcd46e65ea9fbf82c
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 3 10:38:56 2024 +0200
tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::InitPredecessors
in place, it can be seen that `SvxIconChoiceCtrl_Impl::pHead`
is always nullptr as it's initialized to that and never
assigned a different value afterwards.
Therefore, drop it and all related code.
Drop the now unused `bKeepPredecessors` param
from `SvxIconChoiceCtrl_Impl::Arrange` and
`SvxIconChoiceCtrl_Impl::ImpArrange`.
(Use `git show --ignore-space change` to more clearly
see the "actual changes").
Change-Id: I44eceb41866bb6d99ccea032f98637a42dabc9ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169914
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Both methods are unused since:
Change-Id: I926b03a0f2054c21f8ab96eeee0083156443d2c0
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 3 10:17:41 2024 +0200
tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::SetEntryPos
Further cleanup will be done in following commits.
Change-Id: I4a412389669f9cbc6701b7ed78bd45f838e13590
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169912
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The flag is never set, so there's no need to
check or clear it either.
Change-Id: I63ab1272140a0d5386538e6b749ba0f652f49c38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169910
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
The flag is never set, so there's no need to
check or clear it either.
The only method setting it
(`SvxIconChoiceCtrl_Impl::LockEntryPos`) was dropped in
commit 18d18c8a56
Author: Joseph Powers <jpowers27@cox.net>
Date: Sat Jul 23 07:16:14 2011 -0700
unusedcode.easy: svxIconChoiceCtrl_Impl
Doing List cleanup, I ran into SaveSelection() and decided to delete it.
While I was in the class, I went ahead and cleanup them all up.
, but that method was already unused by then.
Drop the flag and related code.
Change-Id: I9b886f3a63444d502ef8c488437889a2b05e065a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169909
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
It's initialized to true and since
Change-Id: I0c6f191017b13fffee57d1e5eba1c03c05736ee2
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 3 09:09:22 2024 +0200
tdf#161853 icon choice ctrl: Drop WB_SMART_ARRANGE handling
, the value never changes, so drop it and simplify
accordingly.
Change-Id: I05007727e29a7884165fa25c668f139a96b7c4c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169905
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
That flag is unused since `OApplicationIconControl`
was ported away from using `SvtIconChoiceCtrl` in
commit fd2ea8e035
Date: Wed Aug 19 14:59:33 2020 +0100
weld OApplicationSwapWindow
, so drop it.
Change-Id: I0c6f191017b13fffee57d1e5eba1c03c05736ee2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169904
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Since
commit af9413cb4a
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 2 11:53:27 2024 +0200
tdf#161853 icon choice ctrl: Drop support for non-single selection modes
, the `IconChoiceFlags::DownDeselect` and `IconChoiceFlags::DownCtrl`
flags are never set, so `SvxIconChoiceCtrl_Impl::MouseButtonUp`
wouldn't effectively do anything.
Drop it and the now unused flags.
Also drop the `SvtIconChoiceCtrl` override for
`Control::MouseButtonUp`.
Change-Id: I06808726389f31a426cba36e627b4305fb362bee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169903
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since
commit af9413cb4a
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 2 11:53:27 2024 +0200
tdf#161853 icon choice ctrl: Drop support for non-single selection modes
, `SvxIconChoiceCtrl_Impl::bHighlightFramePressed` is always
false, so drop it and the corresponding handling.
This also means that the `bKeepHighlightFlags` param
for `SvxIconChoiceCtrl_Impl::SetEntryHighlightFrame`
is now unused, so drop that as well.
Change-Id: I278318b2bda14b06339a375b683a49f8594e2e34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169902
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Variable gb_POLOCATION is empty.
include langlist.mk after TargetLocations.mk
Change-Id: I3e82624df84700c922d116b32a366c0e6b424235
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169928
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
