Commit graph

497835 commits

Author SHA1 Message Date
Mike Kaganski
aa7cf0ec4b Simplify m_xNumFormatAgg use
Change-Id: I48017e8b1bca2f857afebdd1e90deca86b69451c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170134
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-09 05:46:26 +02:00
Mike Kaganski
493b8ab997 Simplify comphelper::query_aggregation
Change-Id: Id673c27e21c6706367f2effc92bbea61c83a5482
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170133
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-09 05:46:19 +02:00
Jonathan Clark
6a54d08e6e tdf#56408 Writer always breaks lines at text direction change
This change implements line breaking underflow for bidi portions.

Previously, Writer would always treat the start of a bidi portion as a
valid position to insert a line break. This caused incorrect line
breaking behavior in certain situations where LTR text is followed by
RTL text with no valid break position between, or vice-versa.

Now, Writer will correctly insert the break at the previous valid
position, rather than always breaking at the direction change.

Change-Id: If4627f4d65d2c44b65653c689ee00a2e0cb4456a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170154
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-07-09 01:32:07 +02:00
Rafael Lima
81f2185c11 tdf#161709 Make selection rectangle symmetric at any zoom level
The previous method to calculate the rectangles used to draw the cursor did not play well with fractional numbers, making them look asymmetrical at some zoom levels.

This patch makes sure that the cursor is symetrical at any zoom level.

Change-Id: I196177e6722772db3a8c8ad343e35c148e4772a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169546
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
Tested-by: Jenkins
2024-07-08 21:54:18 +02:00
Rafael Lima
7383298e14 tdf#161817 Fix Autofill overlay when zoom is low
Prior to this patch, the calculation of the offset to draw the outline was incorrect, which caused the two lines of the outline to overlap.

This patch fixes this issue and makes the outline work at any zoom level.

Change-Id: I95d0b240a53beda872cdf6f0e7d75b48966217d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169665
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
Tested-by: Jenkins
2024-07-08 21:53:20 +02:00
Caolán McNamara
2b0a522bdd cid#1607756 PA: Public Attribute
Change-Id: Ib2f9bff17f865dad2574e5dfe53fba107e4aa81a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170140
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 20:38:06 +02:00
Caolán McNamara
257551a929 cid#1606535 PA: Public Attribute
Change-Id: I1ef55ce7a2ba32ae67a881505ad202fdb8873661
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170139
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 20:37:59 +02:00
Noel Grandin
7e274df5d1 make some of the SfxStringItem subclasses hashable
Change-Id: I7ad748b67266926f1e4e67e843a90b5ac3fe58b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170152
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08 19:25:53 +02:00
Noel Grandin
a6f89b3883 make SdrCustomShapeGeometryItem hashable
Change-Id: Id27784da750e2cc9913c0d00df6e0b10d080f663
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170145
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08 19:25:34 +02:00
Marco Cecchetti
9aaf21b285 sd: function to return a presentation info in a JSON document
The presentation info includes properties like document size, if the
slide is visible, master slide information and similar.

[ Miklos: don't refer to removed tools::ScopedJsonWriterArray. ]

Change-Id: I5b0acff2ee0df351dd1859e02695ca249e17c391
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170155
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-08 19:18:46 +02:00
Christian Lohmaier
6211461c50 Update git submodules
* Update translations from branch 'master'
  to a9266fc54a66142dba20625f94d196898070ca0d
  - update translations for 24.8.0 rc1/master
    
    and force-fix errors using pocheck
    
    Change-Id: I696fda5336e4c075c43ebbdddc1974e5f1c6fe65
2024-07-08 18:21:51 +02:00
Tibor Nagy
611dc34f19 tdf#159900 sw: fix Figure tag placement attribute when exporting to PDF
Paragraph tag is a possible parent element for the Figure tag.
Figure tag and (any structure element) may have a value of “inline”
as a placement attribute and thus, may be a child of a Paragraph tag.

Change-Id: Ie1e0221976dbcfbae9ff01b1c9b76dd2d2e7edcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170015
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-07-08 18:19:26 +02:00
Heiko Tietze
3d0411ef53 Resolves tdf#161421 - Keep soft hyphen always visible
Soft hyphen is now visible as printable character unless
the non-printable is switched on together with the respective
option; and soft hyphens are always black in the printout

Change-Id: Ief84f986e3d1fa5b11eed827d1a94cf0aef46d10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170158
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
2024-07-08 17:38:39 +02:00
Caolán McNamara
7a5d0c413f Resolves: tdf#161478 Insert button not updated on switch tabs
regression since:

commit fbd79c6125
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Wed Mar 20 11:56:03 2019 +0000

    weld SwFieldDlg

Change-Id: Ifb4f107bb8d4d53ae81b8ce38a87c9774112b617
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170150
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:30:02 +02:00
Caolán McNamara
71f0883939 cid#1609594 COPY_INSTEAD_OF_MOVE
Change-Id: Ib21902ed1279710ae1cd15b6e153ff155b57d35e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170100
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-07-08 16:29:50 +02:00
Caolán McNamara
04a5eff9fa cid#1608405 silence Unchecked return value
Change-Id: Iceb414227a67c13efb549857c2943eb3bc495bef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170130
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:29:42 +02:00
Caolán McNamara
6b7bd732e2 cid#1608145 silence Unchecked return value
and

cid#1606678 Unchecked return value
cid#1607752 Unchecked return value

Change-Id: Ic611e2d9db17350a5aacbfb2b7c3f933aaea4afb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170129
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:29:35 +02:00
Caolán McNamara
d6f1c2c2e8 cid#1555801 Unchecked return value
Change-Id: I2fbc0b65b081da5776c49962ff3b6a36b76808da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170128
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:29:28 +02:00
Caolán McNamara
d9365813ab cid#1608463 COPY_INSTEAD_OF_MOVE
Change-Id: I7f7473fa9f0f5985460bc3e5f48b2d6c413f8d04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170126
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:29:21 +02:00
Caolán McNamara
b4564b803b cid#1608336 COPY_INSTEAD_OF_MOVE
Change-Id: I71288cc765b4bcdda35a2a1415537966018806ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170125
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:29:12 +02:00
Caolán McNamara
22802bf3c3 cid#1557639 COPY_INSTEAD_OF_MOVE
Change-Id: I02c8486503a54d1ddcdf80f9d7c7ee6389e4e05c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170104
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-07-08 16:29:03 +02:00
Caolán McNamara
f8480844a6 cid#1556887 COPY_INSTEAD_OF_MOVE
Change-Id: I7e93494191e11c82af9e66ddd467a73f6bc60490
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170103
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:28:55 +02:00
Caolán McNamara
698e89b4fd cid#1556141 COPY_INSTEAD_OF_MOVE
Change-Id: I8bc73176ab44a08553938bb0e9b236639b39a5cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170102
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-07-08 16:28:47 +02:00
Caolán McNamara
4f23893627 cid#1556123 COPY_INSTEAD_OF_MOVE
Change-Id: Ib09e27591987ac1565205cff5c1396ba674c5bfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170101
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:28:39 +02:00
Noel Grandin
6e560140d9 make SvxMarginItem hashable
Change-Id: I9e0d23a81186231ebe314c14993b93e7c8a9d844
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170149
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-07-08 15:43:00 +02:00
Noel Grandin
d05a451fcd make SvxDoubleItem hashable
Change-Id: Ia52a4ce4bd9390872a89bdea0182de697e209180
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170148
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08 15:32:33 +02:00
Noel Grandin
6d3dd30b53 make SvxB3DVectorItem hashable
Change-Id: I759d5f225769d3833c6da664793a9d400a398a51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170147
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08 15:32:25 +02:00
Miklos Vajna
62fb52cd43 tdf#161771 sw content controls: fix DOCX export of empty dropdown list item
Open the bugdoc, save as DOCX, try to open in Word: Word refuses to
open, saying that the file is corrupted.

Each dropdown item has a value and a display text, it seems it's OK to
omit the display text, but the value really should not be empty.

Fix the problem by first trying to copy the display text to the value if
the value would be empty; and if both are empty, then just omit the
dropdown item.

Note that the trick used at display text won't work here, omitting the
value attribute (instead of writing an empty one) is still invalid DOCX.

Change-Id: I4ae86aaf1a11cc8fd7c276634647f5737a9b04e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170142
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2024-07-08 15:00:29 +02:00
Noel Grandin
d3aa585355 make SvxGraphicItem hashable
Change-Id: I2cfca6f61c0247947855f40d6b1cdee521e8382d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170141
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-08 14:56:03 +02:00
Caolán McNamara
343e9126f4 cid#1609651 Pointer to local outside scope
since:

commit 5b57fe2501
Date:   Sun Mar 31 00:07:58 2024 +0900

    vcl: clean-up and refactor GraphicFilter::ImportUnloadedGraphic

Change-Id: Iea3438863df4ac23860cea403d1633a1d3892970
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 13:33:47 +02:00
Caolán McNamara
427f0b402d cid#1546429 COPY_INSTEAD_OF_MOVE
Change-Id: If781c94f9a86ff91a64e014af5f04392e2380d3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170081
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 13:33:40 +02:00
Miklos Vajna
2a22025e18 svx: prefix members of SvxGrfCrop
See tdf#94879 for motivation.

Change-Id: Idbba42dd3af7a47db6a56c3a129a4da54af076d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170135
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-08 12:45:04 +02:00
Andrea Gelmini
5f12f5b2ba Fix typo
Change-Id: I2803d7c8ad026af902fdc4260219a397026f6f51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170136
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-08 11:11:56 +02:00
Martin Srebotnjak
d8c694b5d6 Update git submodules
* Update translations from branch 'master'
  to 7ff3bfd58e3959a0f996a42e40de927d38600252
  - Updated Slovenian translation
    
    Change-Id: Iac317055c86ee98e93a504375865f987e91fd08e
2024-07-07 23:16:51 +02:00
Patrick Luby
7e45017b51 Fix build breakage
Commit 942864606d removed m_bObjectValid
from the SwXTextDocument class but one instance of that data member
was still left in the code.

Change-Id: I0addd63173f62f6e8832f54ba94f526d50f22a8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170097
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-07 21:18:54 +02:00
Adam Seskunas
3c8f9d02e8 dbaccess complex/DataSource.java to extras/dataSource.cxx
Port the Junit test in DataSource.java over to CppUnit.
In order to port the test as written in Java the
CRM Database was ported, so add a test for that here as
well.

Change-Id: Ib9ac369e3faaa30207b83368889763f0eb063876
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169071
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-07 20:07:06 +02:00
Regina Henschel
c8bec7d4b3 tdf#161483 enable chart read text rotate angle unit
Without the patch chart has ignored the units in ODF attribute
style:rotate-angle. The patch uses the method
sax::Converter::convertAngle(), that was introduced in commit
9f62c7a0f2

Change-Id: I606dc1e64c6ba5ee7d1f77d67a936e85f437ed93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170083
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-07-07 19:46:47 +02:00
Olivier Hallot
18da0b566d Update git submodules
* Update helpcontent2 from branch 'master'
  to f2bf7ec5f1192052bc00bdb113885a41e6fb901b
  - Fix example for COUPDAYS.
    
    Change-Id: Id63a3d2a80aa0c829d1507185467ff575beaac3a
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170036
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    Tested-by: Jenkins
2024-07-07 17:08:24 +02:00
Xisco Fauli
942864606d sw: simplify code by checking pointer directly
Change-Id: I873e2d8856e9ceb23a5d0ca5b907c332a8238441
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170087
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-07 15:45:06 +02:00
Julien Nabet
a74d996446 Update git submodules
* Update helpcontent2 from branch 'master'
  to a1ed29aa5320041c72f025e43a9eeabe3bdc2289
  - Fix dup in sbasic/shared/vba_objects.xhp
    
    Change-Id: Ia9019ca5f5129f5d2741941df19622de5ee403eb
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170109
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-07 14:15:10 +02:00
Andrea Gelmini
07821a3516 Fix typo
Change-Id: I68649c1b71fa5455f2bc2edd9d773820299e60f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170095
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-07 12:36:13 +02:00
Caolán McNamara
cb57efe8db cid#1546226 COPY_INSTEAD_OF_MOVE
Change-Id: Ie7bc7b7164f12e167fd6a102c5ed10b71077239a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170080
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-07-07 10:42:10 +02:00
Caolán McNamara
98ae74f85e cid#1546189 COPY_INSTEAD_OF_MOVE
Change-Id: Ia286c035d64aa1534606a7561f3b5a89d66315df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170079
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-07-07 10:42:04 +02:00
Caolán McNamara
5c13cfd43d cid#1546123 COPY_INSTEAD_OF_MOVE
Change-Id: I648c23c4dc739aae73e8ec39be801400cb16c79a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170078
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-07 10:41:56 +02:00
Caolán McNamara
578a9d4ab0 cid#1545993 COPY_INSTEAD_OF_MOVE
Change-Id: I3234bce1f3b71f10529d5874552566d7abcb3a95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170077
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-07 10:41:48 +02:00
Caolán McNamara
b8e46cb2f5 cid#1545961 COPY_INSTEAD_OF_MOVE
Change-Id: I40a4dc9bc13bfb769b2f9f15b0ab1ff9490639da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170076
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-07 10:41:41 +02:00
Caolán McNamara
9320cb2f78 cid#1545821 COPY_INSTEAD_OF_MOVE
Change-Id: I41fd2d990c83b88138b18652d41b8b2e55aaa8e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170075
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-07 10:41:34 +02:00
Caolán McNamara
c10a40e2b7 cid#1545729 COPY_INSTEAD_OF_MOVE
Change-Id: I0a811d37996e53b9a9a0bddcc265521a1125d594
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170074
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-07 10:41:10 +02:00
Xisco Fauli
c396c55adf sw: simplify code by using UnoApiTest
Change-Id: I0c8ea8468058de9f78cabaa905f84f674b9be93b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170082
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-07-07 10:39:45 +02:00
Andrea Gelmini
d258b218e8 Update git submodules
* Update helpcontent2 from branch 'master'
  to ce6b950180c0174cd1b73b37b9fbf7310fe56dbf
  - Fix typo
    
    Change-Id: Ie15138e64d647d669a57a4cfa7c530cd43ad294a
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170085
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-07-07 10:17:01 +02:00