This "comment" was actually interpreted as a shell command. Sure, the
"command" was a comment in shell, too, but still, quite pointless to
run it.
Change-Id: If5abeabb1c10d62fa90dcdaf81b3b54af958ba62
Reviewed-on: https://gerrit.libreoffice.org/79292
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit d7cbe885da)
Apparently the use of [UIFont systemFontOfSize:10] familyName] to get
a default font family name is a bad idea. Presumably the return value
from this, ".SF UI Text", is matched against the list of font family
names enumerated from the system. (The "SF" apparently stands for "San
Francisco".) That ".SF UI Text" is not among them, so maybe vcl
chooses some arbitrary other font instead that happens to be a serif
one? If we instead use "Helvetica", at least we get a sans-serif font,
even if it doesn't match the system UI font exactly.
Change-Id: I7ff39d8e7893ce3c27f3f12d227f87209bbc7952
(cherry picked from commit 685e91a7ae)
Reviewed-on: https://gerrit.libreoffice.org/79196
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit ba9f91a909)
Nah. We already have
com_sun_star_comp_Writer_DocxExport_get_implementation as it is called
in this branch.
This reverts commit 98deb6e96f.
Change-Id: Ic5db66420db9ef2477df8d9905ba3525f3b57e5b
Reviewed-on: https://gerrit.libreoffice.org/79010
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit cb61889e87)
They are needed for .docx and .rtf export at least. No idea how we
have managed without it previously.
Change-Id: Iff9224f92520e19d9baa691a9e7cd3c944004eed
Reviewed-on: https://gerrit.libreoffice.org/78125
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 1a0bd0c691)
Reviewed-on: https://gerrit.libreoffice.org/78996
(cherry picked from commit 98deb6e96f)
(I saw warnings about it missing in the iOS app.)
Change-Id: Ib286b107e529e80ec36ffb87059f4f5923867abe
Reviewed-on: https://gerrit.libreoffice.org/77399
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
...that was there ever since 7b0b5cdfee "initial
import", while 2e93541d00 "Resolves: fdo#69220
crash in doc (ww6)" introduced a WW8PLCFxDesc default ctor that initializes all
members (even though it initializes some of them to non-zero, but lets assume
that that doesn't matter here).
Change-Id: I21a75675d59ded81ccb17397f8c464efdfc3d78f
Reviewed-on: https://gerrit.libreoffice.org/80316
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
On Android, SwAnnotationWin::Rescale leads to invoke
ImpEditEngine::UpdateViews which hides the text cursor. Moreover it
causes sudden document scroll when modifying a commented text.
Not clear the root cause, anyway skipping this method fixes the
problem, and there should be no side effect, since the client has
disabled annotations rendering.
Change-Id: I572a9c6b3fe39473a596209413945d777bd79506
Reviewed-on: https://gerrit.libreoffice.org/80244
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Newly created or ODF charts were still exported incorrectly, because
ShiftedCategoryPosition was stored in the view code. Now it is removed
to the model using ChartTypeTemplate::adaptScales.
See also commit 6027ec08fd 'tdf#127777
OOXML chart export: fix X axis position setting "CrossBetween"'
Change-Id: I7cd69e311833bf9f24f3a600ee7c6312285a7738
Reviewed-on: https://gerrit.libreoffice.org/80160
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
/home/vmiklos/git/libreoffice/master-android/sw/source/core/txtnode/txtedt.cxx:1203:41: error: loop variable 'rImplicitChange' has type 'const std::pair<int, int> &' but is initialized with type 'std::__ndk1::pair<long, long>' resulting in a copy [-Werror,-Wrange-loop-analysis]
Just use auto, the copy that was happening here was not intentional.
Change-Id: I2f98519f7891bd52ccf560ba0707ad8eef415e06
Reviewed-on: https://gerrit.libreoffice.org/80364
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
UNX is defined for Android. Other code in the same file has guards like:
#if !defined(ANDROID) && !defined(IOS)
but this is already in an
#ifndef IOS
block, so just check for ANDROID.
Change-Id: I73f92ef5702ec1f1385e2ffa0ea3dbedf7d3b6a2
clean up the memory management here, the SfxMedium wants to own the
passed-in SfxItemSet
Change-Id: I1bafa520ca7b833c4d2df7593649c3720c46e2ce
Reviewed-on: https://gerrit.libreoffice.org/80332
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The existing code handled two situations:
1.) if both position(escapement) and fontsize set via direct properties
2.) if fontsize came from the document default properties.
That misses both paragraph style fontsize (very common)
and character style fontsize. This patch adds checking for
the paragraph style's fontsize.
Change-Id: I25312cd4544cfd1be09b21c96a270cb05e4f5b8f
Reviewed-on: https://gerrit.libreoffice.org/80179
Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Otherwise it may not get rebuilt in Jenkins when flags in the Makefile
change.
Change-Id: I9a06c5bbfd4af2714497c5658d8c523a6c929f68
Reviewed-on: https://gerrit.libreoffice.org/80318
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
There is nothing catching the exception anyway, and this fails
to compile if compiling the plugin with Clang's CXXFLAGS (which
include -fno-exceptions).
Change-Id: Iad9316ad9613e4fd66d0e5a16fd71bbb8066cc2b
Reviewed-on: https://gerrit.libreoffice.org/80299
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
(*) make them all call the superclass operator==
(*) make the base class check which and typeid to ensure
we are only comparing the safe subclasses together
(*) remove a couple of operator== that were not doing
anything useful
Change-Id: Ia6234aed42df04157a5d6a323dc951916a9cb316
Reviewed-on: https://gerrit.libreoffice.org/80308
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
...since 5926b22b5d "The SystemEnvData passed into
the canvas factories appears to be unused". (And the user-provided SvpSalObject
ctor can be removed, at which point the use in SvpSalInstance::CreateObject
should be written without "()" to avoid loplugin:subtlezeroinit.
Change-Id: I4392fa2d697b29c814d7b577a7b1f8c984c05e70
Reviewed-on: https://gerrit.libreoffice.org/80298
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Adding a map to cache values allows me
20s -> 13s to start LO
Change-Id: If343225def253e29696b96f223cdcb54d0d8525d
Reviewed-on: https://gerrit.libreoffice.org/80290
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Update helpcontent2 from branch 'master'
- XML Source is no longer an experimental feature.
See abb6ee1d2a0f40a4a29c60fb0c71c5644294d658 in the core repository.
Change-Id: I486931b9519200a922bd82dfb051c1500ada12d0
Reviewed-on: https://gerrit.libreoffice.org/80309
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
and only the VclMultiLineEdit one which hides the Edit one so remove the unused
Edit UpdataData related functions leaving the VclMultiLineEdit set
Change-Id: Icd9a633d28907b3e5a3d52771b31574984e64d92
Reviewed-on: https://gerrit.libreoffice.org/80228
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
It was passed in as aArg[1] ever since d551190e83
"INTEGRATION: CWS canvas05", but I can't find any current use of that specific
argument in canvas/source/ (assuming that all the factories are implemented
there), nor can I find any trace in the git history of it ever havig been used.
That means that Window::GetSystemDataAny is unused now and can be removed.
Change-Id: I16efe548afb5cc3e0606cffea135f7e6674d5def
Reviewed-on: https://gerrit.libreoffice.org/80295
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Also makes keyboard use to expand/collapse work
Change-Id: I5b9d065ebe4a612ebe9658feb9ff71c504de7982
Reviewed-on: https://gerrit.libreoffice.org/80173
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
