Commit graph

416197 commits

Author SHA1 Message Date
Tor Lillqvist
6ff84c8a89 We have some Objective-C source files, too
Change-Id: I0e8319596c11f7dc2ed9b5660eebe55aaa9ec493
2017-12-01 12:59:43 +02:00
Tor Lillqvist
a7a13045bc We have Objective-C++ and Swift source files, too
Change-Id: I28dadb64b09e5781d4c28c2c5395f448d4b71e44
2017-12-01 12:58:08 +02:00
Mike Kaganski
50acacae13 Remove nonsensical loop
The comphelper::ContainerUniquePtrEquals loops through containers itself

Change-Id: I78181d9b4b951bebcd31f40abedcda0cd3e91973
Reviewed-on: https://gerrit.libreoffice.org/45634
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-01 11:37:05 +01:00
Samuel Mehrbrodt
54d73c33eb editorconfig: xsl files now also use 4 space indentation
Change-Id: I0368f56d1846731d4ec6453aa967cb4907f7df69
Reviewed-on: https://gerrit.libreoffice.org/45633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01 11:35:05 +01:00
Eike Rathke
b56cd80501 Prepare for translated new AutoFormat Table Styles, tdf#101349
Stored in file are resource IDs for predefined style names, user
defined styles are stored with ID 0xffff and display the given
name. The 16 old styles have IDs 0..15, so add strings for the 10
new styles and append those to the already existing IDs assigning
them the range 16..25

Once the final autotbl.fmt file with only new styles will be
available, patch that to change the 0xffff user defined to those
16..25 (0x10 to 0x19) IDs, it is the uint16 immediately following
the style name (Little Endian). Order of styles should match the
one in this change, if not, change the change..

Also, this eliminates the duplicated translation entries in
sw/inc/strings.hrc and instead in
sw/source/core/doc/DocumentStylePoolManager.cxx pulls the
translations from include/svx/strings.hrc

Change-Id: I7827ae22ab05901e6580ff1b9cd812db55f94f7f
Reviewed-on: https://gerrit.libreoffice.org/45544
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-01 11:21:31 +01:00
heiko tietze
7d12aa833a tdf#101349 Rework of table styles for use in Calc
All table styles formatted with General number format
except first row/column as text; financial defined with Currency

Change-Id: Ib4085230b10d398838b42a449e1166780251f9b4
Reviewed-on: https://gerrit.libreoffice.org/45523
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2017-12-01 11:21:13 +01:00
Eike Rathke
889c72a7e5 ofz: guard against binary crap argument counts and ID/OpCode generation
Change-Id: I60e181729713f3b202e880707a79e9da80d9d85d
2017-12-01 10:57:29 +01:00
Stephan Bergmann
09d96767a4 -Werror,-Wunused-private-field
Change-Id: Ia265d565bbc6b9e4c03aa9be66916b926b54bed8
2017-12-01 10:07:05 +01:00
Caolán McNamara
7d1d5a847d ofz: check col/row bounds
Change-Id: Idaa38f400873372330dd06c14800c4a5018c79db
Reviewed-on: https://gerrit.libreoffice.org/45639
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-01 10:03:32 +01:00
Samuel Mehrbrodt
bb1fd2c981 Unit test for tdf#113696
Change-Id: I566cd5d38cf86547b664f0ae9a1c2f8c37edc0ca
Reviewed-on: https://gerrit.libreoffice.org/45560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01 09:54:43 +01:00
Tor Lillqvist
2b0ff1adeb Need to use dynamic_cast and not static_cast here, thanks UBSan and sberg
Change-Id: I95748f75fc4337481ec6574511bf4b1f47fc4587
Reviewed-on: https://gerrit.libreoffice.org/45611
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-01 09:36:17 +01:00
Stephan Bergmann
a1087bace1 loplugin:unnecessaryoverride
Change-Id: I7a685a82dd6452591d4e5460954366bd31acb268
2017-12-01 09:36:03 +01:00
Miklos Vajna
1a0a026a57 EPUB export: handle custom media dir in cover image / XMP metadata
By changing the default to <media dir>/cover.<extension> and <media
dir>/<basename>.xmp.

Change-Id: I736aefafba5aa5208917d9ed40119ca7721cdde3
Reviewed-on: https://gerrit.libreoffice.org/45604
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-01 09:18:01 +01:00
Miklos Vajna
3ed60d22c3 EPUB export: add UI to test custom media directory
Sets the RVNGMediaDir filter data key at UNO level.

Change-Id: I9919e5ca39c9f4f126d1d67946c8bec99ce0381d
Reviewed-on: https://gerrit.libreoffice.org/45603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-01 09:17:43 +01:00
Miklos Vajna
7f0641de76 EPUB export: allow setting custom media dir explicitly
The default is the same <base directory>/<base name>/ as before.

Change-Id: Idb500193a7f6bd901d861e857147832a3ada91d3
Reviewed-on: https://gerrit.libreoffice.org/45602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-01 09:17:22 +01:00
Miklos Vajna
7dcb4fef3b EPUB export: support image popup for images and text
Handle relative links on image / text as data for a popup. Pick the images up
from <base directory>/<base name>/<relative url> as a start.

Change-Id: I9b6183d554e3792aa71dfffc19a671a0e4c302cc
Reviewed-on: https://gerrit.libreoffice.org/45601
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-01 09:17:01 +01:00
Miklos Vajna
553a35bed7 EPUB export: handle footnotes
Stringly speaking just linking from the main text to the footnote
content would be enough from an EPUB point of view, but let's do the
other direction as well, since Writer provides that.

Change-Id: Iba366ef11a8375347d57a650c57baf8e8002e820
Reviewed-on: https://gerrit.libreoffice.org/45600
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-01 09:16:41 +01:00
Miklos Vajna
8f0f8f80c1 EPUB export: don't loose images with links
And actually handle the link around the image.

Change-Id: Ic9b7b9497becf677dbf550c67074c5c588ef8922
2017-12-01 09:16:23 +01:00
Miklos Vajna
035fad219e sw: remove SvStream operator<< functions of layout classes
This could be useful debugging functionality, but:

- we have a layout dump feature already, which is available in
  dbglevel<2 (and even non-dbgutil) builds already
- for SAL_DEBUG() these functions would have to work with an STL stream,
  not with an SvStream

So there is little value in keeping these.

Change-Id: I1d894f79d3e637f5a56d68abda275ea66d5d0635
2017-12-01 09:10:20 +01:00
Stephan Bergmann
719f2e8462 -Werror,-Wimplicit-fallthrough
Change-Id: I9aae6c5689db2b13830915b683baa8667dfe1068
2017-12-01 09:02:12 +01:00
Samuel Mehrbrodt
9e827c4ead tdf#113696 XHTML Export: Prefer fallback graphic
Which is usually png and browsers can read that,
but they can't read our internal metafile format (svm)

Change-Id: Idfd82da630ead69f508b74285081e32315030825
Reviewed-on: https://gerrit.libreoffice.org/45590
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01 08:24:26 +01:00
Samuel Mehrbrodt
f20ba8466b tdf#113696 Add mimetype also to fallback graphic
Change-Id: I6eb7bb66aa688b5668d0eacd2ec7131bec2b6955
Reviewed-on: https://gerrit.libreoffice.org/45585
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01 08:23:50 +01:00
Samuel Mehrbrodt
3c7b177978 Use isEmpty() instead of getLength()
Change-Id: I2b67c3eebea09d8bebe045ca98341e3347b08fc7
Reviewed-on: https://gerrit.libreoffice.org/45569
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01 08:23:31 +01:00
Samuel Mehrbrodt
38602abc2d tdf#113696 Write replacement graphic also to flat odf
Not only to zipped ODF

Change-Id: Ic86656aea31c9fc20862628cdd31698b9904e999
Reviewed-on: https://gerrit.libreoffice.org/45568
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-01 08:20:28 +01:00
Noel Grandin
e7f6fdd5c3 loplugin:unusedfields
The mnRequestedLength fields in formula/ were introduced in

    commit 6ef6dd0122
    Author: Kohei Yoshida <kohei.yoshida@collabora.com>
    Date:   Wed Feb 26 14:32:57 2014 -0500
    Store the length of originally requested array size prior to
    trimming.

but then partially removed in

    commit d7f1f91b19
    Author: Noel Grandin <noel@peralex.com>
    Date:   Mon Mar 3 13:29:43 2014 +0200
    remove unused code in formula/vectortoken

Change-Id: Ic56b6e42682131ee45df7838867145f980f3d601
Reviewed-on: https://gerrit.libreoffice.org/45571
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-01 08:13:06 +01:00
Matthias Freund
7522dc0f5c tdf#75256 Sifr rework of insertcolumns and rows
Change-Id: I1f4dc91e5a89d7f69749a74b1c1a184337c1747a
Reviewed-on: https://gerrit.libreoffice.org/45625
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matthias Freund <matti_lx@secure.mailbox.org>
2017-12-01 07:53:05 +01:00
Marina Latini
c0bad92c51 Typo in Italian autotext
Fixed a typo in Italian autotext TE

Change-Id: Ied020950669930ef657a9269ced7168d64f4313e
Reviewed-on: https://gerrit.libreoffice.org/45627
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-01 07:13:43 +01:00
Julien Nabet
689d98f2bb Use for-range loops in ViewShellManager (sd)
Change-Id: I753e3536b18bae5a162f78a8e30dc3bd89fa80a3
Reviewed-on: https://gerrit.libreoffice.org/45620
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-01 07:10:45 +01:00
Andras Timar
c1fbc21a45 tdf#89713 localize Windows file picker extensions
Change-Id: Ic56df1aeaeee1f027e8b11e8109dd1a3b3708697
Reviewed-on: https://gerrit.libreoffice.org/45586
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-01 05:53:15 +01:00
Samuel Mehrbrodt
6b3cc69fd2 Related tdf#72966 Provide replacement graphic also for metafiles
With this, SVM files are still written to ODF, but accompanied
by a replacement png graphic.

Change-Id: I2c949f100dd5197a10c741baa42ea740f3a1415a
Reviewed-on: https://gerrit.libreoffice.org/45567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-01 02:20:51 +01:00
Marco Cecchetti
f7c841f56f lok: calc: set outline state
use a specific message from the client for set the visibility state of
a group instead of hijacking the update row/column header message

Change-Id: I9634c24bbffaddc916c8ad716ac6d5d31e735a55
Reviewed-on: https://gerrit.libreoffice.org/45445
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-12-01 01:09:08 +01:00
Michael Stahl
6f2f339d1d dbaccess: -Werror,-Wimplicit-fallthrough
Change-Id: I0580a4aec9762e774679ad3d6a567ec4e74c1908
2017-11-30 23:42:46 +01:00
Michael Stahl
f7a5335ef5 xmloff: turn SvXMLImportContext into a no-op base class
Fix the non-obvious and potentially dangerous recursion that is
implicit in xmloff's context code.

SvXMLImportContext::CreateChildContext() now always creates a
SvXMLImportContext, does not delegate to SvXMLImport.

Rename CreateContext to CreateDocumentContext, to make its purpose of
creating only the top-level context more obvious.

With the previous changes to CreateContext overrides in sw,
reportdesign and dbaccess, this hopefully shouldn't break anything.

Change-Id: I9e147bf6297bbac9e8470454881da73f6e39db0a
2017-11-30 22:32:46 +01:00
Michael Stahl
ebb34571c1 dbaccess: split up ODBFilter::CreateContext()
This was handling XML elements at 3 different levels; add some more
context classes to handle the nesting better.

Change-Id: I05d7b2b7dc2d797acd4e97eacb54fa07e32d88e2
2017-11-30 22:32:46 +01:00
Michael Stahl
2bda2100d8 reportdesign: split up ORptFilter::CreateContext()
This was handling XML elements at 3 different levels; add some more
context classes to handle the nesting better.

There was one tricky case: the ORptExport::exportContainer()
can export a office:report element inside office:body
inside report:sub-document, but i don't know how to
create a report like that.

This was previously handled on import via the fallback to
SvXMLImportContext (created for office:body) calling
ORptFilter::CreateContext(), but now it needs explicit handling
in OXMLSubDocument::CreateChildContext_().

Change-Id: I839986599b2b936f57bb65da355ac1be811fe999
2017-11-30 22:32:46 +01:00
Michael Stahl
dfe635d4f5 sw: std::vector<OUString*> considered silly
Change-Id: Ie5141a01b1a63c083d5fce1842a35a9a4b0d36e3
2017-11-30 22:32:46 +01:00
Michael Stahl
2c081e66cd sw: move generic code out of SwXMLSectionList::CreateContext
... into a new class that recursively creates itself
instead of relying on the import class.

Change-Id: I9bb445ba6a5c490293983d4566bab7b066fb8f24
2017-11-30 22:32:46 +01:00
Michael Stahl
346abc6785 sw: move SvXMLSectionListContext out of header file
Change-Id: I18417484a35d67bde3ec2690d834589c3751005f
2017-11-30 22:32:46 +01:00
Gabor Kelemen
f66ace21cd tdf#114124 Translate 'PNG Bitmap' string in Calc Paste dropdown
Change-Id: I8356f241d0742276cf32aa301c35055a7f3c5898
Reviewed-on: https://gerrit.libreoffice.org/45447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 22:09:45 +01:00
Caolán McNamara
d91e3f5fb4 Resolves: tdf#114112 sort 'select' list
Change-Id: I0b80b2f7e8377f92a397b6557d2c3fad3e63f16a
Reviewed-on: https://gerrit.libreoffice.org/45606
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 22:02:37 +01:00
Caolán McNamara
01d64f95dc add mml support to fftester
Change-Id: Ie0c3dd5eddb274cf04b335af6fdcb32b3445d02c
2017-11-30 20:35:26 +00:00
Caolán McNamara
83d51a0d14 ofz: handle empty Gradient Stops
Change-Id: I7e719b21bd21085ffdd0226a4a25d406a4e69351
Reviewed-on: https://gerrit.libreoffice.org/45617
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 21:31:32 +01:00
Caolán McNamara
36818bbfa9 ofz#4406 limit escher object cell area to calc's limits
Change-Id: I9b9b198f1f96c952692d052a9a527086e453779f
Reviewed-on: https://gerrit.libreoffice.org/45605
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 21:25:57 +01:00
Caolán McNamara
19b86af070 silence various coverity warnings
Change-Id: I9ac4c179c30efa9d5950aa2106639d3781dd0308
Reviewed-on: https://gerrit.libreoffice.org/45583
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 21:24:29 +01:00
Caolán McNamara
18a7a5859b coverity#1424266 Uncaught exception
Change-Id: I63b04fba25b09753baa1dd1cac18f44860cdb264
Reviewed-on: https://gerrit.libreoffice.org/45581
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 21:23:53 +01:00
Caolán McNamara
9310a64bbe coverity#1401344 Uncaught exception
Change-Id: Ia102856797e08ff805958f56d2c468eb39aa937d
Reviewed-on: https://gerrit.libreoffice.org/45582
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 21:23:26 +01:00
Stephan Bergmann
b15f79a8f8 loplugin:unnecessaryparen: signed numeric literals
Change-Id: I75c8224452ca9c3711a2ccaca9ecf549fa59cb64
Reviewed-on: https://gerrit.libreoffice.org/45549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30 19:29:21 +01:00
Samuel Mehrbrodt
32efde5cef tdf#113696 Add mimetype to image element
Otherwise browsers don't recognize base64 encoded svg files.

Change-Id: I54d0b87c52a1ca9da1d820751ae32159b88ed28f
Reviewed-on: https://gerrit.libreoffice.org/45528
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-30 17:42:42 +01:00
Caolán McNamara
b17c29d493 ofz: handle empty paragraphs case
Change-Id: I4c928f55881c1f9147eec1018381b3d3064c58ee
Reviewed-on: https://gerrit.libreoffice.org/45592
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 16:56:11 +01:00
Caolán McNamara
3c62ed6b2f size() cannot be < 0 so just == 0 -> empty()
Change-Id: Ie56cc70ba5d60ded64d011f9d8e8fa9895789a38
Reviewed-on: https://gerrit.libreoffice.org/45591
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30 16:55:49 +01:00