Commit graph

431076 commits

Author SHA1 Message Date
Noel Grandin
ce6ac77816 remove unused PolyOptimizeFlags enum values
Change-Id: I3a2145277212b7b45c25bea2e33aae3f6f4a7776
Reviewed-on: https://gerrit.libreoffice.org/64066
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27 10:17:25 +01:00
Noel Grandin
33e80611c4 remove unused SubsFontFlags flags
and document in the registry that the SubstFontsPS is unused

Change-Id: I66a9e0b4353f17b34cffb02823726c9887b7bdd3
Reviewed-on: https://gerrit.libreoffice.org/64065
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27 10:16:40 +01:00
Noel Grandin
11fc3b52db remove unused BmpDitherFlags enum values
Change-Id: I09a0eb661b66da78d8b3809124930bc761960712
Reviewed-on: https://gerrit.libreoffice.org/64064
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27 10:15:31 +01:00
Noel Grandin
190de05d55 remove unused DrawButtonFlags enum value
Change-Id: I5e1a92d94e5b7963c8162b74f1b67dbbf3eeccc9
Reviewed-on: https://gerrit.libreoffice.org/64063
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27 10:15:14 +01:00
Noel Grandin
40c487469b remove unused HelpEventMode enum value
Change-Id: I0fffa7b02ac61ef009e566d04b903cc02e9b4b3d
Reviewed-on: https://gerrit.libreoffice.org/64062
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27 10:14:46 +01:00
Noel Grandin
ba51e42167 remove unused GraphicManagerDrawFlags enum value
Change-Id: I9e832da8f6b7a90d72c07ab712cbe00774496b76
Reviewed-on: https://gerrit.libreoffice.org/64060
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27 10:14:13 +01:00
Caolán McNamara
f7934ebccd suspicious has-default on help buttons
Change-Id: I604e3bf6362271e767a4862a2c9d789a2c89df88
Reviewed-on: https://gerrit.libreoffice.org/64070
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27 09:55:26 +01:00
Tor Lillqvist
c76160c6e2 tdf#114839: Drop ancient AquaBlinker crack
Most probably that was related to "pulsating" buttons that haven't
been used since 10.9. Whether the code even worked (made buttons
pulsate) on 10.9 anyway is unclear.

Much of the code in this file uses various HITheme (Carbon?) API that
as far as I know is long since deprecated and undocumented. It's weird
that it still compiles, and that it doesn't get caught by the private
API use checking when submitting to the the Mac App Store, in the
LibreOffice Vanilla case.

This change reduces the busy looping in Dialog::Execute() even when
nothing happens (no user input, no mouse movement) when displaying a
dialog.

Change-Id: I9c62db608f637aa5d8493176feb2873f6426fd00
2018-11-27 10:35:01 +02:00
Miklos Vajna
e30f3e76a9 tdf#120527 svx GraphicObjectShape: handle XBitmap for GraphicURL
This restores compatibility for API users who called getByName() on the
bitmap table and expected that the result can be set as a value for the
GraphicURL property.

The case is similar to the Writer images, which was handled in commit
587803ba46 (sw TextGraphicObject: handle
XBitmap for GraphicURL, 2018-08-08) already.

Change-Id: I3740a68989b306425d0d6c4d4e350ac163cb4170
Reviewed-on: https://gerrit.libreoffice.org/64069
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-27 09:04:21 +01:00
Tor Lillqvist
a7f57d86c7 Bump minimum macOS run-time version to 10.10
It is much over a year since we bumped to 10.9, so it is time.

Bumping to 10.10 will allow us to with good conscience get rid of some
code that (presumably) tries to emulate some aspects of OS X user
interface look that went away in 10.10. See tdf#114839.

Change-Id: Ic41f73d8e59a40c4696069af85bb3ff33146086c
Reviewed-on: https://gerrit.libreoffice.org/63880
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-11-27 08:35:44 +01:00
Noel Grandin
1f5fa39b45 remove unused GRFMGR_AUTOSWAPSTREAM defines
Change-Id: I01321f82958bbf22838554010abf706a3e9b9391
Reviewed-on: https://gerrit.libreoffice.org/64061
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27 07:27:08 +01:00
Noel Grandin
30c953423a remove unused QuickHelpFlags enum value
Change-Id: Ia40e882af0df396895a19dd34caa60461cdf6c12
Reviewed-on: https://gerrit.libreoffice.org/64059
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27 07:26:35 +01:00
Rahul Gurung
851c80fdf6 tdf#45904 Move _XLinkTargetSupplier Java Tests to C++
Change-Id: Idd62a6458d7aa0d1d8a479f5ebf78637e0360548
Reviewed-on: https://gerrit.libreoffice.org/63950
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-27 04:12:53 +01:00
Markus Mohrhard
3f2b8db38c add test for tdf#108027
Change-Id: I1048d86bf11b4fdd4a5c90f6e98276893b8ffbf4
Reviewed-on: https://gerrit.libreoffice.org/64078
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-27 04:10:13 +01:00
Miklos Vajna
f21d2b48bd tdf#121723 vcl: leave popup mode on focus loss of toplevel windows
This way it can't happen that we open a menu or context menu, the user
switches away (loosing focus) and a leftover floating window is still
there.

Handle this at the same place where we stop blinking the cursor on focus
loss.

Change-Id: I4321e8e3fa1d3f8976c0a1fa29c6a182972023bf
Reviewed-on: https://gerrit.libreoffice.org/64053
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2018-11-27 00:57:39 +01:00
Tor Lillqvist
27e517b2e5 Fill buildid in versionrc for iOS with the git HEAD hash
Previously it tried to use a BUILDID Make variable that did not exist.

Change-Id: Ie31eb3928c69dc52fcb17a9a5593cbe166d95307
2018-11-27 00:09:26 +02:00
Xisco Fauli
8efb302a44 tdf#121647: fix regression from 85b3c799ed
the pCP = pCodePairs statement was left behind in

- std::vector<sal_UCS4>::const_iterator itInt = aSupportedRanges.begin();
- for( pCP = pCodePairs; itInt != aSupportedRanges.end(); ++itInt )
-     *(pCP++) = *itInt;
+ for (auto const& supportedRange : aSupportedRanges)
+     *(pCP++) = supportedRange;

Change-Id: Icedf7a4dae224f6b328f924691ec4c6767495389
Reviewed-on: https://gerrit.libreoffice.org/64038
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-26 23:01:04 +01:00
Xisco Fauli
2bb070f95a tdf#120879 Remove has_default from help
Change-Id: I5b776f89b7a49307e7a3ed4382f28ac58fc738ff
Reviewed-on: https://gerrit.libreoffice.org/64054
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26 21:48:41 +01:00
Jim Raykowski
73616a273d tdf#105225 Use derived background tab page in Paragraph Style dialog
Missed this one in Change-Id: I47f9ae10a0fd967729ff6e83c1a312aa49e1d13c

Change-Id: Ibb825a922e7d7fcc31456386935b3a847642ebf0
Reviewed-on: https://gerrit.libreoffice.org/63966
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-26 21:29:58 +01:00
Andrea Gelmini
7d58fd88fe Fix typo
Change-Id: I339e1d956ed6f3017453237f0b8ad540d7d4ad20
Reviewed-on: https://gerrit.libreoffice.org/64068
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-26 20:50:37 +01:00
Noel Grandin
0111686c21 remove unused SalLayoutFlags enum values
Change-Id: I5d1559c2cb201ec69fc6353aaf491fbb5c0534dd
Reviewed-on: https://gerrit.libreoffice.org/64047
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 19:13:38 +01:00
Noel Grandin
b8b7963302 remove unused DrawModeFlags enum values
Change-Id: I86775a5b7609f5e85c8fcc18a0be7e0ee3c8f84c
Reviewed-on: https://gerrit.libreoffice.org/64046
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 19:13:20 +01:00
Noel Grandin
b3505dd7ad remove unused enum value ConvertDataFormat::PDF
Change-Id: I61023dc049b914fee1d5d8918b99972d34a82b4a
Reviewed-on: https://gerrit.libreoffice.org/64042
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 19:13:08 +01:00
Noel Grandin
37b3502b5c remove unused enum value SplitWindowItemFlags::Invisible
Change-Id: I4d63601ca3658b4ffd9eaf1c13d4c17503640aa0
Reviewed-on: https://gerrit.libreoffice.org/64041
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 19:11:57 +01:00
Noel Grandin
361fa01df3 inline FindPositionsByName in a couple of places
it is no more complex, and it saves us the construction of an
intermediate vector

Change-Id: Ie92c2970c5b10805d7bcfc0cc2a74378f2cbda08
Reviewed-on: https://gerrit.libreoffice.org/64039
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 19:11:46 +01:00
Michael Meeks
b62c43d120 Anti-alias toolbar button drop-downs.
Change-Id: Id4eed12f3d4a32b71d00b99e6e82ca7cefb3f8ec
Reviewed-on: https://gerrit.libreoffice.org/63961
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-26 18:54:08 +01:00
Roman Kuznetsov
d608b0af3f tdf#117720 Delete Max from list Min and delete Min from list Max in CF dialog
This changes how the list items are identified in the code, making
use of the support for item ids in comboboxes introduced in commit
83cefb5ceb.

Change-Id: I69390c8f9d32b77454e2935cf28b38ea44be8ffd
Reviewed-on: https://gerrit.libreoffice.org/63238
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-26 18:38:14 +01:00
Olivier Hallot
5b3d56351f Update git submodules
* Update helpcontent2 from branch 'master'
  - tdf#120927 Webservice functions needs linking to
    
    Change-Id: I8d96025238fc2005dab37c1050a0c7915210d73a
    Reviewed-on: https://gerrit.libreoffice.org/64055
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-26 17:53:47 +01:00
Caolán McNamara
7a6c84d179 like keypress does, on mouse press create a cursor if missing
Change-Id: I57cd718ed03846dbff164acb5cd3c329d9eee615
Reviewed-on: https://gerrit.libreoffice.org/64036
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26 16:29:30 +01:00
Caolán McNamara
cf9f303ff9 weld DataSourceTabPage
Change-Id: I99b7c2ec397829c2f7ceb7ec18ae24195b9781e2
Reviewed-on: https://gerrit.libreoffice.org/61800
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26 16:09:34 +01:00
Noel Grandin
acfa3917ab remove unused enum value SvTLEntryFlags::IN_USE
Change-Id: Ieb09d4d28cc2084da4660165a96561ee57d2420d
Reviewed-on: https://gerrit.libreoffice.org/64029
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 15:44:49 +01:00
Miklos Vajna
4a59a8aba8 sfx2: show partial signatures even if cert validation fails
Change-Id: I6060b7130827346ac5d6955bf38ebe3b476819fd
Reviewed-on: https://gerrit.libreoffice.org/64022
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-26 14:21:26 +01:00
Noel Grandin
12d0c06703 remove unused enum value TrackingEventFlags::DontCallHdl
Change-Id: I75b28d20e2e0954fbd2fee396b8e06e9bb7d7073
Reviewed-on: https://gerrit.libreoffice.org/64028
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 14:07:48 +01:00
Noel Grandin
ea72ad4474 remove unused ShowFlags::NoParentUpdate
Change-Id: Id63e1d73643a18d823dfcb35479f0f8eb3e20b15
Reviewed-on: https://gerrit.libreoffice.org/63972
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 14:07:37 +01:00
Gabor Kelemen
ae3309c908 tdf#42949 Fix IWYU warnings in chart2/source/view/*cxx
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9ee3318c79d3b59f272a2a5f89c38b26afa05974
Reviewed-on: https://gerrit.libreoffice.org/63775
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-26 12:22:46 +01:00
Alyssa Ross
ab9d95e607 Use -filelist with macOS linker
macOS's linker can take a -filelist argument, in place of taking the
list of object files to link on the command line. This is a more limited
version of "response files" as used elsewhere in the code base, and by
using it we make it far less likely that a linker invocation will hit
ARG_MAX.

A standard LibreOffice build probably won't hit ARG_MAX on macOS just
yet, but it's not far off - some LDFLAGS are enough to tip it over the
edge, which is what prompted me to fix the issue. If not fixed, a few
more object files will probably break LibreOffice builds on macOS! An
example of another large program that has encountered this issue is
Thunderbird, which implemented the same fix[1].

The changes I've made to use -filelist are adapted from the code
elsewhere in gbuild that creates response files, but this is slightly
different because -filelist files are a bit different - they can only
contain object files, as opposed to arbitrary linker arguments, and
arguments are separated by newlines rather than spaces.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=837618

Change-Id: I01b9126aad95056c3dc82f941dea4fd43f95d0f2
Reviewed-on: https://gerrit.libreoffice.org/64010
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-11-26 11:57:19 +01:00
Aleksei Nikiforov
2d6dfead4b Fix menu insertion to specified position
Change-Id: I61f870010003fae98d792f95d7fdac0e59d4305c
Reviewed-on: https://gerrit.libreoffice.org/63885
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-26 11:38:56 +01:00
Caolán McNamara
b1baf73dc6 weld SfxCmisVersionsDialog
Change-Id: I73fc8ba88021f3d1450d10a75970e1fd58f26c3f
Reviewed-on: https://gerrit.libreoffice.org/64002
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26 11:31:37 +01:00
Noel Grandin
aaad3500b3 remove some unused enum values in xmloff
(*) also make it more obvious what XMLShapeExportFlags::SIZE represents

Change-Id: Ie63edf0f2827f171542037b819ebe7d55e090275
Reviewed-on: https://gerrit.libreoffice.org/63948
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 10:41:14 +01:00
andreas kainz
ab86777f93 NB tabbed impress: add shortcuts and Right2Left support
Change-Id: Ic333dd44c980ace2f52057d795c29930515965f1
Reviewed-on: https://gerrit.libreoffice.org/64006
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-26 10:25:26 +01:00
andreas kainz
79def472f6 NB tabbed draw: add shortcuts and Right2Left support
Change-Id: I4531a32f38ecfc1cd26b092d84ec9da442a71ea9
Reviewed-on: https://gerrit.libreoffice.org/64005
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-26 10:24:51 +01:00
andreas kainz
45b47d0e1e NB tabbed calc: add shortcuts and Right2Left support
Change-Id: I96d760063bf1684cf893e7765f10b0695b2e16ed
Reviewed-on: https://gerrit.libreoffice.org/64004
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-26 10:24:27 +01:00
Noel Grandin
313a0efb1d file param is used in DEBUG mode
regression from
    commit 4c19552052
    remove some unused enum values and defines in soltools

Change-Id: I897a75a65ab31068dbb9c51b111c81ab848506c9
Reviewed-on: https://gerrit.libreoffice.org/64018
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 10:11:04 +01:00
Caolán McNamara
7fcdc7efe8 drop unnecessary includes
Change-Id: I5305722d88ed947cbaf8015fc85d6b52900b7b75
Reviewed-on: https://gerrit.libreoffice.org/64003
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26 09:51:39 +01:00
Caolán McNamara
a455d7888c weld SfxVersionDialog
Change-Id: I0b69192a6eab9dadac892968a4a2d4fa3d9febde
Reviewed-on: https://gerrit.libreoffice.org/64001
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26 09:50:50 +01:00
Caolán McNamara
bd1cac5a96 drop some unnecessary includes
Change-Id: I4a45110e69fc76ff5b12e014586a0684c3737dfe
Reviewed-on: https://gerrit.libreoffice.org/64000
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26 09:50:10 +01:00
Tamas Bunth
3339c730f8 Put text label outside of the pie if..
performLabelBestFitInnerPlacement fails.

Change-Id: Ic84e8b42e02da2023b22a9406c44d462170c5305
Reviewed-on: https://gerrit.libreoffice.org/64015
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-26 09:47:43 +01:00
Noel Grandin
f431595568 remove unused StartTrackingFlags enum values
Change-Id: Ib72e4d5e3e1c65bc4d44756f98392393c79dab0e
Reviewed-on: https://gerrit.libreoffice.org/63971
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 08:48:55 +01:00
Noel Grandin
84d9785a04 remove unused DrawFlags enum values
Change-Id: I3f313dfa085612d805ea54352793a3fb0356b986
Reviewed-on: https://gerrit.libreoffice.org/63970
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26 07:26:54 +01:00
Mike Kaganski
761546e088 tdf#120703 PVS: V560 A part of conditional expression is always true/false
Change-Id: I1ac4c52ea51503373644bc58dcd4395c69f1a675
Reviewed-on: https://gerrit.libreoffice.org/64007
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-26 06:30:58 +01:00