Commit graph

431076 commits

Author SHA1 Message Date
Justin Luth
d3144a09dc partial revert tdf79435 doc: round-trip legacy input formfields
Apparently import isn't always properly reading some of these
strings, so it is just garbage being round-tripped in some cases.
Let's just avoid that until such time as import might be fixed.

I couldn't readily identify the import problem. It even happens with
version eWW8 files and also TestBeltAndBraces() didn't seem to
prevent the problem.

These crashes are due to reading garbage:
/srv/crashtestdata/files/doc/ooo78311-1.doc
	-DISTRICT_COURSE_OUTLINE_TEMPLATE.doc
/srv/crashtestdata/files/doc/kde79024-2.doc
	-Ü2_Blanko.doc
/srv/crashtestdata/files/doc/ooo24395-1.doc
	-stateapp-emp.doc
/srv/crashtestdata/files/doc/abi9921-1.doc
/srv/crashtestdata/files/doc/ooo59101-1.doc
	-Hovedblankett.DOC
/srv/crashtestdata/files/doc/fdo48097-1.doc
	-BR1010.doc

Change-Id: Iceaa53760867f06c73ab900c57f197dbc0fb8e65
Reviewed-on: https://gerrit.libreoffice.org/63938
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-11-26 06:11:52 +01:00
Andrea Gelmini
956b39f4b3 Update git submodules
* Update helpcontent2 from branch 'master'
  - Fix typo
    
    Change-Id: Ic224fbb099b86942afb651e5c10c6a91d2dac020
    Reviewed-on: https://gerrit.libreoffice.org/63978
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-26 02:37:49 +01:00
Markus Mohrhard
72e204da9a tdf#108027, add external ref string items to the data array
Change-Id: Iaf607fca6d7e88f2c529ab4a374f34164813331a
Reviewed-on: https://gerrit.libreoffice.org/64009
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-26 02:27:01 +01:00
Markus Mohrhard
9e04fac561 add dumpAsXml methods to more pool items
Change-Id: Ia33ac2dfa23bdc4e2990e6d028d1bae7fedfe4f5
Reviewed-on: https://gerrit.libreoffice.org/63853
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-26 02:26:41 +01:00
Stephan Bergmann
91aba7ca4f Revert "Enabling Developer Toolset 7 for Jenkins' lo_callgrind_linux"
This reverts commit 74d6476a04.  Developer
Toolset 7 has apparently not yet been installed on vm139 (the node exclusively
executing this job), see
<https://ci.libreoffice.org/job/lo_callgrind_linux/6525/console>:

> checking for gcc... /opt/rh/devtoolset-7/root/usr/bin/gcc
> checking whether the C compiler works... no
> configure: error: in `/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux':
> configure: error: C compiler cannot create executables
> See `config.log' for more details
> Error running configure at /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/autogen.sh line 296.
2018-11-25 23:08:53 +01:00
Mike Kaganski
71bbaa87a8 tdf#120703 PVS: (nArse == 0x2225) condition was masked
... since initial commit d791366863

V560 A part of conditional expression is always false: (nArse == 0x2225).

Change-Id: I4afb30f0c6c067d0e42e3fa15e5c2b2c1caa73b3
Reviewed-on: https://gerrit.libreoffice.org/63996
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25 22:00:12 +01:00
Andrea Gelmini
3483dc5bb0 Fix typo
Change-Id: I994a7a6c98d2e6ba32d5e005e204e9ec1f8be44b
Reviewed-on: https://gerrit.libreoffice.org/63999
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-25 21:08:51 +01:00
Stephan Bergmann
04ae4a9721 Missing test dependency
> warn:vcl.layout:29309:29309:vcl/source/window/builder.cxx:446: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window*, const rtl::OUString&, const rtl::OUString&, const rtl::OString&, const com::sun::uno::Reference<com::sun::frame::XFrame>&, bool)
>     when: Unable to read .ui file
>     type: com.sun.star.container.NoSuchElementException
>     message: file:///.../core/instdir/share/config/soffice.cfg/vcl/ui/printprogressdialog.ui

Change-Id: Ie275f5dbee52c5928276c06f65a5401a5fe1ae29
Reviewed-on: https://gerrit.libreoffice.org/63995
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25 20:42:08 +01:00
Mike Kaganski
4ac2f1799f tdf#120703 PVS: V560 A part of conditional expression is always true/false
Change-Id: I2ae298f49ceba8059cd7236431db9a4d9a46b125
Reviewed-on: https://gerrit.libreoffice.org/63992
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25 20:35:57 +01:00
Noel Grandin
1bc269504b seems we need to include algorithm here
commit 260002b16f
    Simplify containers iterations in svgio, svl, svtoolsHEADmaster

Change-Id: Ie97dd4276753e5b1b3a4382cf0060132caf6bd1b
Reviewed-on: https://gerrit.libreoffice.org/63980
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25 20:25:19 +01:00
Noel Grandin
1a4113979f remove unused PresentationFlags enum values
Change-Id: I502ff07467bbfa7117131e2a3e56c45b005512d8
Reviewed-on: https://gerrit.libreoffice.org/63949
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25 20:24:51 +01:00
Caolán McNamara
64d6562004 pretty up assign events dialog
Change-Id: I80ffba5d456e8b41613e0b8df577c614ce23adab
Reviewed-on: https://gerrit.libreoffice.org/63983
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25 20:19:10 +01:00
andreas kainz
c987e731b6 colibre icons: add and update icons for NB
Change-Id: Ia96c0bbb030e6404a18e08556c33ecb40378f843
Reviewed-on: https://gerrit.libreoffice.org/63968
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-25 20:02:26 +01:00
Stephan Bergmann
74d6476a04 Enabling Developer Toolset 7 for Jenkins' lo_callgrind_linux
...aka "Callgrind Linux", <https://ci.libreoffice.org/job/lo_callgrind_linux/>

Change-Id: I518e579ec4ca7b36f700ed412d86feef37c3e203
2018-11-25 18:03:33 +01:00
Stephan Bergmann
d27d75f86c Revert "Enabling Developer Toolset 7 for Jenkins' lo_tb_random_config_linux"
This reverts commit 4d72f292cb.  Developer
Toolset 7 has apparently not yet been installed on gandalf (the node exclusively
executing this job), see
<https://ci.libreoffice.org/job/lo_tb_random_config_linux/1623/console>:

> checking for gcc... /opt/rh/devtoolset-7/root/usr/bin/gcc
> checking whether the C compiler works... no
> configure: error: in `/lo/home/tdf/lode/jenkins/workspace/lo_tb_random_config_linux':
> configure: error: C compiler cannot create executables
> See `config.log' for more details
> Error running configure at ./autogen.sh line 296.
2018-11-25 17:34:20 +01:00
Stephan Bergmann
4d72f292cb Enabling Developer Toolset 7 for Jenkins' lo_tb_random_config_linux
...aka "Random Config Linux builder",
<https://ci.libreoffice.org/job/lo_tb_random_config_linux/>

Change-Id: I5a22526b8dcbed8e6fc9cd1fcc7db90774afb0ff
2018-11-25 17:27:28 +01:00
Stephan Bergmann
ab8454eb26 Enabling Developer Toolset 7 for Jenkins' lo_tb_master_linux_dbg
...aka "Tinderbox on Master for Linux-DbgUtil",
<https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/>

Change-Id: Icf99063e7aaf620cb13dd6ba869f98660f2de82a
Reviewed-on: https://gerrit.libreoffice.org/63982
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25 17:25:34 +01:00
Stephan Bergmann
5b0b08e49a Better way of enabling Developer Toolset 7 for Jenkins' linux_gcc_release_64
Enabling it in the relevant distro-configs/Jenkins/* file is more intuitive than
enabling it in autogen.sh (and avoids issues like
d057e61cb5 "Restrict Developer Toolset to
Config=linux_gcc_release_64"), and will also be used for other Jenkins jobs like
<https://gerrit.libreoffice.org/#/c/63982/> "Enabling Developer Toolset 7 for
Jenkins' lo_tb_master_linux_dbg".

Change-Id: If633044a90c35a12a73d60335839af0a106aa20f
Reviewed-on: https://gerrit.libreoffice.org/63989
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25 17:25:21 +01:00
Mike Kaganski
c59a5b81e9 tdf#120703 PVS: V560 A part of conditional expression is always true/false
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae
Reviewed-on: https://gerrit.libreoffice.org/63981
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25 16:52:30 +01:00
Stephan Bergmann
75299cd119 Blind fix for pre-C++14 std::equal, for now
...which plagues some builders that haven't been updated to full C++17 support
yet, let <https://ci.libreoffice.org/job/lo_tb_master_linux/31969/>

Change-Id: I93ea997b9f7a85b370681103f64c791b2f28e4f2
2018-11-25 16:47:01 +01:00
Stephan Bergmann
f9ba4c2be1 Generally set CCACHE_CPP2 for --enable-werror GCC
This obsoletes <https://gerrit.libreoffice.org/plugins/gitiles/lode/+/
b82e0a9d26ef4c81046c053ff831dccfc84c56be%5E!> "For linux_gcc_release_64, don't
let ccache strip comments" and fixes ccache for all builds using (recent) GCC.

Change-Id: I5fd20b2565f57073c545fe5d3a9639c2c0583a74
Reviewed-on: https://gerrit.libreoffice.org/63979
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25 15:50:45 +01:00
Caolán McNamara
f4955d7b18 drop unnecessary vcl/window.hxx includes in writer
Change-Id: I9bf20f2b4a20444f910738e42789b219efcf51fd
Reviewed-on: https://gerrit.libreoffice.org/63977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25 15:40:48 +01:00
Caolán McNamara
3dacf98b70 weld SfxMacroAssignDlg
Change-Id: I80045f1d1ca189fc490dc88b3471d68782df6f1c
Reviewed-on: https://gerrit.libreoffice.org/63976
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25 15:40:15 +01:00
Caolán McNamara
3a713e78a0 SfxStyleDialog is now unused
Change-Id: I2aa33c6bb53577b84373f7f920f7c6db22cd7cca
Reviewed-on: https://gerrit.libreoffice.org/63975
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25 15:39:43 +01:00
Caolán McNamara
18547e8061 AbstractApplyTabDialog_Impl is now unused
Change-Id: I6c0ab3ee8cadfd5eeb0aa6bd7828715401568e2b
Reviewed-on: https://gerrit.libreoffice.org/63974
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25 15:39:16 +01:00
Caolán McNamara
2fc2f235b9 SwTemplateDlg is now unused
Change-Id: If7de6baf5d2770d18926ee744a5c0fc6283c0195
Reviewed-on: https://gerrit.libreoffice.org/63973
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25 15:38:40 +01:00
Caolán McNamara
51e408533a weld SwFrameDlg
and now can remove...

commit 5d84af7e83
Date:   Tue Dec 4 22:43:46 2012 +0100

    fdo#57553: Picture dialog Macro tab page: lazily init

    ... because JVM startup is annoying, so delay it until really activating
    Macro tab.  This patch is sort of lame but with the change in
    bd2c14ec78 what can you do...

and description is revealed to be a text_view not an entry

Change-Id: Ibc92cf11870d4349ddc728ec17c846e4158e82ac
Reviewed-on: https://gerrit.libreoffice.org/63916
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25 15:38:09 +01:00
Arkadiy Illarionov
260002b16f Simplify containers iterations in svgio, svl, svtools
Use range-based loop or replace with STL functions

Change-Id: I98a3e55a14c8ac00188c5003f84194c2cc6795fb
Reviewed-on: https://gerrit.libreoffice.org/63959
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25 12:29:05 +01:00
andreas kainz
159b30d92f tdf#121401 add shortcuts and Left2Right support
Change-Id: If2be67b9c20d887b7c8ead500daabfd3d224a2f1
Reviewed-on: https://gerrit.libreoffice.org/63965
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-25 12:12:25 +01:00
Noel Grandin
52f0aaa9c6 convert PropType to scoped enum
and drop unused values

Change-Id: Ied5a5aa9c98417b873eeea28fb126f815e742159
Reviewed-on: https://gerrit.libreoffice.org/63947
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25 12:09:20 +01:00
Mike Kaganski
d82349e3fc tdf#120703 PVS: fix possible buffer over-read when iterating string
V560 A part of conditional expression is always true: nStartPos < nLen.

Change-Id: I2ae8634bd656e857724615d5187a14bd087598eb
Reviewed-on: https://gerrit.libreoffice.org/63958
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25 11:15:23 +01:00
Mike Kaganski
f2cd9c0c78 tdf#120703 PVS: V560 A part of conditional expression is always true/false
Change-Id: If173f42302553b164267909a0a3156bb25a6d558
Reviewed-on: https://gerrit.libreoffice.org/63957
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25 09:13:12 +01:00
Noel Grandin
e1cbd51811 drop unused FormulaVectorDisabledNotInSoftwareSubset
Change-Id: I6d9b43ce6c72ff876b48bfba4b6de09ed46fd809
Reviewed-on: https://gerrit.libreoffice.org/63946
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25 08:25:12 +01:00
Julien Nabet
85f129b59c Replace list by vector for ScDDELinkCells typedef (sc)
Change-Id: I3531ebc46bfc1c4362fafd7f6c93dd97f85676fa
Reviewed-on: https://gerrit.libreoffice.org/63963
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-25 00:41:29 +01:00
Stephan Bergmann
d057e61cb5 Restrict Developer Toolset to Config=linux_gcc_release_64
The Jenkins "Gerrit Linux clang/dbgutil" builds started to fail in odd ways,
presumably because of having the Developer Toolset in the PATH now when building
compilerplugins.  So change compilerplugins/clang/pluginhandler.hxx slightly to
force rebuild.

Change-Id: I97b8f89dc2e20c85f130284ca5326a5c96c2a1ba
Reviewed-on: https://gerrit.libreoffice.org/63962
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25 00:25:43 +01:00
Andrea Gelmini
2cc09c4650 Fix typo
Change-Id: I8e90b4592d041e63bd2efa914446db96dd293ac9
Reviewed-on: https://gerrit.libreoffice.org/63964
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-25 00:15:25 +01:00
Tamas Bunth
878c36f829 mysqlc: next() should move cursor from Last
XResultSet::next() should move cursor when called while cursor is on the
last position. It is not documented, but older versions of the mysqlc
extension are implemented that way. The cursor goes to the so called
afterlast position.

Even so, the next() call on the last position should return false.

Change-Id: I0fd145c920077151364a6a8c12e05290496b99c8
Reviewed-on: https://gerrit.libreoffice.org/63895
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-24 23:15:51 +01:00
Tamas Bunth
da16857fe3 Build mysql_jdbc library even when building..
.. without java

Change-Id: Id44ef2d94992423a12b32234822e8ed3f5a48299
Reviewed-on: https://gerrit.libreoffice.org/63889
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-24 23:15:34 +01:00
Julien Nabet
796cbe6efc Replace list by vector in unocoll.cxx (sw)
Same logic as https://gerrit.libreoffice.org/#/c/63928/

Change-Id: I59d5329687f94dcf0dba53a428f580313467829c
Reviewed-on: https://gerrit.libreoffice.org/63939
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-24 21:55:09 +01:00
Julien Nabet
487ed7fdd6 Use returned iterator by list::erase
Change-Id: I42312f5cbd0de65cc8915e6833eff668d244f66b
Reviewed-on: https://gerrit.libreoffice.org/63956
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-24 21:37:24 +01:00
Noel Grandin
843c55d132 remove unused sc::ListenerGroupType::Single
Change-Id: I98a279731b22f88f57ab667b6f5ef8c71b030832
Reviewed-on: https://gerrit.libreoffice.org/63945
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 21:24:11 +01:00
Noel Grandin
61d21e79e6 convert Unit to scoped enum
and drop unused UNIT_REFDEVX,UNIT_REFDEVY values

Change-Id: I4e516f2c51672f6541f3cf7c03a87aebc4a1f1f6
Reviewed-on: https://gerrit.libreoffice.org/63944
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 21:23:54 +01:00
Noel Grandin
f326c3c01c remove unused FuncFlags::BIFFIMPORTONLY,STATE::S_WK1
Change-Id: I94d88f871bfc78a066f6fd583b7fb7a7305944c8
Reviewed-on: https://gerrit.libreoffice.org/63943
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 19:05:07 +01:00
Noel Grandin
1ab34cdb4a remove ScMoveUndoMode enum
we only use one value

Change-Id: I7a0f3760615111adcd8b925234f53fafa46a0bd7
Reviewed-on: https://gerrit.libreoffice.org/63942
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 19:04:55 +01:00
Noel Grandin
d806e7937c disable more vcl pdfexport test on win
Change-Id: I32fe34dc5d3d80dc26a5a2237c56155576789709
Reviewed-on: https://gerrit.libreoffice.org/63940
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 16:50:43 +01:00
Noel Grandin
102091b73d remove ScVbaControlObjectBase::ListenerType enum
we only use one value from it

Change-Id: I3d0391e76f07434915940be25025de36a5475bc5
Reviewed-on: https://gerrit.libreoffice.org/63937
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 16:50:11 +01:00
Noel Grandin
ad74c032ce drop ComplListAppendHandl enum
we only use one value all the time, so it is unnecessary

Change-Id: I37b596f9c9330ad5f35d6b112dcca14851626995
Reviewed-on: https://gerrit.libreoffice.org/63936
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 16:49:59 +01:00
Noel Grandin
8a629c1f9b remove unused DocTreeNode::NodeType::Invalid
Change-Id: I68dde9c81ac73875382cd09bf342340b6c144ee8
Reviewed-on: https://gerrit.libreoffice.org/63935
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 16:49:45 +01:00
Noel Grandin
9afa992b34 remove unused FontChangeMask::HorAlign
Change-Id: I9e38cf1d749aa78e5b3c32575b76a372ca25c7c8
Reviewed-on: https://gerrit.libreoffice.org/63933
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24 16:49:32 +01:00
Caolán McNamara
51e6a95757 allow collapsing rows
Change-Id: I6b137e4fbb860a1d40acc961dae413bcdb27575a
Reviewed-on: https://gerrit.libreoffice.org/63894
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-24 15:42:17 +01:00