This improves the Doxygen-generated documentation for the class at
https://docs.libreoffice.org.
Also remove objdlg.cxx and objdlg.hxx files from clang-format blacklist.
Change-Id: I2299e225892a4d5db638a519bdab51a5d0c72c4d
Reviewed-on: https://gerrit.libreoffice.org/63610
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: If1b2e04872eb0dd6725802c1709a9085f4cd8c91
Reviewed-on: https://gerrit.libreoffice.org/64141
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
The opencl code splits SvDoubleRef into subarguments by each column,
but many functions simply treat each subargument as one argument
for the function, thus possibly getting things wrong (e.g. SUMPRODUCT
would make a product of each column and sum those, rather than making
a product of the whole SvDoubleRef).
So bail out if multi-column SvDoubleRef is encountered, unless
the function is known to handle this case properly (either it takes
extra care, such as VLOOKUP, or it doesn't matter, such as SUM, AND, MAX).
Change-Id: Ied89a2fc252fb35fe49796140489ff4588038e25
Reviewed-on: https://gerrit.libreoffice.org/64238
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
If ScFormulaCell::Interpret() is called to actually compute the cell's
value (bRunning==true), do not bail out on a detected cycle, it
needs to be detected as an actual cyclic reference. Happens with
testCopyPasteMixedReferenceFormula when during computing dependencies
cell C1 actually has a cyclic dependency on itself. Without this
change, it would simply use its previously computed value.
Change-Id: Ibf90b118b87d3536f5014004ea4a1dbad93ab270
Reviewed-on: https://gerrit.libreoffice.org/63183
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
REGEX( Text ; Expression [ ; [ Replacement ] [ ; Flags|Occurrence ] ] )
REGEX(Text;Expression) extracts the first match of Expression in
Text. If there is no match, #N/A is returned.
REGEX(Text;Expression;Replacement) replaces the first match of
Expression in Text, not extracted. If there is no match, Text is
returned unmodified.
REGEX(Text;Expression;Replacement;"g") replaces all matches of
Expression in Text with Replacement, not extracted. If there is no
match, Text is returned unmodified.
REGEX(Text;Expression;;Occurrence) extracts the n-th match of
Expression in Text. If there is no n-th match, #N/A is returned.
If Occurrence is 0, Text is returned unmodified.
REGEX(Text;Expression;Replacement;Occurrence) replaces the n-th
match of Expression in Text with Replacement, not extracted. If
there is no n-th match, Text is returned unmodified. If Occurrence
is 0, Text is returned unmodified.
Change-Id: Iadb705e4c76415c57bf510489410ec029344cca7
Reviewed-on: https://gerrit.libreoffice.org/64199
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
and tweak the methods in check.hxx to make them more flexible when
called with
dc.Class(xxx ? "foo" : "bar")
Change-Id: I881fe628f22121ced4d8849715d6b1c92b092da1
Reviewed-on: https://gerrit.libreoffice.org/64207
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
sberg: Note how that Clang change keeps getting reverted; latest one is
<http://llvm.org/viewvc/llvm-project?view=revision&revision=347656>
"Revert r347417 'Re-Reinstate 347294 with a fix for the failures.'" But
lets wait a little while to see how things settle there.
Change-Id: I05b34ca1377792bcb4c557defd3e9b5d11ee2b14
Reviewed-on: https://gerrit.libreoffice.org/64168
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
sprmPShd (0xC64D) is a SHDOperand value that specifies
the background shading for the paragraph. The SDHOperand
structure is an operand that is used by several Sprm structures
to specify the background shading to be applied.
ShdAuto is a special value for Shd that specifies that no shading
is applied and is defined as 0xFF000000 / 0x0000
ShdNil is a special value for Shd. If ShdNil is used in a Table Style
definition, ShdNil is ignored and the shading of the cell is not affected.
If ShdNil is applied outside of a Table Style, ShdNil
specifies that no shading is applied. ShdNil is defined as 0xFFFFFFFF
Change-Id: I66ec3cbccae60eb658ee00cb01b22cfae36482d0
Reviewed-on: https://gerrit.libreoffice.org/64184
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Cache was empty so pivot table was not exported completely
and pivot table filter were missing.
Change-Id: Ib0b9e98a5588159c5c7de1e2e5d2bdcbfe986d8d
Reviewed-on: https://gerrit.libreoffice.org/63785
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
multi selections are weird with this set
Change-Id: I765c46294803d06911a6ac3fc37d68dd001aacdc
Reviewed-on: https://gerrit.libreoffice.org/64187
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Change tracking can be quite numerous. Showing the
markers (and their comments" as comment-boxes is
sensible where there is limited change in a doc.
However with extensively modified doc, this becomes
overwhelming both in terms of browser load and
editing performance. As such, we disable them
as they don't add much value. The user can still
access them from the Track Changes > Manage menu.
Use a rather nasty env. var hack to propagate this
setting from WSD for now.
Change-Id: I3f964816b4a10f565012b273added8a8413cd309
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit d4f821b7a3)
Reviewed-on: https://gerrit.libreoffice.org/64176
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
New "Header and Footer" style introduced as parent to header/footer styles
Right alignment set for HeaderR and FooterR
Change-Id: Iff407da8907b761236ebc2aa8877b9d6b8294e10
Reviewed-on: https://gerrit.libreoffice.org/64152
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
With d464d505fb "Refactor calc non-linear
ViewToDevice transform", the problems with my macOS build that I described in
the commit message of (abandoned) <https://gerrit.libreoffice.org/#/c/61651/>
"Omit 'Calc adjust to grid hack' when not rendering for the screen" are
apparently solved: `make CppunitTest_vcl_pdfexport test` succeeds, and opening
vcl/qa/cppunit/pdfexport/data/tdf115262.ods and exporting it to PDF while the
on-screen Calc document is displayed at varying zoom levels leads to effectively
identical files now.
Assuming that 232 is the universally correct value for nFirstImageTop now
(nRowTop appears to have always evaluated to 199), it looks cleaner to me to
have the expected values spelled out explicitly in the test code.
Change-Id: Idb9f30f4ab9641b5b5325ddd90084e4112e1b572
Reviewed-on: https://gerrit.libreoffice.org/64171
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
It passed "make check" on Linux.
If accepted, I have to update these files:
helpcontent2/helpers/help_hid.lst : SID_EXTRUSION_TOOGLE,10960,.uno:ExtrusionToggle
helpcontent2/helpers/longnames_commands.csv : SID_EXTRUSION_TOOGLE,.uno:ExtrusionToggle
helpcontent2/helpers/uno_hid.lst : SID_EXTRUSION_TOOGLE,10960,.uno:ExtrusionToggle
Change-Id: Ie315ef92b6aa8c03c6fc180f4e82d95f28975c2e
Reviewed-on: https://gerrit.libreoffice.org/60631
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Currently we cannot tunnel interaction handler dialog, so if there
is a problem with site's SSL cert, the operation (e.g. insert image)
would silently fail. As a workaround, let's not validate the remote
site's SSL cert, as we also do not validate the site's SSL cert when
we download the file through WOPI from the site, in the first place.
So this patch does not really make things worse, but makes it possible
to use the insert image feature with a self signed cert in test environments.
Change-Id: Ibc14f0f76b814abcb9ec9ca02d92c27ad35d3878
Reviewed-on: https://gerrit.libreoffice.org/64154
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
...to further restrict the Windows MSVC baseline to not just VS 2017, but to the
latest update (as the various updates bring significant improvements for C++11/
14/17 support; see the mailing list thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2018-July/080588.html>
"Compiler baselines (was: [Libreoffice-qa] minutes of ESC call ...)").
Change-Id: If6a1b62da1691ae8ae19edb4ed7b35e4b6e46501
Reviewed-on: https://gerrit.libreoffice.org/59209
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
while the extension manager is querying via a dialog. Reuse
the isBusy for this.
Change-Id: I97572404ae296e87fd44711bf1e978bd5bad6280
Reviewed-on: https://gerrit.libreoffice.org/64155
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
instead of the wrapper exception, so that dbaccess can apply its special
handling for SQLException::ErrorCode of dbtools::ParameterInteractionCancelled
in OLinkedDocumentsAccess::open if ParameterInteractionCancelled was the root
cause
Change-Id: I777893cf7355d8c4a9c48237284903176d81402d
Reviewed-on: https://gerrit.libreoffice.org/64123
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
