Commit graph

491790 commits

Author SHA1 Message Date
Caolán McNamara
de4b3a135f cid#1545970 COPY_INSTEAD_OF_MOVE
and

cid#1545957 COPY_INSTEAD_OF_MOVE
cid#1545944 COPY_INSTEAD_OF_MOVE
cid#1545939 COPY_INSTEAD_OF_MOVE
cid#1545931 COPY_INSTEAD_OF_MOVE
cid#1545926 COPY_INSTEAD_OF_MOVE
cid#1545909 COPY_INSTEAD_OF_MOVE
cid#1545899 COPY_INSTEAD_OF_MOVE
cid#1545896 COPY_INSTEAD_OF_MOVE
cid#1545894 COPY_INSTEAD_OF_MOVE
cid#1545858 COPY_INSTEAD_OF_MOVE
cid#1545823 COPY_INSTEAD_OF_MOVE
cid#1545820 COPY_INSTEAD_OF_MOVE
cid#1545819 COPY_INSTEAD_OF_MOVE
cid#1545772 COPY_INSTEAD_OF_MOVE
cid#1545749 COPY_INSTEAD_OF_MOVE
cid#1545743 COPY_INSTEAD_OF_MOVE
cid#1545739 COPY_INSTEAD_OF_MOVE
cid#1545635 COPY_INSTEAD_OF_MOVE
cid#1545603 COPY_INSTEAD_OF_MOVE
cid#1545602 COPY_INSTEAD_OF_MOVE
cid#1545592 COPY_INSTEAD_OF_MOVE
cid#1545544 COPY_INSTEAD_OF_MOVE
cid#1545532 COPY_INSTEAD_OF_MOVE
cid#1545520 COPY_INSTEAD_OF_MOVE
cid#1545512 COPY_INSTEAD_OF_MOVE
cid#1545490 COPY_INSTEAD_OF_MOVE
cid#1545483 COPY_INSTEAD_OF_MOVE
cid#1545467 COPY_INSTEAD_OF_MOVE
cid#1545461 COPY_INSTEAD_OF_MOVE
cid#1545458 COPY_INSTEAD_OF_MOVE
cid#1545428 COPY_INSTEAD_OF_MOVE
cid#1545394 COPY_INSTEAD_OF_MOVE
cid#1545385 COPY_INSTEAD_OF_MOVE
cid#1545383 COPY_INSTEAD_OF_MOVE
cid#1545366 COPY_INSTEAD_OF_MOVE
cid#1545357 COPY_INSTEAD_OF_MOVE

Change-Id: I76224326977b4067b94ca3176cad1ca6de17930a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160847
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-16 22:39:20 +01:00
Caolán McNamara
81c4be4582 cid#1545561 std::swap COPY_INSTEAD_OF_MOVE
Change-Id: I6830f06fe6019ee5688c59260639ed99162eb451
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160876
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-16 22:39:14 +01:00
Caolán McNamara
264c3a962e cid#1545870 Using invalid iterator
Change-Id: I3b09fdee5574e5d3006cc875ce6c0175c0b4e594
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160875
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-16 22:38:57 +01:00
Ilmari Lauhakangas
98ec93183f Update git submodules
* Update helpcontent2 from branch 'master'
  to 25f39b53fb292ec90368f2afd3678884a1a8bb27
  - Make Help navigation layout less busy
    
    Bookmarks don't have to be visible all the time, so make them a
    dropdown and move the search box to header.
    
    Move Xapian search to the top of the content area.
    
    Make Contents tree appear on the left side in 960px and wider screens.
    
    Simplify/clean up some CSS and JS, for example for module colours.
    
    Change-Id: Ic50a834b758d50098868866e4b8d3e8085755423
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160870
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-16 22:11:43 +01:00
Mike Kaganski
247c64fa02 Drop incorrect conditional compilation
Since commit 396196d614 (BigInt's
non-big value type is currently sal_Int32, 2020-11-14), fixed-size
sal_Int32 is used in the unit test; so it must not depend on size
of unrelated long type.

Change-Id: Ida276e87b927381d093796f4137774a18acded82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160857
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-16 20:29:05 +01:00
Caolán McNamara
8c3a651a3f cid#1546456 COPY_INSTEAD_OF_MOVE
and

cid#1546450 COPY_INSTEAD_OF_MOVE
cid#1546430 COPY_INSTEAD_OF_MOVE
cid#1546401 COPY_INSTEAD_OF_MOVE
cid#1546313 COPY_INSTEAD_OF_MOVE
cid#1546302 COPY_INSTEAD_OF_MOVE
cid#1546301 COPY_INSTEAD_OF_MOVE
cid#1546299 COPY_INSTEAD_OF_MOVE
cid#1546280 COPY_INSTEAD_OF_MOVE
cid#1546233 COPY_INSTEAD_OF_MOVE
cid#1546217 COPY_INSTEAD_OF_MOVE
cid#1546215 COPY_INSTEAD_OF_MOVE
cid#1546204 COPY_INSTEAD_OF_MOVE

Change-Id: Iaab419509ad4a0bea9cae3665723af0e99c60ee4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160849
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-16 20:26:16 +01:00
Olivier Hallot
0da294bb82 Update git submodules
* Update helpcontent2 from branch 'master'
  to b84322961aad1cb506f0b92989e9eea95c646531
  - Uncover important content for digital signatures.
    
    Change-Id: I9883445e2fb95f02569fef3b22e06b38a9b5a1ea
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160855
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-16 12:54:42 +01:00
Noel Grandin
73e5161bae no need to allocate these on the heap
Change-Id: I02ec48ba369e91afc67246f9cdf18f88b24af49f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160837
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-16 12:11:08 +01:00
Noel Grandin
23f8c47866 unique_ptr to optional in chart2
Change-Id: Ia61bbedc8a96ac7525eb24997f99546ed26e377c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160835
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-16 10:44:56 +01:00
Noel Grandin
bc640ec911 no need to allocate this on the heap
Change-Id: I9a63c534a12ec2cf11d8820a5bbba8bca9a7c0e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160841
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-16 10:44:35 +01:00
Noel Grandin
dc3849eeb7 no need to allocate this on the heap
Change-Id: I89d4e680e6c8aabcc543605a0e496b3086dd2d3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160838
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-16 10:44:24 +01:00
Noel Grandin
3ca3fd6eaf no need to allocate this on the heap
Change-Id: I99a41076db39b76f6dbbd5974039ee271c29eee5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160840
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-16 10:44:10 +01:00
Gabor Kelemen
c498e2acd6 Drop some wrapper methods from SvtOptionsDrawinglayer
just use the wrapped officecfg methods instead of:
GetMaximumPaperWidth
GetMaximumPaperHeight
GetMaximumPaperLeftMargin
GetMaximumPaperRightMargin
GetMaximumPaperTopMargin
GetMaximumPaperBottomMargin

Change-Id: Id11782a306ca9118cc65607265be516ba9f0abda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160653
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-16 01:30:20 +01:00
Rafael Lima
46c1ce9ac9 tdf#158514 Add "Edit Comment" entry to the navigator popup
Clicking this option will show the comment and enter edit mode.

Change-Id: Ia9d10e5e03229c48120c27de0a623de5c5cf50d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160582
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-16 01:24:38 +01:00
Gabor Kelemen
7f48419469 get-bugzilla-attachments-by-mimetype: GNOME Bugzilla is dead
Comment it out from the script.
Gnumeric's new bugtracking is in gitlab:
https://gitlab.gnome.org/GNOME/gnumeric/-/issues

Change-Id: I53be9c368cf02f7a36991498ac2261e05327131a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160829
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-16 01:24:03 +01:00
Gabor Kelemen
9a71ac689a Drop some wrapper methods from SvtOptionsDrawinglayer
just use the wrapped officecfg methods instead of:

GetStripeLength

Change-Id: Id29c0b1ecbc513b5d778140b6e59139a507035d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160652
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-16 01:22:24 +01:00
Olivier Hallot
d799ba397e Update git submodules
* Update helpcontent2 from branch 'master'
  to 91d39c6ef8fc004c6ed92611333270493199d861
  - tdf#155876 UI cmds Calc-Sheet menu (32)
    
    + Sheet menu for Calc: manage Names
    + untangle manage names and define names
    + refactoring
    
    Change-Id: I27fe448ae251cb98a829e92c307fc31ad3b2c967
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160845
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-16 00:33:37 +01:00
Noel Grandin
df9499d520 use more getFastProperty in chart2
Change-Id: Ia6511f7de33023e1e1e9e8a31ba262c7b989350c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160832
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-15 21:03:55 +01:00
Weblate
f65ef4517a Update translation files for android-viewer
Updated by "Cleanup translation files" hook in Weblate.

Change-Id: Ie0d7d835fba42e9a8cfb73370a8b153168a9cf9e

android-viewer translated using Weblate

Slovenian currently translated at 100.0% (132 of 132 strings)

Change-Id: Id07e5c018310b97460f7750c2db2f43127c483c5

Added translation for android-viewer using Weblate (Slovenian)

Change-Id: Ie9008b437173feb5a871e119fd00e5f134dd0da9

android-viewer translated using Weblate

Polish currently translated at 100.0% (132 of 132 strings)

Change-Id: Iacacacd662c48986358e904598d458c44ca8805f

Added translation for android-viewer using Weblate (Japanese)

Change-Id: I3373654075eabc79c42cd2c67daf62f5f7111158

Added translation for android-viewer using Weblate (Chinese (Traditional))

Change-Id: I7af06e08b6567f990641ad532b8b94df2ec7d367

android-viewer translated using Weblate

Basque currently translated at 100.0% (132 of 132 strings)

Change-Id: I9b29af97d0642fa36c09ce38bf14290f60ccb8cd

android-viewer translated using Weblate

Polish currently translated at 100.0% (132 of 132 strings)

Change-Id: Ie0b345d1dc63102120cb871f8066ed710917e72f

android-viewer translated using Weblate

Portuguese (Brazil) currently translated at 54.5% (72 of 132 strings)

Change-Id: I652b6dde8cd02c9b4baff5ba5453f7471f8eb896

android-viewer translated using Weblate

Catalan currently translated at 100.0% (132 of 132 strings)

Change-Id: Ic7b42998072d6bb02937e88af76620564abc51b8

Added translation for android-viewer using Weblate (Finnish)

Change-Id: Iae55f9b007d7d34162d77c8f62d025fa54ff8035

Added translation for android-viewer using Weblate (Basque)

Change-Id: I88291444f52d5f4189c17330f855683268a2bffc

android-viewer translated using Weblate

Catalan currently translated at 62.1% (82 of 132 strings)

Change-Id: I28ec1b2f54d39209f7d802ba9aa899d12b2a3b35

android-viewer translated using Weblate

Persian currently translated at 2.2% (3 of 132 strings)

Change-Id: I7ba58594540aff2ad592771e73efeeccdff027db

android-viewer translated using Weblate

Portuguese (Brazil) currently translated at 33.3% (44 of 132 strings)

Change-Id: I092277ffea906ad3da9b73e7831536a482bb104f

android-viewer translated using Weblate

French currently translated at 1.5% (2 of 132 strings)

Change-Id: Ia8553c387bec6c66c6def3de9b4b41016ead2bb1

Added translation for android-viewer using Weblate (Polish)

Change-Id: Ibe83470b27b286030024f654df5cf30b2cb727ed

Added translation for android-viewer using Weblate (Persian)

Change-Id: I67bb9684aaa873ca4129139fb340b84634c9fe7e

android-viewer translated using Weblate

Portuguese (Brazil) currently translated at 20.4% (27 of 132 strings)

Change-Id: I628da41052ac2957601226a5e03796bd67744863

Added translation for android-viewer using Weblate (Portuguese (Brazil))

Change-Id: I8ee44239235aaba0c44f805d93d2cb8db4383fab

android-viewer translated using Weblate

Punjabi currently translated at 87.8% (116 of 132 strings)

Change-Id: Ic9ae2d4d5d007638ecf8d58c9069c103d30af7c1

android-viewer translated using Weblate

Catalan currently translated at 59.0% (78 of 132 strings)

Change-Id: Ib6d7f7e1adf85c57f6de66cf21795c27d6945a03

Added translation for android-viewer using Weblate (French)

Change-Id: I936f355b82bf58baea5f1738227b7b1755b23193
Co-authored-by: A S Alam <amanpreet.alam@gmail.com>
Co-authored-by: Adam Rak <kitynska@gmail.com>
Co-authored-by: Aitor Salaberria <trslbrr@gmail.com>
Co-authored-by: Hossein <hossein@libreoffice.org>
Co-authored-by: Joan Montané <joan@montane.cat>
Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Co-authored-by: Naruhiko Ogasawara <naruoga@gmail.com>
Co-authored-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Co-authored-by: Tuomas Hietala <tuomas.hietala@iki.fi>
Co-authored-by: Weblate <noreply@documentfoundation.org>
Co-authored-by: Weblate <noreply@weblate.org>
Co-authored-by: sophie <gautier.sophie@gmail.com>
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eu/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fa/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pa/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pt_BR/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sl/
Translation: android-viewer/android-strings
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160824
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15 20:48:01 +01:00
Rene Engelhard
e897231033 check abseil version
since 918515d6fc updated to a pdfium
version which only builds with >= 20230125.3 (earliest I could get hand
on).

Ideally we should test for the feature, but this suffices too and we do
that for other libs, too...

Change-Id: I14719186d415b9df82f607b26233c9be154492c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160833
Tested-by: René Engelhard <rene@debian.org>
Tested-by: Jenkins
Reviewed-by: René Engelhard <rene@debian.org>
2023-12-15 19:32:10 +01:00
Rafael Lima
c48952eb6b tdf#142926 Add button to Download page in Help dialog box
Change-Id: Ie22dda17949d583a388d45e5aad3728b91637bff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155298
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2023-12-15 18:17:32 +01:00
Mike Kaganski
107b35bd42 Put some static_casts into a dedicated function
And make it explicit that SmModel ctor takes a SmDocShell*.

Change-Id: Ic16b2bce8e0a57b9f00382fa03041867f5e3a4ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160828
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-15 17:40:28 +01:00
Michael Weghorn
d942b4a7d1 android: Set sample texts for design view
As cloph suggested in [1], set sample texts for the
version and vendor information in the About dialog,
using the `tools:text` attribute as described at [2].

These are displayed when viewing the layout in
Android Studio's layout preview. With these placeholder
texts, this gives a better impression at design time
what the actual result will look like at runtime.

The actual texts for the view are set at runtime, s.
`AboutDialogFragment#onCreateDialog`.

[1] https://gerrit.libreoffice.org/c/core/+/160047/comments/52584e2e_50869bef
[2] https://developer.android.com/studio/write/tool-attributes#design-time_view_attributes

Change-Id: I92b1c3d9f947fd1aa68a3ef4f0eee9e5c742e0c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160826
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15 17:28:28 +01:00
Michael Weghorn
da292a61c4 android: Update lint baseline
Update the list of known (tolerated for now) issues by deleting
lint-baseline.xml and running `make` to regenerate
the file, so recent translation-related (config) changes are
reflected.

Change-Id: If8a39d72ba83c2a2e0bab9830c69095445943b09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160818
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15 17:28:14 +01:00
Michael Weghorn
a661667421 android lint: Drop unused string resources
This also avoids that these will show up in Weblate,
causing unnecessary work for translators since they're
unused anyway.

IIUC, dropping the strings in already existing translations
should be handled automatically by Weblate.
(Leave them there to see whether this actually works as
expected.)

Change-Id: Icab66a1768f5c6250598fcf788377575d3f6f611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160821
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15 17:27:59 +01:00
Michael Weghorn
d5922ae240 android lint: Ignore extra translations
These should be managed automatically via weblate, s. [1],
so there shouldn't be any need to manually remove stale
strings for all translations.

There are 2 lint checks for these, `ExtraTranslations`
and `UnusedResources`.

Disable `ExtraTranslations` altogether.
The `UnusedResources` check seems useful in general,
so only disable that for the translations by adding
a lint config file `lint.xml` (s.a. [2]) using a
wildcard for the path that matches the translation's
string.xml files.

This is in preparation for

    Change-Id: Icab66a1768f5c6250598fcf788377575d3f6f611
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Fri Dec 15 10:28:21 2023 +0100

        android lint: Drop unused string resources

        This also avoids that these will show up in Weblate,
        causing unnecessary work for translators since they're
        unused anyway.

        IIUC, dropping the strings in already existing translations
        should be handled automatically by Weblate.
        (Leave them there to see whether this actually works as
        expected.)

[1] https://gerrit.libreoffice.org/c/impress_remote/+/155966/comments/769f76c5_c3c499ec
[2] https://developer.android.com/studio/write/lint

Change-Id: Ic7c7a1c4c5583bf1a42004480435aac70a88dee0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160822
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15 17:27:35 +01:00
Michael Weghorn
f43c133c87 android lint: Replace "..." with ellipsis character
Address this lint warning listed in the lint-baseline.xml:

    <issue
        id="TypographyEllipsis"
        message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
        errorLine1="    &lt;string name=&quot;action_save_as&quot;>Save As...&lt;/string>"
        errorLine2="                                  ~~~~~~~~~~">
        <location
            file="res/values/strings.xml"
            line="53"
            column="35"/>
    </issue>

This also helps to avoid introducing more issues of that kind in newly
added translations, quoting from cloph's Gerrit comment [1]:

> and FYI: if the source-string would end in an Ellipsis, then weblate could
> enforce the translation ending in an ellipsis [...]
>
> ( https://docs.weblate.org/en/latest/user/checks.html#mismatched-ellipsis )

[1] https://gerrit.libreoffice.org/c/core/+/160614/comments/5ef2dc6d_75cde15f

Change-Id: Ic056849dd56d7e6c50615ffd62d470df4ab337bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160817
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15 17:27:21 +01:00
Michael Weghorn
eaa8327c96 android lint: Ignore missing translations
Translations are handled in Weblate now, so missing
translations are tracked there.

Therefore, ignore them in the lint check, since there's
no added value in having them listed in the
`android/source/lint-baseline.xml` file in addition any more.

Change-Id: I82945c0eebe015ca9695813dd19613108884c648
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160816
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15 17:27:05 +01:00
Michael Weghorn
92b7f110a9 Fix placement for --enable-online-update-mar UI
* Resave with glade 3.40, which did all the
  changes to the .ui file
* to be safe, explicitly hide the UI in the C++
  code when building without `--enable-online-update-mar`
  (UI wasn't shown in a quick test with qt6 even
  without that, but better be safe)

Addresses this issue mentioned in [1]:

> - Online Update".  (For non-GTK VCL backends, there's still a bug that
> the "Automatic Update" section on that options page is mixed into the
> traditional --enable-online-update options at the top of the page,
> instead of down at the bottom; fixing of
> cui/uiconfig/ui/optonlineupdatepage.ui welcome...)

[1] https://lists.freedesktop.org/archives/libreoffice/2023-December/091309.html

Change-Id: I2fadbb3b93206834b8c2c17cb540fb0b0687742b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160830
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
2023-12-15 16:08:45 +01:00
Stephan Bergmann
dc08489bc7 Avoid "Desktop disposed before terminating it" assert
...from Desktop::disposing() at framework/source/services/desktop.cxx:1041, on
Windows, when the HAVE_FEATURE_UPDATE_MAR update() call returns true (and
soffice.bin is about to exit now), but the css.frame.Desktop service happens to
already have been created somewhere else (and will thus be disposed as part of
disposing the service manager) but doesn't receive a terminate() call in
Desktop::Main().

So reorder the code in Desktop::Main(), moving the HAVE_FEATURE_UPDATE_MAR code
after the

>     xDesktop = css::frame::Desktop::create( xContext );

so that we have something to call

>                 xDesktop->terminate();

on in this scenario.

Change-Id: Iee5b6eeece33d5a27cadb94a7da0d26aa1492e91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160831
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-15 15:57:08 +01:00
Mike Kaganski
80b67e776a tdf#157569: FormulaImExportBase::getFormulaSize should return mm/100
Similar to commit 798d21e2a1 (tdf#157965:
UNO methods are expected to return sizes in mm/100, 2023-10-29); this
was an omission from commit 9e92a17cb6
(starmath: Improve glyph positioning, 2023-09-19).

The method is called in DomainMapper_Impl::appendStarMath(), and the
returned value is used to define object size using UNO methods.

Change-Id: I37cc4d5dd18641915495b97f0d99fa10a805e18c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160827
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-15 15:02:30 +01:00
Christian Lohmaier
8a645c192f Update git submodules
* Update translations from branch 'master'
  to 38b799b9f758e455d561b03dda4b67ee43d943fe
  - update translations for master/24-2
    
    and force-fix errors using pocheck
    
    Change-Id: Ib2816d25b6b144e161a8b2eced1702af7a527c93
2023-12-15 13:27:30 +01:00
Stephan Bergmann
94233c2e1e -Werror,-Wunused-result
...caused by typo in previous 58bfd8f982 "Fix
backward vs. forward slashes on Windows"

Change-Id: Ibd1967688c6ab4c962818595d435c7f821ad3d64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160820
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-15 12:32:19 +01:00
Michael Stahl
12fbc9ffde Update git submodules
* Update helpcontent2 from branch 'master'
  to d4b5e5598f24273a0f5b3a4d73e3e716a5a34aa9
  - helpcontent2: adapt Digital Signatures to removal of AdES checkbox
    
    ... and clarify what files can be signed a bit.
    
    Change-Id: I101646f97ba6b21e7ba33aa2eef723e91af806a3
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160823
    Tested-by: Jenkins
    Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-15 11:51:44 +01:00
Stephan Bergmann
3a445cb497 Turn onlineupdate into external/onlineupdate
...and update to latest Mozilla sources.

Originally, this was a non-external onlineupdate module (plus correspsonding
top-level include/onlineupdate/ directory) that apparently contained sources
originally copied from Mozilla and subsequently modified in-place (plus, mixed
in, presumably some sources that were not copied from Mozilla but were our own
inventions).  To clean up this mess, this has been turned into a proper
external/onlineupdate module with a tarball containing the pristine external
Mozilla sources.

The sources for the onlineupdate-c003be8b9727672e7d30972983b375f4c200233f.tar.xz
tarball are taken, somewhat arbitrarily, from a recent
<c003be8b97>
("Bug 1867784 - Force reflow all kids in the last column balancing reflow.
r=layout-reviewers,dholbert") trunk state, by running
`external/onlineupdate/generate-sources.sh ~/github.com/mozilla/gecko-dev` on a
Fedora 39 machine.

The layout of the tarball still mostly follows the old onlineupdate/ layout,
even if that deviates heavily from the actual source layout at
<https://github.com/mozilla/gecko-dev/>.  (And some files, which apparently are
not needed, anyway, lacked sources, see the "Missing source for" in
external/onlineupdate/generate-sources.sh.  And win_dirent.h/.cpp has meanwhile
been superseded by updateutils_win.h/.cpp.)  Merely newly included source files
are laid out in the tarball according to the actual source layout.

Any LO-specific modifications are made via patch files (rather than modifying
the sources inline, as was done in the past): external/onlineupdate/lo.patch
contains whatever modifications are needed to adapt the functionality, while
external/onlineupdate/gtk3deprecated.patch fixes

> workdir/UnpackedTarball/onlineupdate/onlineupdate/source/update/updater/progressui_gtk.cpp:97:21: error: use of undeclared identifier 'gtk_vbox_new'; did you mean 'gtk_box_new'?
>    97 |   GtkWidget* vbox = gtk_vbox_new(TRUE, 6);
>       |                     ^~~~~~~~~~~~
>       |                     gtk_box_new

to not use the deprecated gtk_vbox_new, which is hidden because we include
-DGTK_DISABLE_DEPRECATED in our GTK3_CFLAGS as per our configure.ac.

On Windows, the definition of __BYTE_ORDER__ etc. is needed because
workdir/UnpackedTarball/onlineupdate/include/mozilla/ says "Our supported
compilers provide architecture-independent macros for this", but MSVC doesn't
actually, so define here what would implicitly be defined by GCC.  Similarly, on
Windows -U_WIN32_WINNT is needed to undo -D_WIN32_WINNT=0x0601 in
solenv/gbuild/platform/windows.mk, which would cause

> workdir\UnpackedTarball\onlineupdate\include\mozilla/WinHeaderOnlyUtils.h(537): error C2065: 'FILE_ID_INFO': undeclared identifier

etc., despite the #include <windws.h> there.

Curiously, the original gb_CustomTarget_CustomTarget,onlineupdate/generated from
onlineupdate/CustomTarget_generated.mk had to be renamed to
gb_CustomTarget_CustomTarget,external/onlineupdate/generated when the file was
moved to external/onlineupdate/CustomTarget_generated.mk, as otherwise a
top-level `make CustomTarget_onlineupdate/generated` would have failed with "No
rule to make target..."  Also, as there is no gb_CustomTarget_use_unpacked, its
effect has been poorly mimicked for now in
external/onlineupdate/CustomTarget_generated.mk.

Similarly, as there is no gb_WinResTarget_use_unpacked, its effect has been
poorly mimicked for now in external/onlineupdate/WinResTarget_updater.mk.

The original onlineupdate/workben/test_dialog.cxx, which is actually code
written by us, has been moved to external/onlineupdate/workben/test_dialog.cxx.

The original onlineupdate/qa/ sources (which were apparently not used during the
build) have been preserved for now as external/onlineupdate/qa/, for
documentation purposes.

The original onlineupdate/astyle.options (which was apparently not used during
the build) has been removed.

Change-Id: I5ea606202e7837269e7b128e45af2f0b8c277f9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160492
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-15 11:27:49 +01:00
Dione Maddern
b7f7909a22 Update git submodules
* Update helpcontent2 from branch 'master'
  to 0e756ea3d2c84368ceaf30a6cacbbd46d6148327
  - tdf#155877 Update Help page with Tabbed UI info
    
    + Rephrasing instructions
    
    Change-Id: I04fcc9139d0fb0e3a82f4d81d8b55512df6a7ded
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160810
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-12-15 11:21:12 +01:00
Michael Stahl
4eebf31e38 xmlsecurity: remove "AdES-compliant signature" checkbox
This is essentially a footgun because the user can accidentally turn it
off and get non-AdES signatures which use obsolete SHA1 hashes.

Unfortunately it turns out that the initial setting of the checkbox only
works for ODF, because OOXML have m_sODFVersion set to "1.0" due to some
defaulting code somewhere.

So what this checkbox actually did is unintentionally disable XAdES
signatures for OOXML by default.

Now that i actually test it by setting ODF version 1.1 in
Tools->Options, it turns out that signing ODF 1.1 documents isn't
possible at all, a dialog pops up that says "Signing documents
requires ODF 1.2 (OpenOffice.org 3.x)".

Change-Id: I0eaf590c290b2c0ee0ff890ed73f0dbea4cf0ce3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160785
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-15 10:52:04 +01:00
Michael Stahl
53c64cce13 xmlsecurity: fix assert in CertificateChooser::ImplInitialize()
gtk3/gtkinst.cxx:15371: virtual void (anonymous namespace)::GtkInstanceTreeView::select(int): Assertion `gtk_tree_view_get_model(m_pTreeView) && "don't select when frozen, select after thaw. Note selection doesn't survive a freeze"' failed.

(regression from commit ad6f23d2a3)

Change-Id: I8c0639e755188731bdd211f9d71a830d7afeeaa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160786
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-15 10:51:22 +01:00
Mike Kaganski
dcae6615ed tdf#158556: provide objects anchored to node as a hidden property
This introduces a hidden property of SwXParagraph, named
OOXMLImport_AnchoredShapes.

Testing on my system, starting the main process first, then launching
another one like

  time soffice path/to/bugdoc.docx

... so that it only measures time spent in import, gave the following
figures:

LibreOffice 7.5.0.3 (TDF build):
real    1m49.016s
user    0m0.000s
sys     0m0.000s

LibreOffice 7.6.0.3 (TDF build):
real    8m37.386s
user    0m0.000s
sys     0m0.000s

Current master (my no-debug build):
real    10m6.776s
user    0m0.000s
sys     0m0.000s

Current master with this patch (my no-debug build):
real    5m41.524s
user    0m0.000s
sys     0m0.015s

Indeed, it is not as fast as it used to be; and the fix doesn't really
remove the quadratic complexity, just uses faster iteration. If there
is a way to directly list objects anchored to a given paragraph, rather
than iterating over all objects checking their anchors, that would get
much faster, but that would be a rather large change.

Change-Id: Ie50515815e85fdce498d065185199c9b31d95794
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160813
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-15 10:29:14 +01:00
Miklos Vajna
4e8895d3d8 sw floattable: disable UI to enable this when anchored inside TextBox
Similar to headers or footers, shape text is another area where
multi-page floating tables don't make sense, the Word UI to float a
table in shape text is even disabled.

Our UI to create a floating table is to select a table and then insert
frame, and that already refused to make a new frame around a table to
split. However, one could be creative and enable the split only later,
and that was allowed.

Fix the problem by extending SwFramePage::Reset(), so in case the
currently selected frame is edited and it's anchored in a Word-style
shape+text, then the checkbox to allow the split is hidden.

This is meant to help users to not create document model that would be
later problematic to export to Word formats.

Change-Id: I63e981bd93fd16195ccdac2d5a5ec785e7c18b97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160814
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-12-15 10:18:48 +01:00
Stephan Bergmann
58bfd8f982 Fix backward vs. forward slashes on Windows
Change-Id: I24771a526848901ccedb15aa5dd7b373fe854977
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160765
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-15 09:23:56 +01:00
Andrea Gelmini
f9e1b1c9f3 Fix typo
Change-Id: Id2236f5587c4dfcd6d7f4fbac15d1e9dbb93cd07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160779
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-15 09:21:37 +01:00
Andrea Gelmini
f8a288fdeb Fix typo in code
Change-Id: I78900dfd2314fc9b716ef40397229f24e962865f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160780
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-15 09:20:48 +01:00
Miklos Vajna
437062f293 sw doc model xml dump: add initial ruby support
Fixes this warning when some text portion has ruby on it:

warn:sw.core:19310:19310:sw/source/core/txtnode/txatbase.cxx:180: Unhandled TXTATR

Change-Id: If741f7201c56f7f19ae51108312f2813e92f45d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160787
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-15 08:24:12 +01:00
Weblate
50d55703bd android-viewer translated using Weblate
Catalan currently translated at 57.5% (76 of 132 strings)

Change-Id: I477bd8cf847c12e62d00385460caf91f310fa531

Added translation for android-viewer using Weblate (Punjabi)

Change-Id: Idad2440113f7f4cbdc0077ac101eb14b9f449f76
Co-authored-by: A S Alam <amanpreet.alam@gmail.com>
Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
Co-authored-by: Weblate <noreply@documentfoundation.org>
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
Translation: android-viewer/android-strings
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160789
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15 07:59:26 +01:00
Stephan Bergmann
7397fa7cdf Fix salhelper::Timer
Using it was prone to cause deadlocks on shutdown, when the main thread during
exit destroys the static salhelper::TimerManager instance, which blocks
destroying its m_notEmpty member because the salhelper::TimerManager::run thread
is blocking at

>         m_notEmpty.wait(pDelay);

Change-Id: If72700cb622e945f5f314a00ded57538961ab8d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160788
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-15 07:30:35 +01:00
Patrick Luby
2502131667 Fix Skia unit test failures when using a Retina display
When running on macOS with a Retina display, several BackendTest unit tests
also need a lower quality scaling level.

Change-Id: Ied7141af886357a846f5c4633703114c18dfabf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160811
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-15 07:23:18 +01:00
Julien Nabet
fdc87dd565 tdf#151456: AnimatedImages in Basic Dialog : StepTime is ignored
2 problems here
1) Regression on test of "pThrobber" since 51e97b2ffd
toolkit: first cut at switching to VclPtr.

2) as the author of the bug "Jurassik Pork" indicated,
"mnStepTime" wasn't used after having been used in ctr of Throbber
Thank you to him for the suggestion!

Change-Id: I0d1a53738035c3e822ea84d5972363dd9d0b5d8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160771
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-14 22:58:52 +01:00
Caolán McNamara
f3af199874 Related: cool#6893 ScFormulaGroupIterator::next creates columns
that didn't exist before. Lots of time spent in ScColContainer::resize
on getting document statistics.

ScColContainer: :resize
ScTable: :CreateColumnIfNotExistsImpl
ScTable: :FetchColumn
ScFormulaGroupIterator: :next
ScDocument: :GetFormulaGroupCount
ScDocument: :GetDocStat
Change-Id: I52d4ab052e21215eb650bdccf4abc056ee2dd405
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160784
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-14 20:46:57 +01:00
Michael Stahl
c6c5166347 tdf#105844 package: increase PBKDF2 iterations for wholesome ODF encryption
The government recommends 600k iterations.

Change-Id: I8d4137ca8a08c2b3ac0e7724de1c87c2117ec7c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160768
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-14 18:32:25 +01:00