(Somewhat randomly setting it to the same name that is used, via
-DMAR_CHANNEL_ID=\"LOOnlineUpdater\" in external/onlineupdate/Executable_mar.mk,
as the default channel name in the mar executable tool that we build.)
Change-Id: Ia77e3e841139947dad894efa81f011cafd6c7539
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161049
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
This fixes CTRL-clicking on the last half-character of the smarttag
and having nothing happen, or triggering it
with the half-character before the smarttag.
This is a suggested follow-up to right-clicking on a selection,
which had the same problem.
smart tags need an extension to activate,
so a unit test is impractical in this case.
Change-Id: I151c28090b5a6701df16dab95992eeae2aec3ca3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161033
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
* Update helpcontent2 from branch 'master'
to 1ba5e041e6e4e259a69160b90afed882c8c0f664
- tdf#158105 Change character "background" to "highlighting color"
Change-Id: I9352093a3dfa4af8f763aba6bf2b5914b1f2b071
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161051
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Better to check the body text, not just the length.
Change-Id: Id98cc408772c5d2c135bdd184d58a5eb12f1c011
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161005
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This fixes quikee's 7.5 regression
commit 01396925b7
If this is a help document, we don't want to run smart tags,
not the other way around.
It was correct originally - assuming this was just
a typo when the tests were pulled out into a function.
Change-Id: Ie21ed256539ce242a7892c1ddc1556319fc45310
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161006
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Change-Id: I55e7159ff10e7bb0ee32651a8f23f2f3a4e1282c
android-viewer translated using Weblate
Asturian currently translated at 100.0% (118 of 118 strings)
Change-Id: Ica863fed7663f5f5c17820a4010262101fcc358c
android-viewer translated using Weblate
Nepali currently translated at 16.9% (20 of 118 strings)
Change-Id: Ifc64ae37b7faa5bad89f70178565595630993420
android-viewer translated using Weblate
Greek currently translated at 100.0% (118 of 118 strings)
Change-Id: Icb257e6a5cfd38de5a27425f69294e059796e596
android-viewer translated using Weblate
Ukrainian currently translated at 100.0% (118 of 118 strings)
Change-Id: Iddf1e095b789f2a324fbc614d57b98ab3df8ed0e
android-viewer translated using Weblate
Asturian currently translated at 100.0% (118 of 118 strings)
Change-Id: I318be3807e77e190d857f1d9edd25fc9d7a60c0a
android-viewer translated using Weblate
Asturian currently translated at 100.0% (118 of 118 strings)
Change-Id: If8105733d78073254da1ccd16817581d53ab55b8
android-viewer translated using Weblate
Chinese (Traditional) currently translated at 100.0% (118 of 118 strings)
Change-Id: I7ef697098031684e32aed137b2ac6bd844ed94fb
Added translation for android-viewer using Weblate (Nepali)
Change-Id: I2d68cb2696827a6cd6e2ad634873857344c8ac9f
android-viewer translated using Weblate
Greek currently translated at 57.6% (68 of 118 strings)
Change-Id: Ic029d631692c1f47a9d7eeda13ce6ac38a59c3b8
android-viewer translated using Weblate
Greek currently translated at 56.7% (67 of 118 strings)
Change-Id: Id3456928ecb1a9aab0c27e77fbe49a02540fd8c4
android-viewer translated using Weblate
Asturian currently translated at 58.4% (69 of 118 strings)
Change-Id: Ibaf90837a1f25d070f9dd8ac183fbca6c26e85c4
android-viewer translated using Weblate
Italian currently translated at 11.8% (14 of 118 strings)
Change-Id: I64eb0e5cbf5a6ab050c6ef18a1adae68317005d8
android-viewer translated using Weblate
Asturian currently translated at 32.2% (38 of 118 strings)
Change-Id: Ie470cf5f249a0e498413571cd0b56a5421f5710a
android-viewer translated using Weblate
Asturian currently translated at 32.2% (38 of 118 strings)
Change-Id: I687ae9fe76f85a03f0876f4eda55d943f51b43fb
android-viewer translated using Weblate
Slovenian currently translated at 100.0% (118 of 118 strings)
Change-Id: I0c0cc15c6d5f245311c12d05afd4742db649389d
android-viewer translated using Weblate
Chinese (Traditional) currently translated at 100.0% (118 of 118 strings)
Change-Id: I2ddc5b6a36a512e6e4d1e52c96e282b0ff05f2ea
android-viewer translated using Weblate
Welsh currently translated at 100.0% (118 of 118 strings)
Change-Id: I34dbcafeaf61e7400d07910976ff71fdbe8ae4b0
Added translation for android-viewer using Weblate (Greek)
Change-Id: Idfc6ee0a0988f3c414e6e6beee58a96ab5fb9547
Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
Co-authored-by: Andika Triwidada <andika@gmail.com>
Co-authored-by: Cheng-Chia Tseng <pswo10680@gmail.com>
Co-authored-by: Dimitris Spingos <dmtrs32@gmail.com>
Co-authored-by: Elisabetta Manuele <calembour@hotmail.it>
Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Co-authored-by: Po-Yen Huang <jeff.huang@ossii.com.tw>
Co-authored-by: Rhoslyn Prys <post@meddal.com>
Co-authored-by: Saroj Dhakal <lotusnagarkot@gmail.com>
Co-authored-by: Weblate <noreply@documentfoundation.org>
Co-authored-by: Weblate <noreply@weblate.org>
Co-authored-by: Xandru Martino Ruz <xandrumartino@softastur.org>
Co-authored-by: Євген Кондратюк <lachend@gmail.com>
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cy/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/el/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ne/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sl/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/uk/
Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/zh_Hant/
Translation: android-viewer/android-strings
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160909
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Take the checkable state into account when mapping the
`AccessibleRole::BUTTON_DROPDOWN` role.
There is no direct ATK equivalent for
`AccessibleRole::BUTTON_DROPDOWN`.
Don't always use ATK_ROLE_PUSH_BUTTON, but
use ATK_ROLE_TOGGLE_BUTTON when the button is CHECKABLE,
i.e. it can be toggled.
With this in place, Orca now announces the state of
the underline button (on/off) when using the gtk3
VCL plugin.
Related Orca source code that requires the toggle button
role: [1]
The state is not announced when using the qt6 VCL
plugin yet, and Qt currently doesn't have a toggle button
role, so that would have to be added there first to
do something similar there.
For gtk4, mapping could probably be done similarly,
but more is missing for Orca to announce things in
custom widgets (e.g. event handling),
so leave that for later.
[1] b80bb951a6/src/orca/scripts/apps/soffice/speech_generator.py (L177)
Change-Id: If69e08d2e4939cc709d44e89cc2fd1d01691a70b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160904
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
For interoperability, only shrink spaces up to 20%,
not the lines up to 2%.
Follow-up to commit 20cbe88ce5
"tdf#119908 tdf#158419 sw smart justify: fix cursor position"
and commit 7d08767b89
"tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt."
Change-Id: Idb43161cb5a57c3412abd3f0eb266c6afbe5363c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160988
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
DOCX has some odd properties (bold, italic, shadowed, hidden ...),
which switch on/off if they are applied multiple times, e.g. with
paragraph and character styles. To fix that, a hard attribute has to
switch off the attribute in that occasion on import and on export a
hard attribute switches it on in Word.
Includes partial fix for tdf#154370.
Change-Id: Ie4c317cf9b7d02efd89b9d6a9996143585d7e937
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160343
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
a) figures out what might need to redraw
b) triggers redraws on that
Change-Id: Ib6e1d8d0785cc629fd2cfb0cfdc4ad43897fd4f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161012
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
To get the MOZ_MAINTENANCE_SERVICE mode going at all, update.status needs to
contain a "pending-service" token. For Mozilla, code in its
toolkit/mozapps/update/UpdateService.sys.mjs takes care of writing that. For
us, lets always write that in update_checker() (even on Linux, where it's
apparently harmless).
Then, the MOZ_MAINTENANCE_SERVICE code is rather picky with its various sanity
checks: Among other things, it expects argv[0] to be a full path to the updater
executable, and it expects the update.mar (and its status and log files) to be
in a directory hierarchy named updates/0/ rather than patch/. So get all that
fixed in desktop/source/app/updater.cxx. And patch in
external/onlineupdate/lo.patch where it expects to find the updater executable
(just updater.exe vs. our program/updater.exe).
And we shouldn't interfere with the upstream Mozilla maintenance service, so
also rename that in external/onlineupdate/lo.patch.
And `update_service install` wants to read version resources from the
update_service.exe, so provide that (via gb_Executable_add_default_nativeres).
Also, `update_service install` wants to read a MozillaMaintenanceDescription
value from an updater.ini, so provide one (with contents of that value inspired
by Mozilla's browser/locales/en-US/updater/updater.ini).
As we now have an updater.ini anyway (and which apparently works fine with Unix
line ends on both Linux and Windows), also use it on Linux and drop the
onlineupdate/source/update/updater/progressui_gtk.cpp again from
external/onlineupdate/lo.patch. And update external/onlineupdate/README.md how
to manually execute that test against an updater.ini.
Change-Id: I0e3e5e5311be61e1224cda700af2e5d751113a99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160996
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
* Update helpcontent2 from branch 'master'
to 1afd64c6b742bcd7a1b0fd7d8bb16c7a54e91aa0
- tdf#142926 Add HID to new Built-in help page
Now that the change to the dialog has been merged (see [1]), this patch adds the appropriate target HID to the help page.
This does not need to be cherry-picked to 24.2, since the change to the dialog will only be present in 24.8.
[1] c48952eb6b
Change-Id: I5097264191af59a1585fec5f03acc82b708c401d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160948
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
The document had 2 windows. The first window was typing in column A, the
second window ctrl-clicked on a hyperlink in column B. The LOK callback
was emitted in window 1, not in window 2, which is unexpected.
What happens is that ScGlobal::OpenURL() dispatched an async command
when window 2 was active, and we happened to be in window 1 when
processing that user event from the main loop.
Fix the problem by dispatching the URL open command in a synchronous
way, so the LOK view can't be different.
An alternative would be to track the current LOK view id for posted user
events, and set the view back to the one which was current at post-time
before executing the event. We can consider doing that in a follow-up
change, but this fixes the problem at hand and is a safe fix.
Change-Id: I9a3c9fc1b90ad538d8b2510c7844549c9881ca56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160976
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
This also aligns code with 'else' branch behaviour
problem:
in online when coping a slide with comment,
comment text was never copied in online,
it required document to reload to show it correctly
Change-Id: I6d444c10808ef23f282370b4b305c41eb5043b76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160812
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit db7faa0676)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160943
Tested-by: Jenkins
we already have the ScPostIt here
Change-Id: I646cbe073be3a63f8aeaa4939406b56a73b6382e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160973
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
regression from
commit cd3c16fbcb
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri Oct 14 15:14:13 2022 +0200
tdf#129101 CTRL+A & Cut very slow
avoid repeated invalidation of number tree, shaves 90% time off
The problem is that, after the above change, InvalidateListTree is not
called late enough to force invalidation of all necessary stuff.
So simply delay that until we do re-validation in SwNumRule::Validate.
Change-Id: I796cc34fe7d66d4876ee06286a8af7029a759eca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160974
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(and rename SvxOnlineUpdateTabPage's is...OnlineUpdateEnabled predicates to
is...OnlineUpdaetAvailable, to avoid the overloaded term "enabled" here)
Change-Id: I639ac72a17b98c883ff3082747b8576099299867
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160975
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
* Update helpcontent2 from branch 'master'
to d5b39fee6d9f21ca6e155480cef1df612a61629e
- fix link to Styles menu
Change-Id: Ib1c8f2a24384d1282751796cebcee41d4c996f13
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160942
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
There are the classes BufferedDecompositionPrimitive2D
and BufferedDecompositionGroupPrimitive2D that offer
a unified mechanism to preserve/buffer the decomposition
of a Primitive, independent of the complexity. This may
include e.g. the pixel representation of a 3D Scene,
for Charts/CustomShapes and others.
Until now these were refreshed when the objects change,
or when the buffered decomposition decides that it is
necessary, but there was no general mechanism in place
to clean these up while the Primitive owning them was
alive/used. This is not a big thing in Draw/Impress
since this would only be relevant when zooming deep into
a SdrPage, so the non-vislible parts would still hold
data that would not be needed. But for Calc and Writer
this is more relevant: A 3D Chart on the 1st page of a
Writer document would be held buffered all the time a
user would work on pages below that. This is good for
guaranteeing fast re-visualization when scrolling up
again, but until then would just block memory.
So I added this general mechanism that allows activating
flushing timer-based, on Seconds. The default is null
seconds, thus deactivated. It should only be used for
Primitives that can get expensive, not for all.
NOTE: I checked activating for all Primitives to be on
the safe side, works.
It is now (initially) activated for:
- GlowPrimitive2D
- GraphicPrimitive2D
- MetafilePrimitive2D
- ScenePrimitive2D
- ShadowPrimitive2D (softShadow)
- SoftEdgePrimitive2D
- SdrCustomShapePrimitive2D
- SdrGrafPrimitive2D
These are the usual suspects that may use some memory
to buffer their decomposition (for good reasons, each
repaint uses it). Other Primitives which may show need
to be treated this way can easily be added, just by
calling setCallbackSeconds(s) in their constructor. This
is true for all Primitives derived from the two classes
mentioned above.
NOTE: Too short buffering times are *not* useful - e.g.
for a expensive-to-be-recreated 3D chart representation
this may not pay out, so I chose times in a way that try
to respect this.
NOTE: This change needs
7397fa7cdf to work
correctly (thanks to sberg for this). Without this the
office hangs/does not terminate regularly in trying to
destroy the 'TimerManager'.
Change-Id: Id4802afcb6d12480bb2935cc1ef67fe443b3b788
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160926
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
commit 4342408a83
Author: Carsten Driesner <cd@openoffice.org>
Date: Thu May 6 18:15:21 2010 +0200
fwk142: #i104293 Use Commands.xcu files to mark commands which support a toggle state
introduced a `UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON` state
to mark commands that can be toggled, see `framework/inc/properties.h`.
Despite that one being set for the `.uno:Underline` command in
`officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu`,
the underline button in Writer's formatting toolbar would not expose
the CHECKABLE a11y state even after
commit 78241a40628e5721aa50cb0fa13a63333343f766
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon Dec 18 08:48:12 2023 +0100
tdf#123864 a11y: Handle new CHECKABLE state in misc places
because the state set in the .xcu file was only applied
in `ToolBarManager::CreateControllers` in the code path where
no controller is set.
There seems to be no particular reason for that, so move this
out of that block so this gets run for other items, too.
With this in place, the underline button in Writer's formatting
toolbar now has the checkable AT-SPI state when using the gtk3
VCL plugin.
(Orca still doesn't announce the button as checked when it is,
despite the checked state also being set then, but that's another
aspect that will be addressed in a separate commit.)
Change-Id: Ib9200077a95feea3ce7c0380b9b8f31c96632223
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160903
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Add reporting for the new CHECKABLE a11y state introduced in
commit d6c6472bbe
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon Nov 13 15:53:44 2023 +0100
tdf#123864 a11y: Add new AccessibleStateType::CHECKABLE
for `VCLXAccessibleMenuItem`.
`MenuItemData::HasCheck` looks like it already provides
what's needed to say whether an item is checkable, therefore
add a `Menu::IsItemCheckable` that makes use of this and
and a `VCLXAccessibleMenuItem::IsCheckable` that
makes use of that in turn.
Extend `VCLXAccessibleMenuItem::FillAccessibleStateSet` to
use the latter to report the CHECKABLE state accordingly.
Change-Id: Id23196ef2527a71a338102a5143a8bd6fd41db84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160902
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Add reporting/handling of the CHECKABLE a11y state
added in
commit d6c6472bbe
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon Nov 13 15:53:44 2023 +0100
tdf#123864 a11y: Add new AccessibleStateType::CHECKABLE
in various places where it seems pretty straightforward.
`VCLXAccessibleMenuItem` is a bit more complex and will be
handled separately.
Change-Id: I212b8439609d34410413959973163aa7d809cbf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160901
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Add a `GtkAccessibleEventListener` that is in
charge of handling a11y events for the gtk4
VCL plugin.
This is inspired by how the Qt-based VCL plugins
do it (see `QtAccessibleEventListener`).
Initially, only handle the
`css::accessibility::AccessibleEventId::STATE_CHANGED`
for the `AccessibleStateType::CHECKED` state by updating
the value for the corresponding Gtk state.
With this in place, toggling e.g. the "Bold"
toggle button in Writer's formatting toolbar
now properly updates the "checked" state of
the corresponding a11y object in Accerciser's
tree view of LO's a11y hierarchy.
Gtk takes care of sending a corresponding
"state-changed" event on the AT-SPI layer:
10.8 object:state-changed:checked(1, 0, 0)
source: [toggle button | Bold]
application: [application | soffice]
Handling state changes to other states that map to a
`GtkAccessibleState` should be possible in a similar
way.
However, other states - like the FOCUSED state - map
to a `GtkAccessiblePlatformState` in Gtk 4, and the
function `gtk_accessible_platform_changed` to update these
that is used by Gtk's own widgets is private API for now,
so cannot be used by LibreOffice, so I currently don't
see a way to handle these without changes on Gtk side
(see [1]).
[1] https://gitlab.gnome.org/GNOME/gtk/-/issues/6272
Change-Id: I2a5ca4448ad14a61dc96aef7b22af36baeeed5c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160929
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
A proper inFrame() would be identical to hasProperties,
so just substitute the existing, complete function for inFrame.
This is based on a code read, not a problem document,
but finding a document that depended on inFrame
returning true made it trivial to modify it to fail.
Somewhat surprisingly, it made it all the way through
the rtfexports without failing.
make CppunitTest_sw_rtfimport CPPUNIT_TEST_NAME=testFdo52052
Change-Id: I96f00c9b542dabd3709a896d778569b7681c8f19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160928
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
\phcol: Use the column as the horizontal reference frame.
This is the default if no horizontal reference frame is given.
Change-Id: I8ef4a35c578768810edc0a68e3fd3b227c069dfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160776
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
If HoriAlign/VertAlign are defined, that is enough to create a frame.
This fixes mstahl's 7.6.4 regression originating with
commit 4e2f2489c4
make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_lostFrame
Change-Id: Ibb639673cebcd8d5ec79f5551a5703caf948e0d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160744
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
If HoriAnchor/VertAnchor are assigned, that is enough to create a frame.
make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_0B
Note: because of a regression, this was already one page before
this commit, so need to go back to the time of the reverted patch.
Change-Id: Iddbe1cc4ba6d6e95e2d977a227ae6cab5271007e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160743
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This fixes a LO 7.6.4 regression of a lost page break,
as well as another example where part of the paragraph moves to next page,
from mstahl's commit 4e2f2489c4
It seems likely that the run should only be checked
when we know that there is a real frame here,
which essentially becomes a run for most purposes
(except perhaps for page breaks - as seen for DOCX).
This code block was introduced with
commit 0d9132c504
Author: Miklos Vajna on Sat Mar 24 13:04:54 2012 +0100
fdo#47036 fix RTF import of shapes inside text frames
at the start of the doc
and in the other block of touched code, it did test inFrame.
The unit test works when compiling right after the regression,
but has broken because of tdf#153194.
Since this will get backported way back and all over,
it is a good time to introduce rtfexport8.
make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_0
make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_1
Change-Id: Ib4b75efb8422d96e693da337cbef97520e975f3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160655
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
...to reflect whether or not the corresponding item can be modified. Which
matches what the READONLY flag is actually used for today. (And the original,
somewhat arbitrary semantics had been assigned without much thought, IIRC, and
it should be OK to change them.)
Change-Id: I8185e47519a5cb4aff6e8f260326845276b0c092
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160957
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
